Bioconductor / BiocWorkshops

:warning: 2018 :warning: Bioconductor Workshops
https://bioconductor.github.io/BiocWorkshops/
74 stars 53 forks source link

220_Das_SingleCellRNASeq.Rmd #22

Closed lwaldron closed 6 years ago

lwaldron commented 6 years ago

I'm creating an issue for each workshop, to be closed when both 1) the workshop is complete, and 2) it compiles without problems. Please note problems and status updates here.

aroma.light issue, to be resolved on server side.

lwaldron commented 6 years ago

it looks like for a couple of workshops (including ours) the problem is that aroma.light is failing its checks in bioc-devel and hence biocLite won't be able to install it. Any workaround? Or should we ask @HenrikBengtsson to fix it? :)

The workaround is to install https://cran.r-project.org/src/contrib/Archive/princurve/princurve_1.1-12.tar.gz or GitHub devel branch of princurve. The reason is Issue dynverse/princurve#8.

lwaldron commented 6 years ago

Getting a new problem now that aroma.light is installed from HenrikBengtsson/aroma.light:

Quitting from lines 386-390 (220_Das_SingleCellRNASeq.Rmd) 
Error in project_to_curve(X, s, pcurve$ord, stretch = stretch) : 
  unused argument (pcurve$ord)
Calls: <Anonymous> ... getCurves -> .local -> lapply -> FUN -> .shrink_to_avg
In addition: Warning messages:
1: In rgl.init(initValue, onlyNULL) : RGL: unable to open X11 display
2: 'rgl_init' failed, running with rgl.useNULL = TRUE 
Execution halted
HenrikBengtsson commented 6 years ago

That:

Error in project_to_curve(X, s, pcurve$ord, stretch = stretch) : 
  unused argument (pcurve$ord)

appears to come from princurve. For troubleshooting purposes, see if it works with https://cran.r-project.org/src/contrib/Archive/princurve/princurve_1.1-12.tar.gz.

BTW, what timeline are you on here? I can try to push for a CRAN update of princurve - they seem to be willing to make a new release quite soon.

LiNk-NY commented 6 years ago

Hi Henrik, I get a different error:

Quitting from lines 393-397 (220_Das_SingleCellRNASeq.Rmd) 
Error: package 'princurve' 1.1.12 is loaded, but >= 2.0.2 is required by 'slingshot'
Execution halted
kstreet13 commented 6 years ago

Hey all, The project_to_curve function was added in princurve version 2.0.2 (it was previously called get.lam), so I think updating that package may solve this issue.

rcannood commented 6 years ago

The problem with aroma.light has been fixed with princurve 2.0.4, which is now available on CRAN. Please use that version, instead of the @devel version on GitHub.

LiNk-NY commented 6 years ago

Thanks!

rcannood commented 6 years ago

And the problem with slingshot is being caused by princurve 2.0.4. kstreet13/slingshot#19 should do the trick.

HenrikBengtsson commented 6 years ago

I can confirm that aroma.light passes R CMD check --as-cran with the princurve 2.0.4 that just hit CRAN. I've/Travis CI/AppVeyor CI verified on Linux and Windows with various R versions - as soon as macOS binaries are rolled out, I'd expect it to also work there too. This means that aroma.light should build and pass all checks on Bioc release & devel at the next round of Bioc builds.

LiNk-NY commented 6 years ago
Quitting from lines 400-404 (220_Das_SingleCellRNASeq.Rmd) 
Error in project_to_curve(X, s, pcurve$ord, stretch = stretch) : 
  unused argument (pcurve$ord)
Calls: local ... getCurves -> .local -> lapply -> FUN -> .shrink_to_avg
In addition: Warning messages:
1: In rgl.init(initValue, onlyNULL) : RGL: unable to open X11 display
2: 'rgl_init' failed, running with rgl.useNULL = TRUE 
Execution halted
Error in Rscript_render(f, render_args, render_meta) : 
  Failed to compile 220_Das_SingleCellRNASeq.Rmd
Calls: <Anonymous> ... render_new_session -> tryCatch -> tryCatchList -> Rscript_render
Execution halted

Exited with status 1.
rcannood commented 6 years ago

kstreet/slingshot#19 was merged yesterday, but slingshot v 0.99.11 still needs to be published on Bioconductor. Once slingshot v 0.99.11 is out, this error should disappear :)

kstreet13 commented 6 years ago

Yeah, I pushed the new version yesterday, so it should be available soon!

drisso commented 6 years ago

Hi @LiNk-NY ,

can you confirm that the new version of slingshot solves the issue above? It works on my local machine with slingshot 0.99.12 and princurve 2.1.0, but not sure which versions you have for the build.

LiNk-NY commented 6 years ago

Hi Davide, @drisso The builder has these versions:

> packageVersion("slingshot")
[1] ‘0.99.12’
> packageVersion("princurve")
[1] ‘2.1.0’

and it solves the issue. Thanks.

drisso commented 6 years ago

Awesome! Thanks Marcel!

LiNk-NY commented 6 years ago

Hi Diya, @diyadas Could you please fix the citations in your workshop? I don't see any entries in the .bib file for:

pandoc-citeproc: reference Peer2017 not found
pandoc-citeproc: reference Pierson2015 not found
pandoc-citeproc: reference Tseng2005 not found

cc: @drisso @kstreet13

diyadas commented 6 years ago

Will do! Have small formatting things I will also address. Thanks Marcel!

diyadas commented 6 years ago

I did fix the citation issue locally - but I'm unable to push commits. Any chance that someone could check the permissions I have? So sorry for the last-minute change.

seandavi commented 6 years ago

@diyadas, could you make a pull request with just that change? We have disabled commits on the repo for everyone, as the workflows are "live" now. Sorry for the inconvenience.

diyadas commented 6 years ago

PR submitted, sorry if you got a lot of notifications as I had an interesting time with GitHub.