search

Bioconductor / Biostrings

Efficient manipulation of biological strings
https://bioconductor.org/packages/Biostrings
54 stars 16 forks source link

Matchprobes #74

Closed raoulkam closed 2 years ago

hpages commented 2 years ago

Not sure what the tittle of this PR is about. Can we use PR titles that are a little bit more descriptive? If the PR is about converting the matchprobes.Rnw vignette to R markdown, then the title should say so and the changes contained in the PR should stick to that. However, it looks like this PR tries to do a lot more things than that.

I think this whole migration from .Rnw to .Rmd is going to be easier to manage if we create one PR per conversion. Can we close this PR? Thanks

raoulkam commented 2 years ago

Thank you Herve, Your comments are well taken, notably the descriptive nature of the title and one PR per conversation. Should the comment on #72 applies to all conversion? Apart from that, the PR can be closed.

On Tue, Aug 9, 2022 at 8:25 PM Hervé Pagès @.***> wrote:

Not sure what the tittle of this PR is about. Can we use PR titles that are a little bit more descriptive? If the PR is about converting the matchprobes.Rnw vignette to R markdown, then the title should say so and the changes contained in the PR should stick to that. However, it looks like this PR tries to do a lot more things than that.

I think this whole migration from .Rnw to .Rmd is going to be easier to manage if we create one PR per conversion. Can we close this PR? Thanks

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Biostrings/pull/74#issuecomment-1210018499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUVE6QHGXTBUU6M67FCMILVYLZHDANCNFSM53RINPUQ . You are receiving this because you authored the thread.Message ID: @.***>

jwokaty commented 2 years ago

@hpages I talked to @raoulkam about doing 1 PR for 1 conversion. At the time, there was some confusion with branching, which we also discussed. I'm going to clean this and #73, so I can review them. Please be patient. It's taking time to review among other things :)

hpages commented 2 years ago

@raoulkam

Should the comment on #72 applies to all conversion?

Yes.

@jwokaty Thanks for helping with this.

Closing this PR now. @raoulkam Please create a new PR with descriptive name (e.g. "Convert matchprobes.Rnw to Rmd") and with focus on that conversion only.

Thanks guys!