search

Bioconductor / Biostrings

Efficient manipulation of biological strings
https://bioconductor.org/packages/Biostrings
54 stars 16 forks source link

Convert Biostrings2classes.Rnw to .Rmd #83

Open villafup opened 1 year ago

villafup commented 1 year ago

@Bioconductor/sweave2rmd for review

jwokaty commented 1 year ago

@villafup Please remove .Rnw file. I don't think you need to modify the DESCRIPTION because there are other PRs that add BiocStyle

hpages commented 1 year ago

@villafup @jwokaty Where are we standing with this PR?

jwokaty commented 1 year ago

We are waiting on some changes from @villafup. I'll slack him :)

ahl27 commented 3 months ago

@hpages @jwokaty what is the status of this and #90 ? Are these still being worked on, and if not, can we merge/close them?

hpages commented 3 months ago

I'm surprised this vignette made it to the sweave2rmd list. It's very old and outdated and doesn't have much value anymore. It was written to document the classes that I introduced when I took over the package and transitioned it from Biostrings 1 to Biostrings 2 about 18 years ago! The only reason it's still around is that Biostrings doesn't have a good general vignette, so I guess having the "Biostrings 2 classes" vignette was better than nothing. However we should start thinking about addressing that @ahl27. In the mean time I think it's ok to close this unless @jwokaty or @villafup oppose. Thanks!

ahl27 commented 3 months ago

Sounds good, I'll wait for either of them to chime in to confirm and then we can consider closing it.

Is the other PR still something we need to merge? I can ping you on that PR so the conversation stays localized to the PR