fix: ambiguity codes in `matchProbePair` (Issue #29)

Bioconductor / Biostrings

Efficient manipulation of biological strings

https://bioconductor.org/packages/Biostrings

57 stars 16 forks source link

fix: ambiguity codes in `matchProbePair` (Issue #29) #98

Closed ahl27 closed 4 months ago

ahl27 commented 1 year ago

Adds extended argument support to matchProbePair as requested in #29. New version implements ... to match any argument in matchPattern, including the fixed argument for ambiguity code. Documentation updated accordingly.

hpages commented 4 months ago

PR looks good, thanks @ahl27. I know Biostrings lacks good test coverage but maybe this is a good time to change that. Let's try to accompany any new feature with a small set of unit tests that cover it. As discussed earlier, feel free to switch from RUnit to testthat or to any unit testing framework of your choice if you don't like RUnit. Thanks again!

ahl27 commented 4 months ago

Yep, that’s my bad—I got a little too eager to start making bugfixes. All the future changes are going to be held in PR until unit tests are done (eg, the other two m PRs I put up today), and I’ll also add in unit tests for changes introduced in PRs as they go in.

I’ll make sure to double check this functionality, if there’s any issues with it we can roll it back.