Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

scMerge #1014

Closed kevinwang09 closed 5 years ago

kevinwang09 commented 5 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 5 years ago

Hi @kevinwang09

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: scMerge
Type: Package
Title: scMerge: Merging multiple batches of scRNA-seq data
Version: 0.99.0
Authors@R: c(
    person("Kevin", "Wang", email = "kevin.wang@sydney.edu.au", role = c("aut", "cre")
    ),
    person("Yingxin", "Lin", email = "yingxin.lin@sydney.edu.au", role = c("aut")
    ),
    person("Sydney Bioinformatics and Biometrics Group", email = "bioinformatics@maths.usyd.edu.au", role = c("fnd"))
    )
Maintainer: Kevin Wang <kevin.wang@sydney.edu.au>
Description: Remove batch effect and unwanted variations for single-cell RNA-seq expression matrix.
    The method includes the function of identification of stably expressed genes (SEG) from single-cell data, and also creating pseudo-replicates from the data.
License: GPL-3
Encoding: UTF-8
LazyData: false
Depends:
    R (>= 3.5)
Imports:
  BiocParallel,
  distr,
  doSNOW,
  foreach,
  igraph,
  irlba,
  iterators,
  kBET,
  matrixStats,
  M3Drop,
  parallel,
  pdist,
  proxy,
  Rcpp (>= 0.12.18), 
  RcppEigen (>= 0.3.3.4.0),
  rsvd,
  ruv,
  S4Vectors,
  SingleCellExperiment,
  SummarizedExperiment
LinkingTo: 
  Rcpp (>= 0.12.18),
    RcppEigen,
    testthat
RoxygenNote: 6.1.1
Suggests: 
    BiocStyle,
    knitr,
    rmarkdown,
    scater,
    testthat
VignetteBuilder: knitr
biocViews:  BatchEffect, GeneExpression, Normalization, RNASeq, Sequencing, SingleCell, Software, Transcriptomics
URL: https://github.com/SydneyBioX/scMerge
BugReports: https://github.com/SydneyBioX/scMerge/issues

Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.

bioc-issue-bot commented 5 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

59e68ec V0.99.1 rm kBET from import to comply with BioC

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

3b8beae resolve scater add_ticks issue

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

9c50e01 V0.99.3: upd to be compatible with M3DropV1.9.4

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

112c3c1 V0.99.4 version no bump

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

c0c32bf V0.99.5 rm redundant files, version bump

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

13d4b14 rm redu test files

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

404d203 upd travis and R version to 3.6

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

kevinwang09 commented 5 years ago

Hi, the only warning at this point is that we exceeded 5 minutes when running R CMD check… (Somehow Windows and Mac took much longer to run than Linux). We are also not sure why "BUILD BIN" was skipped on Linux. Any help would be appreciated. Thanks!

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

f8f4a32 V0.99.8 try to resolve check time limit

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

684110c V0.99.9 reduced data size again

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

ae71dd3 V0.99.10 recommit due to time stamp issue

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

046f02c V0.99.11 upd example_data

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

nturaga commented 5 years ago

scMerge Review

DESCRIPTION

NAMESPACE

man

Vignettes

 Breast_Data
 CellBench_Data
 ESC_Data
 Mouse_Liver_Data
 Neuronal_Data
 Pancreas4_Data
 mESC_Data

These are not linked to the vignettes, because when the user does `browseVignettes('scMerge') these sources don't show up. It's likely because they need to be in the vignettes parent folder and not sub folders. Please check this.

inst

tests

docs

R

http://bioconductor.org/developers/how-to/coding-style/

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

1dd0524 v0.99.12 added tests and fix vignettes

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

9c7aecf 0.9913: fixed examples

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

d639c0c 0.99.14 fix doc warning, commit before major updat...

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

7e8ffc4 V0.99.15: major upd on scReplicate

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

d2f0346 V0.99.16 fixed namespace for utils::head

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

af527c8 Fixed README install_github vignette issue and pkg... 9153b61 upd pkgdown, news

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

d69041e V0.99.18: added verbose, added tests, simplified s...

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

nturaga commented 5 years ago

When you are ready for a next review, please leave a detailed message about the changes you made.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

3b35730 V0.99.19: Fixed man and tests

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

f5391c2 V0.99.20: upd vignette and man

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

bb6c7ac V0.99.21:covr at 85%, fixed logo

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

a4b1f77 V0.99.22 fixed namespace issue

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

kevinwang09 commented 5 years ago

@nturaga

Thank you for your review comments. We have updated the scMerge package to Version 0.99.22. A summary of the updates:

  1. The package description, news, namespace, installation instruction and the manuals were updated based on your comments. We hope this is sufficient to give the end-users a concise summary of the package and each implemented functions.

  2. With regard to the vignette. We have fixed the title issue and it should now load with vignette(“scMerge”).

  3. Files like Breast_Data.Rmd are included purely for the construction of our pkgdown-GitHub webpage (https://sydneybiox.github.io/scMerge/). These files should be ignored. The only vignette file we intend for our package is vignette/scMerge.Rmd. The pkgdown package automatically creates a “docs” folder, which, to the best of our understanding, does not install to user’s computer.

  4. With regards to the print methods, we have implemented your suggestion. We have consolidated all diagnostic print outs under a verbose option.

  5. With regards to testing scripts, thank you for this comment. We have included these scripts now and the code coverage at this point is 85%.

  6. With regards to computational speed-ups, we have done another check of our codes to make sure vectorisation is used wherever possible.

  7. With regards to code styling, we have used the formatR package with some manual editing at places where it fails to correct for line-character length.

Thank you, Best wishes, Kevin Wang on behalf of all authors