Bioconductor / Contributions

Contribute Packages to Bioconductor
131 stars 33 forks source link

SubCellBarCode #1030

Closed TanerArslan closed 5 years ago

TanerArslan commented 5 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

fb2b73d version bumped 0.99.19

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

06d2c88 devel install deleted 0b98ff2 Example size increased bebd71e Version bumped 0.99.20

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

fd0335a version bumped 0.99.21

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

d743e8e version bumped to 0.99.22

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

61f482f Version bumped 0.99.23

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

TanerArslan commented 5 years ago

Hi @nturaga Nitesh,

I have added and replaced some with codes with rowsum and rowmean as you suggested. Now the package works well without any problem as expected. However, I have a slight problem on windows build, i keep getting error on building vignette

  • Invalid Parameter - /figure-html Warning in shell(paste(c(cmd, args), collapse = " ")) : 'convert "SubCellBarCode_files/figure-html/coverageMarkers-1.png" -trim "SubCellBarCode_files/figure-html/coverageMarkers-1.png"' execution failed with error code 4

You can also from the build report. I used to get this error before as well. After getting this error, when i resubmitted the package, the problem solved (I literally was not doing anything). Today i tried many times, still i get the problems. Do you know why i keep getting this error?

Thanks in advance.

/Taner

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

f669103 Windows issue 29a7219 Version bumped 0.99.24

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

nturaga commented 5 years ago

Hi @TanerArslan

I think the issue might be a Windows only thing because of a few lines of code. Let's try a couple of things,

  1. In this file, https://github.com/TanerArslan/SubCellBarCode/blob/master/R/coveredMarkerProtein.R#L65. Let's change the plot to print(ggplot(.....

  2. It could be the way the path to where these plots end up being a problem. Please take a look at the path, because Linux/Mac do paths in one way, and windows another.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

ccadf61 Version bumped 0.99.25

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

ab49691 Print instead plot dc70090 Version bumped 0.99.26

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

7a8f831 Version bumped 0.99.27

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

TanerArslan commented 5 years ago

Hi @nturaga Nitesh,

I have tried: changing plot to print did not work.

I just re-pushed, and not it works without error.

Thanks again for your concern.

/Taner

nturaga commented 5 years ago

Hi @TanerArslan

I'm not entirely sure what the issue was with the Windows builder. Since it's clean, I'll accept it. But please keep tabs on your package once it has been accepted, specially on the Windows builder.

If it fails again, for the same reason (or similar), bring it to our attention on the bioc-devel mailing list. This would be the maintainer responsibility.

Thanks for your hard work. You'll see some instructions you need to follow once the package is accepted.

Best regards,

Nitesh

bioc-issue-bot commented 5 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.

Thank you for contributing to Bioconductor!

TanerArslan commented 5 years ago

Dear @nturaga ,

Ok. I will keep track if i encounter again with similar issue.

Thank you so much for the reviewing and being helpful.

/Taner

mtmorgan commented 5 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/TanerArslan.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("SubCellBarCode"). The package 'landing page' will be created at

https://bioconductor.org/packages/SubCellBarCode

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.