Closed quanaibn closed 5 years ago
Hi Marcel,
Thanks very much!
We're aiming to submit a manuscript based on the scGPS package by mid-July. We can continue to work on it after we have received your feedback.
Best wishes,
Quan
On Tue, Jun 4, 2019 at 5:13 AM Marcel Ramos notifications@github.com wrote:
Hi Quan, @quanaibn https://github.com/quanaibn Apologies for the delay. I was traveling last week. I will respond to your questions. Briefly, you can go over the 5 minute limit without problems. I will have another look at your package soon.
Best, Marcel
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/1042?email_source=notifications&email_token=AB6U7UEMLIQNP64R2GWJ72LPYVUOVA5CNFSM4G5RC4CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2M2NY#issuecomment-498388279, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6U7UCQ2EEMII74EWIM7EDPYVUOVANCNFSM4G5RC4CA .
Hi Quan, @quanaibn
Please clean up the package. There are a lot of files that should not
be there even if you're using pkgdown
(including _pkgdown.yml
,
logo, scGPS.md
, etc.). You should build your pkgdown
website independently of the GitHub repository.
1:x
sequence generation. It is not robust. Please see:
http://bioconductor.org/developers/package-guidelines/#rcodeverbose = FALSE
at the main function level. Best, Marcel
Thanks Marcel,
We are revising the package to address your comments. We will try to submit the revised package by the middle of next week.
Best regards,
Quan
On Wed, Jun 5, 2019 at 1:24 AM Marcel Ramos notifications@github.com wrote:
Hi Quan, @quanaibn https://github.com/quanaibn
Please clean up the package. There are a lot of files that should not be there even if you're using pkgdown (including _pkgdown.yml, logo, scGPS.md, etc.). You should build your pkgdown website independently of the GitHub repository.
- Avoid using 1:x sequence generation. It is not robust. Please see: http://bioconductor.org/developers/package-guidelines/#rcode
- I think your users would appreciate an argument such as verbose = FALSE at the main function level.
Best, Marcel
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/1042?email_source=notifications&email_token=AB6U7UCCCDKXLCAJVG7TSS3PY2CKVA5CNFSM4G5RC4CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW45XWY#issuecomment-498719707, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6U7UCR5OIOCZAUJ2ID3XTPY2CKVANCNFSM4G5RC4CA .
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, TIMEOUT, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
1520cdb version bump
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
39a9667 version bump, server check
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Dear Marcel,
We have done with all revision of the package to address your comments.
In addition, we also created a github html user's instruction file, in here: https://imb-computational-genomics-lab.github.io/scGPS/articles/vignette.html
I hope you could have time to finalise our package soon.
Many thanks,
Quan
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi Quan, @quanaibn Thank you for making those changes. It looks good! Your package has been accepted. Thank you for your contribution. Best, Marcel
Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.
Thank you for contributing to Bioconductor!
Hi Marcel, Fantastic! Thanks very much for your very valuable comments and help and we hope to contribute more packages in the future. Best wishes, Quan
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/quanaibn.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("scGPS")
. The package 'landing page' will be created at
https://bioconductor.org/packages/scGPS
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[ x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.