Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

animalcules #1052

Closed anfederico closed 5 years ago

anfederico commented 5 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 5 years ago

Hi @anfederico

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: animalcules
Title: Statistical microbiome analysis on metagenomics data
Version: 0.0.1
Author:
    Yue Zhao <yuezh@bu.edu>,
    Anthony Federico <anfed@bu.edu>,
    W. Evan Johnson <wej@bu.edu>
Maintainer: Yue Zhao <yuezh@bu.edu>
Description:
    Statistical microbiome analysis on metagenomics data.
License: Artistic-2.0
Encoding: UTF-8
LazyData: true
Depends:
    R (>= 3.5.0)
Imports:
    assertthat,
    shiny,
    shinyjs,
    DESeq2,
    tibble,
    caret,
    plotly,
    ggplot2,
    rentrez,
    reshape2,
    covr,
    ape,
    vegan,
    dplyr,
    magrittr,
    MultiAssayExperiment,
    SummarizedExperiment,
    S4Vectors,
    XML,
    forcats,
    scales,
    lattice,
    glmnet,
    tsne,
    DMwR,
    plotROC,
    DT,
    utils
Suggests:
    BiocCheck,
    BiocStyle,
    devtools,
    knitr,
    rmarkdown,
    testthat,
    usethis
biocViews:
    MicrobiomeData,
    ReproducibleResearch,
    SequencingData
VignetteBuilder: knitr
URL: https://github.com/compbiomed/animalcules
BugReports: https://github.com/compbiomed/animalcules/issues
RoxygenNote: 6.1.1

Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.

mtmorgan commented 5 years ago

please provide a decent Description: of your package in the DESCRIPTION file, and in the vignette a proper abstract (if you're going to have one) and text in addition to code chunks to provide a literate exposition on your package use. Post a comment here when you have addressed these basic Bioconductor requirements.

anfederico commented 5 years ago

Sorry about that, should be all set now.

bioc-issue-bot commented 5 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

8e9d518 fix vig

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

928c8e9 modify da analysis

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

ec0d96e fix da and update vignette

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

899aa42 fix da

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

jasonzhao0307 commented 5 years ago

@Kayla-Morrell Hey Kayla, we need your help on this error ("appending gaps is not supported") here. So we run this function in the vignette normally in our system, but it keeps failing in the test, I'm wondering if this is related to the unstable R 3.6? Also, from the previous log, it seems to be an S4Vectors function error, I'm wondering which version of S4Vectors is being used in the test? Thanks a lot :)

Kayla-Morrell commented 5 years ago

@jasonzhao0307 We seem to be seeing this error with many of our packages due to a recent modification to S4Vectors (version 0.21.3). We are working on this issue and it's our hope to have it fixed soon.

jasonzhao0307 commented 5 years ago

@Kayla-Morrell Would you please tell us when this could be fixed? Thank you!

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

e2fe460 add docs

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

jasonzhao0307 commented 5 years ago

@Kayla-Morrell Hi Kayla, we've tried to commit again, so the previous error disappeared, but another DEseq2 related error showed up: "logical subscript contains NAs"

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

a9c3adf add more docs

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

49912ad version bump

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

anfederico commented 5 years ago

@Kayla-Morrell Could you help us with this? We'd like to reopen the submission.

Kayla-Morrell commented 5 years ago

@anfederico Please version bump to be sure a new build is initiated.

anfederico commented 5 years ago

@Kayla-Morrell Thanks

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

0c67622 Version bump

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

5581fc0 Proper gitignore and R dependency

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

3bcc84f Remove Rproj

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

Kayla-Morrell commented 5 years ago

Hello @anfederico,

Thank you for submitting to Bioconductor. Please see the initial review of your package below. Comment back here with updates that have been made and when the package is ready for a re-review. Please keep in mind the deadline to accept packages into this release cycle is 4/24, therefore changes should be made in a timely manner so as to give enough time for a re-revew and any additional changes.

General package development

R CMD BiocCheck

Incomplete final line in inst/shiny/utils/ui_util.R

Consider shorter lines, 157 lines are > 80 characters

Consider 4 spaces instead of tabs, 1 line contains tabs

Consider multiples of 4 spaces for line indents, 666 lines are not (FormatR for help)

DESCRIPTION

NAMESPACE

NEWS

Data

vignette

man pages

MAE

animalcules-package

diversities

diversities_help

filter_summary_top

find_taxon_mat

read_pathoscope_data

animalcules

upsample_counts

R code

Best, Kayla

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

0a18396 Imports, namespace, bugs #35

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

7f2d842 Fix vigenette #35

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

c5ce3cd Formatting #35

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

d641cf0 Version bump

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

bba0d9b Update data documentation

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

dc6a34b Remove /docs and update README #35

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

6c7cd9e Snake_case for exported functions

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

08e9578 Document data #35

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

19da8c3 Documentation examples #35

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.