Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

BANDITS #1062

Closed SimoneTiberi closed 5 years ago

SimoneTiberi commented 5 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 5 years ago

Hi @SimoneTiberi

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: BANDITS
Type: Package
Title: BANDITS: Bayesian ANalysis of DIfferenTial Splicing
Version: 0.99.0
Date: 2019-02-19
Author: Simone Tiberi
Maintainer: Simone Tiberi <simone.tiberi@uzh.ch>
Description: BANDITS is a Bayesian hierarchical model for detecting differential splicing of genes and transcripts,
  via differential transcript usage (DTU), 
  between two or more conditions.
  The method uses a Bayesian hierarchical framework, which allows for sample specific proportions
  in a Dirichlet-Multinomial model, and samples the allocation of fragments to the transcripts.
  Parameters are inferred via Markov chain Monte Carlo (MCMC) techniques and a DTU test is performed 
  via a multivariate Wald test on the posterior densities for the average relative abundance of transcripts.
biocViews: DifferentialSplicing, AlternativeSplicing, Bayesian, Genetics,
  RNASeq, Sequencing, DifferentialExpression, GeneExpression, MultipleComparison,
  Software, WorkflowStep, Transcription
License: GPL (>= 3)
Depends: R (>= 3.6.0)
Imports: Rcpp, doRNG, MASS, data.table, doParallel, parallel, foreach, methods, stats, graphics, ggplot2,
  DRIMSeq, BiocParallel
LinkingTo: Rcpp, RcppArmadillo
Suggests: knitr,
  tximport, BiocStyle
SystemRequirements: C++11
ByteCompile: false
VignetteBuilder: knitr
RoxygenNote: 6.1.1
URL: https://github.com/SimoneTiberi/BANDITS

Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.

bioc-issue-bot commented 5 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

501cdba Resolving Warnings

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

52c43a1 Resolving Warnings

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

1f91fd3 Resolving Warnings III

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

8d11694 Resolving Warnings III

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

5b95da5 Resolving Warnings III

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

f223961 Resolving Warnings IV

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

9733bb6 Resolving Warnings IV

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

548bd5d Resolving Warnings IV

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

8e5e00e Resolving Warnings IV

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

8dea71f Resolving Warnings in progress

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

6bdd524 Resolving Warnings in progress

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

72430d8 Warnings solved

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

42734ac Warnings solved

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

7507e0b Warnings solved

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

SimoneTiberi commented 5 years ago

Hi @Kayla-Morrell I think the package is ready for review when you have time.

Have a good one, Simone

Kayla-Morrell commented 5 years ago

Hello @SimoneTiberi,

Perfect! I'll comment back here in a week or so with my initial review.

Best, Kayla

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

bce4e01 Resolving notes

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

Kayla-Morrell commented 5 years ago

Hello @SimoneTiberi,

Thank you for submitting to Bioconductor. Please see the initial review of your package below. Comment back here with updates that have been made and when the package is ready for a re-review. Please keep in mind the deadline to accept packages into this release cycle is 4/24, therefore changes should be made in timely manner so as to give enough time for a re-review and any additional changes.

General package development

See FormatR package (https://cran.r-project.org/web/packages/formatR/index.html) for formating help.

DESCRIPTION

README

inst/script

vignette

man pages

BANDITS-package

BANDITS_test-class

eff_len_compute

filter_genes

Unit tests

R code

Best, Kayla

SimoneTiberi commented 5 years ago

Hi @Kayla-Morrell, thanks for the feedback: I'll take care of it and re-submit the package.

A question/clarification: "REQUIRED: Avoid for loops, instead vectorize." I will try to minimize the presence of for loops, but a few are cumbersome to vectorize, I hope you will be fine with a couple of them being present.

We'll get back to you with the updated package in a few days.

Have a good one, Simone

Kayla-Morrell commented 5 years ago

@SimoneTiberi, a couple is not bad to have just as few as possible will help optimize the timing/speed of the functions.

I look forward to seeing the updated package.

Best, Kayla

SimoneTiberi commented 5 years ago

Ok @Kayla-Morrell, thanks for the feedback.

Maybe I exaggerated with just a couple, but I noticed that most of the computationally intensive code is in Rcpp or already vectorized. Most of the remaining for loops are either necessary or would not benefit (computationally) from a vectorization: 1) in some loops the i-th iteration depends on the previous one; 2) in others, we modify only parts of existing objects; 3) in others we intialize several objects and, if vectorizing, I would still need a loop to allocate the resulting objects.

Btw, I implemented all 'REQUIRED' (still working to reduce some for loops) and some 'SUGGESTION': I will re-submit very soon.

Have a good one, Simone

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

65bcd7e Update DESCRIPTION

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

0566ada Update DESCRIPTION

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

6f43485 Update DESCRIPTION

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

1ad2272 Update DESCRIPTION

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

2d145d9 Update DESCRIPTION

bioc-issue-bot commented 5 years ago

Received a valid push; starting a build. Commits are:

459d3d0 Update DESCRIPTION

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 5 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.