Closed guldenolgun closed 4 years ago
Hi @guldenolgun
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: NoRCE
Type: Package
Title: NoRCE: Noncoding RNA Sets Cis Annotation and Enrichment
Version: 0.1.0
Authors@R: c(person("Gulden", "Olgun", email = "gulden@cs.bilkent.edu.tr", role = c("aut", "cre")))
Maintainer: The package maintainer <gulden@cs.bilkent.edu.tr>
Description: While some regulatory non-coding RNAs (ncRNAs) have been found to play critical roles in biological processes, most remain functionally uncharacterized. This lack of functional annotations presents a challenge when an interesting set of ncRNAs set needs to be placed in a functional context. It is known that transcripts located close-by on the genome are often regulated together and this spatial proximity hints at a functional association. Based on this idea, we present an R package for Non-coding RNA sets Cis Enrichment Tool (NoRCE). NoRCE performs enrichment analysis for a given set of ncRNAs based on the set of coding genes located proximally to the input ncRNAs based on other biological evidence such as the topologically associating domain (TAD) regions, co-expression, miRNA target information. NoRCE repository includes several data files, such as cell line specific TAD regions, TCGA expression data and users can provide custom data files. Results can be obtained in a tabular format or viewed as in graphs. NoRCE is currently available for several species: human, mouse, rat, zebrafish, fruit fly, worm and yeast.
License: MIT + file LICENSE
Depends: R (>= 3.5), GenomicRanges, biomaRt, png, RCurl, ggplot2, dplyr, igraph, TxDb.Hsapiens.UCSC.hg19.knownGene,
readr, TxDb.Hsapiens.UCSC.hg38.knownGene,TxDb.Mmusculus.UCSC.mm10.knownGene,
TxDb.Drerio.UCSC.danRer10.refGene, tidyr, RSQLite, DBI, org.Mm.eg.db, org.Rn.eg.db,
TxDb.Rnorvegicus.UCSC.rn6.refGene, TxDb.Dmelanogaster.UCSC.dm6.ensGene, GenomicFeatures,
TxDb.Celegans.UCSC.ce11.refGene, stats, org.Sc.sgd.db, org.Hs.eg.db, reshape2, graphics,
KEGGREST, reactome.db, dbplyr, org.Ce.eg.db, org.Dr.eg.db,psych, utils, rWikiPathways,grDevices
Encoding: UTF-8
RoxygenNote: 6.1.1
Suggests:
knitr,
rmarkdown,
testthat
VignetteBuilder: knitr
biocViews: GeneSetEnrichment, miRNA, NetworkEnrichment, GeneTarget
LazyData: true
Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
I have not looked at your package closely, but probably many of the packages included in the Depends: field should be in Suggests: (i.e., used in examples or the vignette). @LiNk-NY will have a more complete review of your package.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
955f280 Fixed examples run time aa2c568 Merge branch 'master' of https://github.com/gulden...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
a8db58e change
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
a7db651 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
4edb563 Update DESCRIPTION 79cd992 Merge branch 'master' of https://github.com/gulden...
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi @LiNk-NY ,
We are curiously waiting your response for our package. If you have any question please let us know.
Best.
Hi Gulden, @guldenolgun
Thank you for your submission. Currently, the package does not meet Bioconductor standards. Please see the review below and make considerable improvements to the package for a second review.
Best, Marcel
Depends:
to Suggests:
.BugReports:
fieldreadbed
and readGMT
functions necessary? Some of these have been
written by other packages. See:
http://bioconductor.org/developers/how-to/commonMethodsAndClasses/TxDb.*
and org.*.db
packages.eval=FALSE
in code chunks. This creates stale code quickly.
Pseudocode is not acceptable see line #256PNG
files when you can evaluate code and have a plot outputdata.frame
in the annotate.R
file. See Martin's example here:
https://stackoverflow.com/questions/39217432/r-improving-nested-ifelse-statements-multiple-patternsassign()
, the go
object is being assigned to itself.1:dim(x)[1]
sequence generation. Use the more robust
seq_len(nrow(x))
BiocCheck
on the package to see
recommendations with regards to sapply
, 1:length(n)
, etc. Stay within the
80 column width recommendations. This makes for neater code.hg
argument to something more descriptive and less
specific such as 'genome'.goEnrichment
and
related functions. This will let the user see what assemblies are available.pAdjust
methods in goEnrichment
cRegulome
package for the miRCancer.db
and
see if that works for the purposes of corrbased*
functions.SummarizedExperiment
inputs in the calculateCorr
functiongeneGOEnricher
. They
should be checking that the inputs conform to a specific data type (e.g.,
"character" for Genes).GlobalEnv
within the function scope.R/getNearest.R#L1
)assembly
functionorg.*
package in keggPathwayDB
where other packages have done this already (see
EnrichmentBrowser
)..onLoad
messageGO.db
package (thanks @lgeistlinger) and remove data from
data/
folder or justify why the data you provided is different and
necessary. If the latter, consider providing an experiment data package
separately.Minor:
nrow
or ncol
for dim()[1]
and dim()[2]
, respectively.file.path(x[1], x[2])
instead of
paste0(x[1], "/", x[2], sep = "", collapse = "")
Hi @guldenolgun Please provide an update / response to the review. Thank you. -Marcel
Received a valid push; starting a build. Commits are:
29b9715 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
2583ebe Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
65a5938 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
82f971c Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
28499b4 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
7d71aca Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
07acd38 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
0409a5e update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
@LiNk-NY , I would like to thank for your helpful feedback. I made major changes in the code. However, I would like to share my ideas some points that you raised.
In namespace, you suggested me check the common methods and classes for 'readbed' and 'readGMT' functions. rtracklayer package imports txt formatted bed file and lots of other package (not common methods) accept data frames as bed and read gmt file. Our 'readbed' function accepts both txt formatted bed file and data.frames that needs to be converted to the bed. None of the functions support both features. Also, there is no common method for reading gmt file. Thus, these functions are existed in the current version.
In vignette, you mentioned "Pseudocode is not acceptable see line #256" . However, in this version, there is no pseudocode in this line. So, I could not fix this issue.
In R, you suggested me to check cRegulome package and see if it is suitable to use this package instead of using corrbased functions. However, functions of this package do not accept mRNA genes to get precalculated miRNA:mRNA correlation results for the given cancer. Also, none of the functions retrieve miRNAseq expression of the miRNA genes for the given cancer. Moreover, before calling functions of this package, database connection should be performed in order to use functions. Thus, I kept the functions.
Again in R, you suggested to avoid repetitive codes in assembly function. However, for each species, different org. and different TxDb data should be loaded and biomart object should be defined for the given species and the assembly. The only repetitive 2 line code is where data.frame UCSC data is converted to GRanges object and assigned to the global variable. Since I couldn't find a clear explanation for the scope of variables in if statement (since different programming languages have different variable scopes), I use same 2 line code for each statement to prevent the scoping error.
You recommended me to use EnrichmentBrowser package for mapping the symbols. When I checked this package, related function returns Entrez IDs or GeneSetCollection object that gene symbols are contained. However, there is an issue that is raised in Bioconductor forum for GeneSetCollection that gene symbols in GeneSetCollection are not up-to-date and some of the gene names are not official HGNC symbol so that it has to be mapped with org.* databases (This problem is for the MSigDB but we cannot guarantee that the same problem cannot occur for the KEGG). This problem is very important for our package since only overlapped gene symbols are enriched and we only care the official HGNC symbols. To not miss the genes in the analysis, I kept the function as it is.
https://support.bioconductor.org/p/110298/
Best Regards,
Hi @guldenolgun,
I don't see how readbed
would help users. There are functions already available that take a data.frame
and produce a GRanges
object (GenomicRanges::makeGRangesFromDataFrame
) as well as functions that import BED
files.
Sorry, my line numbers were different at the time of the review.
I went back and looked at the line numbers with issues: 216
, 236
, 247
and all code chunks that include 'code' with the eval=FALSE
flag.
Update your code chunks to minimize the number of code chunks with eval=FALSE
.
Save your users the frustration when coming upon code that purportedly works only to find out
that it is stale. Please avoid that in your package.
Concerning cRegulome
I was referring to the miRCancer.db
database file in the package and was wondering if you could make use of it.
The assembly
function will not be accepted as it stands because it requires users to download all those packages. The code is pretty much the same for all except for some calls to the useMart
function. This can be generated programmatically and without the need to install all packages.
I was referring to the specific implementation found in the EnrichmentBrowser
which does all the mapping of internally, see .org2pkg
specifically.
Best, Marcel
Agree about readbed()
. Also see https://rdrr.io/bioc/GSEABase/man/getObjects.html for reading GMT files.
Devoid of further commentary. I will close the issue within the coming days. Thank you @guldenolgun
@LiNk-NY , we are still working on your feedback. We completely changed the assembly function. However, we need couple of days.
Hi @guldenolgun, Please make sure your changes are in before Monday 10/21 COB so that I can have a last look at them. The hard deadline is October 23rd. Thank you. -Marcel
Received a valid push; starting a build. Commits are:
4575151 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
a4cc8d9 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
595c7a0 update
Received a valid push; starting a build. Commits are:
08f0847 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi @guldenolgun,
I had a look at your DESCRIPTION
file and it seems that
you are putting TxDb.*
packages in the Depends
field.
This would make your package incredibly inconvenient to
load given that you need several database packages loaded
before use.
Depends
field and move
them to the Suggests
. Load them conditionally for functions
that need them by using:if (!requireNamespace(<PKGNAMEHERE>, quietly = TRUE))
stop("Install package A in order to use this function.")
Received a valid push; starting a build. Commits are:
709da6e update
Received a valid push; starting a build. Commits are:
941c196 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi Gulden, @guldenolgun
Please refer to https://bioconductor.org/developers/how-to/buildingPackagesForBioc/
for more information about package Imports
and Depends
fields.
You should only have a minimal number of packages that you Depend
on. Packages
in the Depends
field are packages for which you are extending the codebase or
creating derivative classes (such as for SummarizedExperiment
).
Otherwise, most packages should be in the Imports
field in the DESCRIPTION
file.
Also, please have a look at your check
results. There are a number of issues / notes
to take care of. For example:
* checking installed package size ... NOTE
installed size is 10.1Mb
sub-directories of 1Mb or more:
data 9.7Mb
* checking dependencies in R code ... NOTE
Package in Depends field not imported from: ‘dbplyr’
These packages need to be imported from (in the NAMESPACE file)
for when this namespace is loaded but not attached.
package 'methods' is used but not declared
* checking R code for possible problems ... NOTE
createNetwork: warning in adjustcolor(c("gray50", "tomato", "gold",
"yellowgreen", "dark orange", "red", "blue", "green"), alpha = 0.6):
partial argument match of 'alpha' to 'alpha.f'
mirnaGOEnricher: warning in goEnrichment(gene = miNearGene, GOtype =
pkg.env$GOtype, org_assembly = org_assembly, pCut = pkg.env$pCut,
pAdjCut = pkg.env$pAdjCut, pAdjust = pkg.env$pAdjust, backG =
backGenes, backGType = backGType, min = pkg.env$min, enrichTest =
pkg.env$enrichTest): partial argument match of 'gene' to 'genes'
mirnaRegionGOEnricher: warning in goEnrichment(gene = miNearGene,
GOtype = pkg.env$GOtype, org_assembly = org_assembly, pCut =
pkg.env$pCut, pAdjCut = pkg.env$pAdjCut, pAdjust = pkg.env$pAdjust,
backG = backG, backGType = backGType, min = pkg.env$min, enrichTest =
pkg.env$enrichTest): partial argument match of 'gene' to 'genes'
KeggEnrichment: no visible global function definition for ‘new’
WikiEnrichment: no visible global function definition for ‘new’
annGO: no visible binding for global variable ‘td’
calculateCorr: no visible global function definition for ‘assay’
calculateCorr: no visible global function definition for ‘isEmpty’
commonGene: no visible global function definition for ‘queryHits’
commonGene: no visible global function definition for ‘subjectHits’
commonGene: no visible global function definition for ‘isEmpty’
corrbased: no visible binding for global variable ‘conn’
corrbasedMrna: no visible binding for global variable ‘mirna_base’
corrbasedMrna: no visible binding for global variable ‘feature’
drawDotPlot: no visible binding for global variable ‘Pvalue’
drawDotPlot: no visible binding for global variable ‘EnrichGeneNumber’
drawDotPlot: no visible binding for global variable ‘PAdjust’
geneGOEnricher: no visible binding for global variable ‘tad_hg19’
geneGOEnricher: no visible binding for global variable ‘tad_dmel’
geneGOEnricher: no visible binding for global variable ‘tad_hg38’
geneGOEnricher: no visible binding for global variable ‘tad_mm10’
geneGOEnricher: no visible global function definition for ‘new’
genePathwayEnricher: no visible binding for global variable ‘tad_hg19’
genePathwayEnricher: no visible global function definition for ‘new’
geneRegionGOEnricher: no visible binding for global variable ‘tad_hg19’
geneRegionGOEnricher: no visible binding for global variable ‘tad_dmel’
geneRegionGOEnricher: no visible binding for global variable ‘tad_hg38’
geneRegionGOEnricher: no visible binding for global variable ‘tad_mm10’
geneRegionGOEnricher: no visible binding for global variable ‘geneLoc’
geneRegionGOEnricher: no visible global function definition for ‘new’
geneRegionPathwayEnricher: no visible binding for global variable
‘tad_hg19’
geneRegionPathwayEnricher: no visible binding for global variable
‘geneLoc’
geneRegionPathwayEnricher: no visible global function definition for
‘new’
getNearToExon: no visible global function definition for
‘subsetByOverlaps’
getNearToIntron: no visible global function definition for
‘subsetByOverlaps’
getTADOverlap: no visible binding for global variable ‘tad_hg19’
getTADOverlap: no visible binding for global variable ‘tad_dmel’
getTADOverlap: no visible binding for global variable ‘tad_hg38’
getTADOverlap: no visible binding for global variable ‘tad_mm10’
getTADOverlap: no visible binding for global variable
‘subsetByOverlaps’
getTADOverlap: no visible global function definition for
‘subsetByOverlaps’
getUCSC: no visible global function definition for ‘subsetByOverlaps’
getUCSC: no visible global function definition for ‘unstrand’
getmiRNACount: no visible binding for global variable ‘study’
getmiRNACount: no visible binding for global variable ‘mirna_base’
goEnrichment: no visible global function definition for ‘new’
mirnaGOEnricher: no visible binding for global variable ‘tad_hg19’
mirnaGOEnricher: no visible binding for global variable ‘tad_dmel’
mirnaGOEnricher: no visible binding for global variable ‘tad_hg38’
mirnaGOEnricher: no visible binding for global variable ‘tad_mm10’
mirnaGOEnricher: no visible global function definition for
‘findOverlapPairs’
mirnaGOEnricher: no visible global function definition for ‘new’
mirnaPathwayEnricher: no visible binding for global variable ‘tad_hg19’
mirnaPathwayEnricher: no visible binding for global variable ‘tad_dmel’
mirnaPathwayEnricher: no visible binding for global variable ‘tad_hg38’
mirnaPathwayEnricher: no visible binding for global variable ‘tad_mm10’
mirnaPathwayEnricher: no visible global function definition for
‘findOverlapPairs’
mirnaPathwayEnricher: no visible global function definition for ‘new’
mirnaRegionGOEnricher: no visible binding for global variable
‘tad_hg19’
mirnaRegionGOEnricher: no visible binding for global variable
‘tad_dmel’
mirnaRegionGOEnricher: no visible binding for global variable
‘tad_hg38’
mirnaRegionGOEnricher: no visible binding for global variable
‘tad_mm10’
mirnaRegionGOEnricher: no visible global function definition for
‘findOverlapPairs’
mirnaRegionGOEnricher: no visible global function definition for ‘new’
mirnaRegionPathwayEnricher: no visible binding for global variable
‘tad_hg19’
mirnaRegionPathwayEnricher: no visible binding for global variable
‘tad_dmel’
mirnaRegionPathwayEnricher: no visible binding for global variable
‘tad_hg38’
mirnaRegionPathwayEnricher: no visible binding for global variable
‘tad_mm10’
mirnaRegionPathwayEnricher: no visible global function definition for
‘findOverlapPairs’
mirnaRegionPathwayEnricher: no visible global function definition for
‘new’
pathwayEnrichment: no visible global function definition for ‘new’
reactomeEnrichment: no visible global function definition for ‘new’
reactomePathwayDB: no visible binding for global variable
‘org.Sc.sgd.db’
topEnrichment : split_tibble: no visible binding for global variable
‘.’
Undefined global functions or variables:
. EnrichGeneNumber PAdjust Pvalue assay conn feature findOverlapPairs
geneLoc isEmpty mirna_base new org.Sc.sgd.db queryHits study
subjectHits subsetByOverlaps tad_dmel tad_hg19 tad_hg38 tad_mm10 td
unstrand
Consider adding
importFrom("methods", "new")
to your NAMESPACE file (and ensure that your DESCRIPTION Imports field
contains 'methods').
browseURL
during package
check. Use this function only when identical(interactive(), TRUE)
. R CMD BiocCheck NoRCE_0.99.18.tar.gz
for more
areas of improvement. Best, Marcel
Received a valid push; starting a build. Commits are:
9a4ad9c update
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.