Closed asenabouth closed 5 years ago
Hi @asenabouth
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: ascend
Type: Package
Title: ascend - Analysis of Single Cell Expression, Normalisation, and Differential expression
Version: 0.9.94
Author: c(person("Anne", "Senabouth", email = "a.senabouth@garvan.org.au", rol = "aut, cre"), person("Quan", "Nguygen", email = "quan.nguyen@imb.uq.edu.au", rol = "aut"))
Maintainer: Anne Senabouth <a.senabouth@garvan.org.au>
Description: Provides a series of tools for cleaning, normalisation and analysis of data produced by single cell experiments.
License: GPL-3
Encoding: UTF-8
LazyData: true
RoxygenNote: 6.1.1
Imports:
utils,
stats,
fields,
grDevices,
graphics,
ggplot2,
ggbeeswarm,
RColorBrewer,
gridExtra,
dynamicTreeCut,
dendextend,
data.table,
reshape2,
dplyr,
tidyr,
MASS,
BiocGenerics,
umap,
Rtsne,
irlba,
fastcluster,
Rcpp,
RcppArmadillo
Suggests:
scater,
scran,
Seurat,
scone,
devtools,
knitr,
locfit,
rmarkdown,
testthat,
KernSmooth,
DESeq,
DESeq2
VignetteBuilder: knitr
Depends: R (>= 3.6.0),
methods,
Matrix,
S4Vectors,
SummarizedExperiment,
SingleCellExperiment,
BiocParallel
Collate:
'RcppExports.R'
'ascend.R'
'ascend_DESeq.R'
'ascend_DESeq2.R'
'ascend_confoundingfactors.R'
'ascend_objects.R'
'ascend_getters.R'
'ascend_setters.R'
'ascend_methods.R'
'ascend_cellranger.R'
'ascend_dimreduction.R'
'ascend_clustering.R'
'ascend_diffexpression.R'
'ascend_filtering.R'
'ascend_imports.R'
'ascend_normalisation.R'
'ascend_plots.R'
'ascend_scran.R'
'ascend_subsetters.R'
'ascend_utilities.R'
'data.R'
biocViews: Software,
WorkflowStep,
Preprocessing,
QualityControl,
Normalization,
BatchEffect,
GeneExpression,
SingleCell,
DifferentialExpression
LinkingTo:
Rcpp,
RcppArmadillo
Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
4a58017 version 0.99.4 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
7945d37 version 0.99.5 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
bc059f3 version 0.9.5 cleanup update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
2ee182a version 0.99.62 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
ba8cf3d Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
7ae0d63 version 0.99.64 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hello, Here is review of your package. The code looks very well written and I only have a few concerns. [REQUIRED] tags must have their changes made or addressed. [CONSIDER] tags describe changes that are advisable but not necessary. Message me back when your are finished making changes or if you need help.
GENERAL
.git
directory is 12MB large.
This indicates that you may have committed larger files before deleting them.
Please use BFG-repo cleaner to reduce your package size.
https://rtyley.github.io/bfg-repo-cleaner/message()
instead of print()
for diagnostic
messages. The difference is that messages can be toggled off with
suppressMessages()
.match.arg()
in function declarations that have
several possible character values. For example, in runDESeq2()
, you could
have fileType = c("local", "parametric", "mean")
and later on in the
function statement, grab the user's selected value with
fileType <- match.arg(fileType)
. The first value is the default value.
match.arg()
will throw an error if an option outside of the specified is
given.controls
generic seems like too common a name. It should
be modified to something like ascendControls
. Another option may be to
reuse an existing generic from a source like the BiocGenerics
package
if applicable.vignettes/ascend-tutorial.Rmd
eval=FALSE
multiple times in this vignette. We
generally want to see user-facing code in the vignettes run on our builder. Is
there a reason why you've added these? There are some reasons where they are
acceptable like when they open an interactive ui.Received a valid push; starting a build. Commits are:
5744aca version 0.99.65 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
a816af3 version 0.99.66 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
609e3b2 version 0.99.67 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
91e8f3a version 0.99.68 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
48c235d version 0.99.69 update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi, Just checking in. We tend to like to see no more than two weeks of inactivity on a submission. If there is no activity, we usually close the issue after two weeks. Closed issues can be reopened when the maintainer is ready to make more changes.
Hi @dvantwisk I am currently working on some updates to address your comments. It is taking some more time than expected though, so I am happy to reopen the issue once it's ready.
This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.
Thank you for your interest in Bioconductor.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.