Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

optimalFlow #1260

Closed HristoInouzhe closed 4 years ago

HristoInouzhe commented 5 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

c7f85e6 bump

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

6efd934 bump, bump, bump again

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

2348295 bmp, bmp, bmp again

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

HristoInouzhe commented 4 years ago

Hi @lshep ,

I've managed to solve the warning that I was getting in Linux. Its a bit dirty, but I've used \dontrun in two of the examples associated to labelTransfer and voteLableTransfer. It seems to be related to rnorm, although I export stats and explictely rnorm or maybe with the names of the variables, data.example or test.labels, are creating some conflict.

On the other hand the error I'm getting in windows is due to the fact that optimalFlowData is only built in Linux, therefore it is not able to locate that package.

I hope that now the rest of the revision process can continue.

Best regards and thanks for the attention.

lshep commented 4 years ago

@hpages is your reviewer and will review the packages.

Please use donttest instead of dontrun as donttest requires valid R code. @hpages will review the appropriate use of this.

It has been awhile since we looked at this issue. optimalFlowData should be available on all platforms unless you specified it not to build on windows. If it did not build on windows may I suggest doing a version bump on the data package so it is available for your software package to run.

hpages commented 4 years ago

@HristoInouzhe Are you going to follow @lshep's suggestion to bump optimalFlowData's version? Thanks!

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

8eb9da1 bump

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

7ef5986 bump in v

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

HristoInouzhe commented 4 years ago

@hpages, I have done the bump in the version of optimalFlowData and changed dontrun for donttest. Thanks for the attention!

hpages commented 4 years ago

Thanks. Unfortunately I get a crash when running R CMD build on the package. I've just spent the last 5 hours trying to isolate the problem and was finally able to produce a minimal reproducible example that seems to be suggesting that the culprit is the cytolib package (which you indirectly depend on via the flowMeans package). I just opened an issue here.

The issue is unrelated with optimalFlow but unfortunately the code in optimalFlow's vignette triggers the crash, which is a blocking issue at the moment. FWIW here is what I get:

hpages@spectre:~$ R CMD build optimalFlow
* checking for file ‘optimalFlow/DESCRIPTION’ ... OK
* preparing ‘optimalFlow’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ...*** Error in `/home/hpages/R/R-4.0.r78037/bin/exec/R': double free or corruption (out): 0x00007f1c160d0270 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7f1c154c87e5]
/lib/x86_64-linux-gnu/libc.so.6(+0x8037a)[0x7f1c154d137a]
/lib/x86_64-linux-gnu/libc.so.6(cfree+0x4c)[0x7f1c154d553c]
/home/hpages/R/R-4.0.r78037/library/Rfast/libs/Rfast.so(_Z15row_max_indicesN4Rcpp6MatrixILi14ENS_15PreserveStorageEEE+0x154)[0x7f1bf0327b44]
/home/hpages/R/R-4.0.r78037/library/Rfast/libs/Rfast.so(Rfast_row_max_indices+0x6f)[0x7f1bf032d27f]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0xfcaa0)[0x7f1c15b34aa0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13a55e)[0x7f1c15b7255e]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13e4f7)[0x7f1c15b764f7]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x2ce)[0x7f1c15b7c0fe]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x1490e9)[0x7f1c15b810e9]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x53d)[0x7f1c15b7c36d]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x14a51f)[0x7f1c15b8251f]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x134601)[0x7f1c15b6c601]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13e4f7)[0x7f1c15b764f7]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x1449c9)[0x7f1c15b7c9c9]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x818)[0x7f1c15b7c648]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x14abec)[0x7f1c15b82bec]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x18682f)[0x7f1c15bbe82f]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x136175)[0x7f1c15b6e175]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13e4f7)[0x7f1c15b764f7]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x1449c9)[0x7f1c15b7c9c9]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x144e17)[0x7f1c15b7ce17]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13a242)[0x7f1c15b72242]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13e4f7)[0x7f1c15b764f7]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x1449c9)[0x7f1c15b7c9c9]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x144e17)[0x7f1c15b7ce17]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13a242)[0x7f1c15b72242]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13e4f7)[0x7f1c15b764f7]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x1449c9)[0x7f1c15b7c9c9]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x144e17)[0x7f1c15b7ce17]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13a242)[0x7f1c15b72242]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13e4f7)[0x7f1c15b764f7]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_applyClosure+0x1b4)[0x7f1c15b7eb34]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x13e4f7)[0x7f1c15b764f7]
/home/hpages/R/R-4.0.r78037/lib/libR.so(Rf_eval+0x1a0)[0x7f1c15b7bfd0]
/home/hpages/R/R-4.0.r78037/lib/libR.so(+0x145d91)[0x7f1c15b7dd91]
======= Memory map: ========
00400000-00401000 r-xp 00000000 00:32 23419198                           /home/hpages/R/R-4.0.r78037/bin/exec/R
00600000-00601000 r--p 00000000 00:32 23419198                           /home/hpages/R/R-4.0.r78037/bin/exec/R
00601000-00602000 rw-p 00001000 00:32 23419198                           /home/hpages/R/R-4.0.r78037/bin/exec/R
00f1f000-1f6cd000 rw-p 00000000 00:00 0                                  [heap]
7f1be0000000-7f1be0021000 rw-p 00000000 00:00 0 
7f1be0021000-7f1be4000000 ---p 00000000 00:00 0 
7f1be8000000-7f1be8024000 rw-p 00000000 00:00 0 
7f1be8024000-7f1bec000000 ---p 00000000 00:00 0 
7f1bf025d000-7f1bf054e000 r-xp 00000000 00:32 23468705                   /home/hpages/R/R-4.0.r78037/library/Rfast/libs/Rfast.so
7f1bf054e000-7f1bf074d000 ---p 002f1000 00:32 23468705                   /home/hpages/R/R-4.0.r78037/library/Rfast/libs/Rfast.so
7f1bf074d000-7f1bf0750000 r--p 002f0000 00:32 23468705                   /home/hpages/R/R-4.0.r78037/library/Rfast/libs/Rfast.so
7f1bf0750000-7f1bf0754000 rw-p 002f3000 00:32 23468705                   /home/hpages/R/R-4.0.r78037/library/Rfast/libs/Rfast.so
7f1bf0754000-7f1bf0764000 rw-p 00000000 00:00 0 
7f1bf0764000-7f1bf07a1000 r-xp 00000000 103:02 9963668                   /usr/lib/x86_64-linux-gnu/libgslcblas.so.0.0.0
7f1bf07a1000-7f1bf09a0000 ---p 0003d000 103:02 9963668                   /usr/lib/x86_64-linux-gnu/libgslcblas.so.0.0.0
7f1bf09a0000-7f1bf09a1000 r--p 0003c000 103:02 9963668                   /usr/lib/x86_64-linux-gnu/libgslcblas.so.0.0.0
7f1bf09a1000-7f1bf09a2000 rw-p 0003d000 103:02 9963668                   /usr/lib/x86_64-linux-gnu/libgslcblas.so.0.0.0
7f1bf09a2000-7f1bf0bd0000 r-xp 00000000 103:02 9963666                   /usr/lib/x86_64-linux-gnu/libgsl.so.19.0.0
7f1bf0bd0000-7f1bf0dcf000 ---p 0022e000 103:02 9963666                   /usr/lib/x86_64-linux-gnu/libgsl.so.19.0.0
7f1bf0dcf000-7f1bf0dd2000 r--p 0022d000 103:02 9963666                   /usr/lib/x86_64-linux-gnu/libgsl.so.19.0.0
7f1bf0dd2000-7f1bf0de0000 rw-p 00230000 103:02 9963666                   /usr/lib/x86_64-linux-gnu/libgsl.so.19.0.0
7f1bf0de0000-7f1bf0de1000 rw-p 00000000 00:00 0 
7f1bf0de1000-7f1bf0e08000 r-xp 00000000 00:32 23517352                   /home/hpages/R/R-4.0.r78037/library/RcppZiggurat/libs/RcppZiggurat.so
7f1bf0e08000-7f1bf1008000 ---p 00027000 00:32 23517352                   /home/hpages/R/R-4.0.r78037/library/RcppZiggurat/libs/RcppZiggurat.so
7f1bf1008000-7f1bf1009000 r--p 00027000 00:32 23517352                   /home/hpages/R/R-4.0.r78037/library/RcppZiggurat/libs/RcppZiggurat.so
7f1bf1009000-7f1bf100a000 rw-p 00028000 00:32 23517352                   /home/hpages/R/R-4.0.r78037/library/RcppZiggurat/libs/RcppZiggurat.so
7f1bf100a000-7f1bf100e000 rw-p 00000000 00:00 0 
7f1bf100e000-7f1bf1075000 r-xp 00000000 00:32 23517231                   /home/hpages/R/R-4.0.r78037/library/transport/libs/transport.so
7f1bf1075000-7f1bf1275000 ---p 00067000 00:32 23517231                   /home/hpages/R/R-4.0.r78037/library/transport/libs/transport.so
7f1bf1275000-7f1bf1277000 r--p 00067000 00:32 23517231                   /home/hpages/R/R-4.0.r78037/library/transport/libs/transport.so
7f1bf1277000-7f1bf1278000 rw-p 00069000 00:32 23517231                   /home/hpages/R/R-4.0.r78037/library/transport/libs/transport.so
7f1bf1278000-7f1bf127a000 rw-p 00000000 00:00 0 
7f1bf127a000-7f1bf12ee000 r-xp 00000000 00:32 23464368                   /home/hpages/R/R-4.0.r78037/library/data.table/libs/datatable.so
7f1bf12ee000-7f1bf14ed000 ---p 00074000 00:32 23464368                   /home/hpages/R/R-4.0.r78037/library/data.table/libs/datatable.so
7f1bf14ed000-7f1bf14ee000 r--p 00073000 00:32 23464368                   /home/hpages/R/R-4.0.r78037/library/data.table/libs/datatable.so
7f1bf14ee000-7f1bf14ef000 rw-p 00074000 00:32 23464368                   /home/hpages/R/R-4.0.r78037/library/data.table/libs/datatable.so
7f1bf14ef000-7f1bf14f1000 rw-p 00000000 00:00 0 
7f1bf14f1000-7f1bf14f2000 ---p 00000000 00:00 0 
7f1bf14f2000-7f1bf1cf2000 rw-p 00000000 00:00 0 
7f1bf1cf2000-7f1bf1cf3000 ---p 00000000 00:00 0 
7f1bf1cf3000-7f1bf24f3000 rw-p 00000000 00:00 0 
7f1bf24f3000-7f1bf24f4000 ---p 00000000 00:00 0 
7f1bf24f4000-7f1bf2cf4000 rw-p 00000000 00:00 0 
7f1bf2cf4000-7f1bf2cf5000 ---p 00000000 00:00 0 
7f1bf2cf5000-7f1bf34f5000 rw-p 00000000 00:00 0 
7f1bf35cb000-7f1bf35cc000 rw-p 00000000 00:00 0 
7f1bf35cc000-7f1bf35cd000 ---p 00000000 00:00 0 
7f1bf35cd000-7f1bf3dcd000 rw-p 00000000 00:00 0 
7f1bf3dcd000-7f1bf3e55000 r-xp 00000000 00:32 23517258                   /home/hpages/R/R-4.0.r78037/library/dbscan/libs/dbscan.so
7f1bf3e55000-7f1bf4055000 ---p 00088000 00:32 23517258                   /home/hpages/R/R-4.0.r78037/library/dbscan/libs/dbscan.so
7f1bf4055000-7f1bf4057000 r--p 00088000 00:32 23517258                   /home/hpages/R/R-4.0.r78037/library/dbscan/libs/dbscan.so
7f1bf4057000-7f1bf4058000 rw-p 0008a000 00:32 23517258                   /home/hpages/R/R-4.0.r78037/library/dbscan/libs/dbscan.so
7f1bf4058000-7f1bf405b000 rw-p 00000000 00:00 0 
7f1bf405b000-7f1bf4080000 r-xp 00000000 103:02 10367546                  /usr/lib/x86_64-linux-gnu/ImageMagick-6.8.9/modules-Q16/coders/png.so
7f1bf4080000-7f1bf427f000 ---p 00025000 103:02 10367546                  /usr/lib/x86_64-linux-gnu/ImageMagick-6.8.9/modules-Q16/coders/png.so
7f1bf427f000-7f1bf4280000 r--p 00024000 103:02 10367546                  /usr/lib/x86_64-linux-gnu/ImageMagick-6.8.9/modules-Q16/coders/png.so
7f1bf4280000-7f1bf4281000 rw-p 00025000 103:02 10367546                  /usr/lib/x86_64-linux-gnu/ImageMagick-6.8.9/modules-Q16/coders/png.so
7f1bf4281000-7f1bf428a000 r-xp 00000000 103:02 9970127                   /usr/lib/x86_64-linux-gnu/libltdl.so.7.3.1
7f1bf428a000-7f1bf4489000 ---p 00009000 103:02 9970127                   /usr/lib/x86_64-linux-gnu/libltdl.so.7.3.1
7f1bf4489000-7f1bf448a000 r--p 00008000 103:02 9970127                   /usr/lib/x86_64-linux-gnu/libltdl.so.7.3.1
7f1bf448a000-7f1bf448b000 rw-p 00009000 103:02 9970127                   /usr/lib/x86_64-linux-gnu/libltdl.so.7.3.1
7f1bf448b000-7f1bf4675000 r-xp 00000000 103:02 9969725                   /usr/lib/x86_64-linux-gnu/libfftw3.so.3.4.4
7f1bf4675000-7f1bf4874000 ---p 001ea000 103:02 9969725                   /usr/lib/x86_64-linux-gnu/libfftw3.so.3.4.4
7f1bf4874000-7f1bf4888000 r--p 001e9000 103:02 9969725                   /usr/lib/x86_64-linux-gnu/libfftw3.so.3.4.4
7f1bf4888000-7f1bf4889000 rw-p 001fd000 103:02 9969725                   /usr/lib/x86_64-linux-gnu/libfftw3.so.3.4.4
7f1bf4889000-7f1bf48a0000 r-xp 00000000 103:02 9970123                   /usr/lib/x86_64-linux-gnu/liblqr-1.so.0.3.2
7f1bf48a0000-7f1bf4a9f000 ---p 00017000 103:02 9970123                   /usr/lib/x86_64-linux-gnu/liblqr-1.so.0.3.2
7f1bf4a9f000-7f1bf4aa0000 r--p 00016000 103:02 9970123                   /usr/lib/x86_64-linux-gnu/liblqr-1.so.0.3.2
7f1bf4aa0000-7f1bf4aa1000 rw-p 00017000 103:02 9970123                   /usr/lib/x86_64-linux-gnu/liblqr-1.so.0.3.2
7f1bf4aa1000-7f1bf4af3000 r-xp 00000000 103:02 9963214                   /usr/lib/x86_64-linux-gnu/liblcms2.so.2.0.6
7f1bf4af3000-7f1bf4cf2000 ---p 00052000 103:02 9963214                   /usr/lib/x86_64-linux-gnu/liblcms2.so.2.0.6
7f1bf4cf2000-7f1bf4cf3000 r--p 00051000 103:02 9963214                   /usr/lib/x86_64-linux-gnu/liblcms2.so.2.0.6
7f1bf4cf3000-7f1bf4cf7000 rw-p 00052000 103:02 9963214                   /usr/lib/x86_64-linux-gnu/liblcms2.so.2.0.6
7f1bf4cf7000-7f1bf4cf8000 rw-p 00000000 00:00 0 
7f1bf4cf8000-7f1bf4e19000 r-xp 00000000 103:02 9963327                   /usr/lib/x86_64-linux-gnu/libMagickWand-6.Q16.so.2.0.0
7f1bf4e19000-7f1bf5019000 ---p 00121000 103:02 9963327                   /usr/lib/x86_64-linux-gnu/libMagickWand-6.Q16.so.2.0.0
7f1bf5019000-7f1bf501a000 r--p 00121000 103:02 9963327                   /usr/lib/x86_64-linux-gnu/libMagickWand-6.Q16.so.2.0.0
7f1bf501a000-7f1bf501e000 rw-p 00122000 103:02 9963327                   /usr/lib/x86_64-linux-gnu/libMagickWand-6.Q16.so.2.0.0
7f1bf501e000-7f1bf5261000 r-xp 00000000 103:02 9963347                   /usr/lib/x86_64-linux-gnu/libMagickCore-6.Q16.so.2.0.0
7f1bf5261000-7f1bf5460000 ---p 00243000 103:02 9963347                   /usr/lib/x86_64-linux-gnu/libMagickCore-6.Q16.so.2.0.0
7f1bf5460000-7f1bf5474000 r--p 00242000 103:02 9963347                   /usr/lib/x86_64-linux-gnu/libMagickCore-6.Q16.so.2.0.0
7f1bf5474000-7f1bf54b3000 rw-p 00256000 103:02 9963347                   /usr/lib/x86_64-linux-gnu/libMagickCore-6.Q16.so.2.0.0
7f1bf54b3000-7f1bf54d2000 rw-p 00000000 00:00 0 
7f1bf54d2000-7f1bf554d000 r-xp 00000000 103:02 9963345                   /usr/lib/x86_64-linux-gnu/libMagick++-6.Q16.so.5.0.0
7f1bf554d000-7f1bf574d000 ---p 0007b000 103:02 9963345                   /usr/lib/x86_64-linux-gnu/libMagick++-6.Q16.so.5.0.0
7f1bf574d000-7f1bf5750000 r--p 0007b000 103:02 9963345                   /usr/lib/x86_64-linux-gnu/libMagick++-6.Q16.so.5.0.0
7f1bf5750000-7f1bf5751000 rw-p 0007e000 103:02 9963345                   /usr/lib/x86_64-linux-gnu/libMagick++-6.Q16.so.5.0.0
7f1bf5751000-7f1bf57d5000 r-xp 00000000 00:32 23496279                   /home/hpages/R/R-4.0.r78037/library/magick/libs/magick.so
7f1bf57d5000-7f1bf59d4000 ---p 00084000 00:32 23496279                   /home/hpages/R/R-4.0.r78037/library/magick/libs/magick.so
7f1bf59d4000-7f1bf59d6000 r--p 00083000 00:32 23496279                   /home/hpages/R/R-4.0.r78037/library/magick/libs/magick.so
7f1bf59d6000-7f1bf59d7000 rw-p 00085000 00:32 23496279                   /home/hpages/R/R-4.0.r78037/library/magick/libs/magick.so
7f1bf59d7000-7f1bf59dc000 rw-p 00000000 00:00 0 
7f1bf59dc000-7f1bf59fd000 r--p 00000000 103:02 9972832                   /usr/share/texmf/fonts/opentype/public/tex-gyre/texgyreheros-regular.otf
7f1bf59fd000-7f1bf5a04000 r--s 00000000 103:02 29494673                  /var/cache/fontconfig/4be9850f182b35c1350b6bbf2e42601c-le64.cache-6
7f1bf5a04000-7f1bf5a06000 r--s 00000000 103:02 29495045                  /var/cache/fontconfig/30a99c4256905863f7aa12b5e873c27c-le64.cache-6
7f1bf5a06000-7f1bf5a07000 r--s 00000000 103:02 29495044                  /var/cache/fontconfig/087e1975ba9a574b140bb1df193bf770-le64.cache-6
7f1bf5a07000-7f1bf5a0b000 r--s 00000000 103:02 29494827                  /var/cache/fontconfig/6aa41aa22e18b8fa06a12da28ea9c28b-le64.cache-6
7f1bf5a0b000-7f1bf5a16000 r--s 00000000 103:02 29491544                  /var/cache/fontconfig/945677eb7aeaf62f1d50efc3fb3ec7d8-le64.cache-6
7f1bf5a16000-7f1bf5a2b000 r--s 00000000 103:02 29491520                  /var/cache/fontconfig/04aabc0a78ac019cf9454389977116d2-le64.cache-6
7f1bf5a2b000-7f1bf5a66000 r--s 00000000 103:02 29491555                  /var/cache/fontconfig/365b55f210c0a22e9a19e35191240f32-le64.cache-6
7f1bf5a66000-7f1bf5afc000 r--s 00000000 103:02 29493881                  /var/cache/fontconfig/b80ce64a4bd0ac846cde5fbdd290c01c-le64.cache-6
7f1bf5afc000-7f1bf5b08000 r-xp 00000000 00:32 23419239                   /home/hpages/R/R-4.0.r78037/modules/lapack.so
7f1bf5b08000-7f1bf5d07000 ---p 0000c000 00:32 23419239                   /home/hpages/R/R-4.0.r78037/modules/lapack.so
7f1bf5d07000-7f1bf5d08000 r--p 0000b000 00:32 23419239                   /home/hpages/R/R-4.0.r78037/modules/lapack.so
7f1bf5d08000-7f1bf5d09000 rw-p 0000c000 00:32 23419239                   /home/hpages/R/R-4.0.r78037/modules/lapack.so
7f1bf5d09000-7f1bf5d12000 r-xp 00000000 103:02 394745                    /lib/x86_64-linux-gnu/libcrypt-2.23.so
7f1bf5d12000-7f1bf5f11000 ---p 00009000 103:02 394745                    /lib/x86_64-linux-gnu/libcrypt-2.23.so
7f1bf5f11000-7f1bf5f12000 r--p 00008000 103:02 394745                    /lib/x86_64-linux-gnu/libcrypt-2.23.so
7f1bf5f12000-7f1bf5f13000 rw-p 00009000 103:02 394745                    /lib/x86_64-linux-gnu/libcrypt-2.23.so
7f1bf5f13000-7f1bf5f41000 rw-p 00000000 00:00 0 
7f1bf5f41000-7f1bf6011000 r-xp 00000000 103:02 9964072                   /usr/lib/x86_64-linux-gnu/libsqlite3.so.0.8.6
7f1bf6011000-7f1bf6210000 ---p 000d0000 103:02 9964072                   /usr/lib/x86_64-linux-gnu/libsqlite3.so.0.8.6
7f1bf6210000-7f1bf6213000 r--p 000cf000 103:02 9964072                   /usr/lib/x86_64-linux-gnu/libsqlite3.so.0.8.6
7f1bf6213000-7f1bf6215000 rw-p 000d2000 103:02 9964072                   /usr/lib/x86_64-linux-gnu/libsqlite3.so.0.8.6
7f1bf6215000-7f1bf6216000 rw-p 00000000 00:00 0 
7f1bf6216000-7f1bf625d000 r-xp 00000000 103:02 9970008                   /usr/lib/x86_64-linux-gnu/libhx509.so.5.0.0
7f1bf625d000-7f1bf645c000 ---p 00047000 103:02 9970008                   /usr/lib/x86_64-linux-gnu/libhx509.so.5.0.0
7f1bf645c000-7f1bf645e000 r--p 00046000 103:02 9970008                   /usr/lib/x86_64-linux-gnu/libhx509.so.5.0.0
7f1bf645e000-7f1bf6460000 rw-p 00048000 103:02 9970008                   /usr/lib/x86_64-linux-gnu/libhx509.so.5.0.0
7f1bf6460000-7f1bf6461000 rw-p 00000000 00:00 0 
7f1bf6461000-7f1bf646f000 r-xp 00000000 103:02 9969990                   /usr/lib/x86_64-linux-gnu/libheimbase.so.1.0.0
7f1bf646f000-7f1bf666e000 ---p 0000e000 103:02 9969990                   /usr/lib/x86_64-linux-gnu/libheimbase.so.1.0.0
7f1bf666e000-7f1bf666f000 r--p 0000d000 103:02 9969990                   /usr/lib/x86_64-linux-gnu/libheimbase.so.1.0.0
7f1bf666f000-7f1bf6670000 rw-p 0000e000 103:02 9969990                   /usr/lib/x86_64-linux-gnu/libheimbase.so.1.0.0
7f1bf6670000-7f1bf6697000 r-xp 00000000 103:02 9970665                   /usr/lib/x86_64-linux-gnu/libwind.so.0.0.0
7f1bf6697000-7f1bf6897000 ---p 00027000 103:02 9970665                   /usr/lib/x86_64-linux-gnu/libwind.so.0.0.0
7f1bf6897000-7f1bf6898000 r--p 00027000 103:02 9970665                   /usr/lib/x86_64-linux-gnu/libwind.so.0.0.0
7f1bf6898000-7f1bf6899000 rw-p 00028000 103:02 9970665                   /usr/lib/x86_64-linux-gnu/libwind.so.0.0.0
7f1bf6899000-7f1bf68ae000 r-xp 00000000 103:02 9970406                   /usr/lib/x86_64-linux-gnu/libroken.so.18.1.0
7f1bf68ae000-7f1bf6aad000 ---p 00015000 103:02 9970406                   /usr/lib/x86_64-linux-gnu/libroken.so.18.1.0
7f1bf6aad000-7f1bf6aae000 r--p 00014000 103:02 9970406                   /usr/lib/x86_64-linux-gnu/libroken.so.18.1.0
7f1bf6aae000-7f1bf6aaf000 rw-p 00015000 103:02 9970406                   /usr/lib/x86_64-linux-gnu/libroken.so.18.1.0
7f1bf6aaf000-7f1bf6adf000 r-xp 00000000 103:02 9969988                   /usr/lib/x86_64-linux-gnu/libhcrypto.so.4.1.0
7f1bf6adf000-7f1bf6cdf000 ---p 00030000 103:02 9969988                   /usr/lib/x86_64-linux-gnu/libhcrypto.so.4.1.0
7f1bf6cdf000-7f1bf6ce0000 r--p 00030000 103:02 9969988                   /usr/lib/x86_64-linux-gnu/libhcrypto.so.4.1.0
7f1bf6ce0000-7f1bf6ce1000 rw-p 00031000 103:02 9969988                   /usr/lib/x86_64-linux-gnu/libhcrypto.so.4.1.0
7f1bf6ce1000-7f1bf6ce2000 rw-p 00000000 00:00 0 
7f1bf6ce2000-7f1bf6d81000 r-xp 00000000 103:02 9969425                   /usr/lib/x86_64-linux-gnu/libasn1.so.8.0.0
7f1bf6d81000-7f1bf6f80000 ---p 0009f000 103:02 9969425                   /usr/lib/x86_64-linux-gnu/libasn1.so.8.0.0
7f1bf6f80000-7f1bf6f81000 r--p 0009e000 103:02 9969425                   /usr/lib/x86_64-linux-gnu/libasn1.so.8.0.0
7f1bf6f81000-7f1bf6f84000 rw-p 0009f000 103:02 9969425                   /usr/lib/x86_64-linux-gnu/libasn1.so.8.0.0
7f1bf6f84000-7f1bf7008000 r-xp 00000000 103:02 9970095                   /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0
7f1bf7008000-7f1bf7207000 ---p 00084000 103:02 9970095                   /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0
7f1bf7207000-7f1bf720a000 r--p 00083000 103:02 9970095                   /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0
7f1bf720a000-7f1bf720d000 rw-p 00086000 103:02 9970095                   /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0
7f1bf720d000-7f1bf720e000 rw-p 00000000 00:00 0 
7f1bf720e000-7f1bf7216000 r-xp 00000000 103:02 9969992                   /usr/lib/x86_64-linux-gnu/libheimntlm.so.0.1.0
7f1bf7216000-7f1bf7415000 ---p 00008000 103:02 9969992                   /usr/lib/x86_64-linux-gnu/libheimntlm.so.0.1.0
7f1bf7415000-7f1bf7416000 r--p 00007000 103:02 9969992                   /usr/lib/x86_64-linux-gnu/libheimntlm.so.0.1.0
7f1bf7416000-7f1bf7417000 rw-p 00008000 103:02 9969992                   /usr/lib/x86_64-linux-gnu/libheimntlm.so.0.1.0
7f1bf7417000-7f1bf741a000 r-xp 00000000 103:02 397814                    /lib/x86_64-linux-gnu/libkeyutils.so.1.5
7f1bf741a000-7f1bf7619000 ---p 00003000 103:02 397814                    /lib/x86_64-linux-gnu/libkeyutils.so.1.5
7f1bf7619000-7f1bf761a000 r--p 00002000 103:02 397814                    /lib/x86_64-linux-gnu/libkeyutils.so.1.5
7f1bf761a000-7f1bf761b000 rw-p 00003000 103:02 397814                    /lib/x86_64-linux-gnu/libkeyutils.so.1.5
7f1bf761b000-7f1bf762c000 r-xp 00000000 103:02 9966496                   /usr/lib/x86_64-linux-gnu/libtasn1.so.6.5.1
7f1bf762c000-7f1bf782c000 ---p 00011000 103:02 9966496                   /usr/lib/x86_64-linux-gnu/libtasn1.so.6.5.1
7f1bf782c000-7f1bf782d000 r--p 00011000 103:02 9966496                   /usr/lib/x86_64-linux-gnu/libtasn1.so.6.5.1
7f1bf782d000-7f1bf782e000 rw-p 00012000 103:02 9966496                   /usr/lib/x86_64-linux-gnu/libtasn1.so.6.5.1
7f1bf782e000-7f1bf7887000 r-xp 00000000 103:02 9970282                   /usr/lib/x86_64-linux-gnu/libp11-kit.so.0.1.0
7f1bf7887000-7f1bf7a86000 ---p 00059000 103:02 9970282                   /usr/lib/x86_64-linux-gnu/libp11-kit.so.0.1.0
7f1bf7a86000-7f1bf7a90000 r--p 00058000 103:02 9970282                   /usr/lib/x86_64-linux-gnu/libp11-kit.so.0.1.0
7f1bf7a90000-7f1bf7a92000 rw-p 00062000 103:02 9970282                   /usr/lib/x86_64-linux-gnu/libp11-kit.so.0.1.0
7f1bf7a92000-7f1bf7acf000 r-xp 00000000 103:02 9969911                   /usr/lib/x86_64-linux-gnu/libgssapi.so.3.0.0
7f1bf7acf000-7f1bf7ccf000 ---p 0003d000 103:02 9969911                   /usr/lib/x86_64-linux-gnu/libgssapi.so.3.0.0
7f1bf7ccf000-7f1bf7cd0000 r--p 0003d000 103:02 9969911                   /usr/lib/x86_64-linux-gnu/libgssapi.so.3.0.0
7f1bf7cd0000-7f1bf7cd2000 rw-p 0003e000 103:02 9969911                   /usr/lib/x86_64-linux-gnu/libgssapi.so.3.0.0
7f1bf7cd2000-7f1bf7cd3000 rw-p 00000000 00:00 0 
7f1bf7cd3000-7f1bf7cec000 r-xp 00000000 103:02 9962902                   /usr/lib/x86_64-linux-gnu/libsasl2.so.2.0.25
7f1bf7cec000-7f1bf7eec000 ---p 00019000 103:02 9962902                   /usr/lib/x86_64-linux-gnu/libsasl2.so.2.0.25
7f1bf7eec000-7f1bf7eed000 r--p 00019000 103:02 9962902                   /usr/lib/x86_64-linux-gnu/libsasl2.so.2.0.25
7f1bf7eed000-7f1bf7eee000 rw-p 0001a000 103:02 9962902                   /usr/lib/x86_64-linux-gnu/libsasl2.so.2.0.25
7f1bf7eee000-7f1bf7f05000 r-xp 00000000 103:02 394744                    /lib/x86_64-linux-gnu/libresolv-2.23.so
7f1bf7f05000-7f1bf8105000 ---p 00017000 103:02 394744                    /lib/x86_64-linux-gnu/libresolv-2.23.so
7f1bf8105000-7f1bf8106000 r--p 00017000 103:02 394744                    /lib/x86_64-linux-gnu/libresolv-2.23.so
7f1bf8106000-7f1bf8107000 rw-p 00018000 103:02 394744                    /lib/x86_64-linux-gnu/libresolv-2.23.so
7f1bf8107000-7f1bf8109000 rw-p 00000000 00:00 0 
7f1bf8109000-7f1bf8113000 r-xp 00000000 103:02 9970088                   /usr/lib/x86_64-linux-gnu/libkrb5support.so.0.1
7f1bf8113000-7f1bf8312000 ---p 0000a000 103:02 9970088                   /usr/lib/x86_64-linux-gnu/libkrb5support.so.0.1
7f1bf8312000-7f1bf8313000 r--p 00009000 103:02 9970088                   /usr/lib/x86_64-linux-gnu/libkrb5support.so.0.1
7f1bf8313000-7f1bf8314000 rw-p 0000a000 103:02 9970088                   /usr/lib/x86_64-linux-gnu/libkrb5support.so.0.1
7f1bf8314000-7f1bf8317000 r-xp 00000000 103:02 393421                    /lib/x86_64-linux-gnu/libcom_err.so.2.1
7f1bf8317000-7f1bf8516000 ---p 00003000 103:02 393421                    /lib/x86_64-linux-gnu/libcom_err.so.2.1
7f1bf8516000-7f1bf8517000 r--p 00002000 103:02 393421                    /lib/x86_64-linux-gnu/libcom_err.so.2.1
7f1bf8517000-7f1bf8518000 rw-p 00003000 103:02 393421                    /lib/x86_64-linux-gnu/libcom_err.so.2.1
7f1bf8518000-7f1bf8544000 r-xp 00000000 103:02 9968219                   /usr/lib/x86_64-linux-gnu/libk5crypto.so.3.1
7f1bf8544000-7f1bf8743000 ---p 0002c000 103:02 9968219                   /usr/lib/x86_64-linux-gnu/libk5crypto.so.3.1
7f1bf8743000-7f1bf8745000 r--p 0002b000 103:02 9968219                   /usr/lib/x86_64-linux-gnu/libk5crypto.so.3.1
7f1bf8745000-7f1bf8746000 rw-p 0002d000 103:02 9968219                   /usr/lib/x86_64-linux-gnu/libk5crypto.so.3.1
7f1bf8746000-7f1bf8747000 rw-p 00000000 00:00 0 
7f1bf8747000-7f1bf880a000 r-xp 00000000 103:02 9968224                   /usr/lib/x86_64-linux-gnu/libkrb5.so.3.3
7f1bf880a000-7f1bf8a0a000 ---p 000c3000 103:02 9968224                   /usr/lib/x86_64-linux-gnu/libkrb5.so.3.3
7f1bf8a0a000-7f1bf8a17000 r--p 000c3000 103:02 9968224                   /usr/lib/x86_64-linux-gnu/libkrb5.so.3.3
7f1bf8a17000-7f1bf8a19000 rw-p 000d0000 103:02 9968224                   /usr/lib/x86_64-linux-gnu/libkrb5.so.3.3
7f1bf8a19000-7f1bf8a98000 r-xp 00000000 103:02 9969856                   /usr/lib/x86_64-linux-gnu/libgmp.so.10.3.0
7f1bf8a98000-7f1bf8c97000 ---p 0007f000 103:02 9969856                   /usr/lib/x86_64-linux-gnu/libgmp.so.10.3.0
7f1bf8c97000-7f1bf8c98000 r--p 0007e000 103:02 9969856                   /usr/lib/x86_64-linux-gnu/libgmp.so.10.3.0
7f1bf8c98000-7f1bf8c99000 rw-p 0007f000 103:02 9969856                   /usr/lib/x86_64-linux-gnu/libgmp.so.10.3.0
7f1bf8c99000-7f1bf8ccd000 r-xp 00000000 103:02 9970219                   /usr/lib/x86_64-linux-gnu/libnettle.so.6.2
7f1bf8ccd000-7f1bf8ecc000 ---p 00034000 103:02 9970219                   /usr/lib/x86_64-linux-gnu/libnettle.so.6.2
7f1bf8ecc000-7f1bf8ece000 r--p 00033000 103:02 9970219                   /usr/lib/x86_64-linux-gnu/libnettle.so.6.2
7f1bf8ece000-7f1bf8ecf000 rw-p 00035000 103:02 9970219                   /usr/lib/x86_64-linux-gnu/libnettle.so.6.2
7f1bf8ecf000-7f1bf8f01000 r-xp 00000000 103:02 9969994                   /usr/lib/x86_64-linux-gnu/libhogweed.so.4.2
7f1bf8f01000-7f1bf9100000 ---p 00032000 103:02 9969994                   /usr/lib/x86_64-linux-gnu/libhogweed.so.4.2
7f1bf9100000-7f1bf9101000 r--p 00031000 103:02 9969994                   /usr/lib/x86_64-linux-gnu/libhogweed.so.4.2
7f1bf9101000-7f1bf9102000 rw-p 00032000 103:02 9969994                   /usr/lib/x86_64-linux-gnu/libhogweed.so.4.2
7f1bf9102000-7f1bf9225000 r-xp 00000000 103:02 9962162                   /usr/lib/x86_64-linux-gnu/libgnutls.so.30.6.2
7f1bf9225000-7f1bf9424000 ---p 00123000 103:02 9962162                   /usr/lib/x86_64-linux-gnu/libgnutls.so.30.6.2
7f1bf9424000-7f1bf942f000 r--p 00122000 103:02 9962162                   /usr/lib/x86_64-linux-gnu/libgnutls.so.30.6.2
7f1bf942f000-7f1bf9431000 rw-p 0012d000 103:02 9962162                   /usr/lib/x86_64-linux-gnu/libgnutls.so.30.6.2
7f1bf9431000-7f1bf9432000 rw-p 00000000 00:00 0  ERROR
--- re-building ‘optimalFlow_vignette.Rmd’ using rmarkdown
Loading required package: dplyr

Attaching package: 'dplyr'

The following objects are masked from 'package:stats':

    filter, lag

The following objects are masked from 'package:base':

    intersect, setdiff, setequal, union

Loading required package: rlang

Attaching package: 'ellipse'

The following object is masked from 'package:graphics':

    pairs

Rfast_row_max_indices: ok1
row_max_indices: ok1
row_max_indices: ok2
row_max_indices: ok3
Aborted (core dumped)

A workaround is to make sure that Rfast's namespace gets loaded before cytolib's namespace. I think you can achieve this by making sure to have import(Rfast) before import(flowMeans) in your NAMESPACE file. Although I'm not sure this is doable with an roxygen2- generated NAMESPACE.

Best, H.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

887a28f bump

HristoInouzhe commented 4 years ago

@hpages I have implemented your suggestion. Now imort(Rfast) comes before import(FlowMeans). I hope that this will solve the crash. Best regards and sorry for the troubles caused, I know how tediuos it can be to solve that kind of problems.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

hpages commented 4 years ago

Yes this avoids the crash. Thanks for implementing the workaround. Note that the R CMD check warnings reported by the latest automated build require your attention.

When loading the package, I now get the following warning:

Warning messages:
1: replacing previous import ‘Rfast::nth’ by ‘dplyr::nth’ when loading ‘optimalFlow’ 
2: replacing previous import ‘Rfast::is_integer’ by ‘rlang::is_integer’ when loading ‘optimalFlow’ 
3: replacing previous import ‘Rfast::as_integer’ by ‘rlang::as_integer’ when loading ‘optimalFlow’ 

Since the only things you use from Rfast are dista and rowMaxs, you don't need to import the full Rfast's namespace. Instead you could import selectively the things you need. You will also need to do the same for flowMeans (you seem to only use the flowMeans function from this package). So in the end you will end up with something like this in your NAMESPACE file:

...
importFrom(Rfast,dista)
importFrom(Rfast,rowMaxs)
...
importFrom(flowMeans,flowMeans)
...

This should avoid the name collisions between Rfast and dplyr/rlang. It's important that the import from flowMeans come after the imports from Rfast to avoid the cytolib/Rfast crash.

Thanks, H.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

537012d bump

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

HristoInouzhe commented 4 years ago

@hpages I have eliminated all warnings except the one concerning multiple plot versions. I hope taht this is what you were asking for.

hpages commented 4 years ago

THANK YOU! We're done... finally... and just in time for the 3.11 release. Thanks for your quick response to the latest issues I reported.

Cheers, H.

bioc-issue-bot commented 4 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.

Thank you for contributing to Bioconductor!

HristoInouzhe commented 4 years ago

@hpages and @lshep thanks a lot for your attention and hard work! It is very statisfying to have my package on Bioconductor and I hope it will be an useful contribution for the interested user. Best regards, Hristo.

HristoInouzhe commented 4 years ago

@hpages I have an urgent question, I need to make a change on the optimalFlowData package since I've been informed of a problem with the data. Can I still do it now or do I need to wait untill the package is released. The change only concernes the data, I will just change the .RData files and everything else will stay the same.

HristoInouzhe commented 4 years ago

@hpages I can bump the version and do the new build as soon as you give me the green light.

mtmorgan commented 4 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/HristoInouzhe.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("optimalFlowData"). The package 'landing page' will be created at

https://bioconductor.org/packages/optimalFlowData

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

mtmorgan commented 4 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/HristoInouzhe.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("optimalFlow"). The package 'landing page' will be created at

https://bioconductor.org/packages/optimalFlow

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

hpages commented 4 years ago

I need to make a change on the optimalFlowData package since I've been informed of a problem with the data. Can I still do it now or do I need to wait untill the package is released.

We run the data experiment builds only twice a week (on Mondays and Thursdays):

https://bioconductor.org/checkResults/3.11/data-experiment-LATEST/

Until then, optimalFlow will look broken on the build report for software packages because optimalFlowData won't be on the build machines yet:

https://bioconductor.org/checkResults/3.11/bioc-LATEST/

If you didn't push your change to optimalFlowData in time before @mtmorgan added the package to our git server at git.bioconductor.org, then push them now. It makes no difference. Except that from now on you'll need to remember to also push any change you make to your packages to git.bioconductor.org in addition to GitHub. Make sure to look at the documentation for how to keep your GitHub and Bioconductor repositories in sync (see the links that Martin sent you above). Note that your changes to optimalFlowData won't be picked up by our build system before the next data experiment builds (will be next Monday).

This issue is closed so I will no longer be monitoring it. Please use the bioc-devel mailing list for any further questions about the development of your packages (git, build system, etc...)

Thanks, H.