Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

ceRNAnetsim #1287

Closed selcenari closed 4 years ago

selcenari commented 4 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 4 years ago

Hi @selcenari

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Type: Package
Package: ceRNAnetsim
Title: Regulation Simulator of Interaction between miRNA and
    Competing RNAs (ceRNA)
Version: 0.99.0
Authors@R: 
    c(person(given = "Selcen",
   family = "Ari Yuka",
   role = c("aut", "cre"),
   email = "selcenarii@gmail.com",
   comment = c(ORCID = "0000-0002-0028-2453")),
      person(given = "Alper",
   family = "Yilmaz",
   role = "aut",
   email = "alperyilmaz@gmail.com",
   comment = c(ORCID = "0000-0002-8827-4887")))
Description: This package simulates regulations of ceRNA
    (Competing Endogenous) expression levels after a expression level
    change in one or more miRNA/mRNAs. The methodolgy adopted by the
    package has potential to incorparate any ceRNA (circRNA, lincRNA,
    etc.) into miRNA:target interaction network.  The package basically
    distributes miRNA expression over available ceRNAs where each ceRNA
    attracks miRNAs proportional to its amount. But, the package can
    utilize multiple parameters that modify miRNA effect on its target
    (seed type, binding energy, binding location, etc.).  The functions
    handle the given dataset as graph object and the processes progress
    via edge and node variables.
License: GPL (>= 3.0)
URL: https://github.com/selcenari/ceRNAnetsim
BugReports: https://github.com/selcenari/ceRNAnetsim/issues
Depends:
    R (>= 3.6),
    dplyr,
    tidygraph
Imports: 
    furrr,
    rlang,
    tibble,
    ggplot2,
    ggraph,
    igraph,
    purrr,
    tidyr,
    future
Suggests:
    knitr,
    png,
    rmarkdown,
    testthat,
    covr
VignetteBuilder: 
    knitr
biocViews:
    NetworkInference, 
    SystemsBiology,
    Network,
    GraphAndNetwork,
    Transcriptomics
Encoding: UTF-8
LazyData: true
RoxygenNote: 6.1.1

Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.

bioc-issue-bot commented 4 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

selcenari commented 4 years ago

Hi @Kayla-Morrell ,

I have built and checked the package with no build vignette option. But doesn't the Bioconductor do this in the background? In this case, what should we do?

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

Kayla-Morrell commented 4 years ago

@selcenari - could have possibly been the same time of day when our daily builders were trying to post. I kicked off a manual build and everything seemed to build alright. Just work on cleaning up the ERRORs and WARNINGs and then I'll be able to do the review of the package.

Best, Kayla

selcenari commented 4 years ago

Hi, i have committed last changes 4 day before. But the bioc-devel -issue-bot could not detect automatically. How can i handle it?

Kayla-Morrell commented 4 years ago

@selcenari - Have you set up your push hook for your repo?

selcenari commented 4 years ago

@Kayla-Morrell oh sorry. Thank you!!!

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

a232d9b Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

9d91cd7 Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

ac471fb Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

a2d550e Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

ab31ced Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

726362b Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

2279837 Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

fac4a5e Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

c32d658 latest notes

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

Kayla-Morrell commented 4 years ago

@selcenari - We seem to be having some issues with the single package builder at the moment. I will be fixing them and then kicking off a manual build of your package. Please don't push any commits until then. Thanks!

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

583fd69 description fail

selcenari commented 4 years ago

@Kayla-Morrell i am sorry about i did not see your comment. I have tried to solve this fail. Thank you

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

Kayla-Morrell commented 4 years ago

@selcenari - Not a problem. Everything should be all set now.

selcenari commented 4 years ago

@Kayla-Morrell Thank you!!!

Kayla-Morrell commented 4 years ago

Hello @selcenari,

Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be but we strongly encourage them. Comment back here with updates that have been made and when the package is ready for a re-review.

General package development

DESCRIPTION

NEWS

Vignettes

The 'Introduction' section serves as an abstract to introduce the objective, models, unique functions, key points, etc that distinguish the package from other packages of similar type.

The 'Installation' section should show to users how to download and load the package from Bioconductor. It should include code similar to the following and be eval = FALSE,

if(!requireNamespace("BiocManager", quietly = TRUE))
    install.packages("BiocManager")
BiocManager::install("ceRNAnetsim")

The last section of the vignette should be 'Session Info' and should include sessionInfo().

Man pages

R code

Best, Kayla

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

d2bd625 Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

b9c7b8f Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

selcenari commented 4 years ago

Hi @Kayla-Morrell

Firstly, Thanks for your review. We figured out problems except a few. I've listed changes in package following:

General package development

The 'Introduction' section serves as an abstract to introduce the objective, models, unique functions, key points, etc that distinguish the package from other packages of similar type.

The 'Installation' section should show to users how to download and load the package from Bioconductor. It should include code similar to the following and be eval = FALSE,

if(!requireNamespace("BiocManager", quietly = TRUE))
    install.packages("BiocManager")
BiocManager::install("ceRNAnetsim")

The last section of the vignette should be 'Session Info' and should include sessionInfo().

  • [x] SUGGESTION: Especially if you have lengthy vignettes, we highly suggest the use of table of contents.
  • [ ] SUGGESTION: For formatting reasons, consider shorter lines. There are 291 lines that are > 80 characters long.
  • [ ] SUGGESTION: For formatting reasons, consider 4 spaces instead of tabs. There are 13 lines that contain tabs.
  • [ ] SUGGESTION: For formatting reasons, consider multiples of 4 spaces for line indents. There are 456 lines that are not.

Best

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

938c853 Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

Kayla-Morrell commented 4 years ago

Hello @selcenari - I guess I was a bit preemptive with my review, we are still working on updating the R version on the single package builder. It should hopefully be resolved by the end of the week. Feel free to change back to R 3.6 for the time being so that you can get a proper build report. I can inform you when to make the change to R 4.0 when it is ready on our builder.

Thank you for you patience and I will re-review you package this week.

Best, Kayla

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

aab183b Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

6f271c4 fixed format for source files

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

cca3886 Update DESCRIPTION

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

selcenari commented 4 years ago

Hi @Kayla-Morrell,

Thanks for comment. I didn't have any problems when I changed the version.

As I mentioned in the comment, I marked some chunks of vihgnettes as "eval=FALSE". For reproducubility we also added "binder badge" to our project via github (as you see in here) . But also If we can arrange them as --no build vignettes, in build process, I can change them to eval=TRUE.

Thanks for your help...