Closed selcenari closed 4 years ago
Hi @selcenari
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Type: Package
Package: ceRNAnetsim
Title: Regulation Simulator of Interaction between miRNA and
Competing RNAs (ceRNA)
Version: 0.99.0
Authors@R:
c(person(given = "Selcen",
family = "Ari Yuka",
role = c("aut", "cre"),
email = "selcenarii@gmail.com",
comment = c(ORCID = "0000-0002-0028-2453")),
person(given = "Alper",
family = "Yilmaz",
role = "aut",
email = "alperyilmaz@gmail.com",
comment = c(ORCID = "0000-0002-8827-4887")))
Description: This package simulates regulations of ceRNA
(Competing Endogenous) expression levels after a expression level
change in one or more miRNA/mRNAs. The methodolgy adopted by the
package has potential to incorparate any ceRNA (circRNA, lincRNA,
etc.) into miRNA:target interaction network. The package basically
distributes miRNA expression over available ceRNAs where each ceRNA
attracks miRNAs proportional to its amount. But, the package can
utilize multiple parameters that modify miRNA effect on its target
(seed type, binding energy, binding location, etc.). The functions
handle the given dataset as graph object and the processes progress
via edge and node variables.
License: GPL (>= 3.0)
URL: https://github.com/selcenari/ceRNAnetsim
BugReports: https://github.com/selcenari/ceRNAnetsim/issues
Depends:
R (>= 3.6),
dplyr,
tidygraph
Imports:
furrr,
rlang,
tibble,
ggplot2,
ggraph,
igraph,
purrr,
tidyr,
future
Suggests:
knitr,
png,
rmarkdown,
testthat,
covr
VignetteBuilder:
knitr
biocViews:
NetworkInference,
SystemsBiology,
Network,
GraphAndNetwork,
Transcriptomics
Encoding: UTF-8
LazyData: true
RoxygenNote: 6.1.1
Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi @Kayla-Morrell ,
I have built and checked the package with no build vignette option. But doesn't the Bioconductor do this in the background? In this case, what should we do?
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
@selcenari - could have possibly been the same time of day when our daily builders were trying to post. I kicked off a manual build and everything seemed to build alright. Just work on cleaning up the ERRORs and WARNINGs and then I'll be able to do the review of the package.
Best, Kayla
Hi, i have committed last changes 4 day before. But the bioc-devel -issue-bot could not detect automatically. How can i handle it?
@selcenari - Have you set up your push hook for your repo?
@Kayla-Morrell oh sorry. Thank you!!!
Received a valid push; starting a build. Commits are:
a232d9b Update DESCRIPTION
Received a valid push; starting a build. Commits are:
9d91cd7 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
ac471fb Update DESCRIPTION
Received a valid push; starting a build. Commits are:
a2d550e Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
ab31ced Update DESCRIPTION
Received a valid push; starting a build. Commits are:
726362b Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
2279837 Update DESCRIPTION
Received a valid push; starting a build. Commits are:
fac4a5e Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
c32d658 latest notes
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
@selcenari - We seem to be having some issues with the single package builder at the moment. I will be fixing them and then kicking off a manual build of your package. Please don't push any commits until then. Thanks!
Received a valid push; starting a build. Commits are:
583fd69 description fail
@Kayla-Morrell i am sorry about i did not see your comment. I have tried to solve this fail. Thank you
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
@selcenari - Not a problem. Everything should be all set now.
@Kayla-Morrell Thank you!!!
Hello @selcenari,
Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be but we strongly encourage them. Comment back here with updates that have been made and when the package is ready for a re-review.
[ ] REQUIRED: File LICENSE is not mentioned in the DESCRIPTION file. It is not needed and should be removed.
[ ] REQUIRED: The raw package directory should not contain unnecessary files, system files, or hidden files. These files may be present in your local directory but should not be commited to git. What is the purpose of the 'Dockerfile' file, the '_pkgdown.yaml' file, and the 'codecov.yml' file?
[ ] REQUIRED: 'LazyData' should be set to false. When this field is true it can slow down the loading of packages with data.
[ ] REQUIRED: Now that we have a different devel version of Bioconductor, please update the R version dependency from 3.6 to 4.0.
[ ] REQUIRED: 'tibble' is being imported but I don't see it listed as an
import()
or importFrom()
in the NAMESPACE file. Please determine if this
package should be listed here or not.
The 'Introduction' section serves as an abstract to introduce the objective, models, unique functions, key points, etc that distinguish the package from other packages of similar type.
The 'Installation' section should show to users how to download and load the
package from Bioconductor. It should include code similar to the following and
be eval = FALSE
,
if(!requireNamespace("BiocManager", quietly = TRUE))
install.packages("BiocManager")
BiocManager::install("ceRNAnetsim")
The last section of the vignette should be 'Session Info' and should include
sessionInfo()
.
[ ] SUGGESTION: Especially if you have lengthy vignettes, we highly suggest the use of table of contents.
[ ] REQUIRED: Some of your vignettes should be combined and/or simplified. The idea of a vignette is to demonstrate how to accomplish non-trivial tasks embodying the core functionality of your package. You can have more than one vignette but I would suggest doing one that demonstrates the package as a whole (functions and such) and then one that walks through a real life examples (or how the user might use this in their research).
[ ] REQUIRED: A vignette provides reproducability: the vignette produces the same results as copying the corresponding commands into an R session. It is therefore essential that the vignette embed executed R code. short-cuts (e.g., using the Sweave eval=FALSE flag) undermine the benefit of vignettes and are generally not allowed; exceptions can be made with proper justification.
[ ] REQUIRED: Data man pages must include source information and data structure information. All of them need more information included in them.
[ ] SUGGESTION: For any function that isn't exported (e.g., gene_knowndown
)
you can add @keywords internal
to the roxygen documentation in the R code for
that function. That way the function won't be listed in the documentation index.
[ ] REQUIRED: Undefined global functions or variables: find_node_perturbation: no visible binding for global variable 'len' priming_graph: no visible global function definition for 'na.omit'. Consider adding `importFrom("stats", "na.omit") to your NAMESPACE file.
[ ] REQUIRED: Avoid 1:...; use seq_len()
or seq_along()
instead. Found in
files:
find_iteration.R, line 30
simulate_vis.R, line 45 (still using 1:..., this should be avoided)
simulate.R, line 39 and 59 (still using 1:..., this should be avoided)
[ ] SUGGESTION: In 'simulate_vis.R', I think there should be an argument that the user can indicate if they want the plots saved or not. After running through the vignette I had a number of plot files that I didn't need. Default could be that they are always saved, but the user can chose to not have them saved.
[ ] SUGGESTION: For formatting reasons, consider shorter lines. There are 291 lines that are > 80 characters long.
[ ] SUGGESTION: For formatting reasons, consider 4 spaces instead of tabs. There are 13 lines that contain tabs.
[ ] SUGGESTION: For formatting reasons, consider multiples of 4 spaces for line indents. There are 456 lines that are not.
Best, Kayla
Received a valid push; starting a build. Commits are:
d2bd625 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
b9c7b8f Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi @Kayla-Morrell
Firstly, Thanks for your review. We figured out problems except a few. I've listed changes in package following:
[x] REQUIRED: File LICENSE is not mentioned in the DESCRIPTION file. It is not needed and should be removed.
[x] REQUIRED: 'LazyData' should be set to false. When this field is true it can slow down the loading of packages with data.
[??] REQUIRED: Now that we have a different devel version of Bioconductor, please update the R version dependency from 3.6 to 4.0.
[!!!] I've upgraded version of package. But it gave error as you can see in build report. Rversion is 3.6 in Bioconductor package builder although BiocVersion is 3.10. How can that be figure out?
[x] REQUIRED: 'tibble' is being imported but I don't see it listed as an
import()
or importFrom()
in the NAMESPACE file. Please determine if this
package should be listed here or not.
[x] REQUIRED: All vignettes should minimially include these sections:
Introduction
Installation
Session Info.
The 'Introduction' section serves as an abstract to introduce the objective, models, unique functions, key points, etc that distinguish the package from other packages of similar type.
The 'Installation' section should show to users how to download and load the package from Bioconductor. It should include code similar to the following and be
eval = FALSE
,if(!requireNamespace("BiocManager", quietly = TRUE)) install.packages("BiocManager") BiocManager::install("ceRNAnetsim")
The last section of the vignette should be 'Session Info' and should include
sessionInfo()
.
- [x] SUGGESTION: Especially if you have lengthy vignettes, we highly suggest the use of table of contents.
[x] REQUIRED: Some of your vignettes should be combined and/or simplified. The idea of a vignette is to demonstrate how to accomplish non-trivial tasks embodying the core functionality of your package. You can have more than one vignette but I would suggest doing one that demonstrates the package as a whole (functions and such) and then one that walks through a real life examples (or how the user might use this in their research).
[??] REQUIRED: A vignette provides reproducability: the vignette produces the same results as copying the corresponding commands into an R session. It is therefore essential that the vignette embed executed R code. short-cuts (e.g., using the Sweave eval=FALSE flag) undermine the benefit of vignettes and are generally not allowed; exceptions can be made with proper justification.
[??] Actually, i know that entire vignettes must be reproducible. Because some of our functions are
time-consuming, so there were time-out problems when running some chunks in vignettes, for
example: in our first submission. I can
choose --no-build-vignettes
when performing local build. if we can do this in
your package builder, I can rearrange vignettes.
gene_knowndown
)
you can add @keywords internal
to the roxygen documentation in the R code for
that function. That way the function won't be listed in the documentation index.[x] REQUIRED: Undefined global functions or variables: find_node_perturbation: no visible binding for global variable 'len' priming_graph: no visible global function definition for 'na.omit'. Consider adding `importFrom("stats", "na.omit") to your NAMESPACE file.
[x] REQUIRED: Avoid 1:...; use seq_len()
or seq_along()
instead. Found in
files:
find_iteration.R, line 30 simulate_vis.R, line 45 (still using 1:..., this should be avoided) simulate.R, line 39 and 59 (still using 1:..., this should be avoided)
[x] SUGGESTION: In 'simulate_vis.R', I think there should be an argument that the user can indicate if they want the plots saved or not. After running through the vignette I had a number of plot files that I didn't need. Default could be that they are always saved, but the user can chose to not have them saved.
- [ ] SUGGESTION: For formatting reasons, consider shorter lines. There are 291 lines that are > 80 characters long.
- [ ] SUGGESTION: For formatting reasons, consider 4 spaces instead of tabs. There are 13 lines that contain tabs.
- [ ] SUGGESTION: For formatting reasons, consider multiples of 4 spaces for line indents. There are 456 lines that are not.
Best
Received a valid push; starting a build. Commits are:
938c853 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hello @selcenari - I guess I was a bit preemptive with my review, we are still working on updating the R version on the single package builder. It should hopefully be resolved by the end of the week. Feel free to change back to R 3.6 for the time being so that you can get a proper build report. I can inform you when to make the change to R 4.0 when it is ready on our builder.
Thank you for you patience and I will re-review you package this week.
Best, Kayla
Received a valid push; starting a build. Commits are:
aab183b Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
6f271c4 fixed format for source files
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
cca3886 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi @Kayla-Morrell,
Thanks for comment. I didn't have any problems when I changed the version.
As I mentioned in the comment, I marked some chunks of vihgnettes as "eval=FALSE". For reproducubility we also added "binder badge" to our project via github (as you see in here) . But also If we can arrange them as --no build vignettes, in build process, I can change them to eval=TRUE.
Thanks for your help...
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.