Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

eisaR #1417

Closed mbstadler closed 4 years ago

mbstadler commented 4 years ago

Remark: This is currently the case, except for an issue where the checker fails to correctly interpret non-standard code evaluation, as in BiocGenerics::subset(x, type = "exon"), where the checks fail due to a "missing" variable type.

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

Thank you!

bioc-issue-bot commented 4 years ago

Hi @mbstadler

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: eisaR
Title: Exon-Intron Split Analysis (EISA) in R
Version: 0.99.0
Authors@R: c(person("Michael", "Stadler", email = "michael.stadler@fmi.ch", role = c("aut", "cre")),
   person("Dimos", "Gaidatzis", email = "dimosthenis.gaidatzis@fmi.ch", role = "aut"),
   person("Lukas", "Burger", email = "lukas.burger@fmi.ch", role = "aut"),
   person("Charlotte", "Soneson", email = "charlotte.soneson@fmi.ch", role = "aut"))
Description: Exon-intron split analysis (EISA) uses ordinary RNA-seq data to measure
    changes in mature RNA and pre-mRNA reads across different experimental conditions
    to quantify transcriptional and post-transcriptional regulation of gene expression.
    For details see Gaidatzis et al., Nat Biotechnol 2015. doi: 10.1038/nbt.3269.
    eisaR implements the major steps of EISA in R.
Depends: R (>= 4.0.0)
License: GPL-3
biocViews: 
    Transcription,
    GeneExpression,
    GeneRegulation,
    FunctionalGenomics,
    Transcriptomics,
    Regression,
    RNASeq
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.0
Suggests: 
    knitr,
    rmarkdown,
    testthat,
    BiocStyle,
    QuasR,
    Rbowtie,
    Biostrings,
    BSgenome,
    BSgenome.Hsapiens.UCSC.hg38
VignetteBuilder: knitr
Imports: 
    graphics,
    stats,
    GenomicRanges,
    GenomicFeatures,
    S4Vectors,
    IRanges,
    AnnotationDbi,
    limma,
    edgeR,
    methods,
    SummarizedExperiment,
    BiocGenerics,
    rtracklayer,
    utils
bioc-issue-bot commented 4 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

9b84510 Integer value of start cde4ad0 Version bump 9929bc2 Merge pull request #15 from fmicompbio/fixvignette...

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

17b3f18 Remove empty intron ranges before restricting 918f281 Merge pull request #16 from fmicompbio/fixvignette...

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

9280206 Temporarily remove restrict() fc69f7d Merge pull request #17 from fmicompbio/fixvignette...

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

c22f01b Fix warning about type 19aa370 Merge pull request #18 from fmicompbio/fixvignette...

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

cc18a4b fix broken doc links c609b90 bump version

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

9ee2a50 update docs and bump version

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

65f6016 also allow EnsDb in getRegionsFromTxDb

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

LiNk-NY commented 4 years ago

Hi Michael, @mbstadler

Thank you for your submission to Bioconductor. I have taken a look at your package. It was a pretty straightforward review as most items are in order and well done.

Please see the short review below.

Best regards, Marcel


eisaR #1417

DESCRIPTION

NAMESPACE

vignettes

R

/

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

65d5d7f Add URL/BugReports fields to DESCRIPTION f97f79f Shorten lines in vignette 5b7cc66 remvove eisaR.R from vignette folder afea9ff add install section to eisaR vignette 77725ba bump version 7d24bea Merge pull request #19 from fmicompbio/biocrev_c ...

mbstadler commented 4 years ago

Hi Marcel, @LiNk-NY

Thank you for the review and the feedback.

We have implemented your suggestions, specifically:

Best regards, Michael and Charlotte

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

4bc9fb9 Finish setting up GitHub Actions, bump version

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

LiNk-NY commented 4 years ago

Hi Michael and Charlotte, @mbstadler and @csoneson

Thank you for making those changes. Your package has been accepted. Note. Remove the version="devel" option in the installation section for when the package is released.

Best, Marcel

bioc-issue-bot commented 4 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.

Thank you for contributing to Bioconductor!

mtmorgan commented 4 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/mbstadler.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("eisaR"). The package 'landing page' will be created at

https://bioconductor.org/packages/eisaR

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.