Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

SPsimSeq #1472

Closed sthawinke closed 4 years ago

sthawinke commented 4 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 4 years ago

Hi @sthawinke

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: SPsimSeq
Title: Semi-parametric simulation tool for bulk and single-cell RNA sequencing data
Version: 0.99.0
Authors@R: 
    c(person(given = "Alemu Takele",
 family = "Assefa",
 role = c("aut"),
 email = "alemutak@hotmail.com"),
    person(given = "Olivier",
 family = "Thas",
 role = c("ths"),
 email = "Olivier.Thas@ugent.be"),
    person(given = "Joris",
 family = "Meys",
 role = c("cre"),
 email = "Joris.Meys@ugent.be"),
    person(given = "Stijn",
 family = "Hawinkel",
 role = c("aut"),
 email = "stijnhawinkel@hotmail.com"))
Description: SPsimSeq uses a specially designed exponential family for density estimation 
    to constructs the distribution of gene expression levels from a given real 
    RNA sequencing data (single-cell or bulk), and subsequently, simulates a new 
    dataset from the estimated marginal distributions using Gaussian-copulas to 
    retain the dependence between genes. It allows simulation of multiple groups 
    and batches with any required sample size and library size.
License: GPL-2
Encoding: UTF-8
LazyData: true
URL: https://github.com/CenterForStatistics-UGent/SPsimSeq
Imports: 
         stats, 
         methods,
         SingleCellExperiment,  
         fitdistrplus, 
         graphics,  
         edgeR,
         Hmisc,
         WGCNA, 
         limma, 
         mvtnorm,
         phyloseq,
         utils
biocViews: GeneExpression, RNASeq, SingleCell, Sequencing, DNASeq
RoxygenNote: 7.1.0
Suggests: 
    knitr,    
    rmarkdown,
    LSD,
    testthat
VignetteBuilder: knitr
Depends: R (>= 3.6)

Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.

sthawinke commented 4 years ago

@AlemuTA you can follow the SPsimSeq review process here

bioc-issue-bot commented 4 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

mtmorgan commented 4 years ago

It might be helpful for the user to make the code chunks in your vignette shorter, with more commentary between each line. This might slow the reader down, so that they understand the code rather than simply cut-and-paste without understanding.

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

a10f33b Version bump

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

af89ac0 compressed data 2d6b77d Version bump

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

98a6a2e Faster rmvnorm generation 7913a62 R version

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

9e04dd6 Compressed data files and even shorter examples

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

62a2af2 Faster tests

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

788b065 Even smaller tests

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

8a6e66a Cutting down further on calculation time 5437ead Version bump and r version

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

7d3e18f One more try with smaller datasets

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

8c93351 Last try

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

c748176 Smaller datasets 31d832a Version bump

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

sthawinke commented 4 years ago

Hi @nturaga, are any changes needed before the review can resume?

nturaga commented 4 years ago

Review

R CMD build

R CMD INSTALL

DESCRIPTION

NAMESPACE

General

Warning in readLines(infile) :
  incomplete final line found on '/tmp/RtmpMrgi5t/file59882f797c51/SPsimSeq/tests/testthat.R'
Warning in readLines(infile) :
  incomplete final line found on '/tmp/RtmpMrgi5t/file59882f797c51/SPsimSeq/tests/testthat/test-SPsimSeq-input.R'
Warning in readLines(infile) :
  incomplete final line found on '/tmp/RtmpMrgi5t/file59882f797c51/SPsimSeq/tests/testthat/test-SPsimSeq-output.R'

NEWS

R

vignette

man

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

92303e6 Buildignore readme 0e7ea3c Newlines 309d365 No more : loops f18a5fa : loops out of vignette 6eb5087 Remove sapply from vignette 64b435e BiocStyle vignette 113a7ef Withur r version f5a00fe Passing all tests 842fe56 Version bump

sthawinke commented 4 years ago

Thanks for the feedback. I resolved the issues, an answer to your questions can be found below.

General

* What is the point of the README.Rmd and the README.md?

They have been added to .RbuildIgnore now

NEWS

* Add a NEWS file

There is currently a NEWS.md, is this sufficient, or what should be the extension?

R

* The package `matrixStats` makes functions like rowMeans much quicker
  and performant. Take a look at that see if you can use it in your
  codebase.

I have checked the performance, but currently base::rowMeans is still faster than matrixStats::rowMeans2, so I stuck to the former one. Yet the package cam in handy for optimizing another package, so thanks for the tip!

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 4 years ago

Received a valid push; starting a build. Commits are:

c3130da With r dependency

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

nturaga commented 4 years ago

Thanks for the updates. Good job!

bioc-issue-bot commented 4 years ago

Your package has been accepted. It will be added to the Bioconductor Git repository and nightly builds. Additional information will be posed to this issue in the next several days.

Thank you for contributing to Bioconductor!

mtmorgan commented 4 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/sthawinke.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("SPsimSeq"). The package 'landing page' will be created at

https://bioconductor.org/packages/SPsimSeq

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.