MethylSeqData - Githubissues

PeteHaitch commented 4 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Repository: https://github.com/PeteHaitch/MethylSeqData

Confirm the following by editing each check box to '[x]'

[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.

I am familiar with the essential aspects of Bioconductor software management, including:

[x] The 'devel' branch for new packages and features.
[x] The stable 'release' branch, made available every six months, for bug fixes.
[x] Bioconductor version control using Git (optionally via GitHub).

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 4 years ago

Hi @PeteHaitch

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: MethylSeqData
Title: Collection of Public DNA Methylation Sequencing Datasets
Version: 0.99.0
Date: 2020-08-10
Authors@R: c(
    person("Peter", "Hickey", email = "peter.hickey@gmail.com", 
    role = c("aut", "cre")))
Description: Base-level (i.e. cytosine-level) counts for a collection of public 
    bisulfite-seq datasets (e.g., WGBS and RRBS), provided as MethylExperiment 
    objects with sample- and base-level metadata.
License: CC0
NeedsCompilation: no
Depends: 
    SummarizedExperiment
Imports:
    ExperimentHub, 
    HDF5Array,
    rhdf5,
    GenomeInfoDb,
    S4Vectors,
    GenomicRanges,
    stats,
    IRanges,
    utils
Suggests: 
    BiocFileCache, 
    BiocStyle, 
    data.table, 
    knitr,
    rmarkdown,
    DeepBlueR
VignetteBuilder: knitr
Encoding: UTF-8
biocViews: 
    ExperimentHub,
    ExperimentData, 
    SequencingData, 
    Homo_sapiens_Data,
    Mus_musculus_Data,
    MethylSeqData
BuildResaveData: no
RoxygenNote: 7.1.1

PeteHaitch commented 4 years ago

This is an ExperimentHub data package. I've uploaded the data to the AWS S3 bucket and I am currently co-ordinating with @lshep to finalise making the data public.

bioc-issue-bot commented 4 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MethylSeqData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 4 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: e7815d6ede9944965fae9a4a332a5feba14fdd6f

PeteHaitch commented 4 years ago

@Kayla-Morrell do you think you'll get time to review this for the next release? I'm just trying to plan my workload leading up the next release. Thanks!

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MethylSeqData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

Kayla-Morrell commented 4 years ago

Hello @PeteHaitch - Sorry for the delay on this. I've looked over the package and have no necessary changes. I'm more than happy to accept it and thank you for your continued contribution to Bioconductor.

Best, Kayla

bioc-issue-bot commented 4 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

PeteHaitch commented 4 years ago

Thank you @Kayla-Morrell !

mtmorgan commented 4 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/PeteHaitch.keys is not empty), then no further steps are required. Otherwise, do the following:

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("MethylSeqData"). The package 'landing page' will be created at

https://bioconductor.org/packages/MethylSeqData

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

Bioconductor / Contributions

MethylSeqData #1675