Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

MSPrep #1694

Closed max-mcgrath closed 4 years ago

max-mcgrath commented 4 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 4 years ago

Hi @max-mcgrath

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: MSPrep
Title:
  Package for Summarizing, Filtering, Imputing, and Normalizing Metabolomics 
  Data
Version: 0.99.0
Authors@R:
  c(person("Max", "McGrath",
 email = "max.mcgrath@ucdenver.edu",
 role = c("aut", "cre")),
    person("Matt", "Mulvahill",
 email = "matt.mulvahill@gmail.com",
 role = c("aut")),
    person("Grant", "Hughes",
 email = "",
 role = c("aut")),
    person("Sean", "Jacobson", 
 email = "jacobsonseanr@gmail.com",
 role = c("aut")),
    person("Harrison", "Pielke-lombardo",
 email = "harrison.pielke-lombardo@cuanschutz.edu",
 role = c("aut")),
    person("Katerina", "Kechris",
 email = "Katerina.Kechris@cuanschutz.edu",
 role = c("aut", "cph", "ths")))
Description:
  Package performs summarization of replicates, filtering by frequency, several
  different options for imputing missing data, and a variety of options for 
  transforming, batch correcting, and normalizing data.
URL: https://github.com/KechrisLab/MSPrep
BugReports: https://github.com/KechrisLab/MSPrep/issues
Depends:
  R (>= 4.0)
Imports:
  SummarizedExperiment,
  S4Vectors,
  pcaMethods (>= 1.24.0),
  VIM,
  crmn,
  preprocessCore,
  sva,
  dplyr (>= 0.7),
  tidyr,
  tibble (>= 1.2),
  magrittr,
  rlang,
  stats,
  stringr,
  methods,
  ddpcr
Suggests:
  BiocStyle,
  knitr,
  rmarkdown,
  testthat (>= 1.0.2)
VignetteBuilder: knitr
LazyData: true
NeedsCompilation: no
License: GPL-3
biocViews: Metabolomics,
  MassSpectrometry,
  Preprocessing
Encoding: UTF-8
RoxygenNote: 7.1.1
bioc-issue-bot commented 4 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 4 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSPrep to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 4 years ago

This overall seems like a well organized and well documented package. Please see two minor notes below. When they are addressed I will accept the package

README

DESCRIPTION

Thank you.

bioc-issue-bot commented 4 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 73af43e24bd661064de4b869b6133067e1c4faef

max-mcgrath commented 4 years ago

Hi @lshep

Thank you for taking the time to review the package.

README

  • [X] Please include Bioconductor installation instructions

DESCRIPTION

  • [X] Please remove LazyData: true. We have rarely found it useful and that it can actually slow the installation process.

I've updated the README to include Bioconductor installation instructions and removed LazyData: true from the DESCRIPTION. I pushed the changes (including a bump to the version number) to the Bioconductor git repository and as you can see above the push was received. However, as of now I haven't received an updated build report (and I don't know if that's a problem). Please let me know if any further action is required on my part.

Thanks, Max

lshep commented 4 years ago

The SPB was down unexpectantly -- I've reviewed the changes manually and everything looks good. Thank you for your prompt response.

bioc-issue-bot commented 4 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

mtmorgan commented 4 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/max-mcgrath.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("MSPrep"). The package 'landing page' will be created at

https://bioconductor.org/packages/MSPrep

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.