Closed demar01 closed 3 years ago
Hi @demar01
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: RIC
Title: RIC (RNA interaction capture)
Version: 0.99.0
Authors@R:
person(given = c("Maria","Ni"),
family = c("Dermit","Shuai"),
role = c("aut","cre"),
comment = c(ORCID = "0000-0002-6287-8367",ORCID = "")
email = c("maria.dermit@qmul.ac.uk","nishuai@yahoo.com"))
Description: RIC package automates search for RBP from cRIC (RNA-interactome
capture)proteomics experiments. It requires tabular input (i.e. peptides.txt
files) generated by MaxQuant software for quantitative analysis of raw mass
spectrometry data. It uses QFeatures infrastructure to handle and process
high-throughput mass spectrometry data. Functions provided in the package
enable bacth correction and peptide aggregation as well as vizualization for
intensity distribition across replicates, moderated statistical analysis
adjusted for multiple hypothesis testing and scatter and volcano plots
visualizations, scatter and volcano plots.
License: GPL-2
Encoding: UTF-8
LazyData: true
Depends:
R (>= 4.1), ggplot2
RoxygenNote: 7.1.1
Imports:
assertthat,
dplyr,
stringr,
tibble,
tidyr,
purrr,
limma,
QFeatures,
rmarkdown,
magrittr,
tidyverse,
Biostrings
Suggests:
testthat (>= 3.0.0),
BiocStyle,
knitr,
covr
biocViews: Infrastructure, Proteomics, MassSpectrometry
VignetteBuilder: knitr
Config/testthat/edition: 3
The empty ORCID = ""
in comment = c(ORCID = "0000-0002-6287-8367",ORCID = "")
is blocking initial processing; can you please remove or update it?
Oh, I missed that. It is changed now. However I cannot see RIC package neither on
ssh -T git@git.bioconductor.org
nor on BiocCredentials
I can see another package, which is using the same SSH key.
What I am missing here?
It hasn't been been added to git.bioconductor.org because it was not a valid 'package'. Now that the ORCID issue has been updated, it will be processed; wait unitl the '1. awaiting moderation' tag has been replaced by '2. review in process'.
Sorry for the delay in responding. The Authors@R field is still not correct; I think it should be something like
Authors@R:
c(person(given = "Maria",
family = "Dermit",
role = c("aut","cre"),
comment = c(ORCID = "0000-0002-6287-8367"),
email = "maria.dermit@qmul.ac.uk"),
person(given = "Ni",
family = "Shuai",
role = "aut",
email = "nishuai@yahoo.com")
)
(a vector of person()
objects).
I changed and I updated the remotes in my repo
git remote -v
origin https://github.com/demar01/RIC.git (fetch)
origin https://github.com/demar01/RIC.git (push)
upstream git@git.bioconductor.org:packages/RIC.git (fetch)
upstream git@git.bioconductor.org:packages/RIC.git (push)
However, I cannot push after adding and commiting.
git push git@git.bioconductor.org:packages/RIC
fatal: Could not read from remote repository.
The package is not listed in
https://git.bioconductor.org/BiocCredentials/permissions_by_user/
What may I be missing?
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/RIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
To be add to our git the DESCRIPTION file has to be correct. Since the DESCRIPTION file was not correct, the package was not added to our git. The DESCRIPTION file is now correct, so the package has been added to our git; you should be able to push changes now.
...but it looks like your package depends on another package, RICdata, and that RICdata should have been submitted first. I think you should follow the instructions for adding an additional package, starting at step 3 of https://github.com/Bioconductor/Contributions#submitting-related-packages. Get the additional package building correctly (it needs to be moderated, so it will not be built until that step has occurred) and then return to RIC.
Appreciate your guidance!
Do you plan to submit RICdata here as an accompanied package? If so please remember to submit under this issue submitting related packages
Hi, Thanks for your message. Yes, I am planning to submit RICdata. In fact I tried to submit it (as an ExperimentalData package ) last week but it failed because it was too big. Do I necessarily need to submit it to ExperimentHub?
ExperimentHub is the recommend option for large file sizes.
In the ExperimentHubData vignette is says I would need assistance from a Bioconductor team member to submit data to ExperimentHub . Could you point me out to instructions to submit these data?
Many thanks
@demar01 I think I emailed you credentials. If you did not receive them please let me know.
@lshep, thank you, I confirm I have received them.
Do you plan on moving forward with the submission? We normally expect movement within 2-3 weeks to keep the submission process moving forward.
It is my intention to move forward with this submission. However, I would need to submit another package (RICdata) before submitting RIC. RICdata has some dependencies of other packages (RBDmap https://www.huber.embl.de/users/befische/RBDmap/Rpackage/index.html), which is not currently in bioconductor and I need to make sure I follow the dependencies correctly.
Maria Dermit Postdoctoral Research Assistant | Centre for Molecular Oncology
Barts Cancer Institute - a Cancer Research UK Centre of Excellence Queen Mary, University of London John Vane Science Centre, Charterhouse Square, London EC1M 6BQ Email: @.***
From: lshep @.> Sent: Tuesday, March 9, 2021 4:04 PM To: Bioconductor/Contributions @.> Cc: Maria Dermit @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] RIC (#1851)
Do you plan on moving forward with the submission? We normally expect movement within 2-3 weeks to keep the submission process moving forward.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F1851%23issuecomment-794092686&data=04%7C01%7C%7Cd1b3c516e71248e1ed7b08d8e3151594%7C569df091b01340e386eebd9cb9e25814%7C0%7C0%7C637509027009715837%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=A42CEB7C3KMsJMwSsNqUMfZtbNe5qsS6USZjCg4IEYo%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGGWHNQKFXF6LEKBS7DZJTTCY2JPANCNFSM4WKOH42A&data=04%7C01%7C%7Cd1b3c516e71248e1ed7b08d8e3151594%7C569df091b01340e386eebd9cb9e25814%7C0%7C0%7C637509027009715837%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fnaYROVnOHcYv1Q%2BqCp5bkr5W%2FwoIhQe9YfBGBQwjGo%3D&reserved=0.
Okay. Thank you for the clarification. Cheers
I will close this issue for now. When the other dependencies have been cleared up, please ping on this issue and I will reopen and continue the review. Cheers
This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.
Thank you for your interest in Bioconductor.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[X] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[X] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[X] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[X] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[X] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[X] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.