Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

genomicInstability #1944

Closed reef103 closed 3 years ago

reef103 commented 3 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 3 years ago

Hi @reef103

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: genomicInstability
Version: 0.99.0
Date: 2020-02-21
Title: Genomic Instability estimation for scRNA-Seq
Authors@R: c(person("Mariano", "Alvarez", role=c("aut", "cre"),
 email="reef103@gmail.com"),
 person("Pasquale", "Laise", role="aut",
 email="plaise@darwinhealth.com"),
 person("DarwinHealth", role="cph"))
Depends:
    R (>= 4.0.0),
    checkmate
Suggests:
    SingleCellExperiment,
    ExperimentHub,
    pROC
Imports:
    mixtools
Description:
    This package contain functions to run genomic instability analysis (GIA)
    from scRNA-Seq data.
    GIA estimates the association between gene expression and genomic location
    of the coding genes.
    It uses the aREA algorithm to quantify the enrichment of sets of
    contiguous genes (loci-blocks) on the gene expression profiles and
    estimates the Genomic Instability Score (GIS) for each analyzed cell.
License: file LICENSE
biocViews: SystemsBiology, GeneExpression, SingleCell
BiocType: Software
URL: https://github.com/DarwinHealth/genomicInstability
BugReports: https://github.com/DarwinHealth/genomicInstability
Encoding: UTF-8
ARoxygenNote: 7.1.1
RoxygenNote: 7.1.1
bioc-issue-bot commented 3 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nturaga commented 3 years ago

Hi,

Please be sure to get a clean build report in order to get a review. If you have questions about why you are having certain warnings/errors, reach out. The release is upon us, and more packages are going to flow in leaving less time for the reviewers. An open channel of communication (here) and some work, can get this package in for the release.

Best,

Nitesh

reef103 commented 3 years ago

Hi Nitesh,

I cloned and addressed both warnings, bumped the last digit of the version, but when trying to push, I'm getting an error related to my username.

I tried to change my username to "reef103" or "m.alvarez" with git config user.name but I'm still getting the same error. Help on this will be much appreciated.

Thanks!

FATAL: W any packages/genomicInstability m.alvarez DENIED by fallthru

(or you mis-spelled the reponame)

fatal: Could not read from remote repository.

Please make sure you have the correct access rights

and the repository exists.

On Thu, Mar 18, 2021 at 7:55 AM Nitesh Turaga @.***> wrote:

Hi,

Please be sure to get a clean build report in order to get a review. If you have questions about why you are having certain warnings/errors, reach out. The release is upon us, and more packages are going to flow in leaving less time for the reviewers. An open channel of communication (here) and some work, can get this package in for the release.

Best,

Nitesh

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/1944#issuecomment-801994776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMTMUOBVLCB7RLFEKZKPLTTEIH5RANCNFSM4YUOSB2A .

-- Mariano J. Alvarez

reef103 commented 3 years ago

Hi Nitesh,

Just a reminder I need help on setting my access credentials to the repository:

I cloned and addressed both warnings, bumped the last digit of the version, but when trying to push, I'm getting an error related to my username.

I tried to change my username to "reef103" or "m.alvarez" with git config user.name but I'm still getting the same error. Help on this will be much appreciated.

Thanks!

FATAL: W any packages/genomicInstability m.alvarez DENIED by fallthru

(or you mis-spelled the reponame)

fatal: Could not read from remote repository.

Please make sure you have the correct access rights

and the repository exists.

On Thu, Mar 18, 2021 at 7:55 AM Nitesh Turaga @.***> wrote:

Hi,

Please be sure to get a clean build report in order to get a review. If you have questions about why you are having certain warnings/errors, reach out. The release is upon us, and more packages are going to flow in leaving less time for the reviewers. An open channel of communication (here) and some work, can get this package in for the release.

Best,

Nitesh

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/1944#issuecomment-801994776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMTMUOBVLCB7RLFEKZKPLTTEIH5RANCNFSM4YUOSB2A .

-- Mariano J. Alvarez

nturaga commented 3 years ago

The same thing here as well. I've fixed it for you here.

reef103 commented 3 years ago

I never change my username, it is reef103 in GitHub as well. The repository was cloned in Bioc from Github.

Mariano

On Wed, Mar 31, 2021 at 7:44 AM Nitesh Turaga @.***> wrote:

The same thing here as well, you've ended up creating more work for the git administrator by changing the name. The user should stick to the username provided by Bioconductor, it's an internal name for identification and is not public.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/1944#issuecomment-811123882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMTMUK7KVLZH2FNM3RPAF3TGMYLPANCNFSM4YUOSB2A .

-- Mariano J. Alvarez

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: cb1f43ecc72a6c5450737e3543054edea8aaaeaf

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 2272066060a4eda29de41342ec1d4935e02b1278

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nturaga commented 3 years ago

Hopefully it works as expected now (I see you have been able to push).

I also see that you have access to multiple other packages, it should all reflect on your BiocCredentials account now.

reef103 commented 3 years ago

Thanks!

Mariano

On Mar 31, 2021, at 9:53 AM, Nitesh Turaga @.***> wrote:

 Hopefully it works as expected now (I see you have been able to push).

I also see that you have access to multiple other packages, it should all reflect on your BiocCredentials account now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ebf15b5e443026b34456d84d18982e059a0244dd

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0ca6138e284637612b12635cf28046cbac383a79

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nturaga commented 3 years ago

Hi @reef103 ,

Please take a look at your build report and fix the following coding practice issues,

* Checking coding practice...
    * NOTE: Avoid sapply(); use vapply()
      Found in files:
        analysis.r (line 44, column 32)
        analysis.r (line 53, column 9)
        analysis.r (line 116, column 24)
        analysis.r (line 132, column 25)
        analysis.r (line 134, column 22)
        enrichment.r (line 11, column 11)
        general.r (line 57, column 5)
        mixGaussianFit.r (line 19, column 13)
        mixGaussianFit.r (line 27, column 25)
        mixGaussianFit.r (line 28, column 14)
        mixGaussianFit.r (line 33, column 27)
        mixGaussianFit.r (line 34, column 13)
        mixGaussianFit.r (line 35, column 14)
        mixGaussianFit.r (line 43, column 14)
        mixGaussianFit.r (line 66, column 15)
        mixGaussianFit.r (line 114, column 19)
        mixGaussianFit.r (line 125, column 16)
        mixGaussianFit.r (line 128, column 12)
        mixGaussianFit.r (line 154, column 21)
        plots.r (line 121, column 20)
        plots.r (line 130, column 19)
        plots.r (line 132, column 19)
        plots.r (line 259, column 12)
    * NOTE: Avoid the use of 'paste' in condition signalers
      Found in files:
        /var/folders/xd/gpmk_x0977q95yv9tx6z_pqm0000gv/T//RtmpqNN9ax/file5ff4539eb637/genomicInstability/R/analysis.r

Take a look at http://bioconductor.org/developers/how-to/efficient-code/.

nturaga commented 3 years ago

@reef103,

There is a disconnect between how your packages are submitted. As Lori previously mentioned to you, you still need to submit GSE103322 to Biconductor.

Both of your packages that are submitted are still producing ERRORs. I cannot / should not review packages that don't produce a clean build report. The labeling of your issues is also causing significant confusion.

Please clarify, how HNSCgenomicInstability is related to the package genomicInstability.

Please review https://bioconductor.org/developers/package-submission/ package submission guidelines and how the review process takes place. There is a place where you'd need to submit an AdditionalPackage with your software package (https://github.com/Bioconductor/Contributions#submitting-related-packages).

Please review all the required documentation linked above and we'll go forward.

Best,

Nitesh

bioc-issue-bot commented 3 years ago

This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.

Thank you for your interest in Bioconductor.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ec9d4c54eaaf1f79982a8accbd7a6da2c62e057b

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

reef103 commented 3 years ago

@nturaga ,

I addressed all the sapply() calls, bumped the version and now the package builder is reporting an error for a dataset from ExperimentHub, with access number EH5419, which was added to ExperimentHub two months ago, but seems to not be available in Bioconductor 3.13 anymore. Interestingly, I can build the vignette with no errors in my computer, using BioC 3.13 in R-devel v4.1 because the dataset is present in the cache. Can you please, let me know how should I proceed to have this dataset available so the vignette can be build? I really don't understand why, If the dataset was available 2 months ago, is not currently available. Your help on this is very much appreciated.

Mariano

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: d220f0b747c326932c6dcd2bec99443e7e675125

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

reef103 commented 3 years ago

@nturaga Now the there is an error from R CMD check which seems not related to my package, but to Expression Hub:

eh <- ExperimentHub::ExperimentHub()
snapshotDate(): 2021-05-05
> dset <- eh[["EH5419"]]
Bioconductor version 3.13 (BiocManager 1.30.15), R 4.1.0 alpha (2021-04-29
  r80247)
Installing package(s) 'GSE103322'
Error in UseMethod("conditionMessage") : 
  no applicable method for 'conditionMessage' applied to an object of class "character"
Calls: [[ ... tryCatchOne -> doTryCatch -> install.packages -> getDependencies
Execution halted

R CMD check gives no errors or warnings when running in my computer with R v4.1 and BioC v3.13. R CMD BiocCheck also gives no errors or warnings.

I would appreciate very much your advice on how to move forward with this.

Mariano

nturaga commented 3 years ago

I would first suggest reopening your package submission issue if you haven’t already.

The ExperimentHub issue is better addressed by @lshep. I’ll take a look in the meantime.

Best,

Nitesh

reef103 commented 3 years ago

Can you please, let me know how to re-open this issue? Is there a way I can do it, I mean to re-open the same issue #1944, or should I open a new issue by re-submitting the package?

Thanks,

Mariano

lshep commented 3 years ago

I will have to look into this more. I can not reproduce the ERROR on my system so I will have to go onto the builder. Also please remember. we have mentioned several times you need to submit the GSE103322 package to one of the two issues you have open for review.

reef103 commented 3 years ago

Hi @lshep , thanks for taking care of this. There are still things I don't understand:

1) I'm submitting only one package (genomicInstability) so the other issue should be closed.

2) GSE103322 was added as a dataset to ExperimentHub. Do I have to do anything else about that? Should I add GSE103322 to this issue?

Thanks,

Mariano

lshep commented 3 years ago

We have said it multiple times. The dataset was added to ExperimentHub but all hub packages go through the same review and need to be formally accepted. You need to submit GSE103322 as an issue here for review as we don't do a thorough review of the package when we add data to the hub. You can submit it as an additional package here as described in the comments about by nitesh https://github.com/Bioconductor/Contributions/issues/1944#issuecomment-822629226 .

Thank you we have closed the other issue.

reef103 commented 3 years ago

AdditionalPackage: https://github.com/reef103/GSE103322

bioc-issue-bot commented 3 years ago

Hi @reef103, Thanks for submitting your additional package: https://github.com/reef103/GSE103322. We are taking a quick look at it and you will hear back from us soon.

bioc-issue-bot commented 3 years ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/GSE103322 to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

reef103 commented 3 years ago

Thanks @lshep , I added the GSE103322 package but the build system is reporting problems while cloning it:

Package: GSE103322
--
Version: 0.0.0
RVersion: 4.1
BiocVersion: 3.13
BuildCommand:
BuildTime: NA
CheckCommand:
CheckTime:
BuildBinCommand:
BuildBinTime:
PackageFileSize: -1.00 KiB
BuildID:: GSE103322_20210512204437
PreProcessing: Starting Git clone.
PostProcessing: Git clone Failed.

I checked in GitHub and the repository is public. Any clue about what may I do to fix this and move forward?

Thanks !

lshep commented 3 years ago

Its because it hasn't been added to git yet. give us a second we are straightening it out

lshep commented 3 years ago

Before we process the GSE103322 could you please remove the bioconductor maintainer email from the Description list of authors. Your email should be the maintainer email in the package

reef103 commented 3 years ago

Thanks !!, and done, I removed the bioconductor maintainer e-mail.

lshep commented 3 years ago

I have kicked off a manual build to make sure everything is in proper order. Nitesh will proceed with the reviews of hte package and you should be able to trigger builds with an appropriate version bump to the description on either package. A build report should post shortly

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/GSE103322 to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 75650f3de607b400e16dbf3dbd399b159795aeff

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/GSE103322 to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

reef103 commented 3 years ago

Dear @lshep , GSE103322 is building with no errors or warnings. Looking forward to get the same for genomicInstability. Thanks for all your help

Mariano

nturaga commented 3 years ago

Hi @reef103

As you can see in your build report on May 12th the genomicInstability package is still carrying 'errors' in the build report.

Please issue another build of the package and correct them to move forward with the review.

The AdditionalPackage you submitted is fine, but the main package is still failing.

Best,

Nitesh

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 63ffd20c3c170defbe63ac0c50f885f4532ef704

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/genomicInstability to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

reef103 commented 3 years ago

Dear @nturaga ,

Thanks for following up on this. The error seems to be related to the accessibility of the GSE103322 from ExperimentHub. I can run build, check and bioccheck in my computer with no errors. At this point, I don't think there is anything I can do besides relying on your help to solve the issue with accessing the dataset from ExperimentHub in the build system. Please, let me know if there is anything else I can do from my side.

Best,

Mariano