Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

RCSL #2014

Closed QinglinMei closed 3 years ago

QinglinMei commented 3 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 3 years ago

Hi @QinglinMei

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: RCSL
Version: 0.99.0
Date: 2021-04-01
Title: Rank Constrained Similarity Learning for single cell RNA sequencing data
Description: A novel clustering algorithm and toolkit RCSL (Rank Constrained Similarity Learning) to accurately identify various cell types using scRNA-seq data from a complex tissue. RCSL considers both lo-cal similarity and global similarity among the cells to discern the subtle differences among cells of the same type as well as larger differences among cells of different types. RCSL uses Spearman’s rank correlations of a cell’s expression vector with those of other cells to measure its global similar-ity, and adaptively learns neighbour representation of a cell as its local similarity. The overall similar-ity of a cell to other cells is a linear combination of its global similarity and local similarity. 
Authors@R: c(
  person(given = "Qinglin", family = "Mei", email = "meiqinglinkf@163.com", role = c("cre","aut")),
  person(given = "Guojun", family = "Li", email = "guojunsdu@gmail.com", role = "fnd"),
  person(given = "Zhengchang", family = "Su", email = "zcsu@uncc.edu", role = "fnd")
  )
URL: https://github.com/QinglinMei/RCSL
License: GPL-3
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.1.1
biocViews: SingleCell, Software, Clustering, DimensionReduction, 
 RNASeq, Visualization, Sequencing
Suggests: knitr, rmarkdown, mclust, RcppAnnoy
VignetteBuilder: knitr
Imports:
    RcppAnnoy,
    igraph
bioc-issue-bot commented 3 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ae0e68bf7c0e33e87c90a4e241683b0b42f23c07

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fd356c86dff49fd0ac08092a95da8c0f273d907f

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 463ebcf2f76d8c95ccb4e87e9db88ee9bd0a7172

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 29e0d98e1e24d64ef47505ec3b2ca2e4284fa52d

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 854b96efa46dc568746db0a4723241ef45605fca

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: e163fc6fd20a9ed532c431778a44132c47786c4d

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: d0f02e9c93f17ce34b168394a200e5eafa1c9566

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 41b560f11802f4b49d3973f244c41051e5fbf7dd

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/RCSL to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

vjcitn commented 3 years ago

CMD check on 0.99.91 gives me the following, would you check please?

The error most likely occurred in:

> ### Name: PlotMST
> ### Title: Plot the visualization of constructed Minimum Spanning Tree
> ###   based on the clustering results of RCSL
> ### Aliases: PlotMST
>
> ### ** Examples
>
> gfData <- GenesFilter(yan)
> TrueLabel <- ann$cell_type1
> res_SimS <- SimS(gfData)
Calculate the Spearman correlation
Calculate the Nerighbor Representation
Find neighbors by KNN(Euclidean)
> C <- EstClusters(res_SimS$drData,res_SimS$S)
======== Calculate maximal strongly connected components ========
======== Calculate maximal strongly connected components ========
======== Calculate maximal strongly connected components ========
> res_BDSM <- BDSM(res_SimS$S,C)
======== Calculate maximal strongly connected components ========
> PlotMST(res_SimS$drData,res_BDSM$y,TrueLabel)
Error in geom_point(data = reducedData, aes(x = X1, y = X2, color = label),  :
  could not find function "geom_point"
vjcitn commented 3 years ago

Even in Rstudio, if I add library(ggplot2) before attempting example(PlotMST), the plot that I get is not what you intend. I get

Screenshot from 2021-04-20 08-13-14

by introducing plotly::ggplotly, where transparency is better supported, I get

Screenshot from 2021-04-20 08-12-00

Please run your example in command-line R and try to set the graphics parameters so a reasonable display is produced in this bare-bones setup. Or advise the user on the transparency-capable visualization approach to be used.

vjcitn commented 3 years ago

I see you are passing check on the builder but on my machine

> example(PlotMST)

PltMST> gfData <- GenesFilter(yan)

PltMST> TrueLabel <- ann$cell_type1

PltMST> res_SimS <- SimS(gfData)
Calculate the Spearman correlation 
Calculate the Nerighbor Representation 
Find neighbors by KNN(Euclidean) 

PltMST> C <- EstClusters(res_SimS$drData,res_SimS$S)
======== Calculate maximal strongly connected components ======== 
======== Calculate maximal strongly connected components ======== 
======== Calculate maximal strongly connected components ======== 

PltMST> res_BDSM <- BDSM(res_SimS$S,C)
======== Calculate maximal strongly connected components ======== 

PltMST> PlotMST(res_SimS$drData,res_BDSM$y,TrueLabel)
Error in geom_point(data = reducedData, aes(x = X1, y = X2, color = label),  : 
  could not find function "geom_point"

Enter a frame number, or 0 to exit   

1: example(PlotMST)
2: source(tf, local, echo = echo, prompt.echo = paste0(prompt.prefix, getOptio
3: withVisible(eval(ei, envir))
4: eval(ei, envir)
5: eval(ei, envir)
6: Rex423963b68e6b#13: PlotMST(res_SimS$drData, res_BDSM$y, TrueLabel)

Selection: 0
> library(ggplot2)
1/1 packages newly attached/loaded, see sessionInfo() for details.
> PlotMST(res_SimS$drData,res_BDSM$y,TrueLabel)

In other words the example needs to have library(ggplot2) added.

vjcitn commented 3 years ago

Would you please look at this?

bioc-issue-bot commented 3 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

vjcitn commented 3 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/QinglinMei.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("RCSL"). The package 'landing page' will be created at

https://bioconductor.org/packages/RCSL

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.