Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

GISPA #202

Closed BhaktiDwivedi closed 7 years ago

BhaktiDwivedi commented 8 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 8 years ago

Hi @BhaktiDwivedi

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: GISPA
Type: Package
Title: GISPA: Method for Gene Integrated Set Profile Analysis
Version: 0.99.0
Date: 2016-10-11
Author: Bhakti Dwivedi and Jeanne Kowalski
Maintainer: Bhakti Dwivedi <bhakti.dwivedi@emory.edu>
Description: GISPA is a method intended for the researchers who are interested
    in defining gene sets with similar, a priori specified molecular profile. GISPA
    method has been previously published in Nucleic Acid Research (Kowalski et al.,
    2016; PMID: 26826710).
Depends:
    R (>= 3.2),
    genefilter,
    changepoint
Imports:
    data.table,
    plyr,
    ggplot2,
    HH,
    lattice,
    latticeExtra,
    scatterplot3d
License: GPL-2
LazyData: true
Collate:
    'CopyChangeSet.R'
    'ExpressionSet.R'
    'VariantSet.R'
    'computePer.R'
    'bgfpsPer.R'
    'cof.R'
    'computePS.R'
    'computePercentage.R'
    'computeProp.R'
    'succDiff.R'
    'cptSamples.R'
    'cptPlot.R'
    'cptSlopeplot.R'
    'filterRows.R'
    'filterVars.R'
    'getBoxPlot.R'
    'wgfpsPer.R'
    'readDATA.R'
    'sortData.R'
    'gispa1D.R'
    'gispa2D.R'
    'gispa3D.R'
    'propBarplot.R'
    'stackedBarplot.R'
Suggests:
    knitr
VignetteBuilder: knitr
NeedsCompilation: no
RoxygenNote: 5.0.1
bioc-issue-bot commented 8 years ago

Your package has been approved for building. Your package is now submitted to our queue.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

mtmorgan commented 8 years ago

@LiNk-NY will review this package, but it's surprising that it does not present the user with an interface that builds on standard Bioconductor packages, especially ExpressionSet or SummarizedExperiment to represent expression data, and classes from GSEABase for representing and working with gene sets. The package should be modified before review to incorporate these classes as a way to foster interoperability with existing Bioconductor packages.

bioc-issue-bot commented 8 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161115065628.html

BhaktiDwivedi commented 8 years ago

Hi

I have made the changes and fixed the build results.

Thank you.

Regards,

Bhakti


From: bioc-issue-bot notifications@github.com Sent: Tuesday, November 15, 2016 6:55:35 AM To: Bioconductor/Contributions Cc: Dwivedi, Bhakti; Mention Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161115065628.html

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-260622317, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdVUwzjYeC18e-loNNyY1mtBk8EfAks5q-Z23gaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

lawremi commented 8 years ago

Sorry, but it's not evident how you resolved the lack of integration with Bioconductor. It's still entirely based on data.frame-like objects and exports questionable utilities like sortData(). One could use plyr::arrange() for that, or S4Vectors (0.13.3) sort(x, by=~variable), where x is a DataFrame or any other tabular data structure.

BhaktiDwivedi commented 8 years ago

Hi Michael,

Thank you for your comments. If I understand correctly, I should modify the code to include the use of existing bio-conductor packages and classes where-ever applies such as sortData? or is it has to be all data.matrix objects as well? Is their a way I can obtain a list of functions or issues in the code that are problematic. similar to issues report. Thank you

lawremi commented 8 years ago

The task is a combination of porting the key contributions of your package to operate on and return Bioconductor objects, and to drop functions like sortData() which are redundant with existing R/Bioconductor infrastructure. I also noticed readDATA() just munges some data without actually reading anything (and the casing is inconsistent).

BhaktiDwivedi commented 8 years ago

Thank you so much Michael. Let me work on it and I will submit the version with changes. I apologize as the revisions requested were obvious and I didn't understand.

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

0b7c322 revised version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161118111330.html

bioc-issue-bot commented 7 years ago

We only start builds when the Version field in the DESCRIPTION file is incremented. For example, by changing

Version: 0.99.0

to

Version 0.99.1

If you did not intend to start a build, you don't need to do anything. If you did want to start a build, increment the Version: field and try again.

bioc-issue-bot commented 7 years ago

We only start builds when the Version field in the DESCRIPTION file is incremented. For example, by changing

Version: 0.99.0

to

Version 0.99.1

If you did not intend to start a build, you don't need to do anything. If you did want to start a build, increment the Version: field and try again.

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

eb51154 revised version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161118115919.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

5a425fe revised version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161118191400.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

5be7bac revised version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161118194141.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

5bbeb86 revised version e83dfc3 revised version

BhaktiDwivedi commented 7 years ago

I am getting the below ERROR Bioconductor build msg on Mac OS X

I do not get this ERROR messages when I build on my Mac OS X using R CMD build GISPA R CMD check GISPA R CMD check GISPA_0.99.5.tar.gz R CMD BiocCheck GISPA.Rcheck/00_pkg_src/GISPA

Appreciate your help in suggesting ways to fix this error.

Thank you.

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161118195523.html

BhaktiDwivedi commented 7 years ago

Additionally, I am getting the below warning message:

WARNING: Update R version dependency from 3.3.2 to 3.4.

will changing the DESCRIPTION file from "Depends: R (>= 3.2.2)" to "Depends: R (>= 3.4)" work?

Thank you.

Regards, Bhakti

bioc-issue-bot commented 7 years ago

We only start builds when the Version field in the DESCRIPTION file is incremented. For example, by changing

Version: 0.99.0

to

Version 0.99.1

If you did not intend to start a build, you don't need to do anything. If you did want to start a build, increment the Version: field and try again.

BhaktiDwivedi commented 7 years ago

Hi Marcel,

Could you please help me with the below two build error and warnings?

I am getting the below ERROR Bioconductor build msg on Mac OS X

•installing the package to build vignettes ERROR: dependency HH is not available for package GISPA

•removing /private/var/folders/_l/1jpyvgt17qzgj1yz7f0z4np80000gr/T/Rtmp939MXS/Rinst16ad7608b810a/GISPA ERROR: package installation failed

I do not get this ERROR messages when I build on my Mac OS X using R CMD build GISPA R CMD check GISPA R CMD check GISPA_0.99.5.tar.gz R CMD BiocCheck GISPA.Rcheck/00_pkg_src/GISPA

Additionally, I am getting the below warning message:

WARNING: Update R version dependency from 3.3.2 to 3.4.

Appreciate your help and suggestions to fix them.

Thank you.

Regards, Bhakti

BhaktiDwivedi commented 7 years ago

Hi Marcel @LiNk-NY

Could you please help me with the below two build error and warnings?

I am getting the below ERROR Bioconductor build msg on Mac OS X

•installing the package to build vignettes ERROR: dependency HH is not available for package GISPA

•removing /private/var/folders/_l/1jpyvgt17qzgj1yz7f0z4np80000gr/T/Rtmp939MXS/Rinst16ad7608b810a/GISPA ERROR: package installation failed

I do not get this ERROR messages when I build on my Mac OS X using R CMD build GISPA R CMD check GISPA R CMD check GISPA_0.99.5.tar.gz R CMD BiocCheck GISPA.Rcheck/00_pkg_src/GISPA

Additionally, I am getting the below warning message:

WARNING: Update R version dependency from 3.3.2 to 3.4.

Appreciate your help and suggestions to fix them.

Thank you.

Regards, Bhakti

BhaktiDwivedi commented 7 years ago

@bioc-issue-bot

Could anyone please help me with the below two bioconductor build error and warnings?

I am getting the below ERROR Bioconductor build msg on Mac OS X

•installing the package to build vignettes ERROR: dependency HH is not available for package GISPA

•removing /private/var/folders/_l/1jpyvgt17qzgj1yz7f0z4np80000gr/T/Rtmp939MXS/Rinst16ad7608b810a/GISPA ERROR: package installation failed

I do not get this ERROR messages when I build on my Mac OS X using R CMD build GISPA R CMD check GISPA R CMD check GISPA_0.99.5.tar.gz R CMD BiocCheck GISPA.Rcheck/00_pkg_src/GISPA

Additionally, I am getting the below warning message:

WARNING: Update R version dependency from 3.3.2 to 3.4.

Appreciate your help and any suggestions to fix them.

Thank you.

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

7c634b9 updated version

BhaktiDwivedi commented 7 years ago

Hi @bioc-issue-bot @mtmorgan @lawremi @LiNk-NY

Based on my recent correspondence on bioc-devel@r-project.org, I was suggested to ignore the HH dependency/installation error on oaxaca. Also was referred to this recent post (https://stat.ethz.ch/pipermail/bioc-devel/2016-October/009997.html).

I have tried to make the changes. Please see the updated version. I greatly appreciate all your help with the review, suggestions, and comments.

Thank you

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20161205223034.html

LiNk-NY commented 7 years ago

Hi @BhaktiDwivedi, My apologies for the delay. I will get to your package today. Best regards, Marcel

BhaktiDwivedi commented 7 years ago

Thank you so much Marcel! Appreciate a lot!

Regards, Bhakti

From: Marcel Ramos [mailto:notifications@github.com] Sent: Friday, December 09, 2016 2:43 PM To: Bioconductor/Contributions Contributions@noreply.github.com Cc: Dwivedi, Bhakti bhakti.dwivedi@emory.edu; Mention mention@noreply.github.com Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi @BhaktiDwivedihttps://github.com/BhaktiDwivedi, My apologies for the delay. I will get to your package today. Best regards, Marcel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-266104089, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdU3mnvB6XeiR_iW5Q74LVEZ0u18bks5rGa84gaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

LiNk-NY commented 7 years ago

HI @BhaktiDwivedi, Thank you for submitting to Bioconductor. Below you will find feedback on your package GISPA.

Let me know if you have any questions. Regards, Marcel


GISPA

Package & Vignette

Organization

Grammar/Naming conventions

Overall, your package should be exporting around 5-7 functions with the appropriate changes. Please make use of the Bioconductor classes available.

Best regards, Marcel

LiNk-NY commented 7 years ago

Hi @BhaktiDwivedi, Your issue will be closed if you don't respond within the next 72 hours. Best regards, Marcel

BhaktiDwivedi commented 7 years ago

Hi Marcel,

Please do not close the issue. I am working on implementing the changes/additions requested. I am almost there. I will respond and upload the revised package within 72 hours or by 21st afternoon 12:20 PM? Hope that is alright?

Thank you!

Regards, Bhakti

From: Marcel Ramos [mailto:notifications@github.com] Sent: Wednesday, January 18, 2017 12:28 PM To: Bioconductor/Contributions Contributions@noreply.github.com Cc: Dwivedi, Bhakti bhakti.dwivedi@emory.edu; Mention mention@noreply.github.com Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi @BhaktiDwivedihttps://github.com/BhaktiDwivedi, Your issue will be closed if you don't respond within the next 72 hours. Best regards, Marcel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-273542364, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdZo_0pfESOP0mQsnYBPc1taYFLHdks5rTkukgaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

LiNk-NY commented 7 years ago

Hi @BhaktiDwivedi, Thank you for responding. I can wait for your revisions. You can take a bit longer to finish them up, if need be.

Regards, Marcel

BhaktiDwivedi commented 7 years ago

Hi Marcel,

Thank you! I am still working on the changes, I am trying to finish by tomorrow afternoon, if not it may push to Monday Jan 23rd. Hope its alright. I just want to let you know in advance, so please do not close the issue.

Appreciate your help and support.

Regards,

Bhakti


From: Marcel Ramos notifications@github.com Sent: Wednesday, January 18, 2017 6:04:54 PM To: Bioconductor/Contributions Cc: Dwivedi, Bhakti; Mention Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi @BhaktiDwivedihttps://github.com/BhaktiDwivedi, Thank you for responding. I can wait for your revisions. You can take a bit longer to finish them up, if need be.

Regards, Marcel

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-273630553, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdaq3OJm_KUE8zEUVsiyjU7ArMAcQks5rTpqWgaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

LiNk-NY commented 7 years ago

Hi Bhakti, @BhaktiDwivedi
Thank you for working on making those changes. Looking forward to them. Regards, Marcel

BhaktiDwivedi commented 7 years ago

Hi Marcel,

Appreciate your patience. Can I please request an extension till Jan 26th Thursday end of the day to finally submit the revised version? I would greatly appreciate your help. Please let me know.

Thank you.

Regards,

Bhakti


From: Marcel Ramos notifications@github.com Sent: Monday, January 23, 2017 11:30:28 AM To: Bioconductor/Contributions Cc: Dwivedi, Bhakti; Mention Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi Bhakti, @BhaktiDwivedihttps://github.com/BhaktiDwivedi Thank you for working on making those changes. Looking forward to them. Regards, Marcel

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-274537828, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdSPLHn26qBvim5GvXr8Je5xjgvrFks5rVNWkgaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

LiNk-NY commented 7 years ago

Hi @BhaktiDwivedi, Yes, you can submit tomorrow. Please have all the changes ready.

Best regards, Marcel

BhaktiDwivedi commented 7 years ago

Hi Marcel,

I will be uploading the revised package later tonight, so please bear with me. Thank you for understanding.

Regards, Bhakti

From: Dwivedi, Bhakti Sent: Monday, January 23, 2017 11:24 PM To: Bioconductor/Contributions Contributions@noreply.github.com; Bioconductor/Contributions reply@reply.github.com Cc: Mention mention@noreply.github.com Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi Marcel,

Appreciate your patience. Can I please request an extension till Jan 26th Thursday end of the day to finally submit the revised version? I would greatly appreciate your help. Please let me know.

Thank you.

Regards,

Bhakti


From: Marcel Ramos notifications@github.com<mailto:notifications@github.com> Sent: Monday, January 23, 2017 11:30:28 AM To: Bioconductor/Contributions Cc: Dwivedi, Bhakti; Mention Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi Bhakti, @BhaktiDwivedihttps://github.com/BhaktiDwivedi Thank you for working on making those changes. Looking forward to them. Regards, Marcel

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-274537828, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdSPLHn26qBvim5GvXr8Je5xjgvrFks5rVNWkgaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

LiNk-NY commented 7 years ago

Hi @BhaktiDwivedi, Please provide an update on the status of your package. Much appreciated. Thank you, Marcel

BhaktiDwivedi commented 7 years ago

Hi Marcel,

I have uploaded the revised package on GitHub; however I see a tag stating "version bump required". I did try 0.99.8 and then 0.99.9 but didn't make any change. Please let me know how I can fix this?

Also please see attached by responses to the changes requested.

I hope I have answered all your concerns and changes; however please let me know if there is anything else remaining.

Thank you.

Regards,

Bhakti


From: Marcel Ramos notifications@github.com Sent: Thursday, February 2, 2017 12:57:36 AM To: Bioconductor/Contributions Cc: Dwivedi, Bhakti; Mention Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi @BhaktiDwivedihttps://github.com/BhaktiDwivedi, Please provide an update on the status of your package. Much appreciated. Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-276875286, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdRj9tjHakB4tEKXxjhvXAk45Uh1rks5rYXBQgaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

dd5bd17 revised version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20170203003905.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

cf66de6 revised version 8ee61f4 revised version

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/GISPA_buildreport_20170203115258.html

LiNk-NY commented 7 years ago

Hi @BhaktiDwivedi, Thank you for making those changes. As @mtmorgan mentioned before, you should really make use of the classes in GSEABase to represent gene sets.

After a quick look at your package, there are still some points to be addressed.


Data

Code

Best regards, Marcel

BhaktiDwivedi commented 7 years ago

Hi @Marcel,

Thank you for the prompt review.

I will make the changes as per the below outlined points. I will also try to incorporate GSEABase to the existing function.

What’s the time-line to submit revised version with the changes? Please let me know.

Thank you.

Regards, Bhakti

From: Marcel Ramos [mailto:notifications@github.com] Sent: Friday, February 03, 2017 12:52 PM To: Bioconductor/Contributions Contributions@noreply.github.com Cc: Dwivedi, Bhakti bhakti.dwivedi@emory.edu; Mention mention@noreply.github.com Subject: Re: [Bioconductor/Contributions] GISPA (#202)

Hi @BhaktiDwivedihttps://github.com/BhaktiDwivedi, Thank you for making those changes. As @mtmorganhttps://github.com/mtmorgan mentioned before, you should really make use of the classes in GSEABase to represent gene sets.

After a quick look at your package, there are still some points to be addressed.


Data

Code

Best regards, Marcel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/202#issuecomment-277315211, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFcdUPMP_qJJyZf9XUbZ-j509-QTca_ks5rY2lBgaJpZM4KyDH2.


This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

marcel commented 7 years ago

FYI typing @Marcel subscribes the username @marcel on github to the entire thread.