Closed GuidoBarzaghi closed 3 years ago
Hi @GuidoBarzaghi
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: SingleMoleculeFootprintingData
Type: Package
Title: Data supporting the SingleMoleculeFootprinting pkg
Version: 0.99.0
Authors@R: c(
person(given = "Guido",
family = "Barzaghi",
role = c("aut", "cre"),
email = "guido.barzaghi@embl.de",
comment = c(ORCID = "0000-0001-6066-3920")),
person(given = "Arnaud",
family = "Krebs",
role = c("aut"),
email = "arnaud.krebs@embl.de",
comment = c(ORCID = "0000-0001-7999-6127")),
person(given = "Mike",
family = "Smith",
role = c("ctb"),
email = "mike.smith@embl.de",
comment = c(ORCID = "0000-0002-7800-3848"))
)
Description: This Data package contains r objcets necessary to run some of the
functions from the SingleMoleculeFootprinting package.
SingleMoleculeFootprinting is an R package providing functions
to analyze Single Molecule Footprinting (SMF) data.
biocViews:
ExperimentHub, ExperimentData, SequencingData
License: GPL-3
Encoding: UTF-8
LazyData: true
Imports:
ExperimentHub,
utils
Suggests:
knitr,
rmarkdown,
QuasR,
GenomicRanges,
BSgenome.Mmusculus.UCSC.mm10
VignetteBuilder: knitr
RoxygenNote: 7.1.1
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprintingData
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 4d303a44be346592ac57a3004d204028bceb45d5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprintingData
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: d17d8cb7950e0b6f6153e3a9a1a155c7f4e9a804
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprintingData
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: c882029d08a35b30a3bb11e8d070289da18e0092
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprintingData
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1acbadfe3f3d518a939432cf2693e3a728e3c879
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprintingData
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
AdditionalPackage: https://github.com/GuidoBarzaghi/SingleMoleculeFootprinting
Hi @GuidoBarzaghi, Thanks for submitting your additional package: https://github.com/GuidoBarzaghi/SingleMoleculeFootprinting. We are taking a quick look at it and you will hear back from us soon.
Hi @LiNk-NY,
I was wondering whether I misunderstood the procedure for submitting an additional package. I was expecting for it to automatically go through the build checks analogously to what happened to the primary one. Is there something I did wrong that is causing the system not to be prompted?
Additional Package has been approved for building.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi Guido, @GuidoBarzaghi It looks like the procedure to add the package worked out smoothly. Please see the result report and modify accordingly.
Received a valid push on git.bioconductor.org; starting a build for commit id: d7c9d1950e4dcfae1b71b61d927285347477a8d3
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 9235a89b51b2d6785d488e2fc23dce77c59f91fa
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@LiNk-NY thanks a lot for your reply. This is my first ever submission to Bioconductor so I'm not entirely sure on what to expect at each step.
I'm afraid I need to ask for your input again: there is an ERROR reported under the "tokay2 BUILD BIN output" section that I'm not sure how to tackle. I'm not entirely sure how I can influence the installation of dependencies on windows. Do you have any suggestion?
@GuidoBarzaghi It looks like Rbowtie & subsequently QuasR aren't available for 32-bit Windows. You can specify not to build your package on that platform by adding the file .BBSoptions
to the root of your package. It should be fine to copy the one from QuasR at https://github.com/fmicompbio/QuasR/blob/master/.BBSoptions
Received a valid push on git.bioconductor.org; starting a build for commit id: 97bf140a315e2c8a40683855d4cccf7757d63b9c
@grimbough Oh I see. Thank you for clarifying!
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, WARNINGS, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: e249370a1a73c2246cdb8d33b866a2af8cd03714
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 5d9763b30cbb9980dc83b78094032eee1b532b9b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: d45f3466369e3dd249828a1e24e086a4f5758662
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 335ba6149259df2067a3b726d92ede7f30a8fecc
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi Guido, @GuidoBarzaghi
Thank you for your submission. Please see the reviews below. Feel free to comment with questions.
Best regards, Marcel
Description
field (for BiocCheck
).AnnotationHub
and ExperimentHub
?Suggests
field.LazyData: false
or remove the line.BugReports
field.AnnotationHub
seems out of place.parallel
functionality listed here is for user-level commands?library(parallel)
, for example.eval = FALSE
in code chunks. Use an small example dataset to
show the functionality of your package. eval=FALSE
chunks can become stale
quite quickly.\
backslashes needed in the text?Installation
section to the beginning of the vignette.GitHub
installation section.AnnotationHub
query is not necessary when you already have a data
package that has a covenience function for loading the data. Use your own
package.qQCReport
with a small dataset?1:n
sequence generation, use the more robust seq_len(n)
.print
even in the vignette. Use message
if necessary.sessionInfo
at the end of the vignette.Minor:
<-
for assignment instead of =
but this not
strictly enforced.tempdir()
especially for downloaded data as pointed out above.MethSM_minus = MethSM[apply(MethSM[,IsMinusStrand], 1, function(i){sum(is.na(i)) != length(i)}) > 0, IsMinusStrand]
MethSM_plus = MethSM[apply(MethSM[,!IsMinusStrand], 1, function(i){sum(is.na(i)) != length(i)}) > 0, !IsMinusStrand]
It's not clear in the code what you're trying to do. Perhaps !all(is.na(i))
is what you need to check for each row? or rowSums(is.na(i)) > 0
? These are
likely to be faster.
verbose
argument to functions like CallContextMethylation
and
others.BiocParallel
instead of parallel::makeCluster
for
BaitCapture
. It may work better across systems.SampleCorrelation
should be using data in the extdata
directory.SampleCorrelation
, create the plot
and display it in the graphics device. The user will then be able to choose
their format of choice (e.g., png
).Description
field.createHubAccessor
.Note. For more information, see:
BiocCheck::BiocCheck("SingleMoleculeFootprinting")
Received a valid push on git.bioconductor.org; starting a build for commit id: 6064a7893f6e65bf11b54cdc36a306d8cb1fc140
Received a valid push on git.bioconductor.org; starting a build for commit id: e76f0e43c84566ef97f57b753e95b93c86e46887
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprintingData
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 3219e106bfcafcbb4a43b9603fe7c6c493ed7e48
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: f061feeb9c9d7508f5ee8ab7b973fd1e6df0ae97
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 876c98439222acbb2e16afcf91c725f71199f530
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: b7a89f0b32218c3e617f890fc38a18e8b9501ad5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SingleMoleculeFootprinting
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@LiNk-NY thanks a lot for your comments. I have tried to thoroughly address all the points you brought up.
I would just like to offer some clarifications about a couple of them:
In this case, some of the objects accessed through the data package are necessary for a couple of functions to work. Therefore it is necessary to import the data package when loading the software one
I actually just copy it in order to rename it with a relevant extension. This is necessary for one of the dependencies of SingleMoleculeFootprinting to recognise these files.
Unfortunately, qQCreport will not run with a dataset that is too small (such is the case for the example data provided through SingleMoleculeFootprintingData). Consequently, I removed the code chunk relative to this and referred to the documentation of the package QuasR relative to the function qQCreport.
Because of this and other comments, I removed all the instances of makeCluster/stopCluster across the package and leave to the user the choice of how to create a cluster object. Still in the vignette and the example code in the function manuals I show how to do this using parallel since this is how the documentation of the dependency QuasR indicates.
Unfortunately where numeric indices are still present they are strictly necessary as of now, I will keep this in mind for the future.
Once again, thanks for your suggestions I will keep them in mind as I go along and keep developing in the future. Let me know if I can further clarify something.
Hi Guido, @GuidoBarzaghi
DESCRIPTION:
- Most often, the data package goes in the Suggests field.
In this case, some of the objects accessed through the data package are necessary for a couple of functions to work. Therefore it is necessary to import the data package when loading the software one
I would not require everyone to install data package. Only the users using those functions should install the data package.
You can implement this using some logic to check for the package availability (after putting the package in Suggests
):
if (!requireNamespace("LargeDataPackage", quietly = TRUE))
stop("Install the 'LargeDataPackage' to use this function")
VIGNETTE:
- Please don't move the file and keep it in the default cache. Otherwise, your package will be downloading the data every time it gets checked on our build system (BBS).
I actually just copy it in order to rename it with a relevant extension. This is necessary for one of the dependencies of SingleMoleculeFootprinting to recognise these files.
I see the issue now. I think the software should work regardless of the extension but you don't have any control of QuasR
...
I will ask about a way to preserve the file extension.
Thanks! Best, Marcel
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.