Closed lievenclement closed 3 years ago
Hi @lievenclement
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: msqrob2
Title: Robust statistical inference for quantitative LC-MS proteomics
Version: 0.99.1
Authors@R: c(
person(given = "Lieven",
family = "Clement",
role = c("aut", "cre"),
email = "lieven.clement@ugent.be",
comment = c(ORCID = "0000-0002-9050-4370")),
person(given = "Laurent",
family = "Gatto",
role = c("aut"),
email = "laurent.gatto@uclouvain.be",
comment = c(ORCID = "0000-0002-1520-2268")),
person(family = "Crook",
given = "Oliver M.",
email = "oliver.crook@stats.ox.ac.uk",
comment = c(ORCID = "0000-0001-5669-8506"),
role = "aut"),
person(given = "Adriaan",
family = "Sticker",
email = "adriaan.sticker@ugent.be",
role = "ctb"),
person(given = "Ludger",
family = "Goeminne",
email = " ludgergoeminne@gmail.com",
role = "ctb"))
Description: msqrob2 provides a robust linear mixed model framework for assessing differential abundance in
MS-based Quantitative proteomics experiments. Our workflows can start from raw peptide intensities or
summarised protein expression values. The model parameter estimates can be stabilized by ridge regression,
empirical Bayes variance estimation and robust M-estimation. msqrob2's hurde workflow can handle missing
data without having to rely on hard-to-verify imputation assumptions, and, outcompetes state-of-the-art
methods with and without imputation for both high and low missingness. It builds on QFeature infrastructure
for quantitative mass spectrometry data to store the model results together with the raw data and preprocessed
data.
Depends:
R (>= 4.0),
QFeatures (>= 1.1.2)
Imports:
stats,
methods,
lme4,
purrr,
BiocParallel,
Matrix,
MASS,
limma,
SummarizedExperiment,
codetools
Suggests:
multcomp,
gridExtra,
knitr,
BiocStyle,
RefManageR,
sessioninfo,
rmarkdown,
testthat,
tidyverse,
plotly,
msdata,
MSnbase,
matrixStats,
MsCoreUtils
License: Artistic-2.0
Collate: 'msqrob-framework.R' 'allGenerics.R'
'accessors.R' 'msqrob.R' 'msqrob-utils.R' 'StatModel-methods.R'
'hypothesisTest-methods.R' 'msqrob-methods.R' 'msqrobAggregate.R'
'topFeatures.R' 'data.R' 'msqrobQB.R' 'msqrobHurdle-methods.R'
Encoding: UTF-8
VignetteBuilder: knitr
Roxygen: list(markdown=TRUE)
RoxygenNote: 7.1.1
biocViews:
Proteomics,
MassSpectrometry,
DifferentialExpression,
MultipleComparison,
Regression,
ExperimentalDesign,
Software,
ImmunoOncology,
Normalization,
TimeCourse,
Preprocessing
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/msqrob2
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0f630e107d564fdbb89fe573d50bc83b7f084bf7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/msqrob2
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 167129e2e63d0077079a1b16e2406eed1a5e950c
Dear Nitesh,
With this last version update msqrob2 0.99.3 I tried to address as many notes as possible.
On my system the R CMD checks run without warnings and notes and the BiocChecks runs without warnings and errors and 4 notes. I did not know how I had to address the warning in the bioconductor build of msqrob2 0.99.2
"Found the following significant warnings:
Warning: no function found corresponding to methods exports from 'S4Vectors' for: 'combineRows' "
This warning did not occur in the build of msqrob2 0.99.1. with dependency on R 4.0 while it does since migrating to dependency on R 4.1. I checked all files in the R/ directory and the NAMESPACE file of the msqrob2 package and I do not seem to find where I use the combineRows function. I guess it is imported by one of the packages that msqrob2 depends upon, e.g. QFeatures imports S4vectors.
Best,
Lieven
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/msqrob2
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 9923ea6cef2eda457e50fa6829e94d00f385098e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/msqrob2
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Nitesh,
I triggered a rebuild with a minor modification of the vignette (one chunk was not evaluated).
Best,
Lieven
Received a valid push on git.bioconductor.org; starting a build for commit id: e7031a3657d2b91e2628ca1c46f7d81012f93d7b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/msqrob2
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 121f7f10b40fa8c7f907990092e38d4cd89933a2
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/msqrob2
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
ok
ok
ok
Good! Well written.
ok
ok
ok
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/lievenclement.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("msqrob2")
. The package 'landing page' will be created at
https://bioconductor.org/packages/msqrob2
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.