Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

MetaGSCA #2148

Closed hui-sheen closed 3 years ago

hui-sheen commented 3 years ago

Dear Bioconductor team,

Our R package MetaGSCA got published lately in PLoS Computational Biology (10.1371/journal.pcbi.1008976). Please note that we used to submit MetaGSCA to Bioconductor in last fall (issue #1568). Now the source code has been fundamentally re-written and thus significantly optimized. It has also been shifted under a different maintainer account. So this is a brand new submission, but I'm referring to the historical submission for your reference.

Thanks, Hui Yu ######################################################### Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 3 years ago

Hi @hui-sheen

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: MetaGSCA
Type: Package
Title: Meta-analysis of Gene Set differential Co-expression Analysis
Version: 0.99.0
Date: 2021-6-10
Authors@R: c(person("Yan", "Guo", role = c("aut"), 
  email = "yanguo1978@gmail.com"), 
        person("Fei", "Ye", role="aut", email = "fei.ye@vumc.org"),
        person("Hui", "Yu", role=c("ctb", "cre"), 
  email = "schena.yu@gmail.com", comment=c(ORCID="0000-0002-4491-8855")))
Depends: R (>= 3.6.3), data.table, meta, grid, sjstats, igraph
Description: MetaGSCA systematically assesses the coexpression disturbance of a gene set by pooling the results from individual studies. A nonparametric approach named GSNCA (Rahmatallah 2014, Bioinformatics) is used to test whether the gene set is differentially co-expresssed between the two conditions, and a permutation test p-value is computed. Bootstrapping is used to construct confidence intervals of p-values. Meta-analysis is offered through two options: random-intercept logistic regression model and the inverse variance method. Lastly, a pathway crosstalk network is delineated based on the meta-analysis result outputted from the prior steps. 
License: GPL (>= 2)
Encoding: UTF-8
LazyData: false
biocViews: Software, DifferentialExpression, StatisticalMethod
RoxygenNote: 7.1.1
bioc-issue-bot commented 3 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MetaGSCA to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hui-sheen commented 3 years ago

Dear reviewers, I see there are warnings and errors on my build report. However, many (if not all) errors are not relevant to the current version of MetaGSCA. For instance, "merida1 CHECK output" reports "ERROR: System Files found that should not be git tracked: MetaGSCA.Rproj" and "Do not use Author/Maintainer fields. Use Authors@R." The current MetaGSCA package (https://github.com/hui-sheen/MetaGSCA) does not have these problems. This package was submitted in last fall by Haocan223 and these issues might be existent with that version. There have been a major systematic re-writing of the code files, and the package has been owned by me instead of Haocan223. I wish you could delete the old MetaGSCA package from your build system and test the package from scratch. Meanwhile, I'll read the what to expect and related documents to better communicate with you. Thank you very much!

Hui

hui-sheen commented 3 years ago

Dear reviewers, I made a few minor fixes to the repo MetaGSCA and bumped the version to 0.99.1. I successfully pushed the commit including version bump to github.com, but I couldn't push it to the repo on bioconductor.org. I got the following error. Please advise what I should do. Thanks!

git push upstream master --force ... remote: FATAL: + refs/heads/master packages/MetaGSCA hui-sheen DENIED by fallthru remote: error: hook declined to update refs/heads/master To git@git.bioconductor.org:packages/MetaGSCA.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'git@git.bioconductor.org:packages/MetaGSCA.git'

lshep commented 3 years ago

We apologize for the delay. We needed to change the remotes and references we had internally to be able to point to the correct version of the package. You should have access now and the builds should pick up on the correct version. You will need to activate your Git Credentials Account and then you should be able to trigger a new build by doing a version bump and pushing to git.bioconductor.org. Cheers

lshep commented 3 years ago

@hui-sheen Could you please activate your credentials account and push the changes/including version bump to the git.bioconductor.org version to initiate a new build report. Thanks

hui-sheen commented 3 years ago

@Ishep Thank you very much for relinking the software to the current correct version. I executed the following command on my local work directory yesterday, and it seemed successful with no obvious warning or error message. When I executed the same command about ten days ago, I did encounter an evident error message (see above). I guess I have passed the step of credentials and pushing the version to Github? Can you confirm with me that a new build report will be soon generated?

Command I executed with possible success

git push upstream master --force I did read the tutorial on Bioconductor contributor credentials (SSH key) and I possibly have passed that step. Please let me know which part I am missing if you cannot proceed with the review process. Thanks!

lshep commented 3 years ago

Bioconductor does not allow --force option. Please do git push upstream master to push changes. If you still encounter errors please show the command with the full output.

hui-sheen commented 3 years ago

@lshep Below is what I got after executing the command without --force. I guess I'm good for now. I'm looking forward to a new build report for MetaGSCA v0.99.1. Thanks! $ git push upstream master Enter passphrase for key '/home/huiyu1/.ssh/id_ed25519': Everything up-to-date

lshep commented 3 years ago

The build report did not trigger correctly. Could you please do a version bump to 0.99.2 and try pushing to git.bioconductor.org to trigger a build.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: f2801d17e160d315d3982d88eb5b0173013d313e

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MetaGSCA to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 3 years ago

Please fix all error warning and notes in the build report before an indepth review will continue. thank you

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fdc647c4d1bda9d6a02fcf45a833a501dceb0a98

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MetaGSCA to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 3 years ago

Hi @hui-sheen ,

Please address the R CMD check error and warnings reported by the SPB (Single Package Builder). Thanks!

Best, H.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 2b0d4bba88b7a5163887a464fd81788130b0568e

hui-sheen commented 3 years ago

@hpages, I ran R CMD check locally with the following command, and found no error with v0.99.4. I shut PDF/vignettes check, because we did not attempt to build a PDF vignette. Instead, we generated an HTML tutorial (https://hui-sheen.github.io/MetaGSCA/) using an Rmd script independently. The *.Rmd script was not included in the package v0.99.4.

R CMD check MetaGSCA_0.99.4.tar.gz --no-manual

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MetaGSCA to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 3 years ago

@hui-sheen ,

It's a Bioconductor requirement that your package contain a valid vignette and man pages that can be built and checked with the standard R CMD build and R CMD check commands. Thanks!

H.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 2dc580b909fd78ea014fba23d6285b1c25f7e688

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MetaGSCA to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 3 years ago

@hui-sheen R CMD check is still reporting an error on the 3 platforms. We don't start the review process until the package passes R CMD check cleanly, at least on Linux. Thanks!

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0ad9e0bea5a67a1e3a5a40ac83419e615940c116

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MetaGSCA to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hui-sheen commented 3 years ago

@hpages I don't have sufficient manpower to settle the R CMD check ERRORs. I have to close the submission issue. Thank you very much!