Closed Jfortin1 closed 3 years ago
Hi @Jfortin1
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: crisprScore
Version: 0.99.0
Date: 2021-06-18
Title: On-Target and Off-Target Scoring Algorithms for CRISPR gRNAs
Authors@R: c(
person("Jean-Philippe", "Fortin", email = "fortin946@gmail.com", role = c("aut", "cre", "cph")),
person("Aaron", "Lun", email = "infinite.monkeys.with.keyboards@gmail.com", role = c("aut")),
person("Luke", "Hoberecht", email = "lukehob3@gmail.com", role = c("ctb")))
Depends: R,
crisprScoreData
Imports:
basilisk (>= 1.3.5),
Biostrings,
reticulate,
stringr,
utils
Suggests:
BiocStyle,
knitr,
rmarkdown,
testthat
biocViews:
CRISPR,
FunctionalGenomics,
FunctionalPrediction
Description:
Provides R wrappers of several on-target and off-target scoring methods for CRISPR guide RNAs (gRNAs).
The following nucleases are supported: Cas9, Cas12a and enCas12a.
The available on-target cutting efficiency scoring methods are Azimuth, DeepHF, DeepCpf1 and enPAM+GB.
Both the CFD and MIT scoring methods are available for off-target specificity prediction.
The package also provides a Lindel-derived score to predict the probability of a gRNA to produce
indels inducing a frameshift for the Cas9 nuclease.
License: CC BY-NC-ND 4.0 + file LICENSE
Encoding: UTF-8
RoxygenNote: 7.1.1
VignetteBuilder: knitr
StagedInstall: no
LazyData: TRUE
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/crisprScore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi Jean-Philippe, @Jfortin1
Thank you for your submission. Please see the note below.
Best, Marcel
Suggests
field.I will confirm with the rest of the core team but you cannot restrict the
use with the current (albeit version 2.0
) license.
We have this check in place for version 4.0:
> BiocCheck:::.checkLicenseForRestrictiveUse("CC BY-NC-ND 4.0")
* Checking License: for restrictive use...
* ERROR: License 'CC BY-NC-ND 4.0' restricts use
Hi Marcel @LiNk-NY,
Thank you for reviewing our package. The license was decided by our legal team here at Genentech. I will discuss with them if we can change the license or not. If not, is there an exception that can be made?
Hi Jean-Philippe, @Jfortin1 Unfortunately, we can't make exceptions. Please refer to this table and use a more permissive (non-restrictive) license:
> read.dcf(R.home("share/licenses/license.db")) |> tibble::as_tibble()
# A tibble: 39 x 12
Name Abbrev Version SSS OSI FSF File URL FOSS Extensible
<chr> <chr> <chr> <chr> <chr> <chr> <chr> <chr> <chr> <chr>
1 GNU Ge… GPL 2 GPL-2 open (h… free_an… shar… https… yes NA
2 GNU Ge… GPL 3 GPL-3 open (h… free_an… shar… https… yes yes
3 GNU Li… LGPL 2 LGPL-2 open free_an… shar… https… yes NA
4 GNU Le… LGPL 2.1 LGPL-… open (h… free_an… shar… https… yes NA
5 GNU Le… LGPL 3 LGPL-3 open (h… free_an… shar… https… yes yes
6 GNU Af… AGPL 3 AGPL-3 open (h… free_an… shar… https… yes yes
7 Apache… NA 1.1 NA open bu… free_an… NA https… yes NA
8 Apache… NA 2.0 NA open (h… free_an… NA https… yes NA
9 Artist… NA 1.0 Artis… open bu… non_fre… NA https… no NA
10 Artist… NA 2.0 Artis… open (h… free_an… shar… https… yes NA
# … with 29 more rows, and 2 more variables: Restricts_use <chr>, Note <chr>
Best regards, Marcel
Thanks @LiNk-NY, I'm currently working with our legal team to choose a different license.
Hi Jean-Philippe @Jfortin1 Any updates on this? We can close the issue until you hear back from the legal team. Best, Marcel
@LiNk-NY Thank you for your patience; the team agreed for a MIT license (just pushed the latest changes).
@LiNk-NY Hi Marcel, I'm trying to push my changes to the Bioc package, and I've set up an upstream correctly:
origin git@github.com:Jfortin1/crisprScore.git (fetch)
origin git@github.com:Jfortin1/crisprScore.git (push)
upstream git@git.bioconductor.org:packages/crisprScore (fetch)
upstream git@git.bioconductor.org:packages/crisprScore (push)
but get permission denied when trying to fetch:
git@git.bioconductor.org: Permission denied (publickey).
fatal: Could not read from remote repository.
I've tried to specified a few of my public keys on my personal laptop by changing my .ssh/config
file
(e.g.
host git.bioconductor.org
HostName git.bioconductor.org
IdentityFile ~/.ssh/id_rsa
User git
but I've been unsuccessful. I'm trying to see what ssh-key was added to the BioC crisprScore package by looking at my credentials at https://git.bioconductor.org/BiocCredentials/login/?next=/BiocCredentials/ but when trying to create an account with my email address used for the package (fortin946@gmail.com), it tells me that I don't have a package associated with my account.
Would you be able to help?
Hi Jean-Philippe, @Jfortin1
Nitesh would have a better idea of what's going on. It may be that you are authenticating with the wrong key or email. Can you please help @nturaga ?
Best, Marcel
Thanks @nturaga for helping, I confirm that I'm using the same email to authenticate than the one on my Github
Hi @Jfortin1
It seems you were registered with your JHSPH email. I fixed the issue on our end, so you'll be able to activate your account with https://git.bioconductor.org/BiocCredentials/account_activation.
Add your SSH keys, and you'll be good to go.
Best regards,
Nitesh
Received a valid push on git.bioconductor.org; starting a build for commit id: 5e57af304d1df12ed148fbb66c663f7903a28b0d
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/crisprScore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@nturaga Thanks Nitesh, everything works well now! I have no idea where the JHSPH email was coming from (it's not in any of my settings on Github?)
Received a valid push on git.bioconductor.org; starting a build for commit id: e5c50bc012615282cd61777200fd91af6a63c393
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/crisprScore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi Jean-Philippe, @Jfortin1 Please see the review below. Feel free to ask any questions. Best, Marcel
ExperimentHubData
.crisprScore
package.BugReports
and URL
fields.ExperimentHubData
dependency.crisprScoreData
package.BugReports
and URL
fields.LazyData
fieldR/basilisk2.R
scores[, c(1,4,5,6)]
and
use more robust colnames
.Description
field.Received a valid push on git.bioconductor.org; starting a build for commit id: f7709c1c3f2763898913aed9ebf9357bfb2151cb
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/crisprScore
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@LiNk-NY Hi Marcel, thank you for your review! We've made all of your suggested changes and pushed a new version for both crisprScore
and crisprScoreData
.
Hi Jean-Philippe, @Jfortin1
Please make crisprScore
and additional package with the comment instructions above in the crisprScoreData
issue.
I will move the review over.
Best,
Marcel
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x ] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x ] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x ] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x ] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x ] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[ x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.