Closed lgeistlinger closed 3 years ago
Hi @lgeistlinger
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: BioPlex
Title: R-side access to BioPlex protein-protein interaction data
Version: 0.99.1
Authors@R:
c(person("Ludwig", "Geistlinger",
role = c("aut", "cre"),
email = "ludwig_geistlinger@hms.harvard.edu"),
person("Robert", "Gentleman",
role = "aut",
email = "robert_gentleman@hms.harvard.edu"))
Description: The BioPlex package implements access to the BioPlex protein-protein
interaction networks and related resources from within R.
Besides protein-protein interaction networks for HEK293 and HCT116 cells,
this includes access to CORUM protein complex data, and transcriptome
and proteome data for the two cell lines.
Functionality focuses on importing the various data resources and
storing them in dedicated Bioconductor data structures, as a
foundation for integrative downstream analysis of the data.
URL: https://github.com/ccb-hms/BioPlex
BugReports: https://github.com/ccb-hms/BioPlex/issues
Encoding: UTF-8
License: Artistic-2.0
VignetteBuilder: knitr
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
Depends:
R (>= 4.0.0),
SummarizedExperiment
Imports:
BiocFileCache,
GEOquery,
graph,
methods,
utils
Suggests:
AnnotationDbi,
AnnotationHub,
BiocStyle,
ExperimentHub,
ExpressionAtlas,
knitr,
rmarkdown
biocViews:
DataImport,
DataRepresentation,
GeneExpression,
GraphAndNetwork,
MassSpectrometry,
Network,
Transcriptomics,
Proteomics,
Homo_sapiens_Data,
ColonCancerData
Hi @lgeistlinger please omit the last two entries in biocViews. These produce a conflict in "package type" labeling in our package ingestion process.
Thanks @vjcitn. I have removed the last two entries in biocViews and pushed to the github repo with the version number bumbed.
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Cannot reproduce the build error on linux. Looks like an internet connectivity issue with the ExpressionAtlas package. Bumping version number to give it another try.
Looks like I cannot push to git@git.bioconductor.org:packages/BioPlex. Have reported to the Bioc mailing list.
Received a valid push on git.bioconductor.org; starting a build for commit id: 85460451bd0fc3074cd56631faa3a69cb6c97df7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @Kayla-Morrell :
I have difficulties reproducing the build error on a linux system. When I build the package on an Ubuntu 18.04.5 LTS platform, I look at a clean build report:
lgeistlinger@wallabe4:~$ Rdev CMD build BioPlex
* checking for file ‘BioPlex/DESCRIPTION’ ... OK
* preparing ‘BioPlex’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ...
OK
* checking for LF line-endings in source and make files and shell scripts
* checking for empty or unneeded directories
Omitted ‘LazyData’ from DESCRIPTION
* building ‘BioPlex_0.99.5.tar.gz’
> sessionInfo()
R version 4.1.0 Patched (2021-07-14 r80626)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.5 LTS
Matrix products: default
BLAS/LAPACK: /usr/lib/x86_64-linux-gnu/libopenblasp-r0.2.20.so
locale:
[1] LC_CTYPE=en_US.UTF-8 LC_NUMERIC=C
[3] LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8
[5] LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8
[7] LC_PAPER=en_US.UTF-8 LC_NAME=C
[9] LC_ADDRESS=C LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C
attached base packages:
[1] stats4 stats graphics grDevices utils datasets methods
[8] base
other attached packages:
[1] BioPlex_0.99.5 SummarizedExperiment_1.23.1
[3] Biobase_2.53.0 GenomicRanges_1.45.0
[5] GenomeInfoDb_1.29.3 IRanges_2.27.0
[7] S4Vectors_0.31.0 BiocGenerics_0.39.1
[9] MatrixGenerics_1.5.1 matrixStats_0.59.0
loaded via a namespace (and not attached):
[1] lattice_0.20-44 bitops_1.0-7 grid_4.1.0
[4] zlibbioc_1.39.0 XVector_0.33.0 Matrix_1.3-4
[7] tools_4.1.0 RCurl_1.98-1.3 DelayedArray_0.19.1
[10] compiler_4.1.0 GenomeInfoDbData_1.2.6
> BiocManager::version()
[1] ‘3.14’
Could you take a look at that? It almost looks to me as if there is an internet connectivity issue on the linux builder, as the SummarizedExperiment coming back from the offending lines 278-280 (BioPlex.Rmd) seems to be NULL. I'll add that the same issue appears on the windows builder but not on the mac builder. Thanks!
Also @lshep : For R CMD check under mac (http://bioconductor.org/spb_reports/BioPlex_buildreport_20210715144136.html#merida1_check_anchor), I am encountering here the same ExperimentHub issue as for my GSEABenchmarkeR package and that we started to discuss in the #bioc-builds slack channel.
This time the following pull from ExperimentHub triggers the error:
> # Obtain CCLE proteome data frame
> eh <- ExperimentHub::ExperimentHub()
> ehdb <- AnnotationHub::query(eh, c("gygi", "depmap"))
> ccle.prot <- ehdb[[length(ehdb)]]
Bioconductor version 3.14 (BiocManager 1.30.16), R 4.1.0 RC (2021-05-16 r80304)
Installing package(s) 'depmap'
Error in UseMethod("conditionMessage") :
no applicable method for 'conditionMessage' applied to an object of class "character"
Calls: [[ ... tryCatchList -> tryCatchOne -> doTryCatch -> download.file
Execution halted
Do you mind having another look at that? Many thanks!
Looks like we have another one of these ExperimentHub generated UseMethod("conditionMessage")
errors here: https://github.com/Bioconductor/Contributions/issues/1944#issuecomment-850504392
What is making it challenging is I can't currently reproduce the error on the builders so its making difficult to debug as I don't know where the error is coming from. Taking another look this morning to see if I can make any more headway
Some observations:
EXPERIMENT_HUB_ASK
option (https://github.com/Bioconductor/ExperimentHub/blob/b717d5686023833abb4329d1b21b2c8870a8a89e/R/zzz.R#L36) which seems to be passed on to the internal .Hub
workhorse function (https://github.com/Bioconductor/ExperimentHub/blob/b717d5686023833abb4329d1b21b2c8870a8a89e/R/ExperimentHub-class.R#L50).Hub
in the AnnotationHub codebase (https://github.com/Bioconductor/AnnotationHub/blob/0a44f0c481bc8352ce7ac23b33fe7aa89d765231/R/Hub-class.R#L27), it appears that there is a db_path <- .create_cache(.class, url, cache, proxy, localHub, ask)
command that behaves differently depending on ask
(= running interactive or not), which further down the road calls conditionMessage
if there is an error processing db_path
(https://github.com/Bioconductor/AnnotationHub/blob/0a44f0c481bc8352ce7ac23b33fe7aa89d765231/R/Hub-class.R#L35) which I suspect is the source of the error.Speculating a bit further, it appears this part of the code has problems digesting the recent cache deprecation note, and it would be worthwile taking this deprecation note out of the equation to see whether we revert to running clean through R CMD check.
Thanks for the feedback! Very helpful. I'll do some additional testing and hopefully could have it resolved soon. The deprecation message shouldn't effect anything as it actually isn't being passed as an argument anywhere but it will be a good place to start looking.
Again the problem is I can't reproduce it. It could be related to the db_path creation or the restrictByDate if your drill down is correct. I'm trying to go onto the builders to reproduce but even when I'm logged in on merida1, running R CMD check doesn't produce the error. Trying a few more things....
Other members of the team are able to reproduce and we are working on figure out the exact cause.
This is a bug in BiocManager, tickled by a bug in BioPlex.
BioPlex should Suggests: depmap
because this package is needed for the (failing) example.
The BiocManager issue will be mentioned here.
Thanks! Adding depmap
to Suggests
...
That means I always have to explicitly declare packages served via ExperimentHub / AnnotationHub in my DESCRIPTION file? Somehow my impression was I could pull eg orgdb or txdb packages from AnnotationHub by just declaring AnnotationHub as a dependency ...
Received a valid push on git.bioconductor.org; starting a build for commit id: 4a515958d695c4ab5c5ed70907dda3d78ded9b40
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @lgeistlinger ... this is an interesting situation, isn't it? I think it is true that if there is code in your package that will utilize a given *Hub resource that is an instance of a package-dependent S4 class, you are obligated to add a Suggests entry for the package in which the class is defined.
It is indeed interesting :-) But what do you mean with a package-dependent S4 class? The resource I am requesting from ExperimentHub is a tibble, ie not something specifically defined in the depmap package.
> eh <- ExperimentHub::ExperimentHub()
> ehdb <- AnnotationHub::query(eh, c("gygi", "depmap"))
> ccle.prot <- ehdb[["EH3459"]]
> ccle.prot[1:5,1:5]
# A tibble: 5 x 5
depmap_id gene_name entrez_id protein protein_expression
<chr> <chr> <dbl> <chr> <dbl>
1 ACH-000849 SLC12A2 6558 MDAMB468_BREAST_TenPx01 2.11
2 ACH-000441 SLC12A2 6558 SH4_SKIN_TenPx01 0.0705
3 ACH-000248 SLC12A2 6558 AU565_BREAST_TenPx01 -0.464
4 ACH-000684 SLC12A2 6558 KMRC1_KIDNEY_TenPx01 -0.884
5 ACH-000856 SLC12A2 6558 CAL51_BREAST_TenPx01 0.789
> class(ccle.prot)
[1] "tbl_df" "tbl" "data.frame"
Right, it appears I have misinterpreted the purpose of the metadata element "preparerclass", which evaluates to "depmap" for your request. I simply assumed that that was an S4 class. Why exactly depmap has to be installed/loaded for the request to succeed is not clear to me yet.
From the ExperimentHub vignette:
The preparerclass column of metadata monitors which package is associated with the ExperimentHub data.
Now "monitors" is unclear here. But at the moment, this field names a package that will be loaded when the resource is retrieved. So that's the basis for requiring a "Suggests" entry for your usage.
Thanks for the clarification.
Next question: my package pulls data from ftp://ftp.ebi.ac.uk/pub/databases/microarray/data/atlas/experiments/E-MTAB-2770/E-MTAB-2770-atlasExperimentSummary.Rdata via the ExpressionAtlas package, which works fine on the mac builder and on mac and linux installations where I tested (https://github.com/Bioconductor/Contributions/issues/2180#issuecomment-880964972).
However it fails on the windows builder (http://bioconductor.org/spb_reports/BioPlex_buildreport_20210716162338.html#riesling1_buildsrc_anchor), where the dataset seem to come back as NULL
. Would greatly appreciate any insights that you might have as to why this is the case. Many thanks!
Just guessing but is the windows download type 'binary' (it should be)? Maybe this is an ExpressionAtlas bug, or maybe in your code...? I haven't looked.
Thanks, I'll take a closer look. Also giving it another push, as I had cleaned up some BiocCheck issues incl updating email on support site and mailing list.
Received a valid push on git.bioconductor.org; starting a build for commit id: 2e7266f02891d765b696c2a54516ad4fa6f10f16
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @lgeistlinger ,
This is very fragile:
ehdb <- AnnotationHub::query(eh, c("gygi", "depmap"))
ccle.prot <- ehdb[[length(ehdb)]]
There's no guarantee that this will load the right object when the above query returns more than one result.
Always use the EH id instead:
ccle.prot <- eh[["EH3459"]]
This will never break.
H.
Thank you for the recommendation @hpages. I thought I had encountered an instance where it would break 1,2 years ago. I think it was with the GSE62944 dataset where the corresponding EH id got removed/replaced upon restructuring of the GSE62944 package.
The intention of my, admittedly, slightly innovative construct was to (1) obtain the dataset even if the specific EH id is not available, and (2) always get the latest version if there is more than one record (which seems to work when eg querying AnnotationHub::query(eh, c("ensDb", "Hsapiens"))
. I'd also argue that the readability of my construct is somewhat more instructive as to which dataset is obtained, compared to just using the EH id. But I agree that this solution leaves room for ambiguity and I'll go with your recommendation then.
Received a valid push on git.bioconductor.org; starting a build for commit id: f0153ee8f9d358bddb6366d528e15b5beff04a07
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Just guessing but is the windows download type 'binary' (it should be)? Maybe this is an ExpressionAtlas bug, or maybe in your code...? I haven't looked.
@mtmorgan: So it's a bit weird. This part of the code:
atlasRes <- ExpressionAtlas::searchAtlasExperiments(
properties = "Cancer Cell Line Encyclopedia",
species = "human" )
atlasRes
ccle <- ExpressionAtlas::getAtlasData(atlasRes$Accession)
ccle <- ccle$`E-MTAB-2770`$rnaseq
ccle
which is supposed to return a SummarizedExperiment, seems to return NULL
on the linux builder and the windows builder, causing the error. But it builds fine on the mac builder, our institutional linux server (https://github.com/Bioconductor/Contributions/issues/2180#issuecomment-880964972), and a docker container running ubuntu-18.04. I don't have access to a windows machine, but will try to spin up a VM.
AFAIK the ExpressionAtlas package does not use ExperimentHub, but rather pulls directly from an ftp connection (ftp.ebi.ac.uk).
Received a valid push on git.bioconductor.org; starting a build for commit id: 9485324b05f89dbef3e967609294d566187be094
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: f781e8e58b713d8f968028a9dbb7e3f934c590cb
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 7b9a63915f6422b299e1e93fcdd41fce46cea410
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Update: All remaining BiocCheck issues resolved. The package now passes build, check, bioc check, and install without errors/warnings on the mac builder.
As noted, I cannot reproduce issues encountered on the linux builder and the windows builder. Building the package on a windows machine that I have access to, the package passes R CMD build and R CMD check without warnings/errors:
> devtools::build("C:/Users/geist/Downloads/BioPlex-main/BioPlex")
v checking for file 'C:\Users\geist\Dropbox\Mein PC (BOPHY62)\Downloads\BioPlex-main\BioPlex/DESCRIPTION' (433ms)
- preparing 'BioPlex':
v checking DESCRIPTION meta-information ...
- installing the package to build vignettes
v creating vignettes (8m 33.4s)
- checking for LF line-endings in source and make files and shell scripts
- checking for empty or unneeded directories
Omitted 'LazyData' from DESCRIPTION
- building 'BioPlex_0.99.11.tar.gz'
> devtools::check_built("C:/Users/geist/Downloads/BioPlex-main/BioPlex_0.99.11.tar.gz")
-- Checking ------------------------------------------------------------------------------------------------- BioPlex --
Setting env vars:
* _R_CHECK_CRAN_INCOMING_REMOTE_: FALSE
* _R_CHECK_CRAN_INCOMING_ : FALSE
* _R_CHECK_FORCE_SUGGESTS_ : FALSE
-- R CMD check -----------------------------------------------------------------
- using log directory 'C:/Users/geist/AppData/Local/Temp/RtmpacB0MH/BioPlex.Rcheck' (402ms)
- using R version 4.1.0 (2021-05-18)
- using platform: x86_64-w64-mingw32 (64-bit)
- using session charset: ISO8859-1
- using options '--no-manual --as-cran'
v checking for file 'BioPlex/DESCRIPTION' ...
- this is package 'BioPlex' version '0.99.11'
- package encoding: UTF-8
v checking package namespace information
v checking package dependencies (3.5s)
v checking if this is a source package ...
v checking if there is a namespace
v checking for .dll and .exe files
v checking for hidden files and directories ...
v checking for portable file names ...
v checking whether package 'BioPlex' can be installed (28.6s)
v checking package directory (417ms)
v checking for future file timestamps ...
v checking 'build' directory ...
v checking DESCRIPTION meta-information (602ms)
v checking top-level files
v checking for left-over files ...
v checking index information ...
v checking package subdirectories (433ms)
v checking R files for non-ASCII characters ...
v checking R files for syntax errors ...
v checking whether the package can be loaded (5.7s)
v checking whether the package can be loaded with stated dependencies (5.4s)
v checking whether the package can be unloaded cleanly (5.8s)
v checking whether the namespace can be loaded with stated dependencies (5.3s)
v checking whether the namespace can be unloaded cleanly (5.4s)
v checking dependencies in R code (8.6s)
v checking S3 generic/method consistency (5.7s)
v checking replacement functions (5s)
v checking foreign function calls (5.1s)
N checking R code for possible problems (24.9s)
getCorum: no visible binding for global variable 'Organism'
Undefined global functions or variables:
Organism
v checking Rd files (455ms)
v checking Rd metadata ...
v checking Rd line widths ...
v checking Rd cross-references ...
v checking for missing documentation entries (5.1s)
v checking for code/documentation mismatches (15.2s)
v checking Rd \usage sections (6.5s)
v checking Rd contents ...
v checking for unstated dependencies in examples (339ms)
v checking installed files from 'inst/doc' ...
v checking files in 'vignettes' ...
v checking examples (1m 53.3s)
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
ccleProteome2SummarizedExperiment 52.39 0.95 55.75
annotatePFAM 17.37 1.42 21.86
mapSummarizedExperimentOntoGraph 5.67 0.07 5.85
v checking for unstated dependencies in vignettes (339ms)
v checking package vignettes in 'inst/doc' ...
v checking re-building of vignette outputs (4m 42.1s)
v checking for non-standard things in the check directory
v checking for detritus in the temp directory
See
'C:/Users/geist/AppData/Local/Temp/RtmpacB0MH/BioPlex.Rcheck/00check.log'
for details.
-- R CMD check results ------------------------------------ BioPlex 0.99.11 ----
Duration: 8m 57.1s
> checking R code for possible problems ... NOTE
getCorum: no visible binding for global variable 'Organism'
Undefined global functions or variables:
Organism
0 errors v | 0 warnings x | 1 note x
> sessionInfo()
R version 4.1.0 (2021-05-18)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19043)
Matrix products: default
locale:
[1] LC_COLLATE=German_Germany.1252 LC_CTYPE=German_Germany.1252
[3] LC_MONETARY=German_Germany.1252 LC_NUMERIC=C
[5] LC_TIME=German_Germany.1252
attached base packages:
[1] stats4 stats graphics grDevices utils datasets methods
[8] base
other attached packages:
[1] BioPlex_0.99.11 SummarizedExperiment_1.23.1
[3] Biobase_2.53.0 GenomicRanges_1.45.0
[5] GenomeInfoDb_1.29.3 IRanges_2.27.0
[7] S4Vectors_0.31.0 BiocGenerics_0.39.1
[9] MatrixGenerics_1.5.1 matrixStats_0.59.0
loaded via a namespace (and not attached):
[1] XVector_0.33.0 pillar_1.6.2 compiler_4.1.0
[4] BiocManager_1.30.16 zlibbioc_1.39.0 bitops_1.0-7
[7] prettyunits_1.1.1 remotes_2.4.0 tools_4.1.0
[10] testthat_3.0.4 digest_0.6.27 pkgbuild_1.2.0
[13] pkgload_1.2.1 lattice_0.20-44 memoise_2.0.0
[16] lifecycle_1.0.0 tibble_3.1.3 pkgconfig_2.0.3
[19] rlang_0.4.11 Matrix_1.3-4 DelayedArray_0.19.1
[22] cli_3.0.1 rstudioapi_0.13 xopen_1.0.0
[25] fastmap_1.1.0 GenomeInfoDbData_1.2.6 withr_2.4.2
[28] desc_1.3.0 fs_1.5.0 vctrs_0.3.8
[31] devtools_2.4.2 grid_4.1.0 rprojroot_2.0.2
[34] glue_1.4.2 R6_2.5.0 processx_3.5.2
[37] fansi_0.5.0 rcmdcheck_1.3.3 sessioninfo_1.1.1
[40] callr_3.7.0 purrr_0.3.4 magrittr_2.0.1
[43] ps_1.6.0 ellipsis_0.3.2 usethis_2.0.1
[46] utf8_1.2.2 RCurl_1.98-1.3 cachem_1.0.5
[49] crayon_1.4.1
@lgeistlinger - Thanks for your submission. I have posted an initial review (since I myself use a mac) because I wanted to be sure I got a review out to you before I am on leave for a few months. Hopefully @lshep will be able to help further with the additional issues on linux and windows. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here when these changes have been made and the reassigned reviewer will look over the changes to determine if the package is ready for acceptance.
eval = FALSE
if(!requireNamespace("BiocManager", quietly = TRUE))
install.packages("BiocManager")
BiocManager::install("BioPlex")
[ ] SUGGESTION: Consider clarifying how 1 object(s) are initialized. Maybe it is part of a data set loaded with data(), or perhaps part of an object referenced in with() or within(). function (object) getCorum (Organism)
[ ] REQUIRED: Avoid 1:..., use seq_len() or seq_along(). Found in files: geo.R, line 57
[ ] REQUIRED: Avoid the use of 'paste' in condition signals. Found in files: utils.R, line 41
[ ] SUGGESTION: For formatting reasons, consider shorter lines. There are 59 lines that are > 80 characters long.
[ ] SUGGESTION: For formatting reasons, consider multiples of 4 spaces for line indents. There are 139 lines that are not.
Best, Kayla
Received a valid push on git.bioconductor.org; starting a build for commit id: e232ffaf656822b26793cbcad2c21eb61ad920ca
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/BioPlex
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Thank you @Kayla-Morrell. I have incorporated your suggestions.
The changes look good to me. I have a linux machine and am currently not able to reproduce the ERROR seen on the report. I think at this point, lets proceed with acceptance and if the ERROR continues on the daily report, let us know and we can investigate in more detail.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[ x ] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[ x ] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[ x ] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[ x ] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[ x ] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[ x ] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.