Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

ProteoDisco #2206

Closed J0bbie closed 2 years ago

J0bbie commented 3 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 3 years ago

Hi @J0bbie

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: ProteoDisco
Type: Package
Title: Generation of customized protein variant databases from genomic variants, splice-junctions and manual sequences.
Version: 0.99.0
Date: 2021-07-26
Authors@R: c(
    person("Job", "van Riet", email = "jobvriet@gmail.com", role = c("cre")),
    person("Wesley", "van de Geer", email = "w.vandegeer@erasmusmc.nl", role = c("aut")),
    person("Harmen", "van de Werken", email = "h.vandewerken@erasmusmc.nl", role = c("ths")))
biocViews: Software, Proteomics, RNASeq, SNP, Sequencing, VariantAnnotation, DataImport
URL: https://github.com/ErasmusMC-CCBC/ProteoDisco,
Description: ProteoDisco is an R package to facilitate proteogenomics studies. 
    It houses functions to create customized (mutant) protein databases based on user-submitted genomic variants, splice-junctions, fusion genes and manual transcript sequences.
    The flexible workflow can be adopted to suit a myriad of research and experimental settings.
License: LGPL-2.1
LazyData: FALSE
Depends:
    R (>= 4.1.0),
Imports:
    BiocGenerics (>= 0.38.0),
    BiocParallel (>= 1.26.0),
    Biostrings (>= 2.60.1),
    checkmate (>= 2.0.0),
    cleaver (>= 1.30.0),
    dplyr (>= 1.0.7),
    GenomeInfoDb (>= 1.28.0),
    GenomicFeatures (>= 1.44.0),
    GenomicRanges (>= 1.44.0),
    IRanges (>= 2.26.0),
    methods (>= 4.1.0),
    ParallelLogger (>= 2.0.1),
    plyr (>= 1.8.6),
    rlang (>= 0.4.11),
    S4Vectors (>= 0.30.0),
    tibble (>= 3.1.2),
    tidyr (>= 1.1.3),
    VariantAnnotation (>= 1.36.0),
    XVector (>= 0.32.0),
RoxygenNote: 7.1.1
Suggests: 
    AnnotationDbi (>= 1.54.1),
    BSgenome (>= 1.60.0),
    BSgenome.Hsapiens.UCSC.hg19 (>= 1.4.3),
    BSgenome.Hsapiens.UCSC.hg38 (>= 1.4.3),
    devtools (>= 2.4.2),
    knitr (>= 1.33),
    matrixStats (>= 0.59.0),
    org.Hs.eg.db (>= 3.13.0),
    purrr (>= 0.3.4),
    RCurl (>= 1.98.1.3),
    readr (>= 1.4.0),
    rmarkdown (>= 2.9),
    rmdformats (>= 1.0.2),
    rtracklayer (>= 1.52.0),
    seqinr (>= 4.2.8),
    stringr (>= 1.4.0),
    testthat (>= 3.0.3),
    TxDb.Hsapiens.UCSC.hg19.knownGene (>= 3.2.2),
    TxDb.Hsapiens.UCSC.hg38.knownGene (>= 3.13.0)
VignetteBuilder: knitr
Encoding: UTF-8
bioc-issue-bot commented 3 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 14af053b230bb938cc02aca96540d0c2dce53b39

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 12f800e1ffdaf78d8d610486a268a1851c0fd221

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 3 years ago

Hi @J0bbie ,

Thanks for submitting ProteoDisco.

The package looks good and is almost ready for acceptance. Please address the 2 minor issues below. Thanks,

H.

Screenshot from 2021-08-17 09-49-15

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 56311de3aa2bf9498c5493c836b5188de44a0afa

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 08e816c9d7cebd53931994c32da171a8887c88f3

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 3412debd138bb1789441e81f3755604400867407

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 21e6060398432787a867f953976719065b26bd95

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

J0bbie commented 3 years ago

Hi @hpages,

Thanks for the review! My apologies for the late reply due to holidays.

After some ordeals with also trying to improve the test/example run-times by adding an example dataset instead of generating the example/test dataset from scratch each time, it finally works again with also the requested changes to the vignette / class.

Please let me know if anything else is required!

Kind regards,

Job van Riet

hpages commented 3 years ago

Hi @J0bbie ,

Thanks for the changes.

2 things:

  1. The rendered HTML vignette still starts immediately with the Abstract and is still missing title and author(s).
  2. Your vignette contains a call to ProteoDisco::generateJunctionModels() that uses 20 workers (threads = 20). This will put too much stress on the Bioconductor build machines or on any machine where R CMD build ProteoDisco gets run. Please do not use more than 4 workers in your vignette, examples, or unit tests.

I'm also not sure I see the value of renaming workers -> threads in your functions, but that's a minor consideration.

Thanks, H.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 19a5601c31a38fc4b1058f8b7ea8d13816a05ffe

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 876a4a4245a208749de306b959b7383d6b7358f2

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Dear @J0bbie ,

We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: c51dceaedb3506214e3c50c173d23d4895758589

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 885116c80241e24c366547b95767491f0ffaf745

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

J0bbie commented 3 years ago

Dear @hpages,

My apologies for the "threads = 20", it was left there during testing.. I've also reduced the nr. of large tests as it was sometimes giving a TIMEOUT due to one of our larger test-cases.

I've changed to engine from %\VignetteEngine{knitr::knitr} to %\VignetteEngine{knitr::rmarkdown} and hope that solved the issue as I also noticed that the .css wasn't getting loaded in your output.

Using %\VignetteEngine{knitr::rmarkdown} and devtools::install_github(repo = "ErasmusMC-CCBC/ProteoDisco", build_vignettes = T) on my external PC yielded a vignette incl. the authors.

Please let me know if this fixed the issue!

Kind regards,

Job van Riet

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/ProteoDisco to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 2 years ago

Thanks. Package is good to go.

Cheers, H.

bioc-issue-bot commented 2 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 2 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/J0bbie.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("ProteoDisco"). The package 'landing page' will be created at

https://bioconductor.org/packages/ProteoDisco

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.