Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

netZooR #2238

Closed marouenbg closed 2 years ago

marouenbg commented 3 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 3 years ago

Hi @marouenbg

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: netZooR
Title: Integrate methods: PANDA, LIONESS, CONDOR, ALPACA, SAMBAR, MONSTER and OTTER into one workflow
Version: 0.99.1
Date: 2020-11-20
Authors@R: c(person("Tian", "Wang",
            email = "twang@hsph.harvard.edu", role = c("aut", "cre")),
         person("Marouen", "Ben Guebila", 
            email = "benguebila@hsph.harvard.edu", role = c("aut","ctb")),
         person("John", "Platig",
            email="john.platig@channing.harvard.edu",role="aut"),
         person("Marieke", "Kuijjer",
            email = "marieke.kuijjer@ncmm.uio.no", role = "aut"),
         person("Magha", "Padi",
            email = "mpadi@email.arizona.edu", role = "aut"),
         person("Rebekka", "Burkholz",
            email = "rburkholz@hsph.harvard.edu",role = "aut"),
   person("Deborah", "Weighill",
              email = "",role = "aut"))
Description: PANDA(Passing Attributes between Networks for Data Assimilation) is a message-passing model to reconstruction gene regulatory network. It integrates multiple sources of biological data, including protein-protein interaction data, gene expression data, and sequence motif information to reconstruct genome-wide, condition-specific regulatory networks.[(Glass et al. 2013)]. LIONESS(Linear Interpolation to Obtain Network Estimates for Single Samples) is a method to estimate sample-specific regulatory networks by applying linear interpolation to the predictions made by existing aggregate network inference approaches. CONDOR(COmplex Network Description Of Regulators)is a bipartite community structure analysis tool of biological networks, especially eQTL networks, including a method for scoring nodes based on their modularity contribution.[(Platig et al. 2016). ALPACA(ALtered Partitions Across Community Architectures) is a method for comparing two genome-scale networks derived from different phenotypic states to identify condition-specific modules.[(Padi and Quackenbush 2018)]. This package integrates pypanda--the Python implementation of PANDA and LIONESS(https://github.com/davidvi/pypanda),the R implementation of CONDOR(https://github.com/jplatig/condor) and the R implementation of ALPACA (https://github.com/meghapadi/ALPACA) into one workflow. Each tool can be call in this package by one function, and the relevant output could be accessible in current R session for downstream analysis. 
Depends: R (>= 3.3),
     igraph,
     reticulate,
     pandaR,
biocViews:
Imports: RCy3,
     viridisLite, 
     STRINGdb,
     Biobase,
     matrixStats,
     GOstats,
     GO.db,
     org.Hs.eg.db,
     Matrix,
     gplots,
     nnet,
     data.table,
     vegan,
     stats,
     utils,
     reshape,
     reshape2,
     penalized,
     parallel,
     doParallel,
     foreach,
     ggplot2,
     ggdendro,
     grid,
     MASS,
     assertthat,
     tidyr,
     methods,
     AnnotationDbi,
         dplyr,
     IRanges,
     GenomicRanges,
Remotes: jnpaulson/pandaR,
         PadiLab/CRANE,
License: GPL-3
Encoding: UTF-8
LazyData: true
Suggests: 
    testthat (>= 2.1.0),
    knitr,
    rmarkdown,
    pkgdown,
VignetteBuilder: knitr
RoxygenNote: 7.1.1
lshep commented 3 years ago

Please add valid biocViews to the DESCRIPTION in order to proceed. All Bioconductor package require biocViews terms. See http://bioconductor.org/packages/release/BiocViews.html#___Software and the drop downs on the left for available terms.

rohanbiju commented 3 years ago

Hi @lshep ! @marouenbg and I have made the required changes. It would be great if you take a look again. Thanks!

bioc-issue-bot commented 3 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

lshep commented 3 years ago

@marouenbg Your biocviews are still incorrect. You need to update your biocviews to be valid terms (not packages). We have processed the package anyways but it will need to be corrected in the review process.

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

marouenbg commented 3 years ago

Hi @lshep We fixed biocViews, could you please have a look (https://github.com/netZoo/netZooR)? Thank you @rohanbiju

lshep commented 3 years ago

Thank you. Now the biocViews are valid. Please correct the ERROR shown in the build report before an indepth review will take place.

lshep commented 3 years ago

Please resolve the ERROR in the build report before an in-depth review will take place.

marouenbg commented 3 years ago

Hi @lshep , I wasn't able to reproduce the error on my computer. It basically says that it cannot access .txt files in inst/extdata directory, is it ignored by bioconductor? Do you have the set of commands that the server does so I can reproduce them on my computer?

Thank you

lshep commented 3 years ago

I can reproduce this locally on my computer. Make sure you are using R 4.1.1 and most updated Bioconductor packages with BiocManager::valid(). There are some environment variables set up on the builders https://github.com/Bioconductor/Contributions#r-cmd-check-environment

marouenbg commented 3 years ago

HI @lshep , Indeed, I was wrong, I installed R4..1.1 and I could reproduce the error. Errors should be fixed now, can you please trigger another run? Thank you

lshep commented 3 years ago

Please trigger another run by pushing a version bump to the git.bioconductor.org repository as described https://github.com/Bioconductor/Contributions/issues/2238#issuecomment-910543089

marouenbg commented 3 years ago

Hi @lshep, sorry for bothering your again. I pushed to bioconductor git (git@git.bioconductor.org:packages/netZooR.git) but I did not receive any feedback from the test server.

lshep commented 3 years ago

Can you please try again with an updated version bump? we were having some trouble with the auto build scripts last week that should be remedied

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 1d97e8f2d89bc590af4a8dac21c18719eec271ae

marouenbg commented 3 years ago

It seems that the build was triggered, thank you!

lshep commented 3 years ago

yep thank you. it should post shortly.

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 3330b58dead4dbf4a46f33dd166a130ff40ebf21

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 4bbde9e312dced29817b73f8749f2cbf0ea3aed4

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: dd413b8b2ca4715f93d9282a647db154b0cc194e

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 300557f94ac4533b8f435ad1ca4434cbd1b792c8

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: a5179b264147463728c6202b905f4c9f297cf2b9

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 94e4930355413e8c481102f432b3c822547bf3c6

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 44525597eb2779ced57c04cf42c50d4c61df4718

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 34c64c0848a4d856b99f9b88b0147cad76e8fb59

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 8a1be8f036910105325d96a98d3c5ff7a95e58ea

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: de6711c40961a5b364ed889f03d8a9bebb755d66

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

marouenbg commented 3 years ago

Hi @lshep , I was really trying hard to tidy up the package for bioconductor, the build is ok but I keep getting this error at the Check stage:

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 90e35db21c4b77bcdd233b17474053587eb47346

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

marouenbg commented 3 years ago

OK the previous error was fixed, it was a unicode character hidden in the function description. I still have more errors from the bioconductor check.

marouenbg commented 3 years ago

Hi @lshep , I needed to make significant changes to the master branch to pass the biocoductor tests, therefore I created a new branch called bioc that has the necessary changes while keeping my master branch. However when I push, I get the following error (my upstream is biocup):

git push biocup bioc

Enumerating objects: 13, done. Counting objects: 100% (13/13), done. Delta compression using up to 12 threads Compressing objects: 100% (8/8), done. Writing objects: 100% (8/8), 793 bytes | 198.00 KiB/s, done. Total 8 (delta 6), reused 0 (delta 0) remote: FATAL: W refs/heads/bioc packages/netZooR marouenbg DENIED by fallthru remote: error: hook declined to update refs/heads/bioc To git.bioconductor.org:packages/netZooR.git ! [remote rejected] bioc -> bioc (hook declined) error: failed to push some refs to 'git@git.bioconductor.org:packages/netZooR.git'

Do you have any idea how to fix this? Thank you

lshep commented 3 years ago

Bioconductor does not allow pushing up of other branches and we would really recommended eventually merging into the master branch so not to get out of sync. I think you can specify a linking see step 5 on https://bioconductor.org/developers/how-to/git/new-package-workflow/ that addresses the new default main/master mismatch

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 72e3acd79a16b54d0bad5968cbd9a07ac5ed3239

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: b840324a800e23b500960eb68736ee161950e84b

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/netZooR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 3 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 91a60f835b91503a78c0bb762b0aa035eb48123d