Closed marouenbg closed 2 years ago
Received a valid push on git.bioconductor.org; starting a build for commit id: 436d8d14ac84975515fb28d9c55ffbac8f8f974b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 8420c790577ea88dba770cb9bd5e614131ebbe78
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: d3e4488bc12f7dc07fec609dcddc06ee154bec3b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 4aae90857fd4693f313bba9ca76848c8dd165256
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 2f7ebfcf9aee5f6fedd6315b1ab5588d012592c9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1e5ca32e8108ccfd4982bf3795f013b164dde066
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 6327446856f54f322a44f28543dc66dbce86e4f9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 7c8b8eede960e9580b94a776e0e687fff6e1b060
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ee49d0c141a0e3245c2a18f606f1c3d530b28c36
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: f111fb9983ae4ca42dd0b1925314ca8fd946312b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 28047c203739ad43d00529fb224494592ba3052a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@marouenbg - Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.
[ ] SUGGESTION: Since you are using a standard license, the 'LICENSE' file doesn't need to be included in your package.
[ ] REQUIRED: 'LazyData' should be set to false or removed.
[ ] REQUIRED: There are packages listed in more than one of Depends, Imports, Suggests, Enhances: viridisLite, pandaR
[ ] REQUIRED: There are trailing ',' after pandaR in 'Depends', yarn in 'Imports', and pkgdown in 'Suggests'. These should be removed.
[ ] REQUIRED: Update R version dependency from 3.3 to 4.1.0.
[ ] REQUIRED: There is a trailing ',' after the biocView GeneRegulation. This should be removed.
[ ] SUGGESTION: Consider adding these automatically suggested biocViews: GeneExpression, Transcription, Microarray, GraphAndNetwork See http://bioconductor.org/developers/how-to/biocViews/
[ ] SUGGESTION: We strongly encourage the use of the 'BugReports' field to include the relevant link to GitHub for reporting issues.
[ ] REQUIRED: Exported functions should use camel case or underscoring and not include '.', which indicates S3 dispatch.
[ ] SUGGESTION: Generally 'importFrom()' is encouraged over importing an entire package. However, if there are many functions from a single package, 'import()' can be acceptable.
[ ] REQUIRED: For exon.size, genes, monsterRs, and mut.ucec could you provide the actual reference to Kuijjer et al., similar to how you have a reference for small1976 and yeast.
[ ] REQUIRED: Data in the 'inst/extdata/' directory need proper documentation in an 'inst/script/' directory. The scripts in the directory can vary but most importantly should clearly state how the data was generated. It should include source URLs and any key information regarding filtering or processing. It can be executable code, sudo code, or a text description. Users should be able to download and roughly reproduce the file or object that is present as data.
[ ] REQUIRED: I think there needs to be thought into whether all the vignettes are needed in this package. The idea of a vignette is to demonstrate how to accomplish non-trivial tasks embodying the core functionality of your package, not other established packages. It is fine to explain packages and how they are relevant to yours but you should really be demonstrating the use of your package. It also might be better if all code was in one main vignette instead of many little ones. A user might not know which vignette to browse when looking for answers to questions or examples to run.
[ ] REQUIRED: Whether you decide to go with one or many vignette each one must minimally include:
sessionInfo()
[ ] REQUIRED: There is a library(RColorBrewer)
call in the yarn.Rmd file,
but RColorBrewer isn't listed as a Suggests in the DESCRIPTION file. Please
add to the DESCRIPTION file if usin in the vignette.
[ ] REQURIED: All data used in vignette should come from the package itself or other CRAN/Bioconductor packages. You should avoid downloading files and external data from the web.
[ ] REQUIRED: Data used in examples should come from the package itself or other CRAN/Bioconductor packages. You should avoid downloading files and external data from the web.
[ ] REQUIRED: Found '@' in man/monster.Rd. Use accessors; don't access S4 class slots via '@' in examples/vignettes.
[ ] REQUIRED: All exported objects/functions need valid examples with them. For example, the alpaca function just has "a <- 1 # example place holder" as an example. This is not acceptable.
[ ] REQUIRED: Add runnable examples to the following man pages which document exported objects: create.diff.panda.style.Rd create.panda.style.Rd sambar.convertgmt.Rd sambar.corgenelength.Rd sambar.desparsify.Rd sambar.Rd vis.diff.panda.in.cytoscape.Rd vis.panda.in.cytoscape.Rd
[ ] REQUIRED: Usage of dontrun{} / donttest{} found in man page examples. Use donttest{} instead of dontrun{} if necessary. Found in the following files: vis.diff.panda.in.cytoscape.Rd vis.panda.in.cytoscape.Rd
[ ] REQUIRED: Function names should be camelCase or utilize the underscore and not have a dot.
[ ] SUGGESTION: Consider clarifying how 2 objects are initialized. Maybe they are part of a data set loaded with data(), or perhaps part of an object referenced in with() or within(). function (object) monster.monsterNI (yeast) runEgret (NA12878)
[ ] REQUIRED: Avoid sapply(); use vapply() instead.
[ ] REQUIRED: Avoid 1:...; use seq_len() or seq_along() instead.
[ ] REQUIRED: Avoid use of direct slot access with '@' or slot(). Accessor methods should be created and utilized.
[ ] REQUIRED: Avoid the use of 'paste' in condition signals. Found in files: R/panda.to.alpaca.R, line 49 R/panda.to.condor.object.R, line 72
[ ] REQUIRED: Avoid redundant 'stop' and 'warn*' in signal conditions. Found in files: R/CONDOR.R, lines 375 and 581 R/MONSTER.R, lines 802, 828, and 835
[ ] REQUIRED: Avoid system(); use system2() instead.
[ ] SUGGESTION: For formatting reasons, consider shorter lines. There are 957 lines that are > 80 characters long.
[ ] SUGGESTION: For formatting reasons, consider 4 spaces instead of tabs. There are 9 lines that contain tabs.
[ ] SUGGESTION: For formatting reasons, consider multiples of 4 spaces for line indents. There are 1990 lines that are not.
Best, Kayla
Hi @Kayla-Morrell ,
Thank for the great feedback, I am working on it at the moment. Regarding this point
Where should I provide a reference to Kuijjer et al?
Received a valid push on git.bioconductor.org; starting a build for commit id: 271463ce8d42b08818456da7fda52040e0efe35c
Received a valid push on git.bioconductor.org; starting a build for commit id: 7d967b7db5c938e597edd11b2de6be9402c53ff7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 3605c52563c1fa3aa00fbf68326a6d438856a153
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 38d9ef8f55d102a3b371d6d36482d83d60e31b69
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 6c95b2935bf9d63c302394d76aaba965e52a6110
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 26c6597b1572367198bf2b64d7396dabd6bbeb71
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: bc5c4cb3429514c8d11e78c2e303e30fccecb15c
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 929e2cdf9bc0eeedbcfb0e2e70270a441284362a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: df4a90910e950cbd0cc206900ceb7f142765dd15
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ad27daa4989076a8e38c778a4f1a5de2b2d1d216
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: b7ffa80225dafb2d9d13ef44bf47bdefb7cfeb49
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 279108ea73eadc40d710fa269baa11c283713f07
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: bde159c0aa63327404dcb0043b9360f40a827765
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/netZooR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[ x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x ] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[ x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[ x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x ] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x ] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[ x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.