Closed Danis102 closed 1 year ago
Hi @Danis102
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: seqpac
Type: Package
Title: seqpac - Group-based Analysis of Short Reads Using Sequence Counts
Version: 0.99.0
Authors@R: c(
person("Daniel", "Natt", email="daniel.natt@liu.se", role= c("aut", "cre", "fnd")),
person("Lovisa", "Örkenby", email="lovisa.orkenby@liu.se", role= "ctb"),
person("Signe", "Skog", email="signe.skog@liu.se", role= "ctb"),
person("Anita", "Öst", email="anita.ost@liu.se", role= c("aut", "fnd"))
)
Description: A collection of functions used for complete analysis of short sequenced reads.
The package was originally developed for small RNA analysis, but can be implemented on
any sequencing raw data (provided as a fastq-file) where intended unit of measurement
is counts of unique sequences. The core of the seqpac workflow is the generation and
subsequence analysis/visualization of a standardized list object called PAC. Using an
innovative target system, seqpac extracts, analyze and visualize group differences
using the PAC object.
A PAC object in its most basic form is a list containing three types of data frames:
- Phenotype table (P): Sample names (rows) with associated metadata (columns) e.g. groups.
- Annotation table (A): Unique sequences (rows) with annotation (columns), eg. reference alignment.
- Counts table (C): Counts of unique sequences (rows) for each sample (columns).
The PAC list-objects follow the rule:
- Row names in P must be identical with column names in C.
- Row names in A must be identical with row names in C.
Thus P and A describes the columns and rows in C, respectively. The targeting system, will either
target specific samples in P (pheno_target) or sequences in A (anno_target) and group them according
to a target column in P and A, respectively.
License: GLP-3 + file LICENSE
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.1.1
URL: https://github.com/Danis102/seqpac
BugReports: https://github.com/Danis102/seqpac/issues
biocViews:
Workflow
EpigeneticWorkflow
AnnotationWorkflow
GeneExpressionWorkflow
Depend:
Biostrings (>= 2.46.0),
foreach (>= 1.5.1),
GenomicRanges (>= 1.30.3,
Rbowtie (>= 1.18.0),
ShortRead (>= 1.36.1),
tibble (>= 3.1.2)
Imports:
BiocParallel (>= 1.12.0),
Biostrings (>= 2.46.0),
cowplot (>= 0.9.4),
data.table (>= 1.14.0),
digest (>= 0.6.27),
doParallel (>= 1.0.16),
dplyr (>= 1.0.6),
factoextra (>= 1.0.7),
FactoMineR (>= 1.41),
foreach (>= 1.5.1),
GenomicRanges (>= 1.30.3),
ggplot2 (>= 3.3.3),
IRanges (>= 2.12.0),
parallel (>= 3.4.4),
Rbowtie (>= 1.18.0),
readr (>= 1.4.0),
reshape2 (>= 1.4.4),
rtracklayer (>= 1.38.3),
ShortRead (>= 1.36.1),
stringr (>= 1.4.0),
stats (>= 3.4.4),
tibble (>= 3.1.2),
tidyr (>= 1.1.3)
Suggests:
benchmarkme (>= 0.6.0),
DESeq2 (>= 1.18.1),
GenomeInfoDb (>= 1.14.0),
gginnards (>= 0.0.2),
knitr,
qqman (>= 0.1.8),
rmarkdown,
testthat,
UpSetR (>= 1.4.0),
venneuler
VignetteBuilder:
knitr
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Please fix the errors and warnings to meet the requirement of review process. If you need any help, please let me known or ask help in develop mailing list.
@Danis102 may we expect and updated version of submission soon? We like to see movement within a 3-4 week time frame?
Very soon. We're working on updating the vignette according to some updates in the functions following changes after running BioCheck. Hopefully, the new updates will be submitted in just a few days.
Regards, Daniel Natt (main developer of seqpac)
Skaffa Outlook för Androidhttps://aka.ms/ghei36
From: lshep @.> Sent: Tuesday, November 9, 2021 7:15:00 PM To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
@Danis102https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDanis102&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd43cd6c865204c3b360508d9a3acd8f3%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637720785040605493%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mv%2FKx7t73XjAx68df%2BoQYVrk9%2B4qah%2FayZQAukE9sdo%3D&reserved=0 may we expect and updated version of submission soon? We like to see movement within a 3-4 week time frame?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-964409375&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd43cd6c865204c3b360508d9a3acd8f3%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637720785040615490%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2XbhRUrEWJEjnKLZa6qZiUR%2BwHVDBTMSm9jKnq1k7Fo%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUX2EDLIQC4IYFWNES5TULFQKJANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd43cd6c865204c3b360508d9a3acd8f3%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637720785040625485%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=zJujWDTLcyPPuQ7ofTmKpAFow%2BsS7PXn6CKhigyIsGo%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd43cd6c865204c3b360508d9a3acd8f3%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637720785040625485%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=KzraAYRG8wIXQdJEeOjVSBG15111TFUgh7ZchrMCjjQ%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd43cd6c865204c3b360508d9a3acd8f3%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637720785040635480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RLuIvqRcv6LWMC10eOoltrKsKu5DXZx2tWiJmPGAQFg%3D&reserved=0.
We are temporarily closing this issue for inactivity as it has been another 2 weeks with no progress. When you are ready to submit changes please ask for the issue to be reopened to continue the review process.
This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.
Thank you for your interest in Bioconductor.
Dear Ishep,
Would you please reopen our issue (submission) on Bioconducter. We are now ready to update our GitHub master and submit a new version of seqpac. I apologize for the delay. I can garantee that it is no lack in commitment, but rather that I have been struggling with a rather severe diagnosis during the autumn. We now have a branch of Seqpac, however, that goes through BioCheck and devtools::check without any errors or warnings. So, please, reopen our issue, so we can go on with it :).
Best regards, Main developer Daniel Nätt
Skaffa Outlook för Androidhttps://aka.ms/ghei36
Från: lshep @.***> Skickat: onsdag 24 november 2021 12:51 Till: Bioconductor/Contributions Kopia: Daniel Nätt; Mention Ämne: Re: [Bioconductor/Contributions] (inactive) Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
We are temporarily closing this issue for inactivity as it has been another 2 weeks with no progress. When you are ready to submit changes please ask for the issue to be reopened to continue the review process.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-977804185&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd567d5cb0b0a46a00ed808d9af40b43a%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637733514707399055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=OiHd9KcMreGWQDvz3%2FalwMgjS6y5zW6%2FIF0CNgvcDlE%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUXZHQNDJVXAMMAKNW7TUNTGSXANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd567d5cb0b0a46a00ed808d9af40b43a%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637733514707409050%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rXKFy1kfjbGF0HUlojF6EyHWEYKvIH%2BHMtwYKrShylE%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd567d5cb0b0a46a00ed808d9af40b43a%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637733514707419044%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=TpfwYlzV7TCX%2Bx4FoIN3U0dc9H9g4u7BT153IYQP2rc%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cdaniel.natt%40liu.se%7Cd567d5cb0b0a46a00ed808d9af40b43a%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637733514707429041%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nQd4kx0av3i6q0unDvsqp1WwIFjhI3wWhDDTZtvqZ%2B4%3D&reserved=0.
Dear @Danis102 ,
We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.
Received a valid push on git.bioconductor.org; starting a build for commit id: 344d85383cd7a6490a7a19192e5fe32fcd80b8e0
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 8b6237424ffed57a45546103351cb68a434b570d
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
The package passed check and build. But there are several issues need to be addressed. Please fix the following issues first and I will review it again.
Depends
field is not found in DESCRIPTION.Error in system.file("extdata", "drosophila_sRNA_pac.Rdata", package = "seqpac", mustWork = TRUE)
: no file found
Backtrace:
█
[ ] Vignette should use BiocStyle
package for formatting.
[ ] Please include Bioconductor installation instructions using BiocManager.
[ ] Consider adding runnable examples to the following man pages which document exported objects:
[ ] Usage of dontrun{}
/ donttest{}
found in man page examples.
[ ] no direct slot access with @
or slot()
- accessors implemented and used.
[ ] incomplete final line found on
[ ] is()
or inherits()
instead of class()
.
[ ] system2
instead of system
.
[ ] message()
, warning
, stop
instead of cat
.
[ ] No paste
in message()
, warning
, stop
[ ] ::
is not suggested in source code unless you can make sure all the packages are imported.
[ ] 1:n
is not suggested in source code. Use seq_along
or seq.int
instead.
[ ] Vectorize: no unnecessary for
loops present.
[ ] Use file.path
to replace paste
[ ] Avoid redundant 'stop' and 'warn*' in signal conditions. Found in files:
[ ] Avoid 'suppressWarnings'/'*Messages' if possible (found 13 times)
[ ] Function arguments are tested for validity.
[ ] Functional programming: code repetition.
eg repetition in colnames
and rownames
@Danis102 may we expect any updates soon? We like to see reviews move forward within 3-4 weeks.
Please have patience. It has been Christmas, New Year, Covid-restrictions and sick leaves in the lab that have prevented us to work as much as we would have wanted. But rest assured that we are working as much as we can. I hope that you will have a new update during next week.
From: lshep @.> Sent: Thursday, January 20, 2022 5:38 PM To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
@Danis102https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDanis102&data=04%7C01%7Cdaniel.natt%40liu.se%7C7b98556d891c4ed6ac4008d9dc3340fb%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637782934971615911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=fn3cvRnXBreteS%2FRdgIA4VPyQg%2F4Gpwe%2B1rgN1NCZgg%3D&reserved=0 may we expect any updates soon? We like to see reviews move forward within 3-4 weeks.
- Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-1017695791&data=04%7C01%7Cdaniel.natt%40liu.se%7C7b98556d891c4ed6ac4008d9dc3340fb%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637782934971615911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tyoT4iLdXjrFtm8W85aH0HVLrQekm%2FWhjEwelRSVUEo%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUX2OKKCA5Q7YO55SFE3UXA27JANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7C7b98556d891c4ed6ac4008d9dc3340fb%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637782934971615911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oIjM4qirPFPwrak%2F0R7uDOBhNug0G41QassVIPUN98Q%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cdaniel.natt%40liu.se%7C7b98556d891c4ed6ac4008d9dc3340fb%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637782934971615911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=sYmusmmh2ZD6Nho25m4JYzd6%2Fg7kJL9MTMfsEiNVePI%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cdaniel.natt%40liu.se%7C7b98556d891c4ed6ac4008d9dc3340fb%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637782934971615911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=TG3quGc1YPiSq6AbukqH8PzriBoWr4m6OjGQ0FDyVyQ%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
Received a valid push on git.bioconductor.org; starting a build for commit id: 7ecb616d932c020e89b93e18970c832bb17d49b4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear reviewer, First we like thank you for the valuable comment. We have now made another bump, upload upstream of master, and tried to commit all suggestions and comments as far as we could.
Devtools::check() now runs without neither Errors, Warnings or Notes on our systems
BiocCheck::BiocCheck() runs without Errors and Warnings, but still report a few Notes related suggestions to the code. These were also commented by the reviewer in the latest issue/email. Attached you will find our responses to why it is important for us to avoid committing these suggestions to the code at this point. Since theses notes/comment are suggestions in nature, and not seem to be obligatory for admission to Bioconductor, but may instead seriously affect our workflows unless extensive testing is performed, we hope to address these notes/comments progressively at later updates of seqpac. Please, again, read our response in the attached document.
Yours sincerely, Daniel Nätt
From: JIANHONG OU @.> Sent: Tuesday, December 21, 2021 1:57 AM To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
Package 'seqpac' Review
The package passed check and build. But there are several issues need to be addressed. Please fix the following issues first and I will review it again.
The DESCRIPTION file
The CITATION file
Unacceptable files
General package development
Unit tests
Error in system.file("extdata", "drosophila_sRNA_pac.Rdata", package = "seqpac", mustWork = TRUE): no file found Backtrace: █
Documentation
R code
mailing list
— Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-998381593&data=04%7C01%7Cdaniel.natt%40liu.se%7C8fde9c2945c0445ac06808d9c41cdd73%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637756450550452844%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KEZ9OHM9TQ0IInu9%2F6Zq3PdyAGjsuSAzX5xPhPQzAsM%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUXYY5FU7V5PE2T6J5A3UR7GHRANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7C8fde9c2945c0445ac06808d9c41cdd73%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637756450550452844%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rrj7U0W2Hbql2HT6%2BESWY3VB1m02rOjrd%2FUSJcGlq%2F8%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cdaniel.natt%40liu.se%7C8fde9c2945c0445ac06808d9c41cdd73%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637756450550452844%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=V3zObptYt59zifOwBIZv8JddeDsBhzytzWXQPYDpVfE%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cdaniel.natt%40liu.se%7C8fde9c2945c0445ac06808d9c41cdd73%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637756450550452844%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NEPDNaddFfn%2B%2BDGd3M97XDsr%2BJlI%2B0bTDre7YJ7xuD0%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
Received a valid push on git.bioconductor.org; starting a build for commit id: 0138aa29d65f0b5597adfb6067879d87dae7ec89
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS, ERROR, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: e11a97c319d683aaa2b181e34c4e4b77d31754a8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: b7bd08723373ea2bdf4f29cefd591d78e5872b2a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: b47647cd087bf1105cdb9010f41be19ec2033ff7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Bioconductor reviewer,
We consistently recieve a Timeout error on the Mac server when making a new push. All other platforms go through without a problem. In the last push I even removed the two most time consuming test files, saving about 10 min in processing time, and still Mac report timeout error. Please indicate if you are having problems with the Mac server, or give me more specific information of what is wrong with our package on your Mac system.
Best regards, Daniel Natt
Skaffa Outlook för Androidhttps://aka.ms/ghei36
From: bioc-issue-bot @.> Sent: Friday, February 4, 2022 10:21:22 AM To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build reporthttps://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbioconductor.org%2Fspb_reports%2Fseqpac_buildreport_20220204042108.html&data=04%7C01%7Cdaniel.natt%40liu.se%7Ce8640289a7ca4d57f68608d9e7bfb672%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637795632849862904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ELqSB2iyCQI2N60FCcKHmIP2tGF5Ozyur5XLgTJ6WQQ%3D&reserved=0 for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to @.***:packages/seqpac to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found herehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbioconductor.org%2Fdevelopers%2Fhow-to%2Fgit%2Fnew-package-workflow%2F&data=04%7C01%7Cdaniel.natt%40liu.se%7Ce8640289a7ca4d57f68608d9e7bfb672%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637795632849862904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1rUSbBe5SlT4iMiBl5cJX1z5gVbsnHbO50YcwqN3tnQ%3D&reserved=0.
— Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-1029793084&data=04%7C01%7Cdaniel.natt%40liu.se%7Ce8640289a7ca4d57f68608d9e7bfb672%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637795632849862904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ryVyUyoCH6mSsl79pETNU%2BqVA8b%2F7nRz5wn%2FV0v1Wf0%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUX4HVNX5AM6M2UI662LUZOLBFANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7Ce8640289a7ca4d57f68608d9e7bfb672%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637795632849862904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2FE5FrV3dVUc9UYN7GWsSoUkyBCVxHbPuPHsj%2B%2Fz2afg%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cdaniel.natt%40liu.se%7Ce8640289a7ca4d57f68608d9e7bfb672%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637795632849862904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Sv3XDO279Sxpf6UQjpcHpatLkL%2FextXRN7pindp%2BkLI%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cdaniel.natt%40liu.se%7Ce8640289a7ca4d57f68608d9e7bfb672%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637795632849862904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nK6apoJI6CzNBgjfdSy6EK8x2WXfJSy5mqf%2FTJJ4B%2FU%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
There are several functions that are taking a long time on mac. Here is the seqpack-Ex.timings from our build system for merida1
merida1:seqpac.Rcheck pkgbuild$ cat seqpac-Ex.timings
name user system elapsed
PAC 0.238 0.009 0.324
PAC_check 0.190 0.006 0.214
PAC_covplot 51.285 1.012 57.015
PAC_deseq 90.392 15.140 74.728
PAC_filter 0.265 0.009 0.280
PAC_filtsep 0.229 0.004 0.238
PAC_gtf 72.651 4.932 46.092
PAC_jitter 14.018 0.320 16.245
PAC_mapper 49.646 0.846 55.971
PAC_nbias 16.611 0.078 17.887
PAC_norm 4.185 0.012 4.527
PAC_pca 17.151 0.173 18.314
PAC_pie 2.995 0.060 3.215
PAC_saturation 2.520 0.035 2.676
PAC_sizedist 4.153 0.037 4.430
PAC_stackbar 3.907 0.077 4.168
PAC_summary 1.782 0.006 1.859
PAC_trna 17.937 4.818 22.961
add_reanno 30.307 5.192 36.910
anno 0.338 0.106 0.446
as.PAC 0.220 0.004 0.225
as.reanno 19.634 3.870 20.581
colnames 0.342 0.109 0.455
counts 0.339 0.110 0.455
filtsep_bin 0.224 0.005 0.229
full 15.302 3.758 16.071
import_reanno 5.969 1.310 6.955
length 0.348 0.111 0.462
make_PAC 42.762 7.338 37.543
make_conv 0.102 0.004 0.116
make_counts 79.870 15.191 76.648
make_cutadapt 32.971 0.881 36.983
make_pheno 39.205 9.452 34.955
make_reanno 10.030 2.295 10.484
make_trim 34.092 0.714 34.920
map_rangetype 7.771 3.718 11.283
map_reanno 66.331 13.110 68.910
merge_lanes 7.248 0.725 10.540
names 15.277 3.708 17.318
ncol 0.301 0.097 0.400
norm 0.298 0.082 0.381
nrow 0.287 0.103 0.391
overview 15.905 3.901 19.317
pheno 0.344 0.114 0.692
reanno 20.873 3.987 26.416
rownames 0.311 0.101 0.414
show 0.305 0.095 0.402
simplify_reanno 22.250 4.143 33.875
summary 0.343 0.106 0.691
tRNA_class 17.561 4.231 25.132
These functions also take several seconds on the other platforms so perhaps there is a way to look for inefficiencies and ways to improve the timing. For comparison here is the example timings from nebbiolo1
seqpac.Rcheck$ cat seqpac-Ex.timings
name user system elapsed
PAC 0.075 0.004 0.079
PAC_check 0.060 0.001 0.060
PAC_covplot 15.774 0.433 16.206
PAC_deseq 26.809 8.057 22.807
PAC_filter 0.094 0.000 0.094
PAC_filtsep 0.076 0.000 0.076
PAC_gtf 20.109 2.983 13.620
PAC_jitter 4.617 0.096 4.713
PAC_mapper 14.195 0.451 14.643
PAC_nbias 4.513 0.024 4.537
PAC_norm 1.108 0.004 1.112
PAC_pca 5.263 0.104 5.367
PAC_pie 0.823 0.040 0.863
PAC_saturation 0.758 0.017 0.793
PAC_sizedist 1.162 0.012 1.174
PAC_stackbar 1.111 0.008 1.119
PAC_summary 0.425 0.000 0.425
PAC_trna 5.547 5.245 7.466
add_reanno 11.161 2.742 12.469
anno 0.099 0.124 0.224
as.PAC 0.067 0.004 0.071
as.reanno 7.395 1.984 8.087
colnames 0.120 0.100 0.219
counts 0.092 0.128 0.221
filtsep_bin 0.078 0.004 0.082
full 6.606 1.973 7.320
import_reanno 2.930 0.751 3.389
length 0.109 0.112 0.221
make_PAC 22.330 2.661 18.362
make_conv 0.034 0.000 0.034
make_counts 42.498 6.043 35.342
make_cutadapt 18.616 0.260 18.876
make_pheno 21.767 2.568 17.976
make_reanno 4.307 1.366 4.823
make_trim 19.590 0.296 19.886
map_rangetype 2.587 5.163 4.414
map_reanno 24.051 6.650 23.713
merge_lanes 2.971 0.385 3.301
names 7.218 2.245 8.152
ncol 0.097 0.120 0.218
norm 0.092 0.124 0.216
nrow 0.103 0.116 0.219
overview 6.887 2.120 7.698
pheno 0.110 0.112 0.223
reanno 8.138 1.936 8.778
rownames 0.08 0.14 0.22
show 0.098 0.132 0.230
simplify_reanno 8.053 2.120 8.869
summary 0.094 0.128 0.221
tRNA_class 5.536 5.368 7.581
any progress on potentially improving the efficiency of the functions that are taking long run times?
Hi Isep,
I am very sorry for the delay. Research never stand still, for the last few weeks, I have had to focus my attention on updating one of the main functions in seqpac to accommodate some research questions in our biological/molecular projects. The good news is that seqpac is now even better! I am doing the last tests right now, and hope to attend to the efficiency issues short thereafter. Hope you can give me a couple more weeks before you pause the submission. We are soon there. By the way, did you check the responses to the comments I sent you (attached)?
Best regards, Daniel
From: lshep @.> Sent: Monday, March 14, 2022 3:54 PM To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
any progress on potentially improving the efficiency of the functions that are taking long run times?
- Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-1066898897&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca7f1aa74762249da4bab08da05ca6864%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637828664140052432%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=bBsWukz6KauYCg8JBzcGHMMq1Hj7eA7qpdrMPe5H%2F7U%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUX2FGVGSMIDAOGVJO33U75HGVANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca7f1aa74762249da4bab08da05ca6864%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637828664140052432%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ceSCyAzT28cGGC278kMmMN1Q%2FlKd6Vn%2BN58mFJ2ULZM%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca7f1aa74762249da4bab08da05ca6864%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637828664140052432%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=t1Ri%2Fic71FWhZn2XeqZiAxXUGRRlSrgzb5woemdxK2w%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca7f1aa74762249da4bab08da05ca6864%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637828664140052432%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=fojdeR3S7Rs1hCHz0DbeTEuw%2FNkjg1w7KEFYSegfHBA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
We are closing this issue for now for inactivity. When you are ready to push changes please request this issue be reopened
This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.
Thank you for your interest in Bioconductor.
Dear,
Please reopen our submission (issue #2275). After some delay we are now in revision for a paper presenting the package (Seqpac). One of the reviewers, however, demands a completed that the Bioconductor submission prior to acceptance. Since our package only fails the time limit on the Mac server, without other errors, we believe we can complete our submission to Bioconductor before the 30 days we were given for the revision. Please give us a heads up if reopening our submission is not possible. From now one finalizing our submission is first priority.
Regards, Daniel Natt
From: lshep @.> Sent: Tuesday, 5 April 2022 13:52 To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] (inactive) Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
We are closing this issue for now for inactivity. When you are ready to push changes please request this issue be reopened
— Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-1088609420&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca406cffe6a92419f03ad08da16faaf85%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637847563200554456%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=iEZdcnQlSJrDppY4rGmdtkTd5m5AuViPgKm5QRND71k%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUX6OA42GGKTMRCDN723VDQSNXANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca406cffe6a92419f03ad08da16faaf85%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637847563200554456%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cQxOLfrhjo3YTyNiKcj1uRL%2Bj6uQIW7slI9vGIPm3lI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
Please push any changes and a version bump to trigger a new build report.
Dear @Danis102 ,
We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.
Dear Ishep,
Please reopen our submission. After some delay due adverse circumstances among our team members , we are now ready to push a new version.
Regards, Daniel Natt
From: lshep @.> Sent: Tuesday, April 5, 2022 1:52 PM To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] (inactive) Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
We are closing this issue for now for inactivity. When you are ready to push changes please request this issue be reopened
- Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-1088609420&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca406cffe6a92419f03ad08da16faaf85%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637847563200554456%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=iEZdcnQlSJrDppY4rGmdtkTd5m5AuViPgKm5QRND71k%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUX6OA42GGKTMRCDN723VDQSNXANCNFSM5DZM52BA&data=04%7C01%7Cdaniel.natt%40liu.se%7Ca406cffe6a92419f03ad08da16faaf85%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C637847563200554456%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cQxOLfrhjo3YTyNiKcj1uRL%2Bj6uQIW7slI9vGIPm3lI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@Danis102 the issue was already reopened as you can see from the comments 6 days ago. You need to push the changes to Bioconductor with a valid version bump to trigger a new build so @jianhong can review. The review will only occur once the package builds/checks without TIMEOUT/ERROR
Sorry about the delay. We descovered a minor bug in the newly added chunking mechanism, which allows analysis on low-end systems. Working hard to solve this issue and to make time checks even more efficient. We expect to make a new bump sometime during the week. Better to have a better version, then a version that needs immediate updates.
Regards, Daniel
From: lshep @.> Sent: Tuesday, October 11, 2022 1:36:05 PM To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
@Danis102https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDanis102&data=05%7C01%7Cdaniel.natt%40liu.se%7C35efbff92f9e40c8d97008daab7cc94d%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C638010849684196715%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iHfszgS4q9UlYMxwJDEFbrtzFi%2F9tSJkTQqGaEkN3%2Bk%3D&reserved=0 the issue was already reopened as you can see from the comments 6 days ago. You need to push the changes to Bioconductor with a valid version bump to trigger a new build so @jianhonghttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjianhong&data=05%7C01%7Cdaniel.natt%40liu.se%7C35efbff92f9e40c8d97008daab7cc94d%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C638010849684196715%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bvyd5T0jUNVsG8oFkehPL4lelQ30Kzu6uBi0E09H3g4%3D&reserved=0 can review. The review will only occur once the package builds/checks without TIMEOUT/ERROR
— Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-1274543165&data=05%7C01%7Cdaniel.natt%40liu.se%7C35efbff92f9e40c8d97008daab7cc94d%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C638010849684196715%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Hf5p5vIwtoCEl1VAmGi44Qw0OcnGRefKlSk001Ws%2Bd4%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUXYJ6W3YZZN4UY3JAJTWCVGKLANCNFSM5DZM52BA&data=05%7C01%7Cdaniel.natt%40liu.se%7C35efbff92f9e40c8d97008daab7cc94d%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C638010849684196715%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=X6%2B5YRki7JtV4Pyc47229Oah%2BTNpcZtdfGsLIdqUSH4%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
Can you confirm what the valid version number is? Tried a few already (4,5 and 8), but cant trigger a build. We have made a few updates since the last attempt to get it on Bioconductor. Thus, the version number has progressed. Or is something else wrong?
I see 0.99.7 on git.bioconductor.org which was the last build report on the SPB too. As long as the version number is 0.99.8 or higher it should trigger. Please show the results of remove -v
as well as the commands you are using to push to git.bioconductor.org so we may better assist you
I have identified the problem ( I think). I am work on a new computer and don’t have the ssh credantials for the upstream bioconducter remote. Is there a way for me to receive new ssh and be able to push against the upstream depository?
Best/Daniel
From: lshep @.> Sent: Tuesday, 18 October 2022 13:39 To: Bioconductor/Contributions @.> Cc: Daniel Nätt @.>; Mention @.> Subject: Re: [Bioconductor/Contributions] Submission of new package, seqpac: for small RNA analysis: from fastq (trimming included) to interpretation (#2275)
I see 0.99.7 on git.bioconductor.org which was the last build report on the SPB too. Please show the results of remove -v as well as the commands you are using to push to git.bioconductor.org so we may better assist you
— Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F2275%23issuecomment-1282248206&data=05%7C01%7Cdaniel.natt%40liu.se%7C5fa6fe037710496fe4b708dab0fd55c1%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C638016899360172777%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=CN2baSVVwlAwkbXeExpRO98m3Mr%2F56%2F30mptbNdhYXA%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLCUX4AKJ3BV33TV6YGIHTWD2D4ZANCNFSM5DZM52BA&data=05%7C01%7Cdaniel.natt%40liu.se%7C5fa6fe037710496fe4b708dab0fd55c1%7C913f18ec7f264c5fa816784fe9a58edd%7C0%7C0%7C638016899360172777%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7JXPNTp9RwhoeyEtxqzdMvMFsuDwojj3u2GqwA9oU8o%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
You control your ssh key credentials Bioconductor uses through the GitCredentials app. You can upload new keys there at any time
Received a valid push on git.bioconductor.org; starting a build for commit id: 127cf8c60483882fad669b8b3ecdda7f2866e8f8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 7ad5303fd10a03755adab1b925fdae888602e5da
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 87919a6a3b0f4dcd2c1cdf8c3da1cf1bdb18e73c
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/seqpac
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
Submitter: There are very few specific warnings/errors: for example that we don't have enough run-able examples, using too much of \donttest{}. But since our package depend on user provided references for best function, we cannot provide good examples with fully functional code all the time. We have, however, tried to provide as many self-sustained examples as possible. We hope that this is something reviewers may test and comment on during the review process, but we have tried to fix all R CMD checks and BioChecks as far as we can without disturbing package examples and fuctions
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.