Closed stemangiola closed 2 years ago
Hi @stemangiola
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: sccomp
Title: Robust Outlier-aware Estimation of Composition and Heterogeneity for Single-cell Data.
Version: 0.99.1
Authors@R: c(person("Stefano", "Mangiola", email = "mangiolastefano@gmail.com",
role = c("aut", "cre"))
)
Description: A robust and outlier-aware method for testing differential tissue composition from single-cell data. This model can also transfer knowledge from a large set of integrated datasets to increase accuracy further.
License: GPL-3
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
Biarch: true
Depends:
R (>= 4.1.0),
rstan (>= 2.18.1)
Imports:
methods,
Rcpp (>= 0.12.0),
RcppParallel (>= 5.0.1),
rstantools (>= 2.1.1),
SeuratObject,
SingleCellExperiment,
parallel,
dplyr,
tidyr,
purrr,
magrittr,
rlang,
tibble,
boot,
lifecycle,
stats
Suggests:
BiocStyle,
testthat (>= 3.0.0),
markdown,
ggplot2,
knitr,
furrr
LinkingTo:
BH (>= 1.66.0),
Rcpp (>= 0.12.0),
RcppEigen (>= 0.3.3.3.0),
RcppParallel (>= 5.0.1),
rstan (>= 2.18.1),
StanHeaders (>= 2.18.0)
SystemRequirements: GNU make
VignetteBuilder:
knitr
RdMacros:
lifecycle
biocViews:
ImmunoOncology,
Normalization,
Sequencing,
RNASeq,
Software,
GeneExpression,
Transcriptomics,
SingleCell,
Clustering
LazyDataCompression: xz
Config/testthat/edition: 3
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, TIMEOUT, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hello @lshep ,
I have fixed the repo, including rewriting the history to delete the files in the git that produce the failure in the check
This is BiocCheckGitClone version 1.29.14. BiocCheckGitClone is a work
in progress. Output and severity of issues may change.
* Checking valid files...
* ERROR: System Files found that should not be git tracked:
src/RcppExports.o
dev/latex_equations.log
I am trying to push to upstream forcing (because of the history change) however Bioconductor does not let me do
git push upstream master --force
rstudio-1 258 % git push upstream master --force
Counting objects: 820, done.
Delta compression using up to 56 threads.
Compressing objects: 100% (225/225), done.
Writing objects: 100% (785/785), 3.42 MiB | 1.80 MiB/s, done.
Total 785 (delta 574), reused 747 (delta 543)
remote: Resolving deltas: 100% (574/574), completed with 22 local objects.
remote: FATAL: + refs/heads/master packages/sccomp stemangiola DENIED by fallthru
remote: error: hook declined to update refs/heads/master
To git@git.bioconductor.org:packages/sccomp.git
! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'git@git.bioconductor.org:packages/sccomp.git'
Could you please advise? Maybe we can start over?
@nturaga any suggestions on this?
We do not allow users to do a force push. I think I have reset the repository. Please try to do a version bump to kick off a new build.
We do not allow users to do a force push. I think I have reset the repository. Please try to do a version bump to kick off a new build.
Thanks, I will today.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0ba5af7372921fe9c732e1a5a95424642bab0317
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 313b0324ac8c5a8b5874226881dd8174de42e794
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 757560fabbcb2913e8d52df214d8a9456db22d25
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 01182f994f996194f5ea5ad78b7fd7c1e5ea0e6a
Hello @lshep,
for the error
* ERROR: Remove install() calls (found 1 times)
install.packages() in R/functions_dirichlet_multinomial.R (line
285, column 5)
This install.package is inside a function that is mostly for internal benchmarking (and possible extremely rarely used by a user), but integrated into the package, and I don't want to add non-necessary dependencies.
Could we ignore this error for publication? (I'm solving the other errors/warnings)
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 5e637aaeb9420b47a3cbf8acbc9044d38c82dce1
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hello @lshep,
for the error
* ERROR: Remove install() calls (found 1 times) install.packages() in R/functions_dirichlet_multinomial.R (line 285, column 5)
This install.package is inside a function that is mostly for internal benchmarking (and possible extremely rarely used by a user), but integrated into the package, and I don't want to add non-necessary dependencies.
Could we ignore this error for publication? (I'm solving the other errors/warnings)
I solved all other errors ;)
Received a valid push on git.bioconductor.org; starting a build for commit id: b46856f7d8117eca992b4ac8c3e86f59b2d0b62a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi Stefano -- this sounds like a case for "Enhances" for the package in question. I'd propose that you use
if (!requireNamespace("[pkg u don't want to depend on]")) stop("please install [pkg...] to use this function")
and put the pkg... in the Enhances field in DESCRIPTION. Other approaches could be used as well, but we really want to be systematic about removing install
operations from user code.
I agree with the above suggest. Please implement the above suggestion. I will provide a more detailed review shortly.
Received a valid push on git.bioconductor.org; starting a build for commit id: 433be278223edd585822150c6710b79bcc4fc019
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 3069bb4905e3e52a8d778a17dfb0cc30fe2d95f1
Received a valid push on git.bioconductor.org; starting a build for commit id: f271898ef031abdfec1f8a9169126947c7ca69d8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 36fd3b7448eb2d8f42f378607928cbbec901e4a8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hello @Kayla-Morrell ,
for the warning
WARNING: R CMD check exceeded 10 min requirement
my package has to compile C++ code and takes a bit longer. Is this a deal-breaking problem? (I will try to optimise in the future)
@stemangiola - Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.
Also, I would say the WARNING above is fine for now but should be addressed in the future.
[ ] REQUIRED: Malformed Title field, should not end in a period.
[ ] SUGGESTION: The Description field is made up by less than 3 sentences. Please consider expanding this field, and structure it as a full paragraph.
[ ] REQUIRED: 'LazyData' should be set to false or removed.
[ ] SUGGESTION: We strongly encourage the use of the 'BugReports' field which includes a relevant link to GitHub for reporting issues.
[ ] REQUIRED: When I generate the vignette, the logo does not display. This should be resolved. My suggestion would be to move all figures/images needed for the vignette to the vignette directory, then reference from there.
[ ] REQUIRED: There needs to be an Introduction section that serves as an abstract to introduce the objective, models, unique functions, key points, etc that distinguish the package from other packages in the same area.
[ ] REQUIRED: The Installation section should demonstrate to the user how to
install the package from Bioconductor. The code should look like the following
and include eval = FALSE
.
if (!requireNamespace("BiocManager")) {
install.packages("BiocManager")
}
BiocManager::install("sccomp")
[ ] REQUIRED: The table of contents didn't render when I generated the vignette.
[ ] REQUIRED: All code chunks need to be evaluated. There should be some text that accompany the code chunks explaining what is being demonstrated.
[ ] REQUIRED: It should be visable to users what libraries and data are being loaded, lines 26-33 should be shown.
[ ] REQUIRED: There should not be figures in this directory. Depending on where they are used they should either be in the vignettes directory or the inst directory.
[ ] REQUIRED: All exported objects need to be documented, design_matrix_and_coefficients_to_simulation is undocumented and is exported.
[ ] REQUIRED: For examples, the function being documented needs to be shown. For example, in the replicate_data man page the example code is demonstrating sccomp_glm and not replicate_data.
[ ] SUGGESTION: For any unexported object that is documented I would suggest
adding the @keywords internal
tag to remove the function from the
documentation index.
expect_*
statements. If I'm wrong please
justify.[ ] SUGGESTION: Consider clarifying how 152 objects are initialized. Maybe they are part of a data set loaded with data(), or perhaps part of an object referenced in with() or within(). See the BiocCheck result of the build report for the list of objects.
[ ] REQUIRED: We don't like to see seeds being used in code. The user should always have the option for setting the seed and know when it is being invoked.
[ ] REQUIRED: Avoid sapply(); use vapply() instead where possible. Found in files: R/stanmodels.R, line 12 R/validation.R, line 16
[ ] REQUIRED: Use is() instead of class() == and class() !=.
[ ] REQUIRED: Avoid 1:..., use seq_len() or seq_along() instead where possible. Found in files: functions_dirichlet_multinomial.R, lines 53, 177, 178, 333, and 336 functions_multi_beta_binomial.R, lines 52, 281, 288, and 391 function_multi_beta.R, line 36 methods.R, lines 297 and 376 utilities.R, lines 248, 272, 287, 292, 439, 554, 634, 683, 686, 764, 765, 767, 768, and 783
[ ] REQUIRED: Avoid 'suppressWarnings'/'*Messages' if possible. Found in files: R/utilities.R, lines 263, 410, and 422
[ ] SUGGESTION: For formatting reasons, consider shorter lines. There are 250 lines that are > 80 characters long.
[ ] SUGGESTION: For formatting reasons, consider 4 spaces instead of tabs. There are 8 lines that contain tabs.
[ ] SUGGESTION: For formatting reasons, consider multiples of 4 spaces for line indents. There are 1076 lines that are not.
Best, Kayla
Thanks a lot, @Kayla-Morrell for your feedback.
@stemangiola - Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.
Also, I would say the WARNING above is fine for now but should be addressed in the future.
General package development
- [x] REQUIRED: What is the purpose of the 'dev/' directory? This isn't usually something we include in Bioconductor packages.
This directory includes some R scripts for paper publication, that has always been part of our Github repositories. This is in the .Rbuildignore.
DESCRIPTION
- [x] REQUIRED: Malformed Title field, should not end in a period.
Done.
- [x] SUGGESTION: The Description field is made up by less than 3 sentences. Please consider expanding this field, and structure it as a full paragraph.
Done
- [x] REQUIRED: 'LazyData' should be set to false or removed.
When we use Bayesian inference this option needs to be 'true' Bioconductor already accepted this for our package ppcseq
- [x] SUGGESTION: We strongly encourage the use of the 'BugReports' field which includes a relevant link to GitHub for reporting issues.
Thanks done.
NAMESPACE
- [x] SUGGESTION: Consider adding importFrom("graphics", "par") importFrom("utils", "data")
I have added utils data, for par I don't find where I use it.
NEWS
- [x] SUGGESTION: Consider adding a NEWS file, so your package news will be included in Bioconductor release announcements.
Done
Data
- [x] REQUIRED: The documentations for the data could use a bit more information. For almost all of them, the description is just the name of the data file. There should be a bit more information about creation if possible.
Done
Vignettes
- [x] REQUIRED: When I generate the vignette, the logo does not display. This should be resolved. My suggestion would be to move all figures/images needed for the vignette to the vignette directory, then reference from there.
Done
- [x] REQUIRED: There needs to be an Introduction section that serves as an abstract to introduce the objective, models, unique functions, key points, etc that distinguish the package from other packages in the same area.
Done
- [x] REQUIRED: The Installation section should demonstrate to the user how to install the package from Bioconductor. The code should look like the following and include
eval = FALSE
.if (!requireNamespace("BiocManager")) { install.packages("BiocManager") } BiocManager::install("sccomp")
Done
[ ] REQUIRED: The table of contents didn't render when I generated the vignette.
[x] REQUIRED: All code chunks need to be evaluated. There should be some text that accompany the code chunks explaining what is being demonstrated.
Done
- [x] REQUIRED: It should be visable to users what libraries and data are being loaded, lines 26-33 should be shown.
Done
Man pages
- [x] REQUIRED: There should not be figures in this directory. Depending on where they are used they should either be in the vignettes directory or the inst directory.
Done
- [x] REQUIRED: All exported objects need to be documented, design_matrix_and_coefficients_to_simulation is undocumented and is exported.
design_matrix_and_coefficients_to_simulation is not exported anymore
- [x] REQUIRED: For examples, the function being documented needs to be shown. For example, in the replicate_data man page the example code is demonstrating sccomp_glm and not replicate_data.
Done
- [x] SUGGESTION: For any unexported object that is documented I would suggest adding the
@keywords internal
tag to remove the function from the documentation index.
Done
Unit tests
- [x] REQUIRED: It doesn't seem like your tests in test-sccomp.R are actually testing anything. There are no
expect_*
statements. If I'm wrong please justify.
Done
R code
- [ ] SUGGESTION: Consider clarifying how 152 objects are initialized. Maybe they are part of a data set loaded with data(), or perhaps part of an object referenced in with() or within(). See the BiocCheck result of the build report for the list of objects.
- [x] REQUIRED: We don't like to see seeds being used in code. The user should always have the option for setting the seed and know when it is being invoked.
I changed the argument to mcmc_seed and specified that this seed is sampled at random (by default) and needed for Markov Chain Monte Carlo reproducibility if a user chooses so.
- [x] REQUIRED: Avoid sapply(); use vapply() instead where possible. Found in files: R/stanmodels.R, line 12 R/validation.R, line 16
Done for validation. For stanmodel.R this was automatically generated by Stan, and must not be edited by hand.
- [x] REQUIRED: Use is() instead of class() == and class() !=.
Done
- [x] REQUIRED: Avoid 1:..., use seq_len() or seq_along() instead where possible. Found in files: functions_dirichlet_multinomial.R, lines 53, 177, 178, 333, and 336 functions_multi_beta_binomial.R, lines 52, 281, 288, and 391 function_multi_beta.R, line 36 methods.R, lines 297 and 376 utilities.R, lines 248, 272, 287, 292, 439, 554, 634, 683, 686, 764, 765, 767, 768, and 783
Done
- [x] REQUIRED: Avoid 'suppressWarnings'/'*Messages' if possible. Found in files: R/utilities.R, lines 263, 410, and 422
For line 263, pivot_longer generates a benign warning that is not clear how to avoid given their documentation. For separate was extra="drop".
For lines 410 and 422, rstan generated benign warnings about unjustified thresholds of convergence (they are currently addressing those). Those although completely benign, confuse users about the results, that we have extensively benchmarked and soon published.
I will take care of those ASAP, according to the Stan community
- [ ] SUGGESTION: For formatting reasons, consider shorter lines. There are 250 lines that are > 80 characters long.
- [ ] SUGGESTION: For formatting reasons, consider 4 spaces instead of tabs. There are 8 lines that contain tabs.
- [ ] SUGGESTION: For formatting reasons, consider multiples of 4 spaces for line indents. There are 1076 lines that are not.
Best, Kayla
Received a valid push on git.bioconductor.org; starting a build for commit id: 6288cf4fb59c123d51e56a76f670f5777d32e236
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: c45eea51949a460e915987f1dcdd95f6198727e9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 20e35fd8090de35a993f766c448138d3eeba21b4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ebd874b12efb260841c1cefe75c021ab52ba9716
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1976f29c55e85f58a63afe4d84bc7a63d78619f3
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hello @Kayla-Morrell fixed issues, please find my reply to your review above.
Thanks for your time.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to
git@git.bioconductor.org:packages/sccomp
to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.
I am a bit confused as I see WARNINGS in the summary but I don't see any warnings for
WARNING count:
Its coming from the longer check time.
Its coming from the longer check time.
I see. Thanks. We agreed that it is a goal to optimise compilation down the road. Please let me know if anything else is needed.
Thanks a lot for your time.
Hello @lshep and @Kayla-Morrell thanks for your effort in reviewing sccomp.
I see that sccomp has not been added to the 3.14 release. Given our discussion can I please know the reason?
This submission was for me very important in the perspective of imminent article submission.
Is there any chance the package can be admitted, considering that the only warning is the long compilation time, that I have been told to fix in the future?
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[ x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x ] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[ x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[ x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[ x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x ] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x ] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.