Closed mjchen1996 closed 3 years ago
Hi @mjchen1996
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: MicrobiomeProfiler
Title: An shiny package for microbiome functional enrichment analysis
Version: 0.99.0
Authors@R: c(
person(given = "Meijun",family = "Chen",role = c("aut", "cre"),email = "mjchen1996@outlook.com"),
person(given = "Guangchuang", family = "Yu", email = "guangchuangyu@gmail.com", role = c("aut", "ctb"), comment = c(ORCID = "0000-0002-6485-8781"))
)
Description: This is an R/shiny package to perform functional enrichment analysis for microbiome data.
This package was based on clusterProfiler. Moreover, MicrobiomeProfiler support KEGG enrichment analysis,
COG enrichment analysis, Microbe-Disease association enrichment analysis, Metabo-Pathway analysis.
License: GPL-2
URL: https://github.com/YuLab-SMU/MicrobiomeProfiler/
BugReports: https://github.com/YuLab-SMU/MicrobiomeProfiler/issues
Imports:
clusterProfiler (>= 4.0.2),
config,
DT,
enrichplot,
golem,
magrittr,
shiny (>= 1.6.0),
shinyWidgets,
shinycustomloader,
htmltools,
ggplot2,
graphics,
utils
Encoding: UTF-8
biocViews: Microbiome, Software, Visualization,KEGG
RoxygenNote: 7.1.2
Depends:
R (>= 4.1.0)
Suggests:
rmarkdown,
knitr,
testthat (>= 3.0.0)
Config/testthat/edition: 3
VignetteBuilder: knitr
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: dc36a8435e468528df03ed3454823c41da812e7b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 81caf8dce5bb129681d7e15c6528ee64f13cc5c8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 39c6c9e5c59c230f39b710ab4b47ebc5904e0a74
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 08e41f14534a4ed03907d3d5a37c17978f082a13
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi, @lazappi , thank you for your assistance. I was just wondering if my package had under review queue?
Hi @mjchen1996. As I'm sure you know it's super busy at the moment with everyone trying to get packages accepted for the upcoming release. I think yours is at the top of my list so hopefully not too long.
Thank you for your reply.
Hi @mjchen1996
Thanks for submitting MicrobiomeProfiler :tada:! Below is my review of your package. Please reply here if anything is unclear or needs any further explanation.
What next?
Please address the comments as best as you can. When you are ready for me to check the package again please reply to let me know with a summary of changes you have made or any other responses.
Luke
Key: :rotating_light: Required :warning: Recommended :green_circle: Optional
BiocCheck::BiocCheck()
. Please check these and address as many as you can.Authors@R
field%>%
, %<>%
)? As far as I can see they are only used externally and don't need to be available to the user.R/sysdata.rda
data file. This should either be removed or moved to the data/
or inst/data
directories.README.Rmd
file does not include any executed code. If you do not plan to add any you can just have the simpler README.md
file.README
BiocStyle
package vignette template for formattingsessionInfo()
chunk at section to the end of the vignette.enrichX()
functions slots are accessed directly using @
. Please use a getter/setter function if possible.message()
, warning()
and stop()
join input so there is no need to use paste0
inside them (see bitr_smpdb()
)enrichX()
functions are very similar. It might make sense to put them in one file or even combine them into fewer functions.run_app()
is a fairly generic function name that could be used by many packages. It might make sense to rename it to something more specific like run_MicrobiomeProfiler()
to avoid conflicts.myapp/
and dev/
directories. These should be removed unless they are necessary for the package.Received a valid push on git.bioconductor.org; starting a build for commit id: 8ab6cddf9d429644c7ff09b38fd9b8a58dfc9ab4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @lazappi
Thank you for your assistance. Here is a summary of the changes.
[x] π¨ There are some notes in the build report from BiocCheck::BiocCheck()
. Please check these and address as many as you can.
I have tried to remove some notes. Unfortunately, there are still 4 notes.
[x] π’ It is recommended to add ORCiDs to the Authors@R
field
Thank you. I have added my ORCiDs to the Authors@R
field.
[x] β οΈ Is it necessary to re-export the pipe operators (%>%
, %<>%
)? As far as I can see they are only used externally and don't need to be available to the user.
I have check it and remove the exported operators (%>%
, %<>%
).
[x] π¨ The documentation for data included in the package is very minimal. Please expand this so it is clear what the data is, where it can from and what structure it has.
Thank you. I have expanded the description of data and added reference url.
[x] π¨ There is an additional R/sysdata.rda
data file. This should either be removed or moved to the data/
or inst/data
directories.
Sorry. The sydata.rda
is required for the shiny app and enrichX()
functions. I think it can not be removed or moved to the data/
directory.
[x] β οΈ The README.Rmd
file does not include any executed code. If you do not plan to add any you can just have the simpler README.md
file.
I have removed the README.Rmd
.
[x] π¨ Please add Bioconductor installation instructions to the README
I have added the instructions.
[x] π¨ Please use the BiocStyle
package vignette template for formatting
[x] π¨ Please add a table of contents
[x] π¨ Please add a more detailed Introduction section
[x] π¨ Please add an Installation section with Bioconductor installation instructions. This code chunk should NOT be evaluated.
[x] π¨ The vignette is very minimal, please add more detail. It is harder to document a shiny app but you can still explain the functionality and demonstrate any other functions. Screenshots would be very helpful. Please have a look at other the vignettes for other Bioconductor packages with shiny apps.
[x] π¨ Please add a sessionInfo()
chunk at section to the end of the vignette.
I have tried my best to check and fix these issues. I have added Introduction and Installation sections in the vignette. Also, I added an example of KEGG enrichment analysis demo in the vignette.
[x] β οΈ It is recommended to add a package man page
Yes, I have added it in my package.
enrichX()
functions slots are accessed directly using @
. Please use a getter/setter function if possible.I used slot()
instead of @
.
message()
, warning()
and stop()
join input so there is no need to use paste0
inside them (see bitr_smpdb()
)OK, I removed the paste0()
from bitr_smpdb()
.
Thank you. I have check the para list and try to make them matched.
[x] β οΈ It is recommended to add validity checks to arguments for exported functions. These can reduce a lot of errors for users.
Most exported functions like enrichKO()
were implemented from clusterProfiler
which already included validity checks. Others like bitr_smpdb()
also has validity check for arguments.
enrichX()
functions are very similar. It might make sense to put them in one file or even combine them into fewer functions.Thank you for your advice. Currently, I haven't found a better way to make all the enrichX()
much more concise.
run_app()
is a fairly generic function name that could be used by many packages. It might make sense to rename it to something more specific like run_MicrobiomeProfiler()
to avoid conflicts.Thank you for this tip. I have use run_MicrobiomeProfiler()
instead of run_app()
.
myapp/
and dev/
directories. These should be removed unless they are necessary for the package.Thank you. I have removed these directories.
Thanks again for your support. Please let me know if there is anything necessary to be modified.
Meijun
Package data
- [x] π¨ The documentation for data included in the package is very minimal. Please expand this so it is clear what the data is, where it can from and what structure it has. Thank you. I have expanded the description of data and added reference URL.
I think you can probably still had some detail to this. The main thing is to add something about the data structure (is is a data.frame
, a matrix
, something else?).
- [x] π¨ There is an additional
R/sysdata.rda
data file. This should either be removed or moved to thedata/
orinst/data
directories. Sorry. Thesydata.rda
is required for the shiny app andenrichX()
functions. I think it can not be removed or moved to thedata/
directory.
I think it might be possible to do this another way but it seems like R/sysdata.rda
is a standard file I wasn't aware of so it should be fine.
I have tried my best to check and fix these issues. I have added Introduction and Installation sections in the vignette. Also, I added an example of KEGG enrichment analysis demo in the vignette.
This looks much better. There are a few typos and some formatting things you might want to look at but I'm happy with this.
Unit tests
- [x] β οΈ The unit tests are quite minimal. It is hard to test the shiny app but you could write more tests for the exported functions.
Did you have a look at adding some more tests?
Code
R
- [x] π¨ In the
enrichX()
functions slots are accessed directly using@
. Please use a getter/setter function if possible. I usedslot()
instead of@
.
I had a bit of a look at it seems like there aren't proper getters for this class so slot()
should be ok.
Thanks for your responses. I'm happy with most things now, they only things I think are left is whether you can add a few more tests and adding some information about the data structures for the included data.
Received a valid push on git.bioconductor.org; starting a build for commit id: 3cd387c4e291e195851dd10824cdd2f57ac09b16
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: abde2b59b36d1d3d98bb7f2ec9a9824323cb5056
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi, @lazappi
Thank you for your reply.
I have added some new tests in my package. I think it is enough for exported functions since I have checked the S4 class results. As your known, it is hard to test the shiny app. Also, I have added data structure description as all example data are vectors.
For R/sysdata.rda
, this file included several data frame of annotation data collected from public databases like KEGG. Moreover. I had a bit of a look at vignette file and made some changes.
Meijun
Hi @mjchen1996.
Thank you for adding information about the data structure but I think it would be clear to use the @format
tag, please see the examples in this guide https://r-pkgs.org/data.html. Sorry, I should have been more specific about this earlier. The testing is ok now but I think you could continue to expand it, particularly for things like incorrect inputs.
I will approve this once you have adjusted the data documentation.
Received a valid push on git.bioconductor.org; starting a build for commit id: f7c029e9a41005eaeefd2a71581ef3e573d38a13
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: f88cd81d7dfc9d0a5ca98b96e2798e139b8958a5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MicrobiomeProfiler
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi, @lazappi
Thank you again. I have adjusted the data documentation and added more test for incorrect inputs.
Meijun
Thanks! I will approve this now π. It can take a few days for the package to be picked up by the build system but it should be on Bioconductor soon.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/mjchen1996.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("MicrobiomeProfiler")
. The package 'landing page' will be created at
https://bioconductor.org/packages/MicrobiomeProfiler
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.