Closed sbhattacharya3 closed 7 years ago
Hi @sbhattacharya3
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: IntramiRExploreR
Title: Predicting Targets for Drosophila Intragenic miRNAs
Version: 0.99.0
Authors@R: c(
person("Surajit", "Bhattacharya", email="sbhattacharaya3@student.gsu.edu", role = c("aut", "cre")),
person("Daniel", "Cox", role = "ths"))
Description: Intra-miR-ExploreR, an integrative miRNA target prediction
bioinformatics tool, identifies targets combining expression and biophysical
interactions of a given microRNA (miR). Using the tool, we have identified
targets for 92 intragenic miRs in D. melanogaster, using available microarray
expression data, from Affymetrix 1 and Affymetrix2 microarray array platforms,
providing a global perspective of intragenic miR targets in Drosophila.
Predicted targets are grouped according to biological functions using the DAVID
Gene Ontology tool and are ranked based on a biologically relevant scoring
system, enabling the user to identify functionally relevant targets for a given
miR.
Depends:
R (>= 3.1.2)
Imports:
igraph (>= 1.0.1),
VennDiagram (>= 1.6.17),
FGNet (>= 3.0.7),
knitr (>= 1.12.3)
Suggests:
RDAVIDWebService,
gProfileR,
topGO,
KEGGprofile,
org.Dm.eg.db,
testthat
VignetteBuilder:
knitr
License: GPL-2
biocViews: Software
Encoding: UTF-8
LazyData: true
RoxygenNote: 5.0.1
URL: https://github.com/sbhattacharya3/IntramiRExploreR/
BugReports: https://github.com/sbhattacharya3/IntramiRExploreR/issues
Your package has been approved for building. Your package is now submitted to our queue.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/IntramiRExploreR_buildreport_20170110110233.html
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Received a valid push; starting a build. Commits are:
50629ee Updated description to push to bioconductor.
Received a valid push; starting a build. Commits are:
9beb76f Updated the Vignettes.
Hello,
I just saw that have 2 errors on my latest run. Those are "Maintainer must subscribe to the bioc-devel mailing list." and "Maintainer must register at the support site." I have already registered to both the sites last week.
Please let me know what is the procedure to get rid of those 2 errors.
Thanks, Surajit
Received a valid push; starting a build. Commits are:
be3178d Updated the maintainer, and version.
DESCRIPTION, NAMESPACE
R
MiR_ChipBase()
but throughout -- follow the guidelines for
avoiding iteration, using pre-allocate and fill, and vectorization;
your current code is unacceptably
inefficient. http://bioconductor.org/developers/how-to/efficient-code/tempdir()
or tempfile()
.file.path()
rather than paste()
.stopifnot(file.exists(...))
) or require that the
user explicitly allows the file to be over-written (e.g., with an
argument overwrite=FALSE
).MiR_ChipBase()
should start
with stopifnot(is.character(m), length(m) == 1L, !is.na(m))
or
similar.vignettes
Please update the installation instructions to match those after Bioconductor acceptance, i.e.
source("https://bioconductor.org/biocLite.R")
biocLite("IntramiRExploreR")
miRtargets()
line 44 has argument outpath
, but this is (a)
undefined and (b) unused in the function. Remove it, and review
arguments in this and all function calls to ensure that they are (a)
defined and (b) used).
GetGOS_ALL()
line 107 has argument path="C://"
, apparently
writing to the root directory. Do not do this, but instead use a
temporary location, for a directory use tempdir()
or for a
temporary file tempfile()
. Review all vignette and example code to
ensure that ALL file arguments or outputs are located in temporary
locations.
review the output of all vignette code, making sure that it is visually meaningful; for instance the output of a[1:4,] is too wide for the output medium.
man
character(1)
, data.frame
) rather than
ad-hoc descriptions for parameter and return values (e.g., "String",
"Dataframe").Other
License:
field of the
DESCRIPTION file.Thanks a lot for the review comments. I am presently working on the same, and would update the tool as soon as possible.
Your package requires a version bump to trigger a build; did you intend to do that?
Hello Martin,
I am working on some of the reviews suggested by you. I would be updating the package and doing a version bump this week.
Thanks, Surajit
On Fri, Mar 10, 2017 at 5:00 PM, Martin Morgan notifications@github.com wrote:
Your package requires a version bump to trigger a build; did you intend to do that?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioconductor%2FContributions%2Fissues%2F233%23issuecomment-285796556&data=02%7C01%7Csbhattacharya3%40student.gsu.edu%7Ca07aa2674d4649037e0a08d46800e9d2%7C704d822c358a47849a1649e20b75f941%7C0%7C0%7C636247800505517646&sdata=2Uxlxek3UjI%2B4iQe6reNCa5GqCGlSIAHzDeCh%2FL9bHA%3D&reserved=0, or mute the thread https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASww4IXb-rAJNhWJ6GGN37oSkdOdpwx5ks5rkcgPgaJpZM4La4vh&data=02%7C01%7Csbhattacharya3%40student.gsu.edu%7Ca07aa2674d4649037e0a08d46800e9d2%7C704d822c358a47849a1649e20b75f941%7C0%7C0%7C636247800505517646&sdata=povTvqPHfeBfuYwV3A0WMpxPa%2Fm2pAvHw0XvlJ2IEPc%3D&reserved=0 .
Received a valid push; starting a build. Commits are:
987d786 Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/IntramiRExploreR_buildreport_20170331003249.html
Received a valid push; starting a build. Commits are:
64e0e5e Edited the version R.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/IntramiRExploreR_buildreport_20170331190140.html
Received a valid push; starting a build. Commits are:
afc56bb Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/IntramiRExploreR_buildreport_20170331201447.html
Received a valid push; starting a build. Commits are:
ba4744f Update DESCRIPTION
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/IntramiRExploreR_buildreport_20170331222633.html
If your package is ready for final review please provide a brief summary of how each issue has been addressed. The deadline for adding new packages in time for the next release is Friday.
Hello Morgan,
Please find my comments inline in bold.
DESCRIPTION, NAMESPACE
OK R
It is not appropriate for software packages to contain large data objects. These could be isolated as a separate 'experiment data' package http://bioconductor.org/developers/package-guidelines/#package-types However, the data seems to be an ad-hoc summary of Target-scan and other data. These data objects are not sufficiently documented or processed in a reproducible way to be included in Bioconductor. I'm also concerned about re-distribution of data without appropriate licensing and permissions. For these reasons the data objects should be removed. They should be replaced by instructions for the user to download the data from their original source, and functions that take the downloaded data and transform it to a format useful to this package.: We have deleted all the .RData files related to the public databases like TargetScan, Pita, miRanda and ChipBase. The file size , although remains an issue. The purpose of the package is to identify targets for intragenic miRNAs in fruit flies by statistical analysis of approximately 350 microarray experiments from Gene Expression Omnibus. The package right now can be used to not only query the targets but also visualize the results using network visualisation methods and geneontology using available R and Bioconductor packages. We can also submit it as a experiment package, if you think that would be the correct classification of these type of packages. e.g., MiR_ChipBase() but throughout -- follow the guidelines for avoiding iteration, using pre-allocate and fill, and vectorization; your current code is unacceptably inefficient. http://bioconductor.org/developers/how-to/efficient-code/: Updated and removed iteration where ever needed. Whenever providing a default file path, provide it in a temporary location, e.g., tempdir() or tempfile().: checked and updated where needed. Create file paths using file.path() rather than paste().: Checked and changes made. If a user provides a file path your code should fail if the path already exists (stopifnot(file.exists(...))) or require that the user explicitly allows the file to be over-written (e.g., with an argument overwrite=FALSE).: Did the appropriate checks. Validate all input parameters, e.g., MiR_ChipBase() should start with stopifnot(is.character(m), length(m) == 1L, !is.na(m)) or similar.Did the appropriate checks. please adopt standard and consistent approaches to indentation, e.g., format the code at Chipbase_database.r:80 in the same was as at line 69. Consider using tools such as formatR to arrive at consistent formatting.: used formatR to format. Ensure that your package conforms to overall Bioconductor size (and check time) constraints. http://bioconductor.org/developers/package-guidelines/#correctness vignettes
Please update the installation instructions to match those after Bioconductor acceptance, i.e.
source("https://bioconductor.org/biocLite.R") biocLite("IntramiRExploreR"): Will do that once it gets accepted miRtargets() line 44 has argument outpath, but this is (a) undefined and (b) unused in the function. Remove it, and review arguments in this and all function calls to ensure that they are (a) defined and (b) used).: Updated
GetGOS_ALL() line 107 has argument path="C://", apparently writing to the root directory. Do not do this, but instead use a temporary location, for a directory use tempdir() or for a temporary file tempfile(). Review all vignette and example code to ensure that ALL file arguments or outputs are located in temporary locations.: Updated
review the output of all vignette code, making sure that it is visually meaningful; for instance the output of a[1:4,] is too wide for the output medium.: Updated and checked
man
Use R conventions (e.g., character(1), data.frame) rather than ad-hoc descriptions for parameter and return values (e.g., "String", "Dataframe").: updated the man folder with the changes. Other
It is not appropriate to include the GPL LICENCES file; this is distributed with base R and implied by the License: field of the DESCRIPTION file.: Removed the license file. It was erroneously put there. The NEWS file is not in a format that can be parsed by base R.: News file has been added The tests directory and testthat.R file imply testthat-style unit tests, but the actually tests imply RUnit. The net effect is that no tests are evaluated. The tests as written cover an inadequate amount of the code. Adopt a consistent testing framework (testthat is appropriate) and write sufficiently comprehensive tests (see, e.g., the ).: test directory was updated, and comprehensive tests were added.
Thanks, Surajit —
It looks like your package has been revised but without a version bump. If you bump the version I will complete the review process promptly.
Received a valid push; starting a build. Commits are:
70f8844 Updated the version.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/IntramiRExploreR_buildreport_20170514192622.html
Hi Martin,
I have done a version bump on the package. I have also answered all the questions and comments you had regarding the package inline.
Please let me know if you have any further questions and the package is now ready for your kind perusal.
Thanks again.
Surajit
Your package has been accepted. It will be added to the Bioconductor svn repository and nightly builds. Additional information will be sent to the maintainer email address in the next several days.
Thank you for contributing to Bioconductor!
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.