Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

comapr #2335

Closed ruqianl closed 2 years ago

ruqianl commented 2 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 years ago

Hi @ruqianl

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: comapr
Title: Crossover analysis for genetic map construction 
Version: 0.99.25
Authors@R: 
    person(given = "Lyu",
 family = "Ruqian",
 role = c("aut", "cre"),
 email = "ruqianl@student.unimelb.edu.au",
 comment = c(ORCID = "0000-0002-7736-6612"))
Description: comapr detects crossover intervals for single cells from their 
    haplotype states matrices. The genetic distances can then be calculated via 
    the mapping functions for the list of SNP intervals. Visualisation functions 
    for plotting interval-based genetic map or cumulative genetic distances are 
    implemented, which help reveal the variation of crossovers landscape across 
    the genome and across individuals. 
biocViews: Software, SingleCell, Visualization, Genetics
Depends: 
    R (>= 4.0)
Imports:
 methods,
 ggplot2,
 reshape2,
 dplyr,
 gridExtra,
 plotly,
 circlize,
 rlang,
 GenomicRanges,
 IRanges,
 foreach,
 BiocParallel,
 GenomeInfoDb,
 scales,
 RColorBrewer,
 tidyr,
 S4Vectors,
 utils,
 Matrix,
 grid,
 stats,
 SummarizedExperiment,
 plyr,
 Gviz
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.1.2
VignetteBuilder: knitr
Suggests: 
    BiocStyle,
    knitr,
    rmarkdown,
    testthat (>= 2.1.0),
    statmod
bioc-issue-bot commented 2 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

jianhong commented 2 years ago

Please fix the errors and warnings to meet the requirement of review process. If you need any help, please let me known or ask help in develop mailing list.

ruqianl commented 2 years ago

Hi @jianhong ,

Thanks, I have fixed the warnings, but having some issues pushing to the bioc.git repo. I'm having the errors:

Enter passphrase for key '/home/ubuntu/.ssh/id_ed25519':
FATAL: W any packages/comapr Rachael-rq DENIED by fallthru
(or you mis-spelled the reponame)
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I could pull/fetch from git@git.bioconductor.org:packages/comapr but not able to push. I notice that it is printing my previous github username Rachael-rq which was changed to ruqianl, not sure if that has something to do with it.

I logged into the BiocCredentials and uploaded new SSH key there and also to my GitHub account, but I still do not have access to my package "comapr".

jianhong commented 2 years ago

Please ask help from Nitesh Turaga ( @nturaga ) at Bioc-devel mailing list.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9357cb73d4890d44c94236014d6d6a0b2844ffad

ruqianl commented 2 years ago

Please ask help from Nitesh Turaga ( @nturaga ) at Bioc-devel mailing list.

Thanks @jianhong and @nturaga . The access issue had been resolved.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 568fe77b7e2800c57a7e2cdc93c89e8eb171e65b

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9c123b319232af56a2842a1c091006815b6b7a1c

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9a157235209fbcc568ed190b5666bae5aed92240

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0945d284378c5457fbf6e844e731f538459ed13c

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 1d6b4eb19e7e5d9c7337027851461c7b963b8a63

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

ruqianl commented 2 years ago

Hi @jianhong,

Do you mind having a look at the error reported on x64 build? I couldn't reproduce the error. The error was triggered on x64 when running the examples for the combineHapState function. When I set dontrun{} for this example, the error would be gone.

I'm pretty sure that's related to the BiocParallele::bpapply function, but I tested using SnowParam on Linux and on my local windows laptop, the examples run without any issue.

Thanks, Ruqian

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 3856ccfaf0c89eaa88c6e1a27c6be92452e62d35

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

jianhong commented 2 years ago

Package comapr Review

The package is in good shape but there are some issues need to be fixed.

General package development

The DESCRIPTION file

The NEWS file

Documentation

R code

Unacceptable files

lshep commented 2 years ago

@ruqianl may we expect updates soon? We normally like to see progress and responses to reviews within a 3-4 week time frame.

ruqianl commented 2 years ago

Yes, sorry about the delay. This package is designed to take care of the downstream analysis from an upstream tool which is being updated at the same time, so it's been taking a bit time to integrate them. Will push changes soon. Thanks for the reminder.Best,Ruqian-------- Original message --------From: lshep @.>Date: Wed, Nov 24, 2021, 22:54To: Bioconductor/Contributions @.>Cc: ruqianl @.>, Mention @.>Subject: Re: [Bioconductor/Contributions] comapr (#2335) @ruqianl may we expect updates soon? We normally like to see progress and responses to reviews within a 3-4 week time frame.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 6722cbd7c95508b60b440328c7d2f590c0e7bab3

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 732a1a8f7e3bf3c64ea534b42f49a2ccd86c47fd

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

jianhong commented 2 years ago

@ruqianl Let me know if you are ready for review. And also please describe your modification line by line if you have time.

ruqianl commented 2 years ago

Hi Jianhong,

Thanks a lot. Yep, I will include the list of modifications addressing your comments later when I finish updating.

Best, Ruqian

On Tue, 30 Nov 2021 at 07:51, JIANHONG OU @.***> wrote:

@ruqianl https://github.com/ruqianl Let me know if you are ready for review. And also please describe your modification line by line if you have time.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/2335#issuecomment-982011020, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCKKDHZMK2FMXLXPX7URA3UOPRTXANCNFSM5EYWKBJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9168918efc5f2482e52604d2c099f202ae6834eb

ruqianl commented 2 years ago

Hi @jianhong ,

I'm ready for another review but I'm not sure why has been a report from this commit

Received a valid push on git.bioconductor.org; starting a build for commit id: 9168918efc5f2482e52604d2c099f202ae6834eb

Package comapr Review

The package is in good shape but there are some issues need to be fixed.

General package development

The DESCRIPTION file

The NEWS file

Documentation

R code

Unacceptable files

These files are not intended to be packaged into the package, for example, the .png file of the sticker logo. I have included them to be ignored in the .Rbuildignore file. Is that okay?

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: d216c18c604f3cd1b2fd27e128696eaf92a86a0e

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: e3f0650fda18f9676f05c1c457026f90efff9825

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

jianhong commented 2 years ago

Almost there.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: c35dcf32f85f539e4d5059a66b294f781afe7b86

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: c7e013b2652442d2d51f5721a1e4015c0698325c

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

ruqianl commented 2 years ago

Hi Jianhong,

Thanks for that. I have addressed the following comments

  • [X] remove unused code
  • [X] incomplete final line found on 'R/comapr.R'
  • [X] Parameter not passed. cal-genetic-dist.R line 129, change ref_genome="mm10" to ref_genome=ref_genome
  • [X] is() or inherits() instead of class().

    • Replace getCellCORange.R line 26 stopifnot(class(co_count) %in% c("GRanges","RangedSummarizedExperiment")) to stopifnot(inherits(co_count, c("GRanges","RangedSummarizedExperiment")))
  • [X] no direct slot access with @ or slot() - accessors implemented and used. eg:

    • combineHapState.R line 53, 56
    • count-co.R line 101, 102, 105
    • diagnostic-qc-checks.R line 142
    • get-af-tracks.R line 65
    • get-mean-dp-track.R line 156
    • read-hap-state.R line 206, 218 changed to use accessors instead of @

Ruqian

jianhong commented 2 years ago

Sorry for the multiple review comments.

R code

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 413267315d62fe5b669fbe25128c8f3efa41d844

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/comapr to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

ruqianl commented 2 years ago

Hi @jianhong, No worries at all. Thanks for all the inputs for getting the package more mature.

Sorry for the multiple review comments.

R code

  • [X] Remove unused code.

    • In file R/bootstrap.R:

    • at line 36 found ' #group_size <- sapply(group_idx, length)'

    • at line 158 found ' #stopifnot(length(group_by)==2)'

    • In file R/count-co.R:

    • at line 108 found ' # colnames(mcols(gps_snp_gr)) <- names(sid_geno)'

    • In file R/count-gt.R:

    • at line 35 found ' # name = c(names(n_samples),'

    • at line 36 found ' # names(n_markers)))'

    • at line 48 found ' # name = c("by_sample"="No. samples by marker",'

    • at line 49 found ' # "by_marker"="No. markers by sample")'

    • In file R/diagnostic-qc-checks.R:

    • at line 203 found ' # snpAnno <- read.table(file = paste0(path, sampleName,'

    • at line 204 found ' # "_", chr, "_snpAnnot.txt"), stringsAsFactors = F,'

    • at line 205 found ' # header = T)'

    • In file R/plot-genetic-dist.R:

    • at line 135 found ' # arrange(CHR, BP) %>%'

    • In file R/reformat-geno-mt.R:

    • at line 132 found ' # s_gt[lo_i] <- "missing"'

    • at line 139 found ' # s_gt[lo_i] <- "missing"'

    • at line 215 found ' # stopifnot(ref_change_to %in% c('Het','Fail'))'

  • [X] Functional programming: code repetition.

    • repetition in .get_snp_pos and getAFTracks replaced line 2-12 in getAFTracks with function call .get_snp_pos

    • in .get_snp_pos

      • line 2:{
      • line 3: if (is.null(snp_track)) {
      • line 4: snp_anno <- read.table(file = file.path(path_loc, paste0(sampleName,
      • line 5: "_", chrom, "_snpAnnot.txt")), header = TRUE)
      • line 6: snp_pos <- snp_anno$POS
      • line 7: }
      • line 8: else {
      • line 9: stopifnot(unlist(dimnames(seqinfo(snp_track))) == chrom)
      • line 10: snp_pos <- start(snp_track)
      • line 11: }
      • line 12: snp_pos
    • in getAFTracks

      • line 18: if (is.null(snp_track)) {
      • line 19: snp_anno <- read.table(file = file.path(path_loc,
      • line 20: paste0(sampleName, "_", chrom, "_snpAnnot.txt")),
      • line 21: header = TRUE)
      • line 22: snp_pos <- snp_anno$POS
      • line 23: }
      • line 24: else {
      • line 25: stopifnot(unlist(dimnames(seqinfo(snp_track))) ==
      • line 26: chrom)
      • line 27: snp_pos <- start(snp_track)
      • line 28: }
    • repetition in bootstrapDist and permuteDist

    • in bootstrapDist created a function to calculate distances in two groups after sample ids being shuffled. These two functions differ by sampling method

      • line 1: B = 1000, mapping_fun = "k", group_by)
      • line 2:{
      • line 3: .check_mapping_fun(mapping_fun)
      • line 4: count_m_idex <- .get_count_matrix(co_gr_rse = co_gr, group_by = group_by)
      • line 5: group_idx <- count_m_idex$gi
      • line 6: count_matrix <- count_m_idex$c
      • line 7: result_fun <- function() {
      • line 14: dist_2 <- .rb_to_dist(rb_rate2, mapping_fun = mapping_fun)
      • line 15: sum(dist_1) - sum(dist_2)
      • line 16: }
      • line 17: bplapply(seq_len(B), function(b) bpl_fun(b))
      • line 18: }
      • line 19: boots_result <- result_fun()
    • in permuteDist

      • line 1: B = 100, mapping_fun = "k", group_by)
      • line 2:{
      • line 3: .check_mapping_fun(mapping_fun)
      • line 4: count_m_idex <- .get_count_matrix(co_gr_rse = co_gr, group_by = group_by)
      • line 5: group_idx <- count_m_idex$gi
      • line 6: count_matrix <- count_m_idex$c
      • line 7: stopifnot(length(group_idx) == 2)
      • line 17: dist_2 <- .rb_to_dist(rb_rate_2, mapping_fun = mapping_fun)
      • line 18: sum(dist_1) - sum(dist_2)
      • line 19: }
      • line 20: bplapply(seq_len(B), function(b) bpl_fun(b))
      • line 21: }
      • line 22: perm_result <- result_fun()
    • repetition in getAFTracks and getCellAFTrack create .get_af_track_and_co to return the list with objects of DataTrack and crossover ranges

    • in getAFTracks

      • line 29: af_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_pos[keep_snp],
      • line 30: width = 1, genome = "mm10")), name = paste0(cell,
      • line 31: " AF"), data = cell_af[keep_snp], window = nwindow,
      • line 32: na.rm = TRUE, aggregation = "mean", type = "p")
      • line 33: co_range_cell1 <- getCellCORange(co_count, cellBarcode = cell)
      • line 34: co_range_cell1[seqnames(co_range_cell1) == chrom, ]
      • line 35: list(af_track = af_track, co_range = co_range_cell1)
    • in getCellAFTrack

      • line 18: af_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_pos[keep_snp],
      • line 19: width = 1, genome = "mm10")), name = paste0(cellBarcode,
      • line 20: " AF"), data = af_data[keep_snp], window = nwindow, na.rm = TRUE,
      • line 21: aggregation = "mean", type = "p", ylim = 0:1)
      • line 22: co_range_cell1 <- getCellCORange(co_count, cellBarcode = cellBarcode)
      • line 23: co_range_cell1[seqnames(co_range_cell1) == chrom, ]
      • line 24: list(af_track = af_track, co_range = co_range_cell1)
    • repetition in getAFTracks and getCellDPTrack created .get_cells_mm and .get_cell_idx to reduce repetitions

    • in getAFTracks

      • line 4: stopifnot(file.exists(barcodeFile))
      • line 5: initial_barcodes <- read.table(file = barcodeFile)
      • line 6: whichCells <- match(colnames(co_count), initial_barcodes$V1)
      • line 7: dpMM <- readMM(file = file.path(path_loc, paste0(sampleName,
    • in getCellDPTrack

      • line 6: stopifnot(file.exists(barcodeFile))
      • line 7: initial_barcodes <- read.table(file = barcodeFile)
      • line 8: whichCell <- match(cellBarcode, initial_barcodes$V1)
      • line 9: dpMM <- readColMM(file = file.path(path_loc, paste0(sampleName,
    • repetition in getCellAFTrack and getCellDPTrack created .get_cells_mm and .get_cell_idx to reduce repetitions

    • in getCellAFTrack

      • line 6: initial_barcodes <- read.table(file = barcodeFile)
      • line 7: whichCell <- match(cellBarcode, initial_barcodes$V1)
      • line 8: dpMM <- readColMM(file = paste0(pathloc, sampleName, "",
      • line 9: chrom, "_totalCount.mtx"), which.col = whichCell, chunk = chunk)
    • in getCellDPTrack

      • line 7: initial_barcodes <- read.table(file = barcodeFile)
      • line 8: whichCell <- match(cellBarcode, initial_barcodes$V1)
      • line 9: dpMM <- readColMM(file = file.path(path_loc, paste0(sampleName,
      • line 10: "_", chrom, "_totalCount.mtx")), which.col = whichCell,
    • repetition in getCellDPTrack and getMeanDPTrack created .get_cells_mm and .get_cell_idx to reduce repetitions created .aggregaton_fun_log to reduce repetitions getMeanDPTrack and getCellDPTrack return DataTrack with different track names, thus unchanged currently

    • in getCellDPTrack

      • line 12: dpMM <- dpMM[, whichCell]
      • line 13: snp_pos <- .get_snp_pos(snp_track = snp_track, path_loc = path_loc,
      • line 14: sampleName = sampleName, chrom = chrom)
      • line 15: aggregation_fun <- ifelse(log, function(x) {
      • line 16: log10(mean(x) + 1)
      • line 17: }, "mean")
      • line 18: dp_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_pos,
    • in getMeanDPTrack

      • line 9: meanDP <- rowMeans(dpMM)
      • line 10: snp_pos <- .get_snp_pos(snp_track = snp_track, path_loc = path_loc,
      • line 11: sampleName = sampleName, chrom = chrom)
      • line 12: aggregation_fun <- ifelse(log, function(x) {
      • line 13: log10(sum(x) + 1)
      • line 14: }, sum)
      • line 15: meanDP_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_pos,
    • repetition in getCellDPTrack and getSNPDensityTrack created .aggregaton_fun_log to reduce repetitions

    • in getCellDPTrack

      • line 15: aggregation_fun <- ifelse(log, function(x) {
      • line 16: log10(mean(x) + 1)
      • line 17: }, "mean")
      • line 18: dp_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_pos,
    • in getSNPDensityTrack

      • line 6: aggregation_fun <- ifelse(log, function(x) {
      • line 7: log10(sum(x) + 1)
      • line 8: }, sum)
      • line 9: snp_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_anno$POS,
    • repetition in getMeanDPTrack and getSNPDensityTrack created .aggregaton_fun_log to reduce repetitions

    • in getMeanDPTrack

      • line 12: aggregation_fun <- ifelse(log, function(x) {
      • line 13: log10(sum(x) + 1)
      • line 14: }, sum)
      • line 15: meanDP_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_pos,
    • in getSNPDensityTrack

      • line 6: aggregation_fun <- ifelse(log, function(x) {
      • line 7: log10(sum(x) + 1)
      • line 8: }, sum)
      • line 9: snp_track <- DataTrack(GRanges(seqnames = chrom, IRanges(start = snp_anno$POS,
    • repetition in perCellChrQC and perSegChrQC created .get_barcodes and .get_segInfo_chrs

    • in perCellChrQC

      • line 4: if (is.null(barcodeFile)) {
      • line 5: barcodeFile <- file.path(path, paste0(sampleName, "_barcodes.txt"))
      • line 6: }
      • line 7: stopifnot(file.exists(barcodeFile))
      • line 8: barcodes <- read.table(file = barcodeFile, stringsAsFactors = FALSE,
      • line 9: col.names = "barcodes")
      • line 10: segInfo_list <- bplapply(chroms, function(chr) {
      • line 11: segInfo <- read.table(file = file.path(path, paste0(sampleName,
      • line 12: "_", chr, "_viSegInfo.txt")), stringsAsFactors = FALSE,
      • line 13: col.names = c("ithSperm", "Seg_start", "Seg_end",
      • line 14: "logllRatio", "nSNP", "State"))
      • line 15: segInfo$Chrom <- chr
      • line 16: segInfo
      • line 17: })
      • line 18: segInfo_chrs <- do.call(rbind, segInfo_list)
      • line 19: rm(segInfo_list)
    • in perSegChrQC

      • line 5: if (is.null(barcodeFile)) {
      • line 6: barcodeFile <- file.path(path, paste0(sampleName, "_barcodes.txt"))
      • line 7: }
      • line 8: stopifnot(file.exists(barcodeFile))
      • line 9: barcodes <- read.table(file = barcodeFile, stringsAsFactors = FALSE,
      • line 10: col.names = "barcodes")
      • line 11: segInfo_list <- bplapply(chroms, function(chr) {
      • line 12: segInfo <- read.table(file = file.path(path, paste0(sampleName,
      • line 13: "_", chr, "_viSegInfo.txt")), stringsAsFactors = FALSE,
      • line 14: col.names = c("ithSperm", "Seg_start", "Seg_end",
      • line 15: "logllRatio", "nSNP", "State"))
      • line 16: segInfo$Chrom <- chr
      • line 17: segInfo
      • line 18: })
      • line 19: segInfo_chrs <- do.call(rbind, segInfo_list)
      • line 20: rm(segInfo_list)

Documentation

Included Installation in Vignette via BiocManager

  • [X] Vignette should have an Installation section.
  • [X] Please include Bioconductor installation instructions using BiocManager.
bioc-issue-bot commented 2 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 2 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/ruqianl.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("comapr"). The package 'landing page' will be created at

https://bioconductor.org/packages/comapr

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.