Closed xiuyuma closed 2 years ago
@xiuyuma The simple way is use roxygen to create one. See https://cran.r-project.org/web/packages/roxygen2/vignettes/roxygen2.html for Rcpp part.
Thanks @jianhong , have pushed the latest version.
Received a valid push on git.bioconductor.org; starting a build for commit id: ee16fb2dd56ed2ff96715e4c6466cae184b965d7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scDDboost
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
The package passed check and build. It is almost there.
[ ] NOTE: Selective imports using importFrom
instead of import all with import
.
[ ] Important: Package in Depends field not imported from: ‘ggplot2’ These packages need to be imported from (in the NAMESPACE file) for when this namespace is loaded but not attached.
[ ] Important: 1:n
is not suggested in source code. Use seq_along
or seq.int
instead.
[ ] NOTE: Avoid 'suppressWarnings'/'*Messages' if possible (found 1 times) suppressWarnings() in R/rwMle.R (line 18, column 13)
[ ] Important: Please double check your vignettes format. Only sessionInfo will be shown in table of contents.
[ ] NOTE: use '<-' instead of '=' for assignment in sample codes in Rd files.
Received a valid push on git.bioconductor.org; starting a build for commit id: be8c854e5e22104b60d9eb8b589b9d13a0cd91ef
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scDDboost
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1734aa2104d5ba41b2db3b0f4e9ad12057f765f9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scDDboost
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 4656d86efe7274ce28a36f8ef6f94992f7c08af1
Hi @jianhong,
Thanks for your quick response. I have addressed those issues
The DESCRIPTION file Important: R version should be no less than 4.2
Fixed, now it requires R version >=4.2
The NAMESPACE file NOTE: Selective imports using importFrom instead of import all with import. in line 2 import(RcppEigen) in line 3 import(BiocParallel) in line 4 import(SingleCellExperiment) in line 5 import(ellipsis) in line 6 import(vctrs)
Fixed, the only import used is for RcppEigen since it basically gives a header file for c
Important: Package in Depends field not imported from: ‘ggplot2’ These packages need to be imported from (in the NAMESPACE file) for when this namespace is loaded but not attached.
Fixed, import functions used from ggplot2
R code Important: 1:n is not suggested in source code. Use seq_along or seq.int instead. In file R/pdd.R: at line 156 found ' tmp_z1<-table(ccl[1:n1])'
Fixed, used seq_len and seq.int instead
NOTE: Avoid 'suppressWarnings'/'*Messages' if possible (found 1 times) suppressWarnings() in R/rwMle.R (line 18, column 13)
Fixed, removed the suppressWarnings function
Documentation Important: Please double check your vignettes format. Only sessionInfo will be shown in table of contents.
Fixed, now table of contents presents other sections
NOTE: use '<-' instead of '=' for assignment in sample codes in Rd files.The DESCRIPTION file
Fixed, examples in Rd are using '<-' instead of '='
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scDDboost
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
It is almost there.
#
and the session title.Received a valid push on git.bioconductor.org; starting a build for commit id: 3e6bcae7a0f754d8af86e742c32f976ffa81d32b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/scDDboost
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@jianhong Hi Jianhong,
Thanks, I have added a blank space between the section title and # .
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
@jianhong Hi Jianhong,
Thanks, I have added a blank space between the section title and # .
Congratulations! Thank you for your contribution in Bioconductor!
@jianhong Thanks for your review and advice
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/xiuyuma.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("scDDboost")
. The package 'landing page' will be created at
https://bioconductor.org/packages/scDDboost
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[ x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[ x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[ x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[ x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x ] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[ x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[ x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.