Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

MSstatsLiP #2359

Closed devonjkohler closed 2 years ago

devonjkohler commented 2 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 years ago

Hi @devonjkohler

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Type: Package
Package: MSstatsLiP
Title: LiP Significance Analysis in shotgun mass spectrometry-based proteomic experiments
Version: 0.99.0
Date: 2021-09-21
Description: Tools for Post Translational Modification (PTM) and protein 
    significance analysis. Supports DDA, DIA, and tandem mass tag 
    (TMT) labeling. Provides functions for summarization, estimation 
    of PTM site abundance, and detection of changes in PTMs across 
    conditions. 
Authors@R: c(person("Devon", "Kohler", email = "kohler.d@northeastern.edu", role = c("aut", "cre")),
  person("Tsung-Heng", "Tsai", email = "tsai.tsungheng@gmail.com", role = "aut"),
  person("Ting", "Huang", email = "thuang0703@gmail.com", role=c("aut")),
  person("Mateusz", "Staniak", email = "mtst@mstaniak.pl", role = c("aut")),
    person("Meena", "Choi", email = "mnchoi67@gmail.com", role="aut"),
  person("Valentina", "Cappelletti", email = "valentina.cappelletti@imsb.biol.ethz.ch", role="aut"),
  person("Liliana", "Malinovska", email = "malinovska@imsb.biol.ethz.ch", role="aut"),
    person("Olga", "Vitek", email = "o.vitek@northeastern.edu", role = "aut"))
License: Artistic-2.0
Depends: R (>= 4.1)
Imports: dplyr, gridExtra, stringr, ggplot2, grDevices, MSstats, MSstatsConvert,
data.table, Biostrings, MSstatsPTM, Rcpp, checkmate, factoextra, 
ggpubr, purrr, tibble, tidyr, tidyverse, scales
Suggests: BiocStyle, knitr, rmarkdown, covr, tinytest
LinkingTo: Rcpp
VignetteBuilder: knitr
biocViews: ImmunoOncology, MassSpectrometry, Proteomics, Software, DifferentialExpression, 
 OneChannel, TwoChannel, Normalization, QualityControl
BugReports: https://github.com/Vitek-Lab/MSstatsLiP/issues
Encoding: UTF-8
LazyData: TRUE
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
bioc-issue-bot commented 2 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSstatsLiP to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSstatsLiP to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: b15f7115e822a2a7ba27e401ab5d6f4110650bfe

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSstatsLiP to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 4b5d363422b94f1789f6c185a95dd4fccda7f20e

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSstatsLiP to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

LiNk-NY commented 2 years ago

Hi Devon, @devonjkohler

Thank you for your submission. Please see the review below.

Best regards, Marcel


MSstatsLiP #2359

DESCRIPTION

NAMESPACE

vignettes

R

covr

> covr::package_coverage()
MSstatsLiP Coverage: 38.75%
R/BarcodePlotLiP.R: 0.00%
R/PCAPlotLiP.R: 0.00%
R/SkylinetoMSstatsLiPFormat.R: 0.00%
R/SpectronauttoMSstatsLiPFormat.R: 0.00%
src/model_adjustment.cpp: 0.00%
R/locatePTM.R: 19.59%
R/utils_checks.R: 39.44%
R/dataSummarizationLiP.R: 62.50%
R/correlationPlotLiP.R: 76.74%
R/groupComparisonPlotsLiP.R: 82.35%
R/groupComparisonLiP.R: 86.49%
R/trypticHistogramLiP.R: 94.23%
R/calculateTrypticity.R: 96.77%
R/dataProcessPlotsLiP.R: 100.00%
bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 57ececdfa37561bb05a9fed9614d977f91d9f85e

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSstatsLiP to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

devonjkohler commented 2 years ago

Hey Marcel,@LiNk-NY

Thank you for your review, your comments were very helpful.

I just pushed an update and tried to address everything. Please see below.

DESCRIPTION

I fixed the description field. This is a new package that uses some of the backend of MSstatsPTM. That should be reflected now.

Vignettes

I updated everything here like you suggested.

R

I tried to make all the code updates you suggest.

The only thing I was unable to change was the logging and pdf writing to the user's directory. This is how the entire family of MSstats packages (MSstats/MSstatsTMT/MSstatsPTM) write logs and pdfs and this package relies on them to write the majority of the files (other than a couple of the new plotting functions I wrote for this package specifically).

I will talk to the other developers of MSstats about this and we will work on a different idea for saving logs and plots. This one is more major and requires updates to a number of packages.

For now, the option to not save logs or plots is available to the user and I updated the vignette to not save logs or plots to the user's directory.

covr

I added more tests to try to cover the remaining functions. The only one that does not have coverage now is SkylinetoMSstatsLiPFormat.R. I do not have raw skyline example data in the package so it is hard to write meaningful tests for it.

I hope all of this makes sense!

Best, Devon

LiNk-NY commented 2 years ago

Hi Devon, @devonjkohler Thanks for making those changes. Perhaps there may be some existing packages that make Skyline data available (lipidr?).

Update: Please resolve this note.

* checking R code for possible problems ... NOTE
BarcodePlotLiP: no visible binding for global variable ‘fully_TRI’
BarcodePlotLiP: no visible binding for global variable ‘ProteinName’
BarcodePlotLiP: no visible binding for global variable ‘uniprot_iso’
BarcodePlotLiP: no visible binding for global variable ‘Label’
BarcodePlotLiP: no visible binding for global variable
  ‘PeptideSequence’
BarcodePlotLiP: no visible binding for global variable ‘sig’
BarcodePlotLiP: no visible binding for global variable ‘Coverage’
BarcodePlotLiP: no visible binding for global variable ‘Index’
PCAPlotLiP: no visible binding for global variable ‘FULL_PEPTIDE’
PCAPlotLiP: no visible binding for global variable ‘Protein’
SkylinetoMSstatsLiPFormat: no visible binding for global variable
  ‘Intensity’
SpectronauttoMSstatsLiPFormat: no visible binding for global variable
  ‘R.Condition’
calculate.pc: no visible binding for global variable ‘Cond_rep’
calculate.pc: no visible binding for global variable ‘LogIntensities’
calculate.pc: no visible binding for global variable ‘FULL_PEPTIDE’
calculate.pc: no visible binding for global variable ‘Protein’
calculate.pc: no visible global function definition for ‘prcomp’
correlationPlotLiP: no visible global function definition for ‘cor’
correlationPlotLiP: no visible binding for global variable ‘SUBJECT’
correlationPlotLiP: no visible binding for global variable ‘variable2’
correlationPlotLiP: no visible binding for global variable ‘variable’
correlationPlotLiP: no visible binding for global variable ‘value’
dataProcessPlotsLiP: no visible binding for global variable ‘PROTEIN’
dataProcessPlotsLiP: no visible binding for global variable ‘Protein’
dataProcessPlotsLiP: no visible binding for global variable
  ‘FULL_PEPTIDE’
dataSummarizationLiP: no visible binding for global variable ‘PROTEIN’
dataSummarizationLiP: no visible binding for global variable ‘Protein’
groupComparisonLiP: no visible binding for global variable ‘PEPTIDE’
groupComparisonLiP: no visible binding for global variable ‘Protein’
groupComparisonLiP: no visible binding for global variable
  ‘GlobalProtein’
groupComparisonPlotsLiP: no visible binding for global variable
  ‘..keep’
groupComparisonPlotsLiP: no visible binding for global variable
  ‘FULL_PEPTIDE’
groupComparisonPlotsLiP: no visible binding for global variable
  ‘Protein’
groupComparisonPlotsLiP: no visible binding for global variable
  ‘..adjusted.keep’
trypticHistogramLiP: no visible global function definition for ‘.’
trypticHistogramLiP: no visible binding for global variable ‘GROUP’
trypticHistogramLiP: no visible binding for global variable ‘SUBJECT’
trypticHistogramLiP: no visible binding for global variable ‘fully_TRI’
trypticHistogramLiP: no visible binding for global variable
  ‘percent_plot’
Undefined global functions or variables:
  . ..adjusted.keep ..keep Cond_rep Coverage FULL_PEPTIDE GROUP
  GlobalProtein Index Intensity Label LogIntensities PEPTIDE PROTEIN
  PeptideSequence Protein ProteinName R.Condition SUBJECT cor fully_TRI
  percent_plot prcomp sig uniprot_iso value variable variable2
Consider adding
  importFrom("stats", "cor", "prcomp")
to your NAMESPACE file.

Best regards, Marcel

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 078d76480761c8ce95597b95ec6cdb8faaca17ca

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSstatsLiP to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0f3f340c61e0689385f779f9f9023cde9107b9d8

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/MSstatsLiP to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

devonjkohler commented 2 years ago

Hey Marcel, @LiNk-NY

I made the final changes you mentioned in your last comment. I added some skyline data from the MSstats package to test the function on and cleaned up the note. For the log writing, I set it to not write to the directory, while still giving them the option if desired.

Hope this takes care of everything!

Best, Devon

LiNk-NY commented 2 years ago

Hi Devon, @devonjkohler

Thank you for making those changes and for your contribution. Your package has been accepted to Bioconductor.

Best regards, Marcel

bioc-issue-bot commented 2 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 2 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/devonjkohler.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("MSstatsLiP"). The package 'landing page' will be created at

https://bioconductor.org/packages/MSstatsLiP

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.