Closed devonjkohler closed 2 years ago
Hi @devonjkohler
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Type: Package
Package: MSstatsLiP
Title: LiP Significance Analysis in shotgun mass spectrometry-based proteomic experiments
Version: 0.99.0
Date: 2021-09-21
Description: Tools for Post Translational Modification (PTM) and protein
significance analysis. Supports DDA, DIA, and tandem mass tag
(TMT) labeling. Provides functions for summarization, estimation
of PTM site abundance, and detection of changes in PTMs across
conditions.
Authors@R: c(person("Devon", "Kohler", email = "kohler.d@northeastern.edu", role = c("aut", "cre")),
person("Tsung-Heng", "Tsai", email = "tsai.tsungheng@gmail.com", role = "aut"),
person("Ting", "Huang", email = "thuang0703@gmail.com", role=c("aut")),
person("Mateusz", "Staniak", email = "mtst@mstaniak.pl", role = c("aut")),
person("Meena", "Choi", email = "mnchoi67@gmail.com", role="aut"),
person("Valentina", "Cappelletti", email = "valentina.cappelletti@imsb.biol.ethz.ch", role="aut"),
person("Liliana", "Malinovska", email = "malinovska@imsb.biol.ethz.ch", role="aut"),
person("Olga", "Vitek", email = "o.vitek@northeastern.edu", role = "aut"))
License: Artistic-2.0
Depends: R (>= 4.1)
Imports: dplyr, gridExtra, stringr, ggplot2, grDevices, MSstats, MSstatsConvert,
data.table, Biostrings, MSstatsPTM, Rcpp, checkmate, factoextra,
ggpubr, purrr, tibble, tidyr, tidyverse, scales
Suggests: BiocStyle, knitr, rmarkdown, covr, tinytest
LinkingTo: Rcpp
VignetteBuilder: knitr
biocViews: ImmunoOncology, MassSpectrometry, Proteomics, Software, DifferentialExpression,
OneChannel, TwoChannel, Normalization, QualityControl
BugReports: https://github.com/Vitek-Lab/MSstatsLiP/issues
Encoding: UTF-8
LazyData: TRUE
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MSstatsLiP
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MSstatsLiP
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: b15f7115e822a2a7ba27e401ab5d6f4110650bfe
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MSstatsLiP
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 4b5d363422b94f1789f6c185a95dd4fccda7f20e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MSstatsLiP
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi Devon, @devonjkohler
Thank you for your submission. Please see the review below.
Best regards, Marcel
Description
field about how this package
relates to MSstatsTMTPTM
? Does this package replace it? Does the
functionality overlap?{r,include=TRUE,results="hide",message=FALSE,warning=FALSE}
)lip <- MSstatsLiP_Summarized[["LiP"]]
, to help improve readability.List all the possible inputs in the model_type
argument (and others) as
a character vector. Then, within the function, use match.arg
to select
one from the inputs.
Avoid inefficient code such as splitting model.data
into two data.frame
s
then binding them into one data.frame
rather than just using adding the
result of adj.pvalue < adj.pvalue.cutoff & abs(log2FC) >= FC.cutoff
to the
data.frame
(BarcodePlotLiP
).
Avoid using ifelse
if you are using TRUE
and FALSE
as the results
because you can simplify to, e.g.,
combined_df$NTERMINUS <- combined_df$start == 1
in calculateTripticity
Consider using the name of the element in data
as the model_type
input
so that you can simply pass that input for subsetting data
, i.e.,
data[[model_type]]
in BarcodePlotLiP
.
Do not save files for the user and do not use the current working directory
as default. If anything use the tempdir()
folder. Memory is limited on the
Bioconductor builders.
Remove the pdf
function call from BarcodePlotLiP
and only output the
plot from ggplot
.
If you want to plot, plot to the graphics device as the output of the function.
Avoid nested for loops wherever possible.
Do not create a log by default in the users working directory. Consider
setting the path to the tempfile
or not creating one unless the users
provides a path for it.
Consider using messages
instead of saving a text file as a log.
Consider combining similar calls so that there is less repitition, e.g.,
Trp.model
can be set to NULL
if Trp.model
does not have any rows.
Combine checks and/or create a helper function for .locateCheck
.
Please do not use print
within a function, use message
instead.
Minor: Use seq_along
instead of seq(length())
.
Why not use is.character()
rather than identical(typeof(), "character")
on fasta_file
in calculateTripticity
?
Also, you already ask the user to run tidyFasta()
on the file so why
do it again yourself?
Double evaluation of a logical is not necessary within an if()
, e.g.,
if (use_log_file == TRUE)
can be simplified to if (use_log_file)
.
if (nrow(x))
is equivalent to if (nrow(x) != 0)
> covr::package_coverage()
MSstatsLiP Coverage: 38.75%
R/BarcodePlotLiP.R: 0.00%
R/PCAPlotLiP.R: 0.00%
R/SkylinetoMSstatsLiPFormat.R: 0.00%
R/SpectronauttoMSstatsLiPFormat.R: 0.00%
src/model_adjustment.cpp: 0.00%
R/locatePTM.R: 19.59%
R/utils_checks.R: 39.44%
R/dataSummarizationLiP.R: 62.50%
R/correlationPlotLiP.R: 76.74%
R/groupComparisonPlotsLiP.R: 82.35%
R/groupComparisonLiP.R: 86.49%
R/trypticHistogramLiP.R: 94.23%
R/calculateTrypticity.R: 96.77%
R/dataProcessPlotsLiP.R: 100.00%
Received a valid push on git.bioconductor.org; starting a build for commit id: 57ececdfa37561bb05a9fed9614d977f91d9f85e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MSstatsLiP
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hey Marcel,@LiNk-NY
Thank you for your review, your comments were very helpful.
I just pushed an update and tried to address everything. Please see below.
I fixed the description field. This is a new package that uses some of the backend of MSstatsPTM. That should be reflected now.
I updated everything here like you suggested.
I tried to make all the code updates you suggest.
The only thing I was unable to change was the logging and pdf writing to the user's directory. This is how the entire family of MSstats packages (MSstats/MSstatsTMT/MSstatsPTM) write logs and pdfs and this package relies on them to write the majority of the files (other than a couple of the new plotting functions I wrote for this package specifically).
I will talk to the other developers of MSstats about this and we will work on a different idea for saving logs and plots. This one is more major and requires updates to a number of packages.
For now, the option to not save logs or plots is available to the user and I updated the vignette to not save logs or plots to the user's directory.
I added more tests to try to cover the remaining functions. The only one that does not have coverage now is SkylinetoMSstatsLiPFormat.R. I do not have raw skyline example data in the package so it is hard to write meaningful tests for it.
I hope all of this makes sense!
Best, Devon
Hi Devon, @devonjkohler
Thanks for making those changes.
Perhaps there may be some existing packages that make Skyline data available (lipidr
?).
Update: Please resolve this note.
* checking R code for possible problems ... NOTE
BarcodePlotLiP: no visible binding for global variable ‘fully_TRI’
BarcodePlotLiP: no visible binding for global variable ‘ProteinName’
BarcodePlotLiP: no visible binding for global variable ‘uniprot_iso’
BarcodePlotLiP: no visible binding for global variable ‘Label’
BarcodePlotLiP: no visible binding for global variable
‘PeptideSequence’
BarcodePlotLiP: no visible binding for global variable ‘sig’
BarcodePlotLiP: no visible binding for global variable ‘Coverage’
BarcodePlotLiP: no visible binding for global variable ‘Index’
PCAPlotLiP: no visible binding for global variable ‘FULL_PEPTIDE’
PCAPlotLiP: no visible binding for global variable ‘Protein’
SkylinetoMSstatsLiPFormat: no visible binding for global variable
‘Intensity’
SpectronauttoMSstatsLiPFormat: no visible binding for global variable
‘R.Condition’
calculate.pc: no visible binding for global variable ‘Cond_rep’
calculate.pc: no visible binding for global variable ‘LogIntensities’
calculate.pc: no visible binding for global variable ‘FULL_PEPTIDE’
calculate.pc: no visible binding for global variable ‘Protein’
calculate.pc: no visible global function definition for ‘prcomp’
correlationPlotLiP: no visible global function definition for ‘cor’
correlationPlotLiP: no visible binding for global variable ‘SUBJECT’
correlationPlotLiP: no visible binding for global variable ‘variable2’
correlationPlotLiP: no visible binding for global variable ‘variable’
correlationPlotLiP: no visible binding for global variable ‘value’
dataProcessPlotsLiP: no visible binding for global variable ‘PROTEIN’
dataProcessPlotsLiP: no visible binding for global variable ‘Protein’
dataProcessPlotsLiP: no visible binding for global variable
‘FULL_PEPTIDE’
dataSummarizationLiP: no visible binding for global variable ‘PROTEIN’
dataSummarizationLiP: no visible binding for global variable ‘Protein’
groupComparisonLiP: no visible binding for global variable ‘PEPTIDE’
groupComparisonLiP: no visible binding for global variable ‘Protein’
groupComparisonLiP: no visible binding for global variable
‘GlobalProtein’
groupComparisonPlotsLiP: no visible binding for global variable
‘..keep’
groupComparisonPlotsLiP: no visible binding for global variable
‘FULL_PEPTIDE’
groupComparisonPlotsLiP: no visible binding for global variable
‘Protein’
groupComparisonPlotsLiP: no visible binding for global variable
‘..adjusted.keep’
trypticHistogramLiP: no visible global function definition for ‘.’
trypticHistogramLiP: no visible binding for global variable ‘GROUP’
trypticHistogramLiP: no visible binding for global variable ‘SUBJECT’
trypticHistogramLiP: no visible binding for global variable ‘fully_TRI’
trypticHistogramLiP: no visible binding for global variable
‘percent_plot’
Undefined global functions or variables:
. ..adjusted.keep ..keep Cond_rep Coverage FULL_PEPTIDE GROUP
GlobalProtein Index Intensity Label LogIntensities PEPTIDE PROTEIN
PeptideSequence Protein ProteinName R.Condition SUBJECT cor fully_TRI
percent_plot prcomp sig uniprot_iso value variable variable2
Consider adding
importFrom("stats", "cor", "prcomp")
to your NAMESPACE file.
Best regards, Marcel
Received a valid push on git.bioconductor.org; starting a build for commit id: 078d76480761c8ce95597b95ec6cdb8faaca17ca
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MSstatsLiP
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0f3f340c61e0689385f779f9f9023cde9107b9d8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/MSstatsLiP
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hey Marcel, @LiNk-NY
I made the final changes you mentioned in your last comment. I added some skyline data from the MSstats package to test the function on and cleaned up the note. For the log writing, I set it to not write to the directory, while still giving them the option if desired.
Hope this takes care of everything!
Best, Devon
Hi Devon, @devonjkohler
Thank you for making those changes and for your contribution. Your package has been accepted to Bioconductor.
Best regards, Marcel
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/devonjkohler.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("MSstatsLiP")
. The package 'landing page' will be created at
https://bioconductor.org/packages/MSstatsLiP
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.