Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

cytoKernel #2376

Closed tghosh30 closed 2 years ago

tghosh30 commented 3 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 3 years ago

Hi @tghosh30

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: cytoKernel
Type: Package
Title: Differential expression using kernel-based score test
Version: 0.99.0
Date: 2021-09-27
Authors@R:
    c(person("Tusharkanti", "Ghosh",
 email = "tusharkantighosh30@gmail.com",
 role = c("aut", "cre")),
    person("Victor", "Lui",
 role = c("aut")),
    person("Pratyaydipta", "Rudra",
 role = c("aut")),
    person("Souvik", "Seal",
 role = c("aut")), 
    person("Thao", "Vu",
 role = c("aut")),
    person("Elena", "Hsieh",
 role = c("aut")),
    person("Debashis", "Ghosh",
 role = c("aut", "cph")))
Imports: Rcpp, SummarizedExperiment, utils,
     methods, ComplexHeatmap, circlize,
     ashr, data.table, BiocParallel, dplyr,
     stats, magrittr, rlang, S4Vectors
LinkingTo: Rcpp
Depends: R (>= 4.1)
Suggests: 
    knitr,
    rmarkdown,
    BiocStyle,
    testthat
VignetteBuilder: knitr
Encoding: UTF-8
License: GPL-3
Description: cytoKernel implements a kernel-based score test to
   identify differentially expressed features
   in high-dimensional biological experiments. This
   approach can be applied across many different
   high-dimensional biological data including gene 
   expression data and dimensionally reduced 
   cytometry-based marker expression data. 
   In this R package,
   we implement functions that compute the 
   feature-wise p values and their corresponding 
   adjusted p values. Additionally, it also computes
   the feature-wise shrunk effect sizes and 
   their corresponding shrunken effect size.
   Further, it calculates the percent of 
   differentially expressed features and plots 
   user-friendly heatmap of the top differentially
   expressed features on the rows and samples on the
   columns.
biocViews: ImmunoOncology, Proteomics, SingleCell, Software, 
 OneChannel, FlowCytometry, DifferentialExpression,
 GeneExpression, Clustering
BugReports: https://github.com/Ghoshlab/cytoKernel/issues
RoxygenNote: 7.1.2
bioc-issue-bot commented 3 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 3 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/cytoKernel to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

vjcitn commented 2 years ago

This is looking good so far. BiocCheck complains that the NEWS file is malformed.

I had a look at test coverage:

cytoKernel Coverage: 33.54%
R/AllClasses.R: 0.00%
R/CytoKFunctions.R: 0.00%
R/plots.R: 0.00%
R/diffexpData.R: 36.96%
src/cytoKernelUtility.cpp: 41.67%
R/CytoK.R: 46.43%
R/AllGenerics.R: 83.33%
R/AllslotAccessors.R: 83.33%
R/CytoKProc.R: 83.33%

Not bad. I will accept and perhaps in maintenance/enhancements you can find opportunities to improve test coverage.

bioc-issue-bot commented 2 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

tghosh30 commented 2 years ago

This is looking good so far. BiocCheck complains that the NEWS file is malformed.

I had a look at test coverage:

cytoKernel Coverage: 33.54%
R/AllClasses.R: 0.00%
R/CytoKFunctions.R: 0.00%
R/plots.R: 0.00%
R/diffexpData.R: 36.96%
src/cytoKernelUtility.cpp: 41.67%
R/CytoK.R: 46.43%
R/AllGenerics.R: 83.33%
R/AllslotAccessors.R: 83.33%
R/CytoKProc.R: 83.33%

Not bad. I will accept and perhaps in maintenance/enhancements you can find opportunities to improve test coverage.

Thanks @vjcitn. I will keep on improving the test coverage in package maintenance. Regards, T

lshep commented 2 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/tghosh30.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("cytoKernel"). The package 'landing page' will be created at

https://bioconductor.org/packages/cytoKernel

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.