QHScrnomo

[jixccf]

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

• Repository: https://github.com/jixccf/QHScrnomo

Confirm the following by editing each check box to '[x]'

• [x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.

• [x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.

• [x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.

• [x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.

• [x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.

• [x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.

• [x] I am familiar with the Bioconductor code of conduct and agree to abide by it.

I am familiar with the essential aspects of Bioconductor software management, including:

• [x] The 'devel' branch for new packages and features.
• [x] The stable 'release' branch, made available every six months, for bug fixes.
• [x] Bioconductor version control using Git (optionally via GitHub).

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

[bioc-issue-bot]

Dear @jixccf,

The package version number, '2.99.0', does not start with 0. Expecting format: '0.99.z' for new packages. Starting with non-zero x of 'x.y.z' format is generally only allowed if the package has been pre-released.

We recommend fixing the version number. See Bioconductor version numbers Please also consider running BiocCheck::BiocCheck() on your package to look for other Bioconductor package requirements.

[bioc-issue-bot]

Hi @jixccf

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: QHScrnomo
Type: Package
Title: Construct nomograms for competing risk models
Version: 2.99.0
biocViews: Regression, TimeCourse, Survival
Date: 2021-10-27
Authors@R: c(
    person("Michael", "Kattan", email = "kattanm@ccf", role = "aut"),
    person("Changhong", "Yu", email = "yuc@ccf.org", role = "aut"),
    person("Xinge", "Ji", email="jix@ccf.org", role="cre"))
Depends: R (>= 4.1.0),Hmisc,rms,cmprsk
Suggests: 
    rmarkdown,
    knitr,
    survival,
    testthat (>= 3.0.0)
Description: Nomograms are constructed to predict cumulative incidence
    rate, which is calculated by adjusting for competing causes other
    than that of interest. K-fold cross-validation function is implemented
    to validate the performance. Competing risk version of concordance index
    is calculated.
License: GPL-2
NeedsCompilation: yes
Config/testthat/edition: 3
RoxygenNote: 7.1.2
VignetteBuilder: knitr

[vjcitn]

I don't see how email = "kattanm@ccf" in the DESCRIPTION could be valid.

Is it possible to supply a genomics-oriented application? I think this is an interesting package and would like to see it moving forward here, but Bioconductor doesn't typically review/distribute packages with no example of application in genomic data. Your vignette says you are using artificial prostate cancer data. Can you use data from curatedTCGAData to do something more realistic?

[jixccf]

Thanks for your review. I will close this issue for now and update it.