Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

tinytools #2470

Closed jaspershen closed 2 years ago

jaspershen commented 2 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 years ago

Hi @jaspershen

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: tinytools
Type: Package
Title: All the usefull tools for MS data processing and analysis
Version: 0.99.1
Date: 2021-11-06
Authors@R: c(
    person(given = "Xiaotao",
 family = "Shen",
 role = c("aut", "cre"),
 email = "shenxt1990@outlook.com",
 comment = c(ORCID = "0000-0002-9608-9964")),
        person(given = "Chuchu",
 family = "Wang",
 role = c("aut", "ctb"))
 )
Description: This package contains a lot of tools.
    These tools can be used for mass spectrometry and metabolomics data processing and analysis. 
    This package is dependent by all the tidymass packages. 
URL: https://github.com/tidymass/tinytools
BugReports: https://github.com/tidymass/tinytools/issues
Encoding: UTF-8
LazyData: false
Depends: R (>= 4.1)
Imports: 
    dplyr,
    magrittr,
    tibble,
    tidyr,
    stringr,
    rstudioapi,
    ggplot2,
    methods,
    crayon,
    cli,
    purrr,
    plotly,
    pbapply,
    clisymbols,
    htmltools,
    httr,
    plyr,
    readxl,
    rvest,
    xml2,
    htmlwidgets,
    leaflet,
    stats,
    utils
License: GPL-2 | file LICENSE
RoxygenNote: 7.1.1
Suggests: 
    knitr,
    rmarkdown,
    BiocStyle,
    RUnit,
    BiocGenerics,
    tidyverse,
    testthat (>= 3.0.0)
VignetteBuilder: knitr
Note:
biocViews: Metabolomics, MassSpectrometry
Config/testthat/edition: 3
jaspershen commented 2 years ago

Hi. Just wondering when can I get the comments on this package? Thank you!

bioc-issue-bot commented 2 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

hpages commented 2 years ago

tinytools is such a vague and generic name. If this is about mass spec, maybe something like tinymstools, or simply mstools/masstools or msutils/massutils?

About the Title:

Title: All the usefull tools for MS data processing and analysis

Correct spelling is "useful" (a single "l"), not "usefull".

About the Description:

This package contains a lot of tools.

This kind of sentence is vague and does not actually provide any useful information about the package.

This package is dependent by all the tidymass packages.

"is dependent by" is not correct. Do you mean "is used by" or "provides support for"?

Thanks, H.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/tinytools to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

hpages commented 2 years ago

Your package seems to be using metflow2. There are 2 problems with this:

  1. This dependency is not listed in your DESCRIPTION file.
  2. metflow2 is not a CRAN or Bioconductor package.
jaspershen commented 2 years ago

Hi Herve,

Thank you so much for your comments. I agree with your comment on the name of the package, tinytools is too generic. I will change it to masstools, should I change it and then resubmit it again with a new issue? Thank you.

hpages commented 2 years ago

Yes. Thanks!

jaspershen commented 2 years ago

Dear Herve,

I have changed the package name. And the link is here: https://github.com/tidymass/masstools. I will open another issue for this one. I am just wondering if you can help transfer this to masstools, so we can save lots of time. Thank you so much!