Closed lgatto closed 2 years ago
Hi @lgatto
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: PSMatch
Title: Handling and Managing Peptide Spectrum Matches
Version: 0.99.0
Authors@R:
c(person(given = "Laurent", family = "Gatto",
email = "laurent.gatto@uclouvain.be",
role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-1520-2268")),
person(given = "Johannes", family = "Rainer",
email = "Johannes.Rainer@eurac.edu",
role = "aut",
comment = c(ORCID = "0000-0002-6977-7147")),
person(given = "Sebastian", family = "Gibb",
email = "mail@sebastiangibb.de",
role = "aut"),
person(given = "Samuel", family = "Wieczorek",
email = "samuel.wieczorek@cea.fr",
role = "ctb"),
person(given = "Thomas", family = "Burger",
email = "thomas.burger@cea.fr",
role = "ctb"))
Description: The PSMatch package helps proteomics practitioners to
load, handle and manage Peptide Spectrum Matches. It provides
functions to model peptide-protein relations as adjacency matrices
and connected components, visualise these as graphs and make
informed decision about shared peptide filtering. The package also
provides functions to calculate and visualise MS2 fragment ions.
Depends:
S4Vectors
Imports:
utils,
stats,
igraph,
methods,
Matrix,
BiocParallel,
BiocGenerics,
ProtGenerics (>= 1.27.1),
QFeatures,
MsCoreUtils
Suggests:
msdata,
rpx,
mzID,
mzR,
Spectra,
SummarizedExperiment,
BiocStyle,
rmarkdown,
knitr,
factoextra,
testthat
License: Artistic-2.0
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.2
VignetteBuilder: knitr
BugReports: https://github.com/RforMassSpectrometry/PSM/issues
URL: https://github.com/RforMassSpectrometry/PSM
biocViews: Infrastructure, Proteomics, MassSpectrometry
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/PSMatch
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
The error is
* ERROR: Maintainer must register at the support site; visit
https://support.bioconductor.org/accounts/signup/ .
but I confirm that I have an account - see https://support.bioconductor.org/u/5645/
Its because the email in the description for the maintainer is different than the registered email on the support site.
I have changed it on the support site just now.
Received a valid push on git.bioconductor.org; starting a build for commit id: 78e6bc893ecf15aa77a6d8475e4680ad84bf18a5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/PSMatch
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Error above addressed: I have now added the package to my watched tags on the support site.
@lgatto - great, I'm working on the initial review now and should have it posted by tomorrow.
Thank you @Kayla-Morrell - no hurry at all, and thank you for reviewing the package.
@lgatto - Sorry for the delay! Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.
## Changes in 0.99.1 (2022-03-04)
. Also i
think the bullet points need to be '+' instead of '-'. Best, Kayla
SequenceMatching
tag really doesn't apply. sapply()
in PSMatch-reduce.R
to a vapply()
because de point here is to verify if the output is converted to a list or a vector. cat()
is used in the show()
method, but not directly, it's called in the show()
's subfunction showDetails()
. ConnectedComponents
man page. -
in all other packages), nor the date (which I also often put at the end of the bullet point when there are multiple bullet points/changes per version). I have removed it for now as it wasn't really important here, hoping it sorts the issue. Version 0.99.2 with the changes on its way.
Received a valid push on git.bioconductor.org; starting a build for commit id: e2492158a484253a82b8542c75de15c1415e1809
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/PSMatch
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@lgatto - Thank you for making the necessary changes, I have looked them over and everything looks good. I'm more than happy to accept the package.
Best, Kayla
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
Thank you for your review @Kayla-Morrell
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/lgatto.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("PSMatch")
. The package 'landing page' will be created at
https://bioconductor.org/packages/PSMatch
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[X] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[X] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[X] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[X] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[X] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[X] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[X] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.