Closed rossinerbe closed 2 years ago
rossinerbe
commented
2 years ago @Kayla-Morrell should be ready for re-review. With the caveat that I had to remove the suggested changes to NAMESPACE as these created an error in the build check above. Let me know if this is a problem
rossinerbe
commented
2 years ago @Kayla-Morrell do I need to do anything for the review process at this point?
Kayla-Morrell
commented
2 years ago @rossinerbe - Sorry for the delay in posting my re-review comments. There are two points that need to be addressed before I can accept the package, see below. Please respond with any comments.
dontrun{} instead of donttest{}. Did you attempt to implement this?Best, Kayla
bioc-issue-bot
commented
2 years ago Received a valid push on git.bioconductor.org; starting a build for commit id: 5d651105b59b007d8836f9ce90651d533ea61fee
bioc-issue-bot
commented
2 years ago Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/ATACCoGAPS to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
rossinerbe
commented
2 years ago Okay, I have made those changes. Changing from dontrun to donttest seems to lead to WARNING: R CMD check exceeded 10 min requirement (I'm not sure why) which is why I hadn't done it previously, but if it's required we can include it
Kayla-Morrell
commented
2 years ago @rossinerbe - Interesting, I'm not sure why that would cause an issue. If you want to switch that back to avoid the WARNING I'd allow it. Thank you for making the changes, I'm more than happy to accept the package.
Best, Kayla
bioc-issue-bot
commented
2 years ago Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
lshep
commented
2 years ago The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/rossinerbe.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("ATACCoGAPS"). The package 'landing page' will be created at
https://bioconductor.org/packages/ATACCoGAPS
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.