Closed BioinfOMICS closed 10 months ago
Hi @TMSWCChenglab
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: LipidSigR
Type: Package
Title: A comprehensive analysis for streamlined data mining of
lipidomic data
Version: 0.99.0
Authors@R: c(
person("Wei-Chung", "Cheng", email="cwc0702@gmail.com", role = c("aut","cre","cph"), comment = c(ORCID = "0000-0002-1229-4857")),
person("Wen-Jen", "Lin", role = c("aut","ctb")),
person("Pei-Chun", "Shen", role = c("ctb")),
person("Hsiu-Cheng", "Liu", role = c("ctb")),
person("Meng-Hsin", "Tsai", role = c("ctb")))
Description:
"LipidSigR" is an R package developed based on LipidSig web-based tool (http://www.chenglab.cmu.edu.tw/lipidsig/). This package integrates a comprehensive analysis for streamlined data mining of lipidomic datasets. We provide 4 main analysis workflows, which is "Profiling", "Differential expression", "Machine learning", and "Correlation". Each section provides unique aspects to analyze the lipidome profiling data based on different characteristics including lipid class, chain length, unsaturation, hydroxyl group, and fatty acid composition.
"Profiling" provides an overview of comprehensive analyses to efficiently examine data quality, the clustering of samples, the correlation between lipid species, and the composition of lipid characteristics. "Differential expression" integrates many useful lipid-focused analyses for identifying significant lipid species or lipid characteristics. "Machine learning" provides a broad variety of feature selection methods and classifiers to build binary classification models. Furthermore, the subsequent analyses can help users to evaluate the learning algorithm's performance and to explore important lipid-related variables. "Correlation" illustrates and compares the relationships between different clinical phenotypes and lipid features.
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: FALSE
RoxygenNote: 7.1.2
biocViews: Lipidomics, GeneExpression, Classification, Clustering
Depends: R (>= 4.0.0)
Imports: plotly (>= 4.9.4.1), dplyr, scales, tidyselect, stringr,
magrittr, methods, Hmisc, tidyr, iheatmapr, visNetwork,
ggthemes, caret, e1071, pROC, glmnet, xgboost, yardstick,
rsample, cluster, dbscan, forcats, factoextra, mixOmics, purrr,
hwordcloud, Rtsne, uwot, tibble, stats, grDevices,
RColorBrewer, ggplot2, heatmaply, pathview
Suggests: knitr, devtools, roxygen2, rmarkdown, BiocStyle
Enhances: SHAPforxgboost, rstatix, data.table, fastshap, tidyverse,
ggforce, parsnip, ggpubr, ranger, utils, ggrepel, ggbeeswarm,
showimage, rlang (>= 0.4.11),
VignetteBuilder: utils
NeedsCompilation: no
Packaged: 2022-04-10 14:00:39 UTC; tiffany
Author: Wei-Chung Cheng [aut, cre, cph]
(<https://orcid.org/0000-0002-1229-4857>),
Wen-Jen Lin [aut, ctb],
Pei-Chun Shen [ctb],
Hsiu-Cheng Liu [ctb],
Meng-Hsin Tsai [ctb]
Maintainer: Wei-Chung Cheng <cwc0702@gmail.com>
This package lacks a vignette. Please read the guidelines.
Still no vignette. Should we close this issue and wait for you to produce a vignette?
Checking again.
Reopen the issue when you are ready to revise.
Hi, we have updated the files in the vignettes folder, including a .Rnw file, LipidSigR.rnw. The automatically produced files, LipidSigR.R and LipidSigR.pdf can be found under /inst/doc. Please let us know if there is still anything missing. Thank you for reviewing our submission.
@vjcitn I've updated the package to my GitHub repository based on the comments. Wondering if I'm still missing something to resubmit to Bioconductor?
Sorry, I keep in trying to build vignette ...
'select()' returned 1:1 mapping between keys and columns
Info: Working in directory /tmp/RtmpxHCROO/Rbuildb2c2948d363b7/LipidSigR/vignettes
Info: Writing image file hsa00565.pathview.png
Warning: Expected 2 pieces. Missing pieces filled with `NA` in 84 rows [1, 2, 3, 4, 5, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, ...].
Warning: Expected 2 pieces. Missing pieces filled with `NA` in 84 rows [1, 2, 3, 4, 5, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, ...].
Warning: Expected 2 pieces. Missing pieces filled with `NA` in 84 rows [1, 2, 3, 4, 5, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, ...].
Warning in self$trans$transform(x) : NaNs produced
Warning: Transformation introduced infinite values in continuous y-axis
Warning: 'bar' objects don't have these attributes: 'mode'
Valid attributes include:
'_deprecated', 'alignmentgroup', 'base', 'basesrc', 'cliponaxis', 'constraintext', 'customdata', 'customdatasrc', 'dx', 'dy', 'error_x', 'error_y', 'hoverinfo', 'hoverinfosrc', 'hoverlabel', 'hovertemplate', 'hovertemplatesrc', 'hovertext', 'hovertextsrc', 'ids', 'idssrc', 'insidetextanchor', 'insidetextfont', 'legendgroup', 'legendgrouptitle', 'legendrank', 'marker', 'meta', 'metasrc', 'name', 'offset', 'offsetgroup', 'offsetsrc', 'opacity', 'orientation', 'outsidetextfont', 'selected', 'selectedpoints', 'showlegend', 'stream', 'text', 'textangle', 'textfont', 'textposition', 'textpositionsrc', 'textsrc', 'texttemplate', 'texttemplatesrc', 'transforms', 'type', 'uid', 'uirevision', 'unselected', 'visible', 'width', 'widthsrc', 'x', 'x0', 'xaxis', 'xcalendar', 'xhoverformat', 'xperiod', 'xperiod0', 'xperiodalignment', 'xsrc', 'y', 'y0', 'yaxis', 'ycalendar', 'yhoverformat', 'yperiod', 'yperiod0', 'yperiodalignm [... truncated]
Warning in geom2trace.default(dots[[1L]][[1L]], dots[[2L]][[1L]], dots[[3L]][[1L]]) :
geom_GeomTextRepel() has yet to be implemented in plotly.
If you'd like to see this geom implemented,
Please open an issue with your example code at
https://github.com/ropensci/plotly/issues
Warning in PCA(exp_transform_class, group_info = group_info, sig_feature = DE_char_table_sig[, :
top_n_feature will only show 3
Warning: 'bar' objects don't have these attributes: 'mode'
Valid attributes include:
'_deprecated', 'alignmentgroup', 'base', 'basesrc', 'cliponaxis', 'constraintext', 'customdata', 'customdatasrc', 'dx', 'dy', 'error_x', 'error_y', 'hoverinfo', 'hoverinfosrc', 'hoverlabel', 'hovertemplate', 'hovertemplatesrc', 'hovertext', 'hovertextsrc', 'ids', 'idssrc', 'insidetextanchor', 'insidetextfont', 'legendgroup', 'legendgrouptitle', 'legendrank', 'marker', 'meta', 'metasrc', 'name', 'offset', 'offsetgroup', 'offsetsrc', 'opacity', 'orientation', 'outsidetextfont', 'selected', 'selectedpoints', 'showlegend', 'stream', 'text', 'textangle', 'textfont', 'textposition', 'textpositionsrc', 'textsrc', 'texttemplate', 'texttemplatesrc', 'transforms', 'type', 'uid', 'uirevision', 'unselected', 'visible', 'width', 'widthsrc', 'x', 'x0', 'xaxis', 'xcalendar', 'xhoverformat', 'xperiod', 'xperiod0', 'xperiodalignment', 'xsrc', 'y', 'y0', 'yaxis', 'ycalendar', 'yhoverformat', 'yperiod', 'yperiod0', 'yperiodalignm [... truncated]
A marker object has been specified, but markers is not in the mode
Adding markers to the mode...
Warning: Can't display both discrete & non-discrete data on same axis
Warning: 'scatter' objects don't have these attributes: 'box', 'points'
Valid attributes include:
'cliponaxis', 'connectgaps', 'customdata', 'customdatasrc', 'dx', 'dy', 'error_x', 'error_y', 'fill', 'fillcolor', 'groupnorm', 'hoverinfo', 'hoverinfosrc', 'hoverlabel', 'hoveron', 'hovertemplate', 'hovertemplatesrc', 'hovertext', 'hovertextsrc', 'ids', 'idssrc', 'legendgroup', 'legendgrouptitle', 'legendrank', 'line', 'marker', 'meta', 'metasrc', 'mode', 'name', 'opacity', 'orientation', 'selected', 'selectedpoints', 'showlegend', 'stackgaps', 'stackgroup', 'stream', 'text', 'textfont', 'textposition', 'textpositionsrc', 'textsrc', 'texttemplate', 'texttemplatesrc', 'transforms', 'type', 'uid', 'uirevision', 'unselected', 'visible', 'x', 'x0', 'xaxis', 'xcalendar', 'xhoverformat', 'xperiod', 'xperiod0', 'xperiodalignment', 'xsrc', 'y', 'y0', 'yaxis', 'ycalendar', 'yhoverformat', 'yperiod', 'yperiod0', 'yperiodalignment', 'ysrc', 'key', 'set', 'frame', 'transforms', '_isNestedKey', '_isSimpleKey', [... truncated]
Warning: 'scatter' objects don't have these attributes: 'box', 'points'
Valid attributes include:
'cliponaxis', 'connectgaps', 'customdata', 'customdatasrc', 'dx', 'dy', 'error_x', 'error_y', 'fill', 'fillcolor', 'groupnorm', 'hoverinfo', 'hoverinfosrc', 'hoverlabel', 'hoveron', 'hovertemplate', 'hovertemplatesrc', 'hovertext', 'hovertextsrc', 'ids', 'idssrc', 'legendgroup', 'legendgrouptitle', 'legendrank', 'line', 'marker', 'meta', 'metasrc', 'mode', 'name', 'opacity', 'orientation', 'selected', 'selectedpoints', 'showlegend', 'stackgaps', 'stackgroup', 'stream', 'text', 'textfont', 'textposition', 'textpositionsrc', 'textsrc', 'texttemplate', 'texttemplatesrc', 'transforms', 'type', 'uid', 'uirevision', 'unselected', 'visible', 'x', 'x0', 'xaxis', 'xcalendar', 'xhoverformat', 'xperiod', 'xperiod0', 'xperiodalignment', 'xsrc', 'y', 'y0', 'yaxis', 'ycalendar', 'yhoverformat', 'yperiod', 'yperiod0', 'yperiodalignment', 'ysrc', 'key', 'set', 'frame', 'transforms', '_isNestedKey', '_isSimpleKey', [... truncated]
All the features will be used.
Registered S3 methods overwritten by 'registry':
method from
print.registry_field proxy
print.registry_entry proxy
Error: processing vignette 'LipidSigR.Rnw' failed with diagnostics:
Running 'texi2dvi' on 'LipidSigR.tex' failed.
LaTeX errors:
! Package pdftex.def Error: File `images/exp_profilling_1.png' not found: using
draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/exp_profilling_2.png' not found: using
draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/exp_profilling_3.png' not found: using
draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/pca_biplot.png' not found: using draft
setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/pca_screeplot.png' not found: using dr
aft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/pca_variable.png' not found: using dra
ft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/pca_feature_contrib.png' not found: us
ing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/tsne_plot.png' not found: using draft
setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/UMAP_plot.png' not found: using draft
setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/corr_heatmap_1.png' not found: using d
raft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/corr_heatmap_2.png' not found: using d
raft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/exp_compo_by_lipidinfo_01.png' not fou
nd: using draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/exp_compo_by_lipidinfo_02.png' not fou
nd: using draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_species_dotchart_sig.png' not found
: using draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_species_maplot.png' not found: usin
g draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_species_volcano.png' not found: usi
ng draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! LaTeX Error: File `images/DEs_PCA_plot' not found.
See the LaTeX manual or LaTeX Companion for explanation.
Type H <return> for immediate help.
...
! Package pdftex.def Error: File `images/DEs_PCA_scree_plot.png' not found: usi
ng draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DEs_PCA_correlation_circle.png' not fo
und: using draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DEs_PCA_contribution.png' not found: u
sing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DEs_tsne_plot.png' not found: using dr
aft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DEs_UMAP_plot.png' not found: using dr
aft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/PLSDA_sample.plot.png' not found: usin
g draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/PLSDA_variable.plot.png' not found: us
ing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/Hclustering_all.lipid.png' not found:
using draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/Hclustering_sig.lipid.png' not found:
using draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/Sig_lipid_barplot.png' not found: usin
g draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/Sig_lipid_lollipop.png' not found: usi
ng draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/Sig_lipid_word.png' not found: using d
raft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/enrich_char_barplot.png' not found: us
ing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_char_barplot.png' not found: using
draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_char_barplot_sqrt.png' not found: u
sing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_char_trendplot.png' not found: usin
g draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_char_trendplot_sqrt.png' not found:
using draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_char_boxplot.png' not found: using
draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_sub_char_plot_2_1.png' not found: u
sing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_sub_char_plot_2_4.png' not found: u
sing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_sub_char_plot_2_2.png' not found: u
sing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_sub_char_plot_2_5.png' not found: u
sing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DE_sub_char_plot_2_3.png' not found: u
sing draft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DEc_PCA_plot.png' not found: using dra
ft setting.
See the pdftex.def package documentation for explanation.
Type H <return> for immediate help.
! Package pdftex.def Error: File `images/DEc_PCA_scree_plot.png' not found: usi
ng draft setting.
See the pdftex.def package documentation for explanation.
--- failed re-building ‘LipidSigR.Rnw’
SUMMARY: processing the following file failed:
‘LipidSigR.Rnw’
Error: Vignette re-building failed.
what is going on?
@vjcitn Hi, Sorry for the inconvenience. We have fixed the errors and updated the related files in our GitHub repository under the vignettes directory. The automatically generated files by devtools::build() can be found under /inst/doc. Thank you for reviewing our submission.
Thanks for doing that, the vignette looks nice. Now remove the inst/doc folder from the source repo, it is not supposed to be there.
@vjcitn Hello, I have removed the inst/doc folder from the source repository.Thanks for your kind reminder.
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @vjcitn,
I am one of contributors of LipidSigR.
To fix the "TIMEOUT" issue, we expect that we should firstly clone the LipidSigR from "git.bioconductor" to our folder and then commit/push the fixed codes onto "packages/LipidSigR". (If I did something wrong, please tell me. Appreciate your kindly help.)
Currently, we get problem of using git clone git@git.bioconductor.org:packages/LipidSigR
.
It returned:
Cloning into 'LipidSigR'...
Permission denied (publickey).
fatal: Could not read from remote repository.
Please read carefully https://contributions.bioconductor.org/git-version-control.html#push-to-github-bioc and ensure that your ssh key is registered. @lshep
actually i have no problem cloning ... is that really the command that is failing?
Please read the documentation and activate your GitCredentials account as specified a previous comment from the https://github.com/Bioconductor/Contributions/issues/2631#issuecomment-1243909768
Received a valid push on git.bioconductor.org; starting a build for commit id: b5853c5962477c4c986663f1bdd757e24815432d
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi, @lshep We have checked the build report and found the error messages of the maintainer not subscribed to the bioc-devel mailing list and registered at the support site. However, we have done both of them a few months ago. Wondering if is there still something we need to do. Thanks for your kind assistance.
@TMSWCChenglab
I do not see you registered at bioc-devel @ r-project.org mailing list. Please try again. There is normally a confirmation email that gets sent; sometimes this gets marked as spam.
I currently do see the email on the support site. Please add your package to the WatchTags.
@HelenaLC will be your reviewer and can provide additional comments. Cheers
Received a valid push on git.bioconductor.org; starting a build for commit id: d89332a5921a01090766d24d3cd4541c6a7b13ca
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
First round of comments below! Note that many are suggestions and not strictly required (e.g., "consider..."). Please comment back here with what has/not been addressed how/why not, or any comments regarding any needed clarification or questions you might have; happy to help/discuss. Cheers!
BiocManager::install()
.URL:
field pointing to the code repo,BugReports:
field for reporting issues (e.g., to Github)[ ] Please add details on the source information
or how the example data/*.RData
was generated; see here for details.
[ ] All objects in data
are documented, which is great. I noticed that the *.man
pages for corr_exp_data
and ML_exp_data
(perhaps also others?) are hard to read / overly verbose and might benefit from some simplification. E.g., corr_exp_data
lists 129 samples that are "a numeric vector"; this could be said in one line, e.g., 130 variables: feature
(a character vector) and sample1-129
(a numeric vector), or something like that.
[ ] Consider having a look at some of coding style guidelines here. While these are recommendations, it's nice to be consistent (e.g., <-
for variable assignment vs. =
for arguments; space after ,
and around logical operators; no space around argument =
s, etc.). The code is currently rather compact and difficult to read.
[ ] Connected to the above, I would encourage sticking to a 80-character line limit in both code and roxygen
headers for documentation. Especially when viewing code online, this greatly improved readability.
[ ] The recommended function length is 50 lines, 85 functions currently Exceed this. Of course, it is not always possible to adhere to his, however, there are some strategies that can help! First and foremost: functional programming, i.e., (very briefly put) dividing functions into smaller, re-usable and unit-testable sub-functions. To give an example, a popular approach for this is to keep all sub-functions/helpers for a given method in the same script, and otherwise have a utils
script for cases where sub-functions are used by many others; or, one can also think of a, say, utils-plotting
script (or similar for other groups of functions) that contains helpers for plotting that are used by all plotting functions. See also the next comment regarding the currently rather excessive function lengths; I think this could definitely be improved and also be used as a learning opportunity regarding coding practices!
[ ] Taking one example here, but this might apply to other functions/scripts as well: The code in Hclustering.R
is extremely repetitive. E.g.,
if
-statement of lines 315+ and 336+ and 444+, heatmaps are exactly the same 4 times, with the addition of add_col_labels
under a certain condition. Would it not be possible to define a "base" version of the heatmap with all common features, and then add to it depending on the subsequent if
s?if
-statement of lines 410+, max(nchar(row/colnames(exp.mat.sig))
is spelled out 7 times each. Would it not be easier to define nr/c <- max(nchar(row/colnames(exp.mat.sig))
and just check these variables?stop
statement is written out twice. Would it not be easier to define a stop_message <- "...text...text..."
and pass that to stop
?x
is computed vs. 10 lines where x
appears and is re-computed again and again). Of course, these are just recommendations, but I'd encourage getting in the habit of such practices to make maintenance and development much easier and efficient :)![ ] Avoid =
for assignment and use <-
instead; see comment above regarding coding guidelines.
[ ] Avoid sapply
and use vapply
(if the output type & dimension is constant) or lapply
(if it is not) instead; see here for details.
[ ] Avoid cat
and print
outside of show
methods; found in ML_final.R
and DE_sub_chat_2.R
. Specifically, non-show
methods should use message
to report progress, as these can be suppressed by the user. In addition, it is good practice to include a verbose = TRUE/FALSE
argument in relevant functions to let users control whether or not they want information printed to the console or not.
[ ] There are currently ~15 examples that take >5s (the recommended time for examples), with ~10 around 15s. I'd strongly encourage reducing these via (depending on use-case) downsampling input data, or running on only a subset of the data, or reducing the number of sub-examples, etc. From a user-perspective, it is generally nice to have examples run near-instant. Of course, there might be cases/methods where this is difficult to achieve, but if it is for some/most examples, that would be great!
[ ] The vignette looks nice, overall, but I found the figure text (tick/axis/legend labels etc.) too small/difficult to read throughout, even when zooming in. I think enlarging these would be worthwhile doing, and could easily be done with fig.width/height
and dpi
chunk options.
[ ] In the vignette, eval=FALSE
flags are generally not permitted as these i) defeat the purpose; and, ii) can result in confusion (e.g., I have frequently seen un-evaluated code-chunks that actually didn't run/gave errors, but this goes unnoticed via eval=FALSE
); see also the comment here. I would say the BiocManager::install
chunk is the only one where this flag is acceptable. Everywhere else, please remove it and either leave the executing & output as-is, or make use of the, e.g., message/warning/results/output/fig.show
chunk options (this will have the code executed, but let you control what's being included in the output document).
Received a valid push on git.bioconductor.org; starting a build for commit id: e45a6bc66b96dde5456a425244fa718ebaaee456
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: fb92beef550964bc884379902f1a0df62fdea91e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 9d889cacf57cfd9dbde51879134f76886769354e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1308a6f66d7fcdbbf3e3662d39b85c5abd5d6382
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ae71406051d208cb520b5367b90f6184b51d616e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: aad717fc8688555e11a7542692c1dc2052554001
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 57893c4761b908b08d85594b418eaa6669cad82e
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 47d839130950da4b289d2c393ab1098d3bde4e85
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ff0f1c927a8f9bbbe397ae81313fbd2cf07ad768
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: be93e999c18626a996097ae8abef00acd1c07012
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1c1dc718036b2bcd7409c090b1815fd6cd717f7b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 50c5be58130acf8a673da04e93ee8a643ba44fc5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0c21cc6772005c4ca9ab7e68cbe5dddb15ec15e0
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/LipidSigR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.