Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

EasyCellType #2687

Closed rx-li closed 2 years ago

rx-li commented 2 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 years ago

Hi @rx-li

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: EasyCellType
Title: Annotate cell types for scRNA-seq data.
Version: 0.99.0
Authors@R: c(
    person(given="Ruoxing", family="Li", email="ruoxingli@outlook.com", role=c("aut", "cre", "ctb")),
    person(given="Ziyi", family="Li", email="zli16@mdanderson.org", role="ctb"))
Description: We developed EasyCellType that can automatically examine the input marker lists obtained from existing software such as Seurat over the cell marker databases. Two quantification approaches to annotate cell types are provided: Gene set enrichment analysis (GSEA) and a fisher exact test combining with expression significance.
License: Artistic-2.0 
RoxygenNote: 7.2.0
Encoding: UTF-8
Depends: R (>= 4.1.0)
biocViews: SingleCell, Software, GeneExpression, GeneSetEnrichment
Imports: clusterProfiler, dplyr, forcats, ggplot2
Suggests: knitr, rmarkdown, testthat (>= 3.0.0)
VignetteBuilder: knitr
Config/testthat/edition: 3
bioc-issue-bot commented 2 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

jianhong commented 2 years ago

Package 'EasyCellType' Review

Thank you for submition your package to Bioconductor. The package passed check and build. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review.

The DESCRIPTION file

The NAMESPACE file

General package development

R code

rx-li commented 2 years ago

Thanks so much for your comments! Please find my responses below.

The DESCRIPTION file

The NAMESPACE file

General package development

R code

Documentation

Thanks again for your time!

jianhong commented 2 years ago

@rx-li,

Thank you for your answers. Could you please push the changes to git.bioconductor.org? Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

rx-li commented 2 years ago

@jianhong,

Hi! Thanks for letting me know. I have pushed the changes to git.bioconductor.org. Please let me know if you find any questions.

jianhong commented 2 years ago

@rx-li ,

Could you please also update your version number to trigger a builder? After that I can start my review.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 82155c757e493efb98dad1031906903705924a47

rx-li commented 2 years ago

@jianhong

Thanks for letting me know! I have updated the version number.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/EasyCellType to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

rx-li commented 2 years ago

I think I have subscribed to the bioc-devel mailing list...

jianhong commented 2 years ago

please try to bump up the version number again to confirm the issue.

Best!

Your sincerely,

Jianhong Ou

On Jul 13, 2022, at 12:36 PM, Ruoxing Li @.***> wrote:

 I think I have subscribed to the bioc-devel mailing list...

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0a9b4d07b9a55765df272504de77ffb754250b3d

rx-li commented 2 years ago

@jianhong Just bumped. Thanks so much.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/EasyCellType to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

jianhong commented 2 years ago

Package 'EasyCellType' Review

The package passed check and build. It is almost there.

The DESCRIPTION file

R code

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: abbf09a18e7243cd5e863ed64b26eda1fb26e4ae

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/EasyCellType to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

rx-li commented 2 years ago

Thanks so much for your comments. Please find my responses below.

The DESCRIPTION file

R code

Thanks for your help again, and please feel free to let me know if you have any other questions.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5e432245f19d434b1bd59aa5bbe58231678dda81

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/EasyCellType to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

jianhong commented 2 years ago

I got some warning during check:

 Variables with usage in documentation object 'cellmarker_tissue' but not in code:
  ‘cellmarker_tissue’

Could you please try to follow this direction to update your help files?

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 6f42c89cbe1988167c2deeaa735d41bd8f00c14a

rx-li commented 2 years ago

@jianhong Thanks for the insight. I just updated the files.

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/EasyCellType to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

rx-li commented 2 years ago

Thanks so much for your help on the package building.

I am wondering if you can provide a Bioconductor repo link of our package?

Best regards, Ruoxing

On Tue, Aug 16, 2022 at 8:06 AM bioc-issue-bot @.***> wrote:

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations http://contributions.bioconductor.org/reviewer-resources-overview.html.

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/2687#issuecomment-1216613405, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASV6ODT7NQ7PU5VDLOC4TNTVZOG63ANCNFSM5YD5WUDA . You are receiving this because you were mentioned.Message ID: @.***>

lshep commented 2 years ago

You can use a package short url that will default to the devel version package landing page until released and then always redirect to the most current released version: https://bioconductor.org/packages/EasyCellType . It is not activate yet but will be within the next 48 hours that also provides links to the git repo https://git.bioconductor.org/packages/EasyCellType ( or git@git.bioconductor.org:packages/EasyCellType for developers)

lshep commented 2 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/rx-li.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("EasyCellType"). The package 'landing page' will be created at

https://bioconductor.org/packages/EasyCellType

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.