Closed rx-li closed 2 years ago
Hi @rx-li
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: EasyCellType
Title: Annotate cell types for scRNA-seq data.
Version: 0.99.0
Authors@R: c(
person(given="Ruoxing", family="Li", email="ruoxingli@outlook.com", role=c("aut", "cre", "ctb")),
person(given="Ziyi", family="Li", email="zli16@mdanderson.org", role="ctb"))
Description: We developed EasyCellType that can automatically examine the input marker lists obtained from existing software such as Seurat over the cell marker databases. Two quantification approaches to annotate cell types are provided: Gene set enrichment analysis (GSEA) and a fisher exact test combining with expression significance.
License: Artistic-2.0
RoxygenNote: 7.2.0
Encoding: UTF-8
Depends: R (>= 4.1.0)
biocViews: SingleCell, Software, GeneExpression, GeneSetEnrichment
Imports: clusterProfiler, dplyr, forcats, ggplot2
Suggests: knitr, rmarkdown, testthat (>= 3.0.0)
VignetteBuilder: knitr
Config/testthat/edition: 3
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Thank you for submition your package to Bioconductor. The package passed check and build. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review.
Description
field is required.importFrom
instead of import all with import
.
@
or slot()
- accessors implemented and used.
::
is not suggested in source code unless you can make sure all the packages are imported. Please note that you need to manully double check the import items when you make any change in the DESCRIPTION file during development.
1:n
is not suggested in source code. Use seq_along
or seq.int
instead.
for
loops present.
[ ] Important: Remove unused code.
In file R/easyct.R:
In file R/plot_dot.R:
drop=FALSE
to avoid the reduction of dimension for matrices and arrays.
sessionInfo()
.motivation for submitting to Bioconductor
as part of the abstract/intro of the main vignette.Thanks so much for your comments! Please find my responses below.
importFrom
instead of import
.@importFrom rlang .data
to address this note. But there are still 6 objects that been pointed when running BiocCheck. I checked the variables, "spe", "organ", "celltype" and "entrezid" are from dataset loaded with data(). "ID" and "cluster" are from the porcess_results
function in the package. @
in file R/process_results.R. Changed to enrich.re.l <- lapply(results.c, function(x) x[seq(dim(x)[1]), drop=FALSE])
. ::
has been removed.1:n
has been changed to seq.int
.for
loops to lapply
.drop=FALSE
:
drop=FALSE
for split
.
At line 85 and 88 (line 61 and 64 in the previous version), I would like to have a dimension reduction. So I did not include drop=FALSE
here. drop=FALSE
at line 39, 67 and 70 (line 26, 54 and 57 in the previous version).drop=FALSE
at line 22 (line 16 in the previous version).drop=FALSE
At line 36 and 52 ( line 25 and 43 in the previous version), I did not include drop=FALSE
here since I would like to reduce the data frame to a vector. sessionInfo()
right before the reference. motivation for submitting to Bioconductor
under the introduction of the main vignette.data/
. All chunks in vignette should be runnable. But it might need some time to finish the analysis. Thanks again for your time!
@rx-li,
Thank you for your answers. Could you please push the changes to git.bioconductor.org? Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
@jianhong,
Hi! Thanks for letting me know. I have pushed the changes to git.bioconductor.org. Please let me know if you find any questions.
@rx-li ,
Could you please also update your version number to trigger a builder? After that I can start my review.
Received a valid push on git.bioconductor.org; starting a build for commit id: 82155c757e493efb98dad1031906903705924a47
@jianhong
Thanks for letting me know! I have updated the version number.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/EasyCellType
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
I think I have subscribed to the bioc-devel mailing list...
please try to bump up the version number again to confirm the issue.
Best!
Your sincerely,
Jianhong Ou
On Jul 13, 2022, at 12:36 PM, Ruoxing Li @.***> wrote:
I think I have subscribed to the bioc-devel mailing list...
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0a9b4d07b9a55765df272504de77ffb754250b3d
@jianhong Just bumped. Thanks so much.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/EasyCellType
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
The package passed check and build. It is almost there.
[ ] Note: try to use match.arg
or stopifnot
to replace the codes 'if(!xxx %in% yyy)' for arguments check.
[ ] NOTE: Consider clarifying how 8 object(s) are initialized. Maybe they are part of a data set loaded with data(), or perhaps part of an object referenced in with() or within(). easyct: no visible binding for global variable ‘spe’ easyct: no visible binding for global variable ‘organ’ easyct: no visible binding for global variable ‘celltype’ easyct: no visible binding for global variable ‘entrezid’ plot_bar : plot_one_cluster: no visible binding for global variable ‘ID’ plot_dot: no visible binding for global variable ‘cluster’ plot_dot: no visible binding for global variable ‘ID’ process_results: no visible binding for global variable ‘cluster’ Undefined global functions or variables: ID celltype cluster entrezid organ spe
Received a valid push on git.bioconductor.org; starting a build for commit id: abbf09a18e7243cd5e863ed64b26eda1fb26e4ae
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/EasyCellType
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Thanks so much for your comments. Please find my responses below.
In file R/easyct.R: Modified all codes for parameter checking. Using stopifnot
now.
In file R/plot_bar.R: Modified all codes for parameter checking. Using stopifnot
now.
In file R/plot_dot.R: Modified all codes for parameter checking. Using stopifnot
now.
In file R/process_results.R: Modified all codes for parameter checking. Using stopifnot
now.
In file R/test_fisher.R: Modified all codes for parameter checking. Using stopifnot
now.
The NOTE has been addressed by using .data
.
Thanks for your help again, and please feel free to let me know if you have any other questions.
Received a valid push on git.bioconductor.org; starting a build for commit id: 5e432245f19d434b1bd59aa5bbe58231678dda81
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/EasyCellType
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
I got some warning during check:
Variables with usage in documentation object 'cellmarker_tissue' but not in code:
‘cellmarker_tissue’
Could you please try to follow this direction to update your help files?
Received a valid push on git.bioconductor.org; starting a build for commit id: 6f42c89cbe1988167c2deeaa735d41bd8f00c14a
@jianhong Thanks for the insight. I just updated the files.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/EasyCellType
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
Thanks so much for your help on the package building.
I am wondering if you can provide a Bioconductor repo link of our package?
Best regards, Ruoxing
On Tue, Aug 16, 2022 at 8:06 AM bioc-issue-bot @.***> wrote:
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations http://contributions.bioconductor.org/reviewer-resources-overview.html.
— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/2687#issuecomment-1216613405, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASV6ODT7NQ7PU5VDLOC4TNTVZOG63ANCNFSM5YD5WUDA . You are receiving this because you were mentioned.Message ID: @.***>
You can use a package short url that will default to the devel version package landing page until released and then always redirect to the most current released version: https://bioconductor.org/packages/EasyCellType . It is not activate yet but will be within the next 48 hours that also provides links to the git repo https://git.bioconductor.org/packages/EasyCellType ( or git@git.bioconductor.org:packages/EasyCellType for developers)
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/rx-li.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("EasyCellType")
. The package 'landing page' will be created at
https://bioconductor.org/packages/EasyCellType
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x ] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.