Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

signifinder #2701

Closed SPirrotta closed 2 years ago

SPirrotta commented 2 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 years ago

Hi @SPirrotta

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: signifinder
Type: Package
Title: A collection of signatures
Version: 0.99.0
Authors@R: c(person("Stefania", "Pirrotta", role = c("cre", "aut"),
          email = "stefania.pirrotta@studenti.unipd.it"),
   person("Enrica", "Calura", role = "aut", 
          email = "enrica.calura@unipd.it"))
Description: signifinder is an R package for computing and exploring a 
  compendium of tumor signatures. It allows computing signatures
  scores providing the only gene expression values and returns a
  single-sample score. Currently, signifinder contains 46 distinct 
  signatures collected from the literature.
License: AGPL-3
Imports: ggplot2, org.Hs.eg.db, patchwork, AnnotationDbi, BiocGenerics, 
    ComplexHeatmap, DGEobj.utils, GSVA, IRanges, SummarizedExperiment, 
    consensusOV, dplyr, ensembldb, ggridges, grid, magrittr, matrixStats, 
    maxstat, methods, openair, parallel, TxDb.Hsapiens.UCSC.hg19.knownGene, 
    TxDb.Hsapiens.UCSC.hg38.knownGene, stats, survival, survminer, viridis
Encoding: UTF-8
RoxygenNote: 7.2.0
Depends: R (>= 4.2.0)
LazyData: true
Suggests: BiocStyle, knitr, testthat (>= 3.0.0), edgeR, limma
Config/testthat/edition: 3
VignetteBuilder: knitr
biocViews: GeneExpression
bioc-issue-bot commented 2 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/signifinder to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 2 years ago

@nilseling Please take the lead on this review. thank you

nilseling commented 2 years ago

Thanks @lshep, will do and post my review soon.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 56608924af9d72e334203b8c6ff8db45ae8de044

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/signifinder to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 1bc39cad10ce6a0de96fd5dc86c0f1fa57d7d5cf

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/signifinder to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nilseling commented 2 years ago

Hi @SPirrotta,

thanks for submitting signifinder. In general it's a nicely written package. There are a few things that need to be addressed/clarified:

General comments

Documentation

General comments:

Vignette:

Description
It creates survival curves from either a formula (e.g. the Kaplan-Meier), a previously fitted Cox model, or a previously fitted accelerated failure time model.

Man pages:

Value
A SummarizedExperiment object in which the Epithelial and Mesenchymal scores are added in the colData section.
data    
An object of type SummarizedExperiment coming from signatures functions. Th function takes as input a matrix where each row represents a signature and each column represent a samples.
Description
Given a matrix of multiple signatures, the function gives the opportunity to observe signatures correlates between each other.

data    
An object of type SummarizedExperiment coming from signatures functions.

The DESCRIPTION file

The NEWS file

Package data

Unit tests

signifinder Coverage: 53.84%
R/Plots.R: 0.00%
R/UtilityFunctions.R: 62.36%
R/SignatureFunction.R: 75.82%
R/fakeData.R: 77.78%

R code

nilseling commented 2 years ago

Hi @SPirrotta, we would like to continue with the revision process and usually expect changes to the package within 2-3 weeks. Would you be able to post the requested changes soon?

SPirrotta commented 2 years ago

Hi Nils, I have not yet been able to complete all the changes to the package. I will publish the ones I have already made today or tomorrow. Then, I’ll send the others as soon as I can. Thank you.

nilseling commented 2 years ago

Hi @SPirrotta I'm closing this for now. Please re-open once you are ready to submit the requested changes.

bioc-issue-bot commented 2 years ago

This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.

Thank you for your interest in Bioconductor.

SPirrotta commented 2 years ago

Hi, I completed all the requested changes:

General comments

Documentation

General comments:

Vignette:

Man pages:

The DESCRIPTION file

The NEWS file

Package data

Unit tests

R code

I am ready now to reopen the issue.

nilseling commented 2 years ago

Hi @SPirrotta,

thanks for submitting the changes. I'll reopen the issue and go through the package next week.

bioc-issue-bot commented 2 years ago

Dear @SPirrotta ,

We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.

nilseling commented 2 years ago

Hi @SPirrotta could you please push your changes to Bioconductor to trigger a new build?

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: f160d797071e559f30fb1546e30d281c9e85d986

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/signifinder to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: bbe878b72544aed63f5e020433db7d86d5c55d10

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/signifinder to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nilseling commented 2 years ago

Hi @SPirrotta

thanks for adding the changes. I have ticked off the points that have been addressed. However, there are still a couple of things that need to be addressed:

signifinder Coverage: 63.55%
R/Plots.R: 38.40%
R/UtilityFunctions.R: 71.16%
R/SignatureFunction.R: 75.58%
nilseling commented 2 years ago

Hi @SPirrotta I just quickly wanted to check in if you'd like to address the last couple of changes before the deadline on the 26.10. next week?

SPirrotta commented 2 years ago

Hi @nilseling, I am working on it. I should be able to submit everything before the 26th.

nilseling commented 2 years ago

Hi @SPirrotta thanks for the update. Keep in mind that that package needs to be accepted before the 26.10 (https://bioconductor.org/developers/release-schedule/). I'll do my best to directly have a final check but will need a bit of buffer time.

bioc-issue-bot commented 2 years ago

Received a valid push on git.bioconductor.org; starting a build for commit id: b18ba7312b63d779a447d6be4694251534416db6

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/signifinder to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

SPirrotta commented 2 years ago

Hi @nilseling , here you can see my last changes:

Thank you.

nilseling commented 2 years ago

Hi @SPirrotta

thanks for making these changes! I will now accept the package. One thing that I noticed for future reference is that

if (is(userdata)[1] %in% c(
            "SpatialExperiment",
            "SummarizedExperiment",
            "SingleCellExperiment")) {

can be simply replaced by

if (is(userdata, "SummarizedExperiment")) {

as SingleCellExperiment and SpatialExperiment inherit from SummarizedExperiment.

bioc-issue-bot commented 2 years ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

SPirrotta commented 2 years ago

Hi @nilseling, thank you so much for the help and advice!

lshep commented 2 years ago

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/SPirrotta.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("signifinder"). The package 'landing page' will be created at

https://bioconductor.org/packages/signifinder

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.