Closed SPirrotta closed 2 years ago
Hi @SPirrotta
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: signifinder
Type: Package
Title: A collection of signatures
Version: 0.99.0
Authors@R: c(person("Stefania", "Pirrotta", role = c("cre", "aut"),
email = "stefania.pirrotta@studenti.unipd.it"),
person("Enrica", "Calura", role = "aut",
email = "enrica.calura@unipd.it"))
Description: signifinder is an R package for computing and exploring a
compendium of tumor signatures. It allows computing signatures
scores providing the only gene expression values and returns a
single-sample score. Currently, signifinder contains 46 distinct
signatures collected from the literature.
License: AGPL-3
Imports: ggplot2, org.Hs.eg.db, patchwork, AnnotationDbi, BiocGenerics,
ComplexHeatmap, DGEobj.utils, GSVA, IRanges, SummarizedExperiment,
consensusOV, dplyr, ensembldb, ggridges, grid, magrittr, matrixStats,
maxstat, methods, openair, parallel, TxDb.Hsapiens.UCSC.hg19.knownGene,
TxDb.Hsapiens.UCSC.hg38.knownGene, stats, survival, survminer, viridis
Encoding: UTF-8
RoxygenNote: 7.2.0
Depends: R (>= 4.2.0)
LazyData: true
Suggests: BiocStyle, knitr, testthat (>= 3.0.0), edgeR, limma
Config/testthat/edition: 3
VignetteBuilder: knitr
biocViews: GeneExpression
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/signifinder
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@nilseling Please take the lead on this review. thank you
Thanks @lshep, will do and post my review soon.
Received a valid push on git.bioconductor.org; starting a build for commit id: 56608924af9d72e334203b8c6ff8db45ae8de044
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/signifinder
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1bc39cad10ce6a0de96fd5dc86c0f1fa57d7d5cf
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/signifinder
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @SPirrotta,
thanks for submitting signifinder
. In general it's a nicely written package. There are a few things that need to be addressed/clarified:
IPSOVSign
function as it does not contain functional code .
(e.g., .myFunction
)Seurat
objects. Please be consistent when supporting Seurat
objects across the package.availableSignatures
that lists the data transformation step.fakeData
into UtilityFunctions.R
General comments:
?signifinder
Vignette:
signifinder
eval=FALSE
knit::kable
and echo=FALSE
survivalSignPlot
function as the description states:Description
It creates survival curves from either a formula (e.g. the Kaplan-Meier), a previously fitted Cox model, or a previously fitted accelerated failure time model.
Man pages:
nametype
are allowedclass
as the input object.Value
A SummarizedExperiment object in which the Epithelial and Mesenchymal scores are added in the colData section.
heatmapSignPlot
function contains an unclear description of the data
argument. It appears the second sentence is obsolete? data
An object of type SummarizedExperiment coming from signatures functions. Th function takes as input a matrix where each row represents a signature and each column represent a samples.
data
argument in the documentation of the correlationSignPlot
function Description
Given a matrix of multiple signatures, the function gives the opportunity to observe signatures correlates between each other.
data
An object of type SummarizedExperiment coming from signatures functions.
LazyData:
entry should be set to false or removedBugReports
and URL
field.NEWS
fileovse
dataset is not properly documented. Please provide instructions for its creation, source information e.g. in form of a citation and its entries. ovse
is empty. Please consider providing an informative name such as counts
.R/sysdata.rda
need to be documented in inst/script/
. It can be executable code, pseudo code, or a text description and needs to describe how the variables were generated and what they contain.signifinder Coverage: 53.84%
R/Plots.R: 0.00%
R/UtilityFunctions.R: 62.36%
R/SignatureFunction.R: 75.82%
R/fakeData.R: 77.78%
fakeData
can be directly accessed without the need to call it via signifinder:::fakeData
::
for accessing functions and import all needed functions via @importFrom
Hi @SPirrotta, we would like to continue with the revision process and usually expect changes to the package within 2-3 weeks. Would you be able to post the requested changes soon?
Hi Nils, I have not yet been able to complete all the changes to the package. I will publish the ones I have already made today or tomorrow. Then, I’ll send the others as soon as I can. Thank you.
Hi @SPirrotta I'm closing this for now. Please re-open once you are ready to submit the requested changes.
This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.
Thank you for your interest in Bioconductor.
Hi, I completed all the requested changes:
General comments:
Vignette:
Man pages:
I am ready now to reopen the issue.
Hi @SPirrotta,
thanks for submitting the changes. I'll reopen the issue and go through the package next week.
Dear @SPirrotta ,
We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.
Hi @SPirrotta could you please push your changes to Bioconductor to trigger a new build?
Received a valid push on git.bioconductor.org; starting a build for commit id: f160d797071e559f30fb1546e30d281c9e85d986
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/signifinder
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: bbe878b72544aed63f5e020433db7d86d5c55d10
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/signifinder
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @SPirrotta
thanks for adding the changes. I have ticked off the points that have been addressed. However, there are still a couple of things that need to be addressed:
vapply
. For example, in line 1208 in SignatureFunctions.R
the vapply
function expects an integer vector of length 1. However, when running the examples, a vector of length 40 is returned..getMatrix
function, the userdata <- as.matrix(assay(userdata))
call defaults to the first assay entry in the object. Is this intended or do you want to give the user the choice to specify which assay to use?is
instead of class
. E.g. in the .getMatrix
function.transformationStep
column.survivalSignPlot
function is computed. DESCRIPTION
file the BugReports
entry should be https://github.com/CaluraLab/signifinder/issues
and the URL entry should be https://github.com/CaluraLab/signifinder
NEWS.Rd
file does not match the package version in DESCRIPTION
.ovse
dataset. All relevant information should be contained in the data.R
documentation. E.g. it is not clear that the data were extracted from TCGA.signifinder Coverage: 63.55%
R/Plots.R: 38.40%
R/UtilityFunctions.R: 71.16%
R/SignatureFunction.R: 75.58%
[x] Please make sure to import functions via @importFrom
rather than pkg::function
. There are still quite a few cases (e.g. AnnotationDbi::mapIds
, org.Hs.eg.db::org.Hs.eg.db
, viridis::magma
) where this is not the case.
Please let me know once you have addressed these points and we can proceed with the acceptance.
Hi @SPirrotta I just quickly wanted to check in if you'd like to address the last couple of changes before the deadline on the 26.10. next week?
Hi @nilseling, I am working on it. I should be able to submit everything before the 26th.
Hi @SPirrotta thanks for the update. Keep in mind that that package needs to be accepted before the 26.10 (https://bioconductor.org/developers/release-schedule/). I'll do my best to directly have a final check but will need a bit of buffer time.
Received a valid push on git.bioconductor.org; starting a build for commit id: b18ba7312b63d779a447d6be4694251534416db6
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/signifinder
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Hi @nilseling , here you can see my last changes:
Thank you.
Hi @SPirrotta
thanks for making these changes! I will now accept the package. One thing that I noticed for future reference is that
if (is(userdata)[1] %in% c(
"SpatialExperiment",
"SummarizedExperiment",
"SingleCellExperiment")) {
can be simply replaced by
if (is(userdata, "SummarizedExperiment")) {
as SingleCellExperiment
and SpatialExperiment
inherit from SummarizedExperiment
.
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
Hi @nilseling, thank you so much for the help and advice!
The master branch of your GitHub repository has been added to Bioconductor's git repository.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/SPirrotta.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("signifinder")
. The package 'landing page' will be created at
https://bioconductor.org/packages/signifinder
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.