Bioconductor / Contributions

Contribute Packages to Bioconductor
131 stars 33 forks source link

iNETgrate #2979

Closed habilzare closed 1 year ago

habilzare commented 1 year ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 year ago

Hi @habilzare

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: iNETgrate
Type: Package
Title: Integrates DNA methylation data with gene expression in a single gene network
Version: 0.99.12
Date: 2022-06-01
Authors@R: c(
    person("Isha", "Mehta", role = "aut",
    comment = c(ORCID = "0000-0002-6009-0787")),
    person("Ghazal", "Ebrahimi", role = "aut"),
    person("Hanie", "Samimi", role = "aut"),
    person("Habil", "Zare", email = "zare@u.washington.edu",
    role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5902-6238")))
biocViews: GeneExpression, RNASeq, DNAMethylation,
    NetworkInference, Network, GraphAndNetwork, BiomedicalInformatics, 
    SystemsBiology, Transcriptomics, Classification, Clustering, 
    DimensionReduction, PrincipalComponent, mRNAMicroarray,
    Normalization, GenePrediction, KEGG, Survival
Depends: R (>= 3.5.0), BiocStyle (>= 2.18.1)
Description: The iNETgrate package provides functions to build a correlation network in which nodes
    are genes. DNA methylation and gene expression data are integrated to define the
    connections between genes. This network is used to identify modules (clusters) of
    genes. The biological information in each of the resulting modules is represented by an
    eigengene. These biological signatures can be used as features e.g., for classification
    of patients into risk categories. The resulting biological signatures are very robust
    and give a holistic view of the underlying molecular changes.
Imports: SummarizedExperiment, GenomicRanges (>= 1.24.1), stats, WGCNA, grDevices, 
    graphics, survival, igraph, Pigengene (>= 1.19.26), Homo.sapiens, glmnet, 
    caret, gplots, minfi, TCGAbiolinks, matrixStats, Rfast, tidyr, tidyselect, utils
Suggests: knitr, org.Hs.eg.db, org.Mm.eg.db, IlluminaHumanMethylation450kanno.ilmn12.hg19,
    AnnotationDbi
License: GPL-3
BugReports: https://github.com/Bioconductor/BiocManager/issues
VignetteBuilder: knitr
NeedsCompilation: no
vjcitn commented 1 year ago

I am passing this for review but I think there are a couple of issues you might want to get a jump on. I could not build the whole vignette, I am not sure why. You should use R markdown instead of Sweave markup. I saw

Keeping only 71 entities in dnam because ratio is set to 1 . 
The correlation plots are saved at: 
 /home/stvjc/SUBMISSIONS/MAR22/iNETgrate/vignettes/iNETgrateRes/plots 
Combining filtered data...
unionGenes set size: 77 
Warning messages:
1: In filter.low.cor(Data = genExpr, survival = survival, whichData = "expression",  :
  Both minCor and ratio are passed as inputs!! Function will use both thresholds.
2: In stats::cor(t(Data[, common]), as.numeric(deathTime[common]),  :
  the standard deviation is zero
3: In stats::cor(t(Data[, names(sample2vital)]), sample2vital, method = "spearman",  :
  the standard deviation is zero

and those warnings will need to be repaired. Please run R CMD check on your package and get it to zero errors and zero warnings. Finally, why are plots being written to disk? Thank you

habilzare commented 1 year ago

Thanks vjcitn,

You should use R markdown instead of Sweave markup. Is this a Bioconductor requirement?

During the analysis, plots are written to disk for the user to look at after the analysis is done. There are too many plots to look at during the analysis.

bioc-issue-bot commented 1 year ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nilseling commented 1 year ago

Hi @habilzare,

Thanks for submitting the package. Could you please address the issues of the build report while I'll take a couple of days to review the package?

habilzare commented 1 year ago

Hi Nils, Thanks for accepting to review our package. I'll address the issues and give you updates.

habilzare commented 1 year ago

Nils, I get the following error when I try to push changes to Bioconductor repository. Can you help with this?

G1100154022:iNETgrate habil$ git push upstream devel FATAL: W any packages/iNETgrate h.zare DENIED by fallthru (or you mis-spelled the reponame) fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

I get the same error with: G1100154022:iNETgrate habil$ git push upstream main:devel

I am using SSH as shown below:

G1100154022:iNETgrate habil$ git remote -v origin git@github.com:habilzare/iNETgrate.git (fetch) origin git@github.com:habilzare/iNETgrate.git (push) upstream git@git.bioconductor.org:packages/iNETgrate.git (fetch) upstream git@git.bioconductor.org:packages/iNETgrate.git (push)

nilseling commented 1 year ago

Hi @lshep Could you potentially help with this? Thanks in advance!

lshep commented 1 year ago

There was a mismatch on the username for access. Could you please try again.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 62282ee76487ae59a10f0533cf5f40bae4da48c1

habilzare commented 1 year ago

My push worked fine, thanks Ishep!

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

habilzare commented 1 year ago

Hi @lshep

I cannot reproduce the check error on my macOS. Maybe it is due to older or different versions of TCGAbiolinks or dplyr on the Bioconductor servers. How can I figure out which versions of these packages are used during the check?

Also, I looked in CRAN but couldn't find "R Under development (unstable) (2023-03-16 r83996)", which was used to check my package.

lshep commented 1 year ago

The Bioconductor build system will always use whatever is available for download from Biocondcutor and CRAN repositories. Please make sure you are using R 4.3 and Bioc 3.17 to test. You can do a BiocManager::install / BiocManager::valid to make sure you have a valid installation and packages match what should be expected (and would be on the build system)

nilseling commented 1 year ago

Hi @habilzare

I was able to reproduce the errors on R 4.3 and Bioc 3.17, could you please test the package locally and address these issues. As Vince previously suggested, I would recommend to use R markdown to create the vignette. At the moment I'm still having issued building the vignette.

habilzare commented 1 year ago

@nilseling and @lshep,

How can I install the dependency TCGAbiolinks package on Bioc 3.17? I have now R 4.3 (i.e., "R version 4.3.0 alpha (2023-04-04 r84161)"), and Bioc 3.17. I got the following warning when I tried to install TCGAbiolinks. I tried both devel and release.

> BiocManager::install("TCGAbiolinks") 'getOption("repos")' replaces Bioconductor standard repositories, see 'help("repositories", package = "BiocManager")' for details. Replacement repositories: CRAN: https://mirrors.nics.utk.edu/cran Bioconductor version 3.17 (BiocManager 1.30.20), R 4.3.0 alpha (2023-04-04 r84161) Installing package(s) 'TCGAbiolinks' Warning message: package ‘TCGAbiolinks’ is not available for Bioconductor version '3.17'

A version of this package for your version of R might be available elsewhere, see the ideas at https://cran.r-project.org/doc/manuals/r-patched/R-admin.html#Installing-packages

habilzare commented 1 year ago

The error should be reproduced using the following commands, which has nothing to do with my package. I can run this fine on Bioc 16, but not Bioc 17:

query <- TCGAbiolinks::GDCquery(project="TCGA-LAML", data.category="Clinical", file.type="xml") TCGAbiolinks::GDCdownload(query, directory=".") clinical <- TCGAbiolinks::GDCprepare_clinic(query,directory=".",clinical.info="patient")

nilseling commented 1 year ago

Hi @habilzare

I can't tell why TCGAbiolinks is not available on Bioc 3.17 or where the differences in functionality are coming from. You could reach out on the Bioc mailing list and ask for help. For debugging you can install the development version from Github which seems to be the same version as the one on Bioc devel.

lshep commented 1 year ago

We updated R on the build system a few days ago and it looks like TCGAbiolinks has yet to build/check cleaning so likely the reason it might have not been available. I expect that will resolve in a day or two

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 268b822e7b7465db5124182ba407b18b677954a0

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fe7f33bb5279ce63f5c7afe1e6b4c76a4717181d

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: af6e83a7e47fe249c4ca6f96c8e6cd71cf6f2563

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: c98360bf78a5e3431596e73f6f42e3967d715208

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

habilzare commented 1 year ago

It takes only 12 minutes on my Macbook to check. One difference is that I do not use --no-resave-data when I build the package. Could it be the reason of the significantly higher check time on Bioconductor (it does not give me this warning at the check time: * checking data for ASCII and uncompressed saves ... WARNING)?

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9ab192b6f22fc134c70e6f4a1bc20dd9fb63faae

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nilseling commented 1 year ago

Hi @habilzare

I had the first pass through the package. Please have a look at my comments below and let me know how you address them. The biggest issue at the moment is that I can't build the vignette. The package installs but I can't find the vignette in the package and can't build it due to knit and LaTeX issues. It would be a huge help if you could use Rmarkdown (as recommended) so that I better understand the functionality of the package.

General package development

    * NOTE: Avoid 'cat' and 'print' outside of 'show' methods
    * NOTE: Avoid the use of 'paste' in condition signals
    * WARNING: Remove browser() statements (found 2 times)
    * NOTE: Avoid 'suppressWarnings'/'*Messages' if possible (found 1 times)
    * NOTE: Usage of dontrun{} / donttest{} tags found in man page examples. 9% of man
      pages use at least one of these tags.
    * NOTE: Use donttest{} instead of dontrun{}.

The DESCRIPTION file

The NAMESPACE file

Package data

checking examples with --run-donttest ... [309s/306s] ERROR
  Running examples in ‘iNETgrate-Ex.R’ failed
  The error most likely occurred in:

  > base::assign(".ptime", proc.time(), pos = "CheckExEnv")
  > ### Name: toyCleanedAml
  > ### Title: A subset of cleaned TCGA-LAML data
  > ### Aliases: toyCleanedAml
  > ### Keywords: datasets
  > 
  > ### ** Examples
  > 
  > 
  > 
  > ## This dataset can be regenerated using the following commands,
  > ##which can take some time to run.
  > ## No test: 
  > dataProject <- "TCGA-LAML"
  > dataPath <- file.path(getwd(), "data", dataProject)
  > dir.create(savePath)
  Error: object 'savePath' not found
  Execution halted

Documentation

Writing to file iNETgrate_inference.tex
Processing code chunks with options ...
Error in match.arg(options$results, c("verbatim", "tex", "hide")) : 
  'arg' should be one of “verbatim”, “tex”, “hide”
Calls: <Anonymous> -> SweaveParseOptions -> check -> match.arg
Execution halted

Please consider using a .Rmd vignette instead so that I can understand the functionality of the package.

Unit tests

habilzare commented 1 year ago

Hi @nilseling , Thanks for reviewing my package and your comments. I'll let you know when I am done with addressing them.

The vignette is built well on the Bioconductor server. It will take some time for me to learn R markdown and I am not sure the mathematical formulas will be shown as good as the current Sweave vignette. So, I prefer to continue using Sweave.

Are you using RStudio? It is buggy. You should be able to make the vignette using the following command:

R CMD Sweave --pdf iNETgrate/vignettes/iNETgrate_inference.Rnw

https://tex.stackexchange.com/a/125328

nilseling commented 1 year ago

Hi @habilzare

thanks, that worked. Here are the last comments on the vignette:

## Warning in stats::cor(t(Data[, common]), as.numeric(deathTime[common]),
: the standard deviation is zero

be avoided by properly pre-processing the data?

Please also keep in mind that the package should be accepted until April 19th.

nilseling commented 1 year ago

Hi @habilzare

just a reminder that if the package should be released in the next round, it should be accepted on Wednesday. No rush with the revisions, the package can always be included in the next release.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 719b42e11a03cf8e2c11de302553e848636b2051

habilzare commented 1 year ago

Hi @nilseling , I am working hard for this package to be accepted by April 19. I addressed most of your comments in Version 0.99.50. I'll respond to your comments and explain what I did for each in a few hours. Thanks!

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

habilzare commented 1 year ago

Hi @nilseling,

Please see my responses to the comments you send me on April 11th below in bold.

General package development

  • [ ] I would not recommend to write files into the current working directory (getwd()) but (if needed) use a temporary directory (tempdir()).

Done.

  • [ ] Please address the following BiocCheck NOTEs and WARNINGs:

    * NOTE: Avoid 'cat' and 'print' outside of 'show' methods

I removed most of them. I believe the few that are left are legitimate e.g., at high levels of verbosity, I use ‘print’ to give information about the output of the ‘table’ command to the user. It cannot be easily replaced with ‘message’

* NOTE: Avoid the use of 'paste' in condition signals

Done.

  • WARNING: Remove browser() statements (found 2 times) These two browsers will be turned only on the debug mode so that the developer can look into the situation. Please let me know if there is a better way to do this.
  • NOTE: Avoid 'suppressWarnings'/'*Messages' if possible (found 1 times) The AnnotationDbi::select() function prints a message per each query. There are thousands of queries in an iNETgrate run and these messages would make the standard output too busy. Unfortunately, there is no other way to silence this function.
  • NOTE: Usage of dontrun{} / donttest{} tags found in man page examples. 9% of man pages use at least one of these tags. a) In toyRawAml.Rd and toyCleanedAml.Rd, I have code in the example section to document how these toy data can be reproduced. I used \donttest{} for this code because running them takes a long time and it is unnecessary to test this process in every check.
    b) I used \donttest{} in download.data.Rd because new TCGAbiolinks is buggy (2.24.3 < Version <= 2.27.2). This function is not a major part of the iNETgrate pipeline and data can be provided in other ways.
  • NOTE: Use donttest{} instead of dontrun{}. Done.
## The DESCRIPTION file
* [ ]  It won't be necessary to fix the package versions for `BiocStyle`, `GenomicRanges` and `Pigengene` as the latest versions will be used as dependencies.
**Users may build and install iNETgrate in some other ways than Bioc. Lower versions of these packages would cause issues.**

* [ ]  Either remove R as dependency or set it to `4.3`.
**Done**.

* [ ]  I believe you can move `BiocStyle` from `Depends` to `Suggests`.
**With an old version of BiocStyle, building iNETgrate will be problematic and that is very difficult to debug. So, I prefer not to allow building without a proper version of BiocStyle.**

## The NAMESPACE file
* [ ]  Please avoid function names in the form of `function.name` as these indicate S3 generics and use `functionName` or `function_name` instead.
**Changed to camelCase.**

## Package data
* [ ]  Please check the example for `toyCleanedAml` - the variable `savePath` is not defined.

checking examples with --run-donttest ... [309s/306s] ERROR Running examples in ‘iNETgrate-Ex.R’ failed The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")

Name: toyCleanedAml

Title: A subset of cleaned TCGA-LAML data

Aliases: toyCleanedAml

Keywords: datasets

** Examples

This dataset can be regenerated using the following commands,

which can take some time to run.

No test:

dataProject <- "TCGA-LAML" dataPath <- file.path(getwd(), "data", dataProject) dir.create(savePath) Error: object 'savePath' not found Execution halted

Fixed.

Documentation

  • [ ] Please add examples for best.inetgrator, compute.inetgrator, infer.eigengenes,

As mentioned in the docs, examples are included in analyzeSurvival, . Running this example takes a long time and repeating them would result in timeout at check time.

Unit tests

  • [ ] It is highly recommended to add unit tests covering the main funtionality of the package. All functions have examples, which can be used as tests.
nilseling commented 1 year ago

Hi @habilzare

could you please update your Github repository so that I can have a look at the changes? For now, please make sure that all code chunks in the vignette are run and please remove the browser() statements in the code. For debugging you would use the debug function.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9d002a0ae7f432317175670c34416fbda0a5e29c

habilzare commented 1 year ago

Hi @nilseling, I pushed Version 0.99.52 to Bioc and GitHub.

The last two examples in the vignette are run. The first one, iNETgrate(), is just a wrapper for the whole pipeline and running it would take 2 minutes. Therefore, I did not run it to save time. The example is the same in the docs, which is run at check time.

I'll update again later today to remove browser() and some other things.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5786b2735b85d68e8fc927b33be73203807266f2

habilzare commented 1 year ago

Hi @nilseling , I think I responded all of your comments now. Please let me know if I missed anything that does not allow the acceptance of the package today. See some of my latest changes in bold below.

  • [ ] ...please remove the browser() statements in the code.

Done.

  • [ ] I would replace the devel installation with BiocManager::install("habilzare/iNETgrate")

Done.

  • [ ] Can a warning such as:
## Warning in stats::cor(t(Data[, common]), as.numeric(deathTime[common]),
: the standard deviation is zero

be avoided by properly pre-processing the data?

This is actually the pre-processing code. I used suppressWarnings() on this line if you agree with me that these warnings are extra.

  • [] Please also make sure the oneStep, inetgrator and pathway_analysis chunks are executed.

I explained about the oneStep (iNETgrator()) above. Running inetgrator and pathway_analysis added 1 minute to the check time resulting in a warning. Do you think I should leave it as is, or skip running them? . Thanks for helping me improving the package. Hopefully, it will be accepted in this Bioconductor release.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/iNETgrate to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

nilseling commented 1 year ago

Hi @habilzare

Unfortunately I won't be able to review the changes in the next hours (already being quite late in Europe) but I'll look at them in the next days.

habilzare commented 1 year ago

Hi @nilseling , Do you have an update on the iNETgrate package? I have responded to all of your comments. Please let me know if I missed anything.

nilseling commented 1 year ago

Hi @habilzare Really sorry for the delay, I will get back to it on Wednesday.

nilseling commented 1 year ago

Hi @habilzare

I went through the changes again and there are still three things that need to be addressed:

## Warning in stats::cor(balancedData, as.matrix(eigengenes[rownames(balancedData),
: the standard deviation is zero

Could this be avoided by filtering out features with sd == 0? If not, you could add instructions to the vignette if the user can ignore this but also the other warnings that occur during analysis.