Closed mtiberti closed 1 year ago
Hi @mtiberti
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: Moonlight2R
Type: Package
Title: Identify oncogenes and tumor suppressor genes from omics data
Version: 0.99.0
Date:
Authors@R:
c(person("Astrid", "Saksager",
role="aut"),
person("Mona", "Nourbakhsh",
role="aut"),
person("Nikola", "Tom",
role="aut"),
person("Xi Steven", "Chen",
role="aut"),
person("Antonio", "Colaprico",
role="aut"),
person("Catharina", "Olsen",
role="aut"),
person("Matteo", "Tiberti",
role=c("cre", "aut"),
email="tiberti@cancer.dk"),
person("Elena", "Papaleo",
role="aut",
))
Depends: R (>= 4.2), doParallel, foreach
Imports: parmigene, randomForest, gplots,
circlize, RColorBrewer, HiveR, clusterProfiler, DOSE, Biobase,
grDevices, graphics, GEOquery, stats, purrr,
RISmed, grid, utils, ComplexHeatmap, GenomicRanges, dplyr, fuzzyjoin,
rtracklayer, magrittr, qpdf, readr, seqminer, stringr,
tibble, tidyHeatmap, tidyr, AnnotationHub
Description: The understanding of cancer mechanism requires
the identification of genes playing a role in the development
of the pathology and the characterization of their role
(notably oncogenes and tumor suppressors). We present
an updated version of the R/bioconductor package called MoonlightR,
namely Moonlight2R, which returns a list of candidate driver genes
for specific cancer types on the basis of omics data integration.
The Moonlight framework contains a primary layer where gene expression
data and information about biological processes are integrated to
predict genes called oncogenic mediators, divided into putative tumor
suppressors and putative oncogenes. This is done through functional enrichment
analyses, gene regulatory networks and upstream regulator
analyses to score the importance of well-known biological
processes with respect to the studied cancer type. By evaluating the effect
of the oncogenic mediators on biological processes or through
random forests, the primary layer predicts two putative
roles for the oncogenic mediators: i) tumor suppressor genes
(TSGs) and ii) oncogenes (OCGs). As gene expression data alone is not
enough to explain the deregulation of the genes, a second layer of
evidence is needed. We have automated the integration of a
secondary mutational layer through new functionalities in Moonlight2R.
These functionalities analyze mutations in the cancer cohort and classifies
these into driver and passenger mutations using the driver mutation
prediction tool, CScape-somatic. Those oncogenic mediators with at
least one driver mutation are retained as the driver genes.
As a consequence, this methodology does not only identify genes playing a dual role
(e.g. TSG in one cancer type and OCG in another) but also helps
in elucidating the biological processes underlying their
specific roles. In particular, Moonlight2R can be used to
discover OCGs and TSGs in the same cancer type. This may for instance help
in answering the question whether some genes change role
between early stages (I, II) and late stages (III, IV). In the future,
this analysis could be useful to determine the causes of different
resistances to chemotherapeutic treatments.
License: GPL (>= 3)
biocViews: DNAMethylation, DifferentialMethylation, GeneRegulation,
GeneExpression, MethylationArray, DifferentialExpression,
Pathways, Network, Survival, GeneSetEnrichment,
NetworkEnrichment
Suggests: BiocStyle, knitr, rmarkdown, testthat, devtools, roxygen2,
png
SystemRequirements: CScapeSomatic
VignetteBuilder: knitr
URL: https://github.com/ELELAB/Moonlight2R
BugReports: https://github.com/ELELAB/Moonlight2R/issues
RoxygenNote: 7.2.3
LazyData: true
Encoding: UTF-8
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 944725926e9fa9a37344028ced2488468443a9b7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details. This link will be active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
My apologies for the delay - this is quite a busy time for package submission. The package looks good and a few improvements to the package would make it great! Could you address the following or breifly explain that it's not possible/appropraite.
My main comment is that the package relies on data.frames and tables as input into its analysis, it would be much better if it interoperates with the already available bioconductor infrastructure on differential expression etc.
R code
Vignette
eval = FALSE
chunks. This can be more unhelpful than helpful. If they’re too slow you consider preloading the result?thank you very much @ococrook - and no worries about the timing. We'll try to get the changes in as soon as possible but having seen what needs to be changed we think it's unlikely we'll manage before the deadline for 3.17. Keep you posted!
I wouldn't worry to much about the deadline - the package will still be added to the devel build when accepted and you can install from there.
Hi @mtiberti, is this still active? We can close the issue if you need more time and re-open it at a later date when you're ready. If you no longer plan to make the changes that also works and we can also close the issue.
Best wishes, Olly
hi @ococrook,
we are actively working on the package as a new paper connected to it is under review, and the reviewers asked for some changes. We should soon be able to update the version in Bioconductor soon and work on the revision as well, so I would keep the issue open if possible
Thank you!
We are closing the package review for inactivity. When you are ready to push changes to git.bioconductor.org and continue the process please let us know with a message here and we will reopen the issue.
This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.
Thank you for your interest in Bioconductor.
hi, we would like to start pushing changes to the repository again. We are ready to push a couple of new functions/fixes that were done during the revision of the associated paper and will follow through revision points from there. Thank you
Dear @mtiberti ,
We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.
Received a valid push on git.bioconductor.org; starting a build for commit id: 896c54a6fb2bf3d25ad8230717dea3cd30dc1699
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: Moonlight2R_0.99.2.tar.gz Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.2.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: d37c360c2e4c0d4d25f6bd3186d6902c53b8f847
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.3.tar.gz macOS 12.6.5 Monterey: Moonlight2R_0.99.3.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: bc91a5ad5d3e9501b8bf5aed1e959c8641d09b8c
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.4.tar.gz macOS 12.6.5 Monterey: Moonlight2R_0.99.4.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: a73831a471e4beb22bb63a8d48941074698837a5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.5.tar.gz macOS 12.6.5 Monterey: Moonlight2R_0.99.5.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 724be62272cbdf9d7cbacc80d59a46e7a2345e74
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.6.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 9e47c58c05bd518c261ef12d33a794289cbbc794
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.7.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ea2143af6dc037ee3c87b1f698f1a691d7b0afb4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.8.tar.gz macOS 12.6.5 Monterey: Moonlight2R_0.99.8.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 83b124b8287c4848c7380cd3e64c3edb05352395
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.9.tar.gz macOS 12.6.5 Monterey: Moonlight2R_0.99.9.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 34b2172d1fb158721b5aa156944d08fba98e6ac1
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: Moonlight2R_0.99.10.tar.gz Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.10.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
hi @ococrook, sorry it took us a while, we were busy with revisions for the paper we recently published for this package, but we now managed to work on revisions and considered/implemented all your suggestions. We think overall code quality and robustness did improve, so thank you! Answers to your points below
My main comment is that the package relies on data.frames and tables as input into its analysis, it would be much better if it interoperates with the already available bioconductor infrastructure on differential expression etc.
Moonlight2R takes a table of differential expression analysis results as primary data input. We have not been able to find a ready-made container for DEA data as SummarizedExperiment is mostly designed for matrices containing samples x features.
Further, we have investigated differential expression data structures in BioConductor and found that the most popular DEA tools (edgeR, DESeq2 and limma) each use a unique and different data structure based on a SummarizedExperiment object. These DEA tools have a function that can be used in the end to convert from their data representation to a data.frame
that contains the differentially expressed genes, log fold change values, FDR values etc - functions that we ourselves use at the end of the DEAm, when we perform it outside of Moonlight2R. Therefore, this seems to be the most transferable data format that these tools can produce. Using one of the specialised data formats as inputs would restrict our ability to support natively only some of the aforementioned tools, while we would like to be more general and support the output from all of them with a minimal overhead. In this sense, We think that maintaining Moonlight’s flexibility in accepting a simple as possible DEA data format is beneficial for its usage.
Nonetheless, we are open for further suggestions on how we can interoperate with the BioConductor infrastructure on differential expression
Please add unit tests as this helps avoid bug accumulate over successive versions
we added unit tests with testthat
I think you need to add the follow imports to the NAMESPACE importFrom("stats", "end", "start") importFrom("utils", "head")
this was fixed
“You can remove the “no visible bindings for global variable” NOTE by adapting the following code utils::globalVariables(c(“ID”))
done - we added these calls where necessary
LazyData to false
done - and refactored code and vignettes to comply to this
Update R version to 4.3
done
The License is unclear (you have to fix a license it can’t be a conditional statement)
done - we just left GPL 3
You have some instances of sapply, we strongly suggest switching to vapply
we switched all instances of sapply
to vapply
The 1:.. Construct can go wrong ( e.g. 1:-1) switch to seq_len, seq.int, seq_along etc.
we replaced all instances of such constructs
There is some uncommented code in the package - sometime its need to clarify something but commented out code mid-function is likely to be confusing
we removed commented code
The code is quite crowded in places - adding extra white space can help and a space after commas can be really useful Try to be consistent with indenting in if statements and for loops
we considered these comments and uniformed and streamlined code style throughout the package, addressing these and other considerations
Please switch \dontrun in examples to \donttest to ensure they still correct syntax
we replaced all instances
Please check the inputs to the functions to help the user. Getting the code wrong currently leads to cryptic errors.
we added checks for all user-facing functions
You have quite a lot of eval = FALSE chunks. This can be more unhelpful than helpful. If they’re too slow you consider preloading the result?
we changed most of these to eval=TRUE
where possible and preloaded results where relevant
Thanks for the changes!
I get a couple of errors when going through the vignette, which you could help me with
whenever I run URA
I get
"object 'DiseaseList' not found"
whenever I run RMA I get
Error in get("EncodePromoters") : object 'EncodePromoters' not found
do something additional need to be passed to these functions to make them work?
Received a valid push on git.bioconductor.org; starting a build for commit id: 6f6c4a5ca2107c4bbb2e4f6be1ad38239730a4e5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: Moonlight2R_0.99.11.tar.gz Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.11.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
hi @ococrook,
thank you again,
no - these functions should work out of the box, there were a couple of data()
calls missing in the vignette. We have now added them in. We've also retried running each code line in the vignette from the generated html file and found a couple of other issues, which we fixed - hopefully it should be fine now
More in general regarding your question, two functions (DMA
, and moonlight
, which internally calls DMA
), as used in our vignette, do require a couple of data files that contain pre-computed CScape-Somatic scores. These are available on the CScape-Somatic website, as detailed in the vignette in the DMA: Driver Mutation Analysis
section. These files take ~50GB of disk space in total.
Thanks! I suspect there is some windows magic happening because:
dataURA <- URA(dataGRN = dataGRN,
DEGsmatrix = DEGsmatrix,
BPname = BPselected,
nCores=1)
gives
Error in { : task 1 failed - "object 'DiseaseList' not found" 4: stop(simpleError(msg, call = expr)) 3: e$fun(obj, substitute(ex), parent.frame(), e$data) 2: foreach(j = seq.int(tRlist), .combine = "rbind", .packages = "foreach") %dopar% { currentTF <- as.character(tRlist[j]) currentTF_regulon <- names(which(dataGRN$miTFGenes[currentTF, ] > as.numeric(dataGRN$maxmi[currentTF]))) currentTF_regulon <- as.matrix(currentTF_regulon) DEGsregulon <- intersect(rownames(DEGsmatrix), currentTF_regulon) if (length(DEGsregulon) > 2) { tabFEA <- FEA(BPname = BPname, DEGsmatrix = DEGsmatrix[DEGsregulon, ]) return(tabFEA$Moonlight.Z.score) } else { return(rep(0, length(BPname))) } } 1: URA(dataGRN = dataGRN, DEGsmatrix = DEGsmatrix, BPname = BPselected, nCores = 1)
It looks like it still can't find DiseaseList
despite it being clearly loaded. I wonder whether you need to check whether DiseaseList
is in the environment and if not call the data from inside the function? You could check this by names(.GlobalEnv)
inside the function but I suspect that it's correctly exporting for you. There is no windows build report so I assume this is a windows only issue for the moment.
thanks, indeed we tested it on Linux (Docker container from bioconductor:devel
) and MacOS and it was working fine. I currently don't have a Windows computer at work, I'll try and see if I can find one and test it on there, and I'll try out your idea - we do call data
inside other functions but not in that one so that might very well be the culprit. I'll be back to you
hi @ococrook ,
just a question - to fix this problem we are adding conditional data()
calls to our functions where applicable, this seems to work (I could test it on Windows), but we get a note, e.g.
* checking R code for possible problems ... [70s/76s] NOTE
Found the following calls to data() loading into the global environment:
File ‘Moonlight2R/R/DMA.R’:
data(variable_name)
File ‘Moonlight2R/R/FEA.R’:
data(variable_name)
...
our checks are like
if (! variable_name %in% names(.GlobalEnv)) {
data(variable_name)
so we're not just blindly loading them, just when we are not overloading pre-existing variables in the global environment. Do you think this is an acceptable compromise?
Thanks
Yes! That's the best approach I think
Great! I will do a final round of tests later today and push our commits, will ping you when/if we pass checks
Received a valid push on git.bioconductor.org; starting a build for commit id: f6d74e8af970c3fbe338f6987d7d975860242a8c
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: Moonlight2R_0.99.12.tar.gz Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.12.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: f08a5e7b38aa80994dd3c879cbaa934c747dcac8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: Moonlight2R_0.99.13.tar.gz Linux (Ubuntu 22.04.2 LTS): Moonlight2R_0.99.13.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/Moonlight2R
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@ococrook thanks for your patience, I have tested the package on Windows after applying the fix you suggested and it worked fine for me, as well as doing the usual checks on Linux. We also slimmed down the examples quite a bit as we were getting a package check timeout. I think it's ready if you want to give it another go
Your package has been accepted. It will be added to the Bioconductor nightly builds.
Thank you for contributing to Bioconductor!
Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.
thank you @ococrook ! We're happy the package was accepted. So now we just have to wait for the package to appear in the nightly builds and we should be done. If we need to change/add something after this step we will just push to the repo before or after release following BioC version numbering
The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.
To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/mtiberti.keys is not empty), then no further steps are required. Otherwise, do the following:
See further instructions at
https://bioconductor.org/developers/how-to/git/
for working with this repository. See especially
https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/
to keep your GitHub and Bioconductor repositories in sync.
Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at
https://bioconductor.org/checkResults/
(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("Moonlight2R")
. The package 'landing page' will be created at
https://bioconductor.org/packages/Moonlight2R
If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.
Hi, here's our submission for the
Moonlight2R
package. Thanks for reviewing it!Repository: https://github.com/ELELAB/Moonlight2R
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor [Package Submission][2] instructions. My package is consistent with the Bioconductor [Package Guidelines][1].
[x] I understand Bioconductor [Package Naming Policy][9] and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the [support site][3] for issues that users may have, subscribing to the [bioc-devel][4] mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the [Bioconductor code of conduct][7] and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including: