Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

scMultiSim #3068

Closed lhc70000 closed 7 months ago

lhc70000 commented 1 year ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 year ago

Hi @lhc70000

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: scMultiSim
Title: Simulation of Multi-Modality Single Cell Data Guided By Gene Regulatory Networks and Cell-Cell Interactions
Version: 0.99.0
Authors@R:
    c(person(given = "Hechen",
   family = "i",
   role = c("aut", "cre"),
   email = "hli691@gatech.edu",
   comment = c(ORCID = "0000-0003-4907-429X")),
      person(given = "Xiuwei",
   family = "Zhang",
   email = "zhangxiuwei03@gmail.com",
   role = "aut"),
      person(given = "Michael",
   family = "Squires",
   email = "squiresmf@gatech.edu",
   role = "aut"))
Description:
    scMultiSim simulates paired single cell RNA-seq, single cell ATAC-seq and RNA velocity data,
    while incorporating mechanisms of gene regulatory networks, chromatin accessibility and
    cell-cell interactions. It allows users to tune various parameters controlling the
    amount of each biological factor, variation of gene-expression levels,
    the influence of chromatin accessibility on RNA sequence data, and so on.
    It can be used to benchmark various computational methods for single cell multi-omics data,
    and to assist in experimental design of wet-lab experiments.
License: Artistic-2.0
Encoding: UTF-8
RoxygenNote: 7.2.3
Depends:
    R (>= 3.5.0)
Imports:
    foreach,
    rlang,
    dplyr,
    ggplot2, 
    Rtsne,
    ape,
    MASS,
    matrixStats,
    phytools,
    SummarizedExperiment,
    KernelKnn,
    gplots,
    zeallot,
    crayon,
    assertthat,
    igraph,
    methods,
    grDevices,
    graphics,
    stats,
    utils
Suggests:
    knitr,
    rmarkdown,
    roxygen2,
    testthat (>= 3.0.0)
biocViews: SingleCell, Transcriptomics
VignetteBuilder: knitr
Roxygen: list(markdown = TRUE)
BugReports: https://github.com/ZhangLabGT/scMultiSim/issues
Config/testthat/edition: 3
vjcitn commented 1 year ago
* checking re-building of vignette outputs ... ERROR
Error(s) in re-building vignettes:
  ...
--- re-building ‘basics.Rmd’ using knitr
Error: processing vignette 'basics.Rmd' failed with diagnostics:
there is no package called ‘markdown’
--- failed re-building ‘basics.Rmd’

--- re-building ‘spatialCCI.rmd’ using knitr

Quitting from lines 75-94 [unnamed-chunk-1] (spatialCCI.rmd)
Error: processing vignette 'spatialCCI.rmd' failed with diagnostics:
object 'GRN_params_100' not found
--- failed re-building ‘spatialCCI.rmd’

SUMMARY: processing the following files failed:
  ‘basics.Rmd’ ‘spatialCCI.rmd’

Error: Vignette re-building failed.
Execution halted

if you need markdown, please declare in DESCRIPTION. fix the data availability error. thanks

lhc70000 commented 1 year ago

Thank you very much. I have updated the repo to fix these two problems.

bioc-issue-bot commented 1 year ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "skipped, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

ococrook commented 1 year ago

Hi, I'm looking forward to reviewing the package! Please fix the build errors before I can proceed.

lhc70000 commented 1 year ago

Hi @ococrook! I'm so sorry for the delay. I wanted to resolve the timeout issue; however, since scMultiSim is a data simulator, some simulation code in the vignette may take a long time to run (~10 minutes). I'm considering either

Which one do you prefer, or is there any other solution you would recommend? Thanks!

ococrook commented 1 year ago

Hi!

How big the demo data - this maybe your limitation if it over 5mb you would have to store it in a data package. I favour the first option if it makes sense to do that - and allow your user to locally increase the number of cells and genes easily.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fec3625e8e1a92cd7257412ecfdabe4c382dd526

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.1.tar.gz macOS 12.6.5 Monterey: scMultiSim_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 202095c24cdd54f75fd56c3099510282b0138618

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: scMultiSim_0.99.2.tar.gz Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 2da09c98aa81f7fba5cad81e4c26c5bb0011bc7e

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: scMultiSim_0.99.3.tar.gz Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: f1de0798304d060669131bbe1dd335b7b1bab78a

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: scMultiSim_0.99.4.tar.gz Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ec3e9adebb6feac1dfafe016ff069d77baf7643e

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: scMultiSim_0.99.5.tar.gz Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.5.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lhc70000 commented 1 year ago

Hi @ococrook, sorry for the delay! Now I'll prioritize this package and all build errors have been fixed. I will also look into the warnings soon.

I'm committed to promptly addressing any review comments. Thank you for your time with this large package!

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: bdd4db716924724c9975d8f8b113aa215dd7a1b9

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.6.tar.gz macOS 12.6.5 Monterey: scMultiSim_0.99.6.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 04a1bcb7c494a030c4490e2cb870d8a7ba2e81f6

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.7.tar.gz macOS 12.6.5 Monterey: scMultiSim_0.99.7.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lhc70000 commented 1 year ago

Hi @ococrook! The package now builds without errors or warnings. I apologize once more for the delay caused by my personal issues. I look forward to your review and will promptly address any comments.

ococrook commented 1 year ago

Thanks! Sorry I didnt see the notification. I'll get to this shortly

ococrook commented 12 months ago

This is great! A few things to tidy up:

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 41e5ec655fb519ca4f9654e7d07ef1dc53d9937f

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR, TIMEOUT". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.8.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fce57e6db2800ec00ccbb4a8f8cd561ae6e549c6

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.9.tar.gz macOS 12.7.1 Monterey: scMultiSim_0.99.9.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

ococrook commented 11 months ago

Are you able to fix the timeout?

lhc70000 commented 11 months ago

The problem this time was not the timeout…… My unit test failed on BioConductor's build server after I pushed the new changes.

Running the tests in tests/testthat.R failed.
Last 20 lines of output:

    `actual[3:15]`: 18 33 88 0 2 0 24 72 6  7 and 3 more...
  `expected[3:15]`: 18 33 88 5 4 0  8 96 0 18           ...
   Failure ('test-1_main.R:151:3'): simulates spatial data with discrete population and HGE 
  res$counts[selectedIndicies] (`actual`) not equal to c(...) (`expected`).

       actual  | expected               
   [1] 116.691 - 109.069  [1]           
   [2] 59.994  - 60.415   [2]           
   [3] 85.398  - 91.912   [3]           
   [4] 1.082   - 0.582    [4]           
   [5] 172.034 - 177.674  [5]           
   [6] 202.649 - 197.066  [6]           
   [7] 95.052  - 102.315  [7]           
   [8] 56.943  - 65.998   [8]           
   [9] 96.683  - 89.161   [9]           
  [10] 2.693   - 3.173    [10]          
   ... ...       ...      and 7 more ...

  [ FAIL 7 | WARN 0 | SKIP 0 | PASS 5 ]
  Error: Test failures

This is really strange since these tests successfully pass on my macOS and Linux machines. I'm still trying to figure it out; do you have any thoughts?

ococrook commented 11 months ago

Odd, usually a package dependcy or perhaps random seed issue?

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 35e1dff21954135aaf5a62f8f2bc7429ae80fc11

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "TIMEOUT, skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.10.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 6ec61db49244ddb98b83fd3d03d7852efa24e489

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "TIMEOUT, skipped, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.11.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: adec9bb148c3c3562392bd66becfc997d51a441e

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "TIMEOUT, skipped, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.12.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: c53c7f438bb30f92b9c412d239d63f0f1230ede4

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 45bbffbc2d46e7d310fa602369b343e028aea20a

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: scMultiSim_0.99.14.tar.gz Linux (Ubuntu 22.04.2 LTS): scMultiSim_0.99.14.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lhc70000 commented 10 months ago

Hi @ococrook, I have resolved the review comments and passed the Bioc Build System. Could you have a look? Thanks!

ococrook commented 9 months ago

@lshep where are the old build reports contained? I think we can accept this one shortly after double check.

lshep commented 9 months ago

http://staging.bioconductor.org:8000/jobs/1917/

ococrook commented 8 months ago

Sorry for the delay on my end - working only part time at the moment.

This is a very clear package as a I noted before.

Im keen to see some of the easy Notes cleared up e.g. vapply, 1:N constructions etc, corrected R dependency.

Make sure to run Biochcheck. A few notes are fine but 13 is too many.

I realise not every package can depend on bioc infrastructure but could you give me a breif reason why this package does not depend on any bioconductor packages and why its more appropraite for the package on Bioconductor rather than CRAN?

bioc-issue-bot commented 8 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 8c05dd3aae844eb7a8f4fe7884768202714cf547

bioc-issue-bot commented 8 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): scMultiSim_0.99.15.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/scMultiSim to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 8 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 50ca31d190e6032bd67554468e2c7d87959d6ba2