Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

roastgsa #3086

Closed adricaba closed 1 year ago

adricaba commented 1 year ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 year ago

Hi @adricaba

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: roastgsa
Type: Package
Version: 0.99.2
Date: 2023-06-13
Title: Rotation based gene set analysis
Authors@R: person("Adria", "Caballe", email = "adria.caballe@irbbarcelona.org",role = c("aut", "cre"))
Description: This package implements a variety of functions useful for
   gene set analysis using rotations to approximate the
         null distribution. It contributes with the implementation of
         seven test statistic scores that can be used with different goals
         and interpretations. Several functions are available to complement the statistical results
         with graphical representations.
Encoding: UTF-8
VignetteBuilder: knitr
biocViews: Microarray, Preprocessing, Normalization, GeneExpression, Survival, Transcription, Sequencing, Transcriptomics, Bayesian, Clustering, Regression, RNASeq,  MicroRNAArray, mRNAMicroarray, FunctionalGenomics, SystemsBiology, ImmunoOncology,  DifferentialExpression, GeneSetEnrichment, BatchEffect, MultipleComparison, QualityControl, TimeCourse, Metabolomics, Proteomics, Epigenetics, Cheminformatics, ExonArray, OneChannel, TwoChannel, ProprietaryPlatforms, CellBiology, BiomedicalInformatics, AlternativeSplicing, DifferentialSplicing, DataImport, Pathways
Depends: R (>= 4.1.3), gplots, ggplot2, limma, RColorBrewer, Biobase
Imports: parallel, grDevices, graphics, utils, stats,  methods, grid
Suggests: BiocStyle, knitr, rmarkdown, GSEABenchmarkeR, EnrichmentBrowser, preprocessCore, DESeq2
License: GPL-3
bioc-issue-bot commented 1 year ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): roastgsa_0.99.2.tar.gz macOS 12.6.5 Monterey: roastgsa_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/roastgsa to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 962e115c36958a9045a44c716407b4add888c618

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): roastgsa_0.99.3.tar.gz macOS 12.6.5 Monterey: roastgsa_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/roastgsa to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

Kayla-Morrell commented 1 year ago

@adricaba - Thank you for submitting to Bioconductor. Please see the initial review of the package below. The required changes must be made while the suggested changes do not have to be (though we strongly encourage them). Comment back here with updates that have been made and when the package is ready for a re-review.

DESCRIPTION

NAMESPACE

NEWS

Data

Vignettes

if (!require("BiocManager", quietly = TRUE))
    install.packages("BiocManager")
BiocManager::install("roastgsa")

Man pages

Unit tests

R code

Best, Kayla

adricaba commented 1 year ago

Dear Kayla,

thanks for all comments.

We have addressed all the REQUIRED comments and most of the SUGGESTED comments:

We have pushed the version 0.99.3 of the package. Let us know if there is any issue unresolved, please.

Best, Adria

On 10 Aug 2023, at 16:59, Kayla-Morrell @.***> wrote:

Man pages

REQUIRED: You do not need to document internal functions. REQUIRED: All man pages need runnable examples. The code for 'htmlrgsa', 'ploteffsignaturesize', and 'varrotrand' need to be run (not commented out). Unit tests

SUGGESTION: Consider adding unit tests. We strongly encourage them. See https://contributions.bioconductor.org/tests.html https://contributions.bioconductor.org/tests.html R code

SUGGESTION: Avoid cat outside of show methods, this is found in the R/utils.R file. SUGGESTION: Avoid using = for assignment and use <- instead.

Kayla-Morrell commented 1 year ago

@adricaba - Thank you for making the necessary changes. The last version was 0.99.3, as shown in this build report - https://github.com/Bioconductor/Contributions/issues/3086#issuecomment-1667640660. Please push a version bump to trigger the new build.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 8835839c99c212fddbb58eb5e5468602ccf7531b

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: roastgsa_0.99.4.tar.gz Linux (Ubuntu 22.04.2 LTS): roastgsa_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/roastgsa to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 359349fd20cfc23d3048b5a54c9e62226890bd23

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: roastgsa_0.99.5.tar.gz Linux (Ubuntu 22.04.2 LTS): roastgsa_0.99.5.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/roastgsa to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fee6fb5e44954573ea115d4c67f4d0873cf8fac3

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: roastgsa_0.99.6.tar.gz Linux (Ubuntu 22.04.2 LTS): roastgsa_0.99.6.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/roastgsa to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: b0812fef1bc941ebd18925ae4160769cc3f7daf3

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: roastgsa_0.99.7.tar.gz Linux (Ubuntu 22.04.2 LTS): roastgsa_0.99.7.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/roastgsa to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0410a15f623961c6c88aef5ecb5b1b3c4e23890a

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: roastgsa_0.99.8.tar.gz Linux (Ubuntu 22.04.2 LTS): roastgsa_0.99.8.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/roastgsa to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

adricaba commented 1 year ago

Hi Kayla,

I finally managed to make it work, apologises for the delay, I had a few warnings that I had to deal to.

Let me know if there is any further concern.

Best, Adria

On 15 Aug 2023, at 15:55, Kayla-Morrell @.***> wrote:

@adricaba https://github.com/adricaba - Thank you for making the necessary changes. The last version was 0.99.3, as shown in this build report - #3086 (comment) https://github.com/Bioconductor/Contributions/issues/3086#issuecomment-1667640660. Please push a version bump to trigger the new build.

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/3086#issuecomment-1678973832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4PHKVTZDBQ7HAYACAP7OTXVN5W3ANCNFSM6AAAAAA2PUK44I. You are receiving this because you were mentioned.

Kayla-Morrell commented 1 year ago

@adricaba - Thank you for making the necessary changes. I have looked everything over and it all looks good. I'm more than happy to accept the package.

Best, Kayla

bioc-issue-bot commented 1 year ago

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

lshep commented 1 year ago

The default branch of your GitHub repository has been added to Bioconductor's git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/adricaba.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("roastgsa"). The package 'landing page' will be created at

https://bioconductor.org/packages/roastgsa

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.