Closed jfanale26 closed 7 months ago
Hi @jfanale26
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: CytoMethIC
Type: Package
Title: DNA methylation-based classification and regression
Description: This package provides DNA methylation-based prediction of cancer type, molecular signature and clinical
outcomes. It provides convenience functions for missing value imputation, probe ID conversion, model interpretation
and visualization. The package includes 3 models for classification of 33 tumor types and cell of origin. The package
currently supports HM450, EPIC and EPICv2.
Version: 0.99.0
Authors@R: c(person("Wanding", "Zhou", role = c("aut","cre"),
email = "zhouwanding@gmail.com", comment = c(ORCID = "0000-0001-9126-1932")))
License: Artistic-2.0
Depends: R (>= 4.3.0), ExperimentHub, AnnotationHub
Imports:
tibble,
utils,
stats,
tools,
randomForest
Suggests:
sesame,
testthat,
sesameData,
knitr,
rmarkdown,
e1071,
xgboost,
keras,
tensorflow
biocViews: ExperimentData, MicroarrayData, Genome, ExperimentHub, MethylationArrayData, CancerData, PackageTypeData
VignetteBuilder: knitr
NeedsCompilation: no
RoxygenNote: 7.2.3
Encoding: UTF-8
There are numerous references to "askMe". Like in the vignette. 'askMe' package
. Please correct these.
We recommend renaming your vignette to the package name rather than something common and not unique like quickstart as there could be naming conflicts with other packages loaded in a user environment. The vignette does not meet the conditions of the contributions guidelines. Please explain the use of the tool and its relationship to Bioconductor. Try to imagine a newcomer to your package who needs to get the flavor of it, and who can be inspired to try it out by what you write.
Please provide test relevant to your package code not that the download from the dependent package works correctly.
Any data provided in inst/extdata
should have an associated file in inst/scripts
describing its creation. It looks like this might be an experiment data package? You should have a script that describes how the files that were uploaded to Azure were generated as well.
You export both cmi_classify_rda and cmi_classify but I only see runnable example code for cmi_classify?
@jfanale26 any responses on the above?
Sorry about the delayed response. All of these issues should be fixed now- let me know what else needs to be done.
Just following up on this, as the deadline for review completion is in 2 days @lshep
I will process this into git.bioconductor.org so that we can proceed in the review process however there is still not a description in inst/scripts that describes how the objects uploaded to the hub were created with any relevant source information. It would also be helpful to provide more text on what is occurring and how it is significant in each of your vignette sections.
Your package has been added to git.bioconductor.org to continue the pre-review process. A build report will be posted shortly. Please fix any ERROR and WARNING in the build report before a reviewer is assigned or provide a justification on why you feel the ERROR or WARNING should be granted an exception.
IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. All changes should be pushed to git.bioconductor.org moving forward. It is required to push a version bump to git.bioconductor.org to trigger a new build report.
Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: CytoMethIC_0.99.1.tar.gz Linux (Ubuntu 22.04.2 LTS): CytoMethIC_0.99.1.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: e441d53650dbd74dc7b134a7f718f12186727480
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): CytoMethIC_0.99.3.tar.gz macOS 12.6.5 Monterey: CytoMethIC_0.99.3.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: a8b921364cd09ad3d08cc31e30a623de0f36479a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): CytoMethIC_0.99.4.tar.gz macOS 12.6.5 Monterey: CytoMethIC_0.99.4.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
All described issues have been addressed, and the only remaining error is "Maintainer must subscribe to the bioc-devel mailing list", though I am subscribed to this mailing list with the email in the DESCRIPTION file. Let me know how I should proceed from here. @lshep
A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.
Please bump the version number and remove the error tag first.
Received a valid push on git.bioconductor.org; starting a build for commit id: e0f64c8ea3b47759f1bbedf340c84bd3f7cd773c
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: macOS 12.6.5 Monterey: CytoMethIC_0.99.5.tar.gz Linux (Ubuntu 22.04.2 LTS): CytoMethIC_0.99.5.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Could you fix the warnings?
Should I expect any updates soon?
Sorry, I have been extremely busy with exams and classes lately. I have been trying to fix the "package is over 5MB" warning, but I don't get this warning on my local computer, only when I update the version and push to Bioconductor. Will update you as I make progress.
Received a valid push on git.bioconductor.org; starting a build for commit id: a95398599f6d7339e64df6c501a2c0c2dcf0a381
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: d15e52ac412d39314b30216ddd6dd7cea892c037
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): CytoMethIC_0.99.7.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0b31df337fc37e82dfb686379e97abdeb00d3547
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: CytoMethIC_0.99.8.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 2008828526eefb358b434df1f74b012f7a8fdbc9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: CytoMethIC_0.99.9.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
@jianhong We have been getting a warning when built on the Bioconductor system, but this warning does not show up on local builds (tested on multiple machines). Is this a common issue/how would we troubleshoot this problem?
Thank you for submitting your package to Bioconductor. The package passed check and build. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. Code: Note: please consider; Important: must be addressed.
importFrom
instead of import all with import
.
is()
or inherits()
instead of class()
.
warning
, message
, stop
instead of cat
and print
outside of show
methods.
::
is not suggested in source code unless you can make sure all the packages are imported. Some people think it is better to keep ::
. However please note that you need to manully double check the import items when you make any change in the DESCRIPTION file during development. My recommendation is to remove one or two repeats to force the dependency check.
for
loops present, try to replace them by *apply
funcitons.
BiocStyle
package for formatting.
sesameDataCache()
, otherwise error:| File HM450.1.TCGA.PAAD needs to be cached to be used in sesame. | Please make sure you have updated ExperimentHub and try | > sesameDataCache() | to retrieve and cache needed sesame data. --- failed re-building ‘CytoMethIC.Rmd’
Received a valid push on git.bioconductor.org; starting a build for commit id: d8d19b52d4ed704ab4d13eeef0eb32f97a4413ea
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): CytoMethIC_0.99.10.tar.gz macOS 12.7.1 Monterey: CytoMethIC_0.99.10.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Should I expect any updates soon?
Hi, I made many of the changes you suggested, but adding an Installation section raised an error during build. The installation code in vignettes/CytoMethIC.rmd is as follows: The error is as follows: `* Checking vignette directory...
Please set eval=FALSE
after or among r, message=FALSE...
Should I expect any updates soon?
Received a valid push on git.bioconductor.org; starting a build for commit id: 3824eaf9c20815bf248af4396e7d6f48d9cce330
Received a valid push on git.bioconductor.org; starting a build for commit id: 58e665ba6a17c652c6404b728bc234194c3fe2a9
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: CytoMethIC_0.99.12.tar.gz Linux (Ubuntu 22.04.3 LTS): CytoMethIC_0.99.12.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): CytoMethIC_0.99.11.tar.gz macOS 12.7.1 Monterey: CytoMethIC_0.99.11.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: fdcda4e459a91713ae510dd0eccff8ba7748a4d5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS, skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): CytoMethIC_0.99.13.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Should I expect any updates soon?
We are finished with the requested modifications, please let us know what else should be done @jianhong
@jfanale26 Thanks for the updates. Could you please fix the file size warning?
Received a valid push on git.bioconductor.org; starting a build for commit id: 772581d13267f2d1033675a7aa36504ee4ddb08a
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 34d3c30c4fcabe3a8026e40d107bc4c2da0fc2ea
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 2a0c54be223b2f6849f5a2632ec9f8cbf19b71a4
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.3 LTS): CytoMethIC_0.99.16.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/CytoMethIC
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[x] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.