Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

SurfR #3105

Closed auroramaurizio closed 6 months ago

auroramaurizio commented 1 year ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

ococrook commented 11 months ago

Hi @auroramaurizio

Did you recieved and respond to a review from Peter? I cant see anything explicit above but dont want to make you do work you have already done? In the meantime. The package is welll put together and like the vignette

Thanks, Olly

auroramaurizio commented 11 months ago

Hi @ococrook, I haven't received a package review yet. Thank you for your advice. I will address the points you mentioned and get back to you!

Best, Aurora

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 54cad3db2983c804f50361655fdaf6b21e6fd6ef

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.15.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ffd115480b34d41d14bde0cc2736e1ed372fbb0d

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 4139265566489b8d05b39898c91fc765ebb8a5f8

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.17.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

auroramaurizio commented 11 months ago

Dear @ococrook, I bumped the new package version addressing your points, in particular, I:

Thank you, let me know how it looks now! Aurora

ococrook commented 11 months ago

Thanks Aurura, trying to make may way through the package but I get stuck in the vignette

> # Download metadata from GEO
> mGSE121810 <- GEOmetadata(GSE = "GSE121810")

Warning: cannot open file 'GSE121810_series_matrix.txt.gz': No such file or directoryError in file(file, "rt") : cannot open the connection

Some comments on the R code:

I think the R code in general could be cleaned up but I'm very happy with the documentation and vignette (once I can getting working)

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 22e04aadb47aa156fb00a00e8c79c94b90967104

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.18.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 30802c4ff892064f75d304a9276049f80d17f148

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.19.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 11 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 88a0c6739b8d3552f748a27ca1a6b029e044ea41

auroramaurizio commented 11 months ago

Thank you @ococrook for your careful code revision.

Aurora

bioc-issue-bot commented 11 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.20.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 10 months ago

R CMD check

Must specify at least one of url or handle

dw_genes <- c("CD275", "COL1A1", "COL1A2","LUM", "SOX9") dfList[["fdr_down"]] <- enrichR::enrichr(dw_genes, dbs)

Must specify at least one of url or handle

Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, num_term = 5, cond = "UP") Error in Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : Selected Enrich databases not present in your enrichment analysis. In addition: Warning message: In Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : GO_Biological_Process_2021WikiPathways_2016MSigDB_Hallmark_2020not present in your Enrichment analysis. Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, num_term = 5, cond = "DOWN") Error in Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : Selected Enrich databases not present in your enrichment analysis. In addition: Warning message: In Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : GO_Biological_Process_2021WikiPathways_2016MSigDB_Hallmark_2020not present in your Enrichment analysis.


**BiocCheck**
- [ ] The R version WARNING should also be corrected;  we can not verify that this will work on such an outdated version of R.  

- [ ] avoiding `cat` and use `message` instead so users that don't want verbose output can suppressMessages. Found in 

cat() in R/Enrichment.R (line 66, column 5) cat() in R/Enrichment.R (line 74, column 5) cat() in R/Enrichment.R (line 91, column 5)


- [ ] Please explain why the suppressWarnings are justified 

suppressWarnings() in R/Annotate_SPID.R (line 156, column 3) suppressWarnings() in R/SVenn.R (line 41, column 3)

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 9fa3fb52b31c3936736c6bd8c17cbae9475d5eaf

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 4eff6784e9b55a00190d17074ac9c19eaab384f4

auroramaurizio commented 10 months ago

Dear @lshep, Thank you for your attention to SurfR package. I'm sorry to hear you got an ERROR on your manual linux build. I can confidently say the ERROR you are facing now is due to a temporary connection problem with the EnrichR database. If it happens I re-run the command after a few minutes (1, 2 minutes) and the connection with EnrichR is re-established. I now added a line in the vignette about this potential temporary issue.

The automatic linux builds and checks on nebbiolo2 of SurfR_0.99.20.tar.gz, but also SurfR_0.99.19.tar.gz, SurfR_0.99.18.tar.gz etc. were all successful. I can assure we also tested it on our linux cluster and 4 different MacOS laptops and it worked well without any errors. If It may be helpful I can send the session info of each.

We tested the package on R versions 4.1 and greater. I now explicitly report all tested versions (4.1, 4.2, and 4.3) in the README. I do not get an Rversion warning, unfortunately, I can not reproduce it.

I replaced cat with message in R/Enrichment.R (line 66, line 74, line 91).

I removed suppressWarnings() in SVenn function, while I kept it in Annotate_SPID. I added a comment above suppressWarnings() in Annotate_SPID to provide context to the user and justify its usage.

Thank you, Aurora

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0b388348c701ef6f7fdb9cbba9d5778e96d4e1a6

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 37943dbe6d4e1a5f28cb82feb67ae648e9277b0b

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 403ccee75673cfaad51f36b3eb52683c95e954bf

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 230ff3aedfd36581d940fff59ab8a902005689da

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5f70efc421dc3fd59c4047fa365c46f6b28cdf44

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 10 months ago

Unfortunately it seems to be consistently ERRORing. Is there any way to make the package more dependable or able to fail out gracefully if the connection cannot be established.

Because there are data objects R during the build stage will automatically add an R version because of incompatiblity with pervious version saved objects. To fix this ERROR please put the following in the DESCRIPTION R (>= 4.3.0) in the Depends field.

Thank you for the other changes.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 8a798c9d8f29ec8f335ecbb763f56d0f27ed7584

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, TIMEOUT, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ea06032ee1a2f38ec6916e3b12d17de2ee65a517

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 0642a03c3786505827c3b8185684d5656082d791

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 6382538062857838d15196599d54de858b04f249

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 10 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: be3f192178f1ffd85181f8a70ccd9dbc1af32215

bioc-issue-bot commented 10 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.32.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

auroramaurizio commented 10 months ago

Dear @lshep, thank you for your advice. I added the Depends field in DESCRIPTION, fixed the issue with the failing function and now the check on the nebbiolo2 linux builder is successful.

Aurora

ococrook commented 9 months ago

Sorry for the delay here, could you add the bioconductor install instruction. Could you also trigger a new build? I would like to see whats happening there more recently.

bioc-issue-bot commented 9 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ef1dc75cbf3f000c6cef2ec5753e0307311f25bd

bioc-issue-bot commented 9 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.33.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 9 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 1f8236e24bc767e588644695889d21644a0c6c85

bioc-issue-bot commented 9 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.34.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 9 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 1b72992535cd355cb521dafc0bcddaf9d03f88bf

bioc-issue-bot commented 9 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.35.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.