Closed auroramaurizio closed 6 months ago
Hi @auroramaurizio
Did you recieved and respond to a review from Peter? I cant see anything explicit above but dont want to make you do work you have already done? In the meantime. The package is welll put together and like the vignette
Thanks, Olly
Hi @ococrook, I haven't received a package review yet. Thank you for your advice. I will address the points you mentioned and get back to you!
Best, Aurora
Received a valid push on git.bioconductor.org; starting a build for commit id: 54cad3db2983c804f50361655fdaf6b21e6fd6ef
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.15.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ffd115480b34d41d14bde0cc2736e1ed372fbb0d
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 4139265566489b8d05b39898c91fc765ebb8a5f8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.17.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear @ococrook, I bumped the new package version addressing your points, in particular, I:
Thank you, let me know how it looks now! Aurora
Thanks Aurura, trying to make may way through the package but I get stuck in the vignette
> # Download metadata from GEO
> mGSE121810 <- GEOmetadata(GSE = "GSE121810")
Warning: cannot open file 'GSE121810_series_matrix.txt.gz': No such file or directoryError in file(file, "rt") : cannot open the connection
Some comments on the R code:
[ ] You have some contructions like 5:N
, we generally recommend using something like seq_along
, seq_int
etc.
[ ] Still examples of code with comments that are likely to cause confusion: e.g. `grouped <- exploded %>%
group_by(GeneID) %>% summarise(temp = toString(term)) %>% ungroup()`
[ ] Is this sequence going backwards? as.factor(dim(pathways.dataframe)[1]:1)
Im a bit confused as to what this coded is intneded to do.
[ ] Try to be consistent with white spaces, espcially after columns or operations
[ ] I'm not sure whats happening here, did you redefine log
and then use the base log
again? `log <- sort(list.files("log/", pattern = "*.xlsx"))
if (!Surfy_version %in% c("log", "new")) { stop("The specified database version is not available. \n Choose between log or new") }
if (length(log)>0 & Surfy_version == "log") { ST <- read.xlsx(xlsxFile = paste0(".log/", log[length(log)]), startRow = 1) }`
[ ] I would stick with <-
for assignment note sure why you switch to using =
for some functions?
[ ] I usually don't advise to use as.factor
and suggest to convert to a factor more explicity with factor
specificying the levels you expect
[ ] You have lots of imports in the description are these necessary?
I think the R code in general could be cleaned up but I'm very happy with the documentation and vignette (once I can getting working)
Received a valid push on git.bioconductor.org; starting a build for commit id: 22e04aadb47aa156fb00a00e8c79c94b90967104
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.18.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 30802c4ff892064f75d304a9276049f80d17f148
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.19.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 88a0c6739b8d3552f748a27ca1a6b029e044ea41
Thank you @ococrook for your careful code revision.
I'm sorry to hear that you are having problems in the vignette with the GEOmetadata function. Most probably you are facing the Rhdf5lib Mac Iconway builder issue reported here https://github.com/Bioconductor/BBS/issues/245#issuecomment-1721605029. hpages clearly defines the problem and the steps to solve it. This issue is also the reason why SurfR fails the Mac check on the Iconway buidler but i.e. runs successfully on our Mac laptops https://github.com/Bioconductor/Contributions/issues/3105#issuecomment-1713954422. Hope you'll manage to fix it!
All the functions should be cleared from code commented lines now.
I removed the line "as.factor(dim(pathways.dataframe)[1]:1)" from the "Enrichment_barplot" function. It wasn't used.
I spotted some instances like 1:... where seq_len(), seq_along(), etc. would fit better and used these constructs.
In the Gene2SProtein function we allow the user to select the version of the Surfy data frame he wishes to use. In other words, to decide if he wants to use an xlsx table already downloaded from Surfy's URL or to download it again, choosing between "log" and "newest" Surfy_version. The line "log <- sort(list.files("log/", pattern = "*.xlsx"))" screens the ".log/" directory and lists in "log" all the xlsx files present in the directory in the variable "log". To avoid confusion I renamed the variable log as log_list.
I improved code styling: commas now always have a space after, spaces are present around infix operators, I always use double quotes, etc.
I stuck with <- for assignments
I replaced as.factor with factor.
I agree there are quite a few imports. The package aims to allow the user to perform an end-to-end protein annotation analysis from data retrieval to DGE, meta-analysis, annotation, plotting, etc., and each of these steps requires dedicated packages
Aurora
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.20.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
R CMD check
> dbs
[1] "GO_Biological_Process_2021" "WikiPathways_2016"
[3] "MSigDB_Hallmark_2020"
> up_genes <- c("RUNX1", "DLK1", "TOP2A", "EPCAM", "GATA1", "KDR")
dfList[["fdr_up"]] <- enrichR::enrichr(up_genes, dbs)
Must specify at least one of url or handle
dw_genes <- c("CD275", "COL1A1", "COL1A2","LUM", "SOX9") dfList[["fdr_down"]] <- enrichR::enrichr(dw_genes, dbs)
Must specify at least one of url or handle
Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, num_term = 5, cond = "UP") Error in Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : Selected Enrich databases not present in your enrichment analysis. In addition: Warning message: In Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : GO_Biological_Process_2021WikiPathways_2016MSigDB_Hallmark_2020not present in your Enrichment analysis. Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, num_term = 5, cond = "DOWN") Error in Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : Selected Enrich databases not present in your enrichment analysis. In addition: Warning message: In Enrichment_barplot(dfList, enrich.databases = dbs, p_adj = 0.01, : GO_Biological_Process_2021WikiPathways_2016MSigDB_Hallmark_2020not present in your Enrichment analysis.
**BiocCheck**
- [ ] The R version WARNING should also be corrected; we can not verify that this will work on such an outdated version of R.
- [ ] avoiding `cat` and use `message` instead so users that don't want verbose output can suppressMessages. Found in
cat() in R/Enrichment.R (line 66, column 5) cat() in R/Enrichment.R (line 74, column 5) cat() in R/Enrichment.R (line 91, column 5)
- [ ] Please explain why the suppressWarnings are justified
suppressWarnings() in R/Annotate_SPID.R (line 156, column 3) suppressWarnings() in R/SVenn.R (line 41, column 3)
Received a valid push on git.bioconductor.org; starting a build for commit id: 9fa3fb52b31c3936736c6bd8c17cbae9475d5eaf
Received a valid push on git.bioconductor.org; starting a build for commit id: 4eff6784e9b55a00190d17074ac9c19eaab384f4
Dear @lshep, Thank you for your attention to SurfR package. I'm sorry to hear you got an ERROR on your manual linux build. I can confidently say the ERROR you are facing now is due to a temporary connection problem with the EnrichR database. If it happens I re-run the command after a few minutes (1, 2 minutes) and the connection with EnrichR is re-established. I now added a line in the vignette about this potential temporary issue.
The automatic linux builds and checks on nebbiolo2 of SurfR_0.99.20.tar.gz, but also SurfR_0.99.19.tar.gz, SurfR_0.99.18.tar.gz etc. were all successful. I can assure we also tested it on our linux cluster and 4 different MacOS laptops and it worked well without any errors. If It may be helpful I can send the session info of each.
We tested the package on R versions 4.1 and greater. I now explicitly report all tested versions (4.1, 4.2, and 4.3) in the README. I do not get an Rversion warning, unfortunately, I can not reproduce it.
I replaced cat with message in R/Enrichment.R (line 66, line 74, line 91).
I removed suppressWarnings() in SVenn function, while I kept it in Annotate_SPID. I added a comment above suppressWarnings() in Annotate_SPID to provide context to the user and justify its usage.
Thank you, Aurora
Received a valid push on git.bioconductor.org; starting a build for commit id: 0b388348c701ef6f7fdb9cbba9d5778e96d4e1a6
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 37943dbe6d4e1a5f28cb82feb67ae648e9277b0b
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 403ccee75673cfaad51f36b3eb52683c95e954bf
Received a valid push on git.bioconductor.org; starting a build for commit id: 230ff3aedfd36581d940fff59ab8a902005689da
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 5f70efc421dc3fd59c4047fa365c46f6b28cdf44
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Unfortunately it seems to be consistently ERRORing. Is there any way to make the package more dependable or able to fail out gracefully if the connection cannot be established.
Because there are data objects R during the build stage will automatically add an R version because of incompatiblity with pervious version saved objects. To fix this ERROR please put the following in the DESCRIPTION R (>= 4.3.0)
in the Depends field.
Thank you for the other changes.
Received a valid push on git.bioconductor.org; starting a build for commit id: 8a798c9d8f29ec8f335ecbb763f56d0f27ed7584
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, TIMEOUT, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: ea06032ee1a2f38ec6916e3b12d17de2ee65a517
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 0642a03c3786505827c3b8185684d5656082d791
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 6382538062857838d15196599d54de858b04f249
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: be3f192178f1ffd85181f8a70ccd9dbc1af32215
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Build System.
On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.32.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Dear @lshep, thank you for your advice. I added the Depends field in DESCRIPTION, fixed the issue with the failing function and now the check on the nebbiolo2 linux builder is successful.
Aurora
Sorry for the delay here, could you add the bioconductor install instruction. Could you also trigger a new build? I would like to see whats happening there more recently.
Received a valid push on git.bioconductor.org; starting a build for commit id: ef1dc75cbf3f000c6cef2ec5753e0307311f25bd
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, WARNINGS, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.33.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1f8236e24bc767e588644695889d21644a0c6c85
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.34.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Received a valid push on git.bioconductor.org; starting a build for commit id: 1b72992535cd355cb521dafc0bcddaf9d03f88bf
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on the Bioconductor Single Package Builder.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.35.tar.gz
Links above active for 21 days.
Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/SurfR
to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[X] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[X] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[X] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.
[X] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[X] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[X] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
[X] I am familiar with the Bioconductor code of conduct and agree to abide by it.
I am familiar with the essential aspects of Bioconductor software management, including:
For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.